@mohasinac/appkit 4.26.0 → 4.28.0

package/dist/_internal/client/features/lottery/LotteryAdminEditView.d.ts

@@ -1,4 +1,5 @@
 import React from "react";
+import type { LotteryConfigWriteInput } from "../../../../features/lottery/schemas/config-write";
 interface LotterySlotRow {
     slotNumber: number;
     name: string;
@@ -6,26 +7,25 @@ interface LotterySlotRow {
     /** Prize photo — rendered publicly in the prize collage on the detail page. */
     image?: string;
 }
+/**
+ * What this form hands its caller.
+ *
+ * `lotteryConfig` is the WRITE input — deliberately not `LotteryConfig`. It
+ * carries no `isBooked`, no `bookedBy*` and no `weight`, because an admin
+ * editing a lottery is describing prizes, not attendance. The stored config
+ * gains those in `mergeLotteryConfig`, server-side, from the slots that are
+ * already there.
+ *
+ * `totalSlots` is absent for the same reason: derived from `slots.length` by
+ * the merge, never sent. A caller-supplied count that disagrees with the array
+ * is the mirror-drift trap (Root Cause #42), and the count is what the
+ * fullness check reads.
+ */
 interface LotteryEventFormData {
     title: string;
     description?: string;
     type: "lottery";
-    lotteryConfig: {
-        slots: Array<{
-            slotNumber: number;
-            name: string;
-            image?: string;
-            price: number;
-            weight: number;
-            isBooked: boolean;
-        }>;
-        totalSlots: number;
-        pricingMode: "uniform" | "variable";
-        uniformPrice?: number;
-        drawWindowDurationMinutes: number;
-        maxPullsPerTransaction: number;
-        maxPullsPerUser: number;
-    };
+    lotteryConfig: LotteryConfigWriteInput;
 }
 interface LotteryAdminEditViewProps {
     eventId?: string;

package/dist/_internal/client/features/lottery/LotteryAdminEditView.js

@@ -5,6 +5,7 @@ import { normalizeError } from "../../../../errors/normalize";
 import { Stack, Row, Text, Heading, Section, Container, Button, DataTable, } from "../../../../ui";
 import { Form, FieldInput, FieldSelect, Input } from "../../../../ui";
 import { lotteryConfigFormSchema } from "../../../shared/features/lottery/config-form";
+import { lotteryConfigWriteSchema } from "../../../../features/lottery/schemas/config-write";
 import { FormErrorSummary } from "../../../../ui/forms/FormErrorSummary";
 export function LotteryAdminEditView({ eventId, initialData, onSubmit, }) {
     const [isPending, startTransition] = useTransition();
@@ -35,23 +36,45 @@ export function LotteryAdminEditView({ eventId, initialData, onSubmit, }) {
         setError(null);
         startTransition(async () => {
             try {
-                const lotteryConfig = {
+                /*
+                 * 🛑 This used to send `isBooked: false` and `weight: 0` on every slot,
+                 * and drop `bookedByUserId` / `bookedByDisplayName` /
+                 * `bookedByUserLotteryNumber` entirely — against a `.passthrough()`
+                 * PATCH, which made the first save of a live lottery erase every
+                 * purchased slot, silently, with a 200.
+                 *
+                 * The write shape now has NO booking fields at all and is `.strict()`,
+                 * so a slot's buyer is not something this form can express, let alone
+                 * overwrite. `PUT /lottery-config` merges by `slotNumber` against the
+                 * stored config and is the only writer.
+                 */
+                const candidate = {
                     slots: slots.map((s) => ({
                         slotNumber: s.slotNumber,
                         name: s.name,
                         image: s.image?.trim() || undefined,
                         price: s.price,
-                        weight: 0,
-                        isBooked: false,
                     })),
-                    totalSlots: slots.length,
                     pricingMode,
-                    uniformPrice: pricingMode === "uniform" ? Math.round(parseFloat(uniformPrice) * 100) / 100 || 0 : undefined,
+                    uniformPrice: pricingMode === "uniform"
+                        ? Math.round(parseFloat(uniformPrice) * 100) / 100 || 0
+                        : undefined,
                     drawWindowDurationMinutes: parseInt(drawWindowMinutes, 10) || 5,
                     maxPullsPerTransaction: parseInt(maxPullsPerTx, 10) || 1,
                     maxPullsPerUser: parseInt(maxPullsPerUser, 10) || 1,
                 };
-                await onSubmit({ title, description, type: "lottery", lotteryConfig });
+                /*
+                 * The schema was passed to `<Form>` and never actually run — so the
+                 * `parseFloat(x) || 0` coercions above, which it exists to catch, were
+                 * still live. Parsed here so a bad slot is refused on the client
+                 * rather than discovered as a 400.
+                 */
+                const parsed = lotteryConfigWriteSchema.safeParse(candidate);
+                if (!parsed.success) {
+                    setError(parsed.error.issues[0]?.message ?? "Check the lottery settings.");
+                    return;
+                }
+                await onSubmit({ title, description, type: "lottery", lotteryConfig: parsed.data });
             }
             catch (err) {
                 void normalizeError(err);

package/dist/_internal/client/features/lottery/LotteryListView.js

@@ -2,6 +2,7 @@
 import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
 import { Stack, Row, Text, Heading, Badge, Card, Section, Container, Anchor, Div, Grid, } from "../../../../ui";
 import { MediaImage } from "../../../../features/media/MediaImage";
+import { ROUTES } from "../../../../next/routing/route-map";
 /**
  * Card grid of lotteries.
  * Admin sees all statuses; public sees active only.
@@ -17,7 +18,18 @@ export function LotteryListView({ items, adminMode = false }) {
                             const claimed = event.lotteryConfig?.slots.filter((s) => s.isBooked).length ?? 0;
                             const total = event.lotteryConfig?.totalSlots ?? 0;
                             const slotsLeft = total - claimed;
-                            return (_jsx(Anchor, { href: `/lottery/${event.id}`, tone: "brand", rounded: "2xl", className: "block focus:outline-none focus-visible:ring-2 focus-visible:ring-primary", "aria-label": `${event.title} lottery`, children: _jsxs(Card, { variant: "default", padding: "none", animate: "hoverLift", className: "overflow-hidden", children: [event.coverImageUrl || event.coverImage?.url ? (_jsx(Div, { className: "relative aspect-video overflow-hidden", children: _jsx(MediaImage, { src: event.coverImageUrl || event.coverImage?.url || "", alt: event.title, size: "card" }) })) : (_jsx(Div, { className: "aspect-video", surface: "muted", align: "center", justify: "center", children: _jsx(Text, { size: "3xl", children: "\uD83C\uDFB0" }) })), _jsxs(Stack, { gap: "xs", padding: "md", children: [_jsxs(Row, { gap: "xs", align: "center", wrap: true, children: [_jsx(Badge, { variant: event.status === "active"
+                            return (_jsx(Anchor, { 
+                                /*
+                                 * In adminMode this used to link to the PUBLIC lottery page,
+                                 * so an admin on the admin list had no route to slot
+                                 * configuration at all — which went unnoticed because the
+                                 * editor was orphaned and there was nowhere to link TO.
+                                 * Nested anchors are invalid, so the card itself changes
+                                 * target rather than gaining a second link.
+                                 */
+                                href: adminMode
+                                    ? String(ROUTES.ADMIN.LOTTERY_CONFIG(event.id))
+                                    : `/lottery/${event.id}`, tone: "brand", rounded: "2xl", className: "block focus:outline-none focus-visible:ring-2 focus-visible:ring-primary", "aria-label": `${event.title} lottery`, children: _jsxs(Card, { variant: "default", padding: "none", animate: "hoverLift", className: "overflow-hidden", children: [event.coverImageUrl || event.coverImage?.url ? (_jsx(Div, { className: "relative aspect-video overflow-hidden", children: _jsx(MediaImage, { src: event.coverImageUrl || event.coverImage?.url || "", alt: event.title, size: "card" }) })) : (_jsx(Div, { className: "aspect-video", surface: "muted", align: "center", justify: "center", children: _jsx(Text, { size: "3xl", children: "\uD83C\uDFB0" }) })), _jsxs(Stack, { gap: "xs", padding: "md", children: [_jsxs(Row, { gap: "xs", align: "center", wrap: true, children: [_jsx(Badge, { variant: event.status === "active"
                                                                 ? "success"
                                                                 : event.status === "ended"
                                                                     ? "danger"

package/dist/_internal/server/features/bundles/data.d.ts

@@ -40,6 +40,25 @@ export declare const listBundleMembers: (bundle: Pick<CategoryDocument, "bundleP
  * displayed discount.
  */
 export declare function resolveBundleOriginalTotal(productIds: string[]): Promise<number | undefined>;
+/**
+ * Reject a bundle whose members belong to more than one seller.
+ *
+ * `storeId` is a SCALAR on the cart line, and it is simultaneously the
+ * order-splitting key and the key that per-store add-ons, coupons, shipping and
+ * payout all hang off. A bundle spanning two sellers therefore produces one
+ * order belonging to one of them while containing the other's products — the
+ * second seller gets no notification, no shipping resolution and no payout.
+ *
+ * Grouped cart lines refuse this at both the picker and the add-to-cart action.
+ * Bundles had no equivalent guard, so the only reason nothing was broken was
+ * that every bundle anyone had built happened to be single-store. This closes
+ * that at the point a bundle is SAVED, which is the cheapest place to say no:
+ * bundles already in the database keep working, and checkout is untouched.
+ *
+ * Returns the offending store ids (empty when fine) rather than throwing, so
+ * each route can phrase its own 400.
+ */
+export declare function findBundleMemberStores(productIds: string[]): Promise<string[]>;
 /**
  * Union of the member products' `categorySlugs` — the `bundleCategorySlugs`
  * mirror that lets a category page scope its Bundles tab.

package/dist/_internal/server/features/bundles/data.js

@@ -68,6 +68,38 @@ export async function resolveBundleOriginalTotal(productIds) {
     const total = prices.reduce((sum, p) => sum + p, 0);
     return Math.round(total * 100) / 100;
 }
+/**
+ * Reject a bundle whose members belong to more than one seller.
+ *
+ * `storeId` is a SCALAR on the cart line, and it is simultaneously the
+ * order-splitting key and the key that per-store add-ons, coupons, shipping and
+ * payout all hang off. A bundle spanning two sellers therefore produces one
+ * order belonging to one of them while containing the other's products — the
+ * second seller gets no notification, no shipping resolution and no payout.
+ *
+ * Grouped cart lines refuse this at both the picker and the add-to-cart action.
+ * Bundles had no equivalent guard, so the only reason nothing was broken was
+ * that every bundle anyone had built happened to be single-store. This closes
+ * that at the point a bundle is SAVED, which is the cheapest place to say no:
+ * bundles already in the database keep working, and checkout is untouched.
+ *
+ * Returns the offending store ids (empty when fine) rather than throwing, so
+ * each route can phrase its own 400.
+ */
+export async function findBundleMemberStores(productIds) {
+    if (productIds.length === 0)
+        return [];
+    const results = await Promise.all(productIds.map((id) => productRepository.findById(id).catch(() => null)));
+    const stores = new Set();
+    for (const p of results) {
+        // An unresolvable member says nothing about seller spread — the price
+        // helper above already refuses to guess in that case, and inventing a
+        // store here would produce a false positive that blocks a valid save.
+        if (p?.storeId)
+            stores.add(p.storeId);
+    }
+    return [...stores];
+}
 /**
  * Union of the member products' `categorySlugs` — the `bundleCategorySlugs`
  * mirror that lets a category page scope its Bundles tab.

package/dist/_internal/server/features/bundles/index.d.ts

@@ -1,4 +1,4 @@
-export { getBundleForDetail, listBundleMembers, listFeaturedBundles, getRelatedBundles, resolveBundleMemberIds, resolveBundleOriginalTotal, resolveBundleCategorySlugs, type BundleDataOptions, } from "./data";
+export { getBundleForDetail, listBundleMembers, listFeaturedBundles, getRelatedBundles, resolveBundleMemberIds, resolveBundleOriginalTotal, findBundleMemberStores, resolveBundleCategorySlugs, type BundleDataOptions, } from "./data";
 export { buildBundleMetadata, type BundleMetadataOptions } from "./metadata";
 export { renderBundleOg, renderBundleOgImage, type BundleOgData, } from "./og";
 export { addBundleToCartAction } from "./actions";

package/dist/_internal/server/features/bundles/index.js

@@ -1,4 +1,4 @@
-export { getBundleForDetail, listBundleMembers, listFeaturedBundles, getRelatedBundles, resolveBundleMemberIds, resolveBundleOriginalTotal, resolveBundleCategorySlugs, } from "./data";
+export { getBundleForDetail, listBundleMembers, listFeaturedBundles, getRelatedBundles, resolveBundleMemberIds, resolveBundleOriginalTotal, findBundleMemberStores, resolveBundleCategorySlugs, } from "./data";
 export { buildBundleMetadata } from "./metadata";
 // S-SBUNI-4 2026-05-13 — bundle OG renderer.
 export { renderBundleOg, renderBundleOgImage, } from "./og";

package/dist/_internal/server/features/checkout/actions.js

@@ -80,7 +80,7 @@ async function claimDigitalCodeForOrder(db, productId, orderId, userId, opts) {
             userName: opts.userName ?? "there",
             productTitle: opts.productTitle ?? "your product",
             orderId,
-        }).catch((e) => serverLogger.error("claimDigitalCode: email failed", e));
+        }).catch((e) => serverLogger.error("claimDigitalCode: email failed", { error: normalizeError(e).message }));
     }
 }
 /**
@@ -550,7 +550,7 @@ async function createOrderForGroup(group, orderType, ctx) {
             userEmail: userEmail || undefined,
             userName,
             productTitle: firstItem.productTitle,
-        }).catch((e) => serverLogger.error("claimDigitalCode", e));
+        }).catch((e) => serverLogger.error("claimDigitalCode", { error: normalizeError(e).message }));
     }
     for (const code of groupCouponCodes) {
         const entry = couponUsageAccumulator.get(code);
@@ -892,8 +892,10 @@ export async function previewCheckoutPricing(input) {
         // A preview never throws — it just shows the lane the buyer can actually
         // check out, matching what the checkout page's active tab displays.
         (!previewLane || laneOf(item) === previewLane));
+    // A fresh object, not the module singleton — an in-process caller mutating
+    // the returned preview would otherwise poison every later empty result.
     if (cartItems.length === 0)
-        return EMPTY_PRICING_PREVIEW;
+        return { ...EMPTY_PRICING_PREVIEW, stores: [] };
     // Best-effort product lookup — a preview never throws on a since-unpublished
     // product, it just falls back to the item's cart-snapshot price for that
     // line (same fallback cartRepository.getSubtotal() implicitly relies on).
@@ -1268,7 +1270,7 @@ async function createRazorpayGroupOrder(group, orderType, ctx) {
             userEmail: userEmail || undefined,
             userName,
             productTitle: firstItem.productTitle,
-        }).catch((e) => serverLogger.error("claimDigitalCode", e));
+        }).catch((e) => serverLogger.error("claimDigitalCode", { error: normalizeError(e).message }));
     }
     for (const code of groupCouponCodes) {
         const entry = couponUsageAccumulator.get(code);

package/dist/_internal/server/features/classified/metadata.js

@@ -21,7 +21,9 @@ export function buildClassifiedMetadata(product, opts) {
             : product.description?.slice(0, 160) ?? "";
     const image = opts?.ogImageUrl ?? (product.mainImage || product.images?.[0] || null);
     const siteUrl = opts?.siteUrl?.replace(/\/+$/, "");
-    const canonical = siteUrl ? `${siteUrl}/classified/${product.id}` : undefined;
+    // Prefer `slug` — the route is `/classified/[slug]`, so a canonical built from
+    // `id` names a URL the router does not serve whenever the two differ.
+    const canonical = siteUrl ? `${siteUrl}/classified/${product.slug ?? product.id}` : undefined;
     return {
         title,
         description,

package/dist/_internal/server/features/digital-code/metadata.js

@@ -14,7 +14,9 @@ export function buildDigitalCodeMetadata(product, opts) {
         : product.description?.slice(0, 160) ?? "";
     const image = opts?.ogImageUrl ?? (product.mainImage || product.images?.[0] || null);
     const siteUrl = opts?.siteUrl?.replace(/\/+$/, "");
-    const canonical = siteUrl ? `${siteUrl}/digital-codes/${product.id}` : undefined;
+    // Prefer `slug` — the route is `/digital-codes/[slug]`, so a canonical built
+    // from `id` names a URL the router does not serve whenever the two differ.
+    const canonical = siteUrl ? `${siteUrl}/digital-codes/${product.slug ?? product.id}` : undefined;
     return {
         title,
         description,

package/dist/_internal/server/features/live/metadata.js

@@ -17,7 +17,9 @@ export function buildLiveItemMetadata(product, opts) {
         : product.description?.slice(0, 160) ?? "";
     const image = opts?.ogImageUrl ?? (product.mainImage || product.images?.[0] || null);
     const siteUrl = opts?.siteUrl?.replace(/\/+$/, "");
-    const canonical = siteUrl ? `${siteUrl}/live/${product.id}` : undefined;
+    // Prefer `slug` — the route is `/live/[slug]`, so a canonical built from `id`
+    // names a URL the router does not serve whenever the two differ.
+    const canonical = siteUrl ? `${siteUrl}/live/${product.slug ?? product.id}` : undefined;
     return {
         title,
         description,

package/dist/_internal/server/features/refunds/actions.js

@@ -16,6 +16,7 @@ import { wrapAction } from "@mohasinac/appkit/server";
  */
 import { randomUUID } from "crypto";
 import { getProviders } from "../../../../contracts/registry";
+import { normalizeError } from "../../../../errors/normalize";
 import { rupeesToPaise } from "../../../../providers/payment-razorpay/index";
 import { orderRepository } from "../../../..";
 import { ORDER_FIELDS } from "../../../../constants/field-names";
@@ -65,7 +66,7 @@ function revokeAvailableDigitalCodes(orderId, items) {
             .limit(1)
             .get()
             .then((snap) => revokeFirstSnapDoc(snap))
-            .catch((e) => serverLogger.error("refund: code query failed", e));
+            .catch((e) => serverLogger.error("refund: code query failed", { error: normalizeError(e).message }));
     }
 }
 function revokeFirstSnapDoc(snap) {
@@ -73,7 +74,7 @@ function revokeFirstSnapDoc(snap) {
         return;
     snap.docs[0].ref
         .update({ status: "revoked", updatedAt: new Date() })
-        .catch((e) => serverLogger.error("refund: code revoke failed", e));
+        .catch((e) => serverLogger.error("refund: code revoke failed", { error: normalizeError(e).message }));
 }
 export async function processRefundAction(input) {
     return wrapAction(async () => {

package/dist/_internal/server/features/reviews/actions.js

@@ -71,8 +71,9 @@ export async function deleteReviewAction(input) {
 }
 export async function markReviewHelpfulAction(reviewId) {
     return wrapAction(async () => {
-        await requireRoleUser(["buyer", "seller", "admin"]);
+        const user = await requireRoleUser(["buyer", "seller", "admin"]);
         await getReviewOrThrow(reviewId);
-        await reviewRepository.incrementHelpful(reviewId);
+        // Keyed on the voter so a repeated call is a no-op rather than another +1.
+        return reviewRepository.voteHelpful(reviewId, user.uid);
     });
 }