@modusoperandi/licit 0.1.9 → 0.13.2

package/src/EditorCommands.js

@@ -5,20 +5,20 @@ import * as ProsemirrorTables from 'prosemirror-tables';
 // import BlockquoteInsertNewLineCommand from './BlockquoteInsertNewLineCommand';
 // import BlockquoteToggleCommand from './BlockquoteToggleCommand';
 import DocLayoutCommand from './DocLayoutCommand';
-import HeadingCommand from './HeadingCommand';
+import { HeadingCommand } from '@modusoperandi/licit-ui-commands';
 import HistoryRedoCommand from './HistoryRedoCommand';
 import HistoryUndoCommand from './HistoryUndoCommand';
 import HorizontalRuleCommand from './HorizontalRuleCommand';
 import ImageFromURLCommand from './ImageFromURLCommand';
 import ImageUploadCommand from './ImageUploadCommand';
-import IndentCommand from './IndentCommand';
+import { IndentCommand } from '@modusoperandi/licit-ui-commands';
 import LinkSetURLCommand from './LinkSetURLCommand';
 import ListItemInsertNewLineCommand from './ListItemInsertNewLineCommand';
 import ListItemMergeCommand from './ListItemMergeCommand';
 import ListSplitCommand from './ListSplitCommand';
 import { ListToggleCommand } from './ListToggleCommand';
 import * as MarkNames from './MarkNames';
-import MarkToggleCommand from './MarkToggleCommand';
+import { MarkToggleCommand } from '@modusoperandi/licit-ui-commands';
 import MarksClearCommand from './MarksClearCommand';
 import MathEditCommand from './MathEditCommand';
 import PrintCommand from './PrintCommand';
@@ -26,11 +26,11 @@ import TableBackgroundColorCommand from './TableBackgroundColorCommand';
 import TableBorderColorCommand from './TableBorderColorCommand';
 import TableInsertCommand from './TableInsertCommand';
 import TableMergeCellsCommand from './TableMergeCellsCommand';
-import TextAlignCommand from './TextAlignCommand';
-import TextColorCommand from './TextColorCommand';
-import TextHighlightCommand from './TextHighlightCommand';
+import { TextAlignCommand } from '@modusoperandi/licit-ui-commands';
+import { TextColorCommand } from '@modusoperandi/licit-ui-commands';
+import { TextHighlightCommand } from '@modusoperandi/licit-ui-commands';
 import TextInsertTabSpaceCommand from './TextInsertTabSpaceCommand';
-import TextLineSpacingCommand from './TextLineSpacingCommand';
+import { TextLineSpacingCommand } from '@modusoperandi/licit-ui-commands';
 import createCommand from './createCommand';
 
 const {

package/src/ImageSourceCommand.js

@@ -12,7 +12,7 @@ import {
 } from './CursorPlaceholderPlugin';
 import { IMAGE } from './NodeNames';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
 import type { ImageLike } from './Types';
 

package/src/LinkSetURLCommand.js

@@ -10,11 +10,11 @@ import {
   hideSelectionPlaceholder,
   showSelectionPlaceholder,
 } from './SelectionPlaceholderPlugin';
-import applyMark from './applyMark';
-import findNodesWithSameMark from './findNodesWithSameMark';
+import { applyMark } from '@modusoperandi/licit-ui-commands';
+import { findNodesWithSameMark } from '@modusoperandi/licit-ui-commands';
 import LinkURLEditor from './ui/LinkURLEditor';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
 class LinkSetURLCommand extends UICommand {
   _popUp = null;

package/src/LinkTooltipPlugin.js

@@ -9,15 +9,15 @@ import {
   hideSelectionPlaceholder,
   showSelectionPlaceholder,
 } from './SelectionPlaceholderPlugin';
-import applyMark from './applyMark';
-import findNodesWithSameMark from './findNodesWithSameMark';
+import { applyMark } from '@modusoperandi/licit-ui-commands';
+import { findNodesWithSameMark } from '@modusoperandi/licit-ui-commands';
 import lookUpElement from './lookUpElement';
 import LinkTooltip from './ui/LinkTooltip';
 import LinkURLEditor from './ui/LinkURLEditor';
-import { atAnchorTopCenter } from './ui/PopUpPosition';
-import createPopUp from './ui/createPopUp';
+import { atAnchorTopCenter } from '@modusoperandi/licit-ui-commands';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
-import './ui/czi-pop-up.css';
+import '@modusoperandi/licit-ui-commands/dist/ui/czi-pop-up.css';
 
 // https://prosemirror.net/examples/tooltip/
 const SPEC = {

package/src/ListToggleCommand.js

@@ -6,10 +6,10 @@ import { findParentNodeOfType } from 'prosemirror-utils';
 import { EditorView } from 'prosemirror-view';
 
 import { BULLET_LIST, ORDERED_LIST, IMAGE } from './NodeNames';
-import noop from './noop';
-import toggleList from './toggleList';
+import { noop } from '@modusoperandi/licit-ui-commands';
+import { toggleList } from '@modusoperandi/licit-ui-commands';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import isNodeSelectionForNodeType from './isNodeSelectionForNodeType';
+import { isNodeSelectionForNodeType } from '@modusoperandi/licit-ui-commands';
 
 export class ListToggleCommand extends UICommand {
   _ordered: boolean;

package/src/MarksClearCommand.js

@@ -4,7 +4,7 @@ import { EditorState, AllSelection, TextSelection } from 'prosemirror-state';
 import { Transform } from 'prosemirror-transform';
 import { EditorView } from 'prosemirror-view';
 
-import { clearMarks, clearHeading } from './clearMarks';
+import { clearMarks, clearHeading } from '@modusoperandi/licit-ui-commands';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
 
 class MarksClearCommand extends UICommand {

package/src/MathEditCommand.js

@@ -15,7 +15,7 @@ import {
 import { MATH } from './NodeNames';
 import MathEditor from './ui/MathEditor';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
 function insertMath(tr: Transform, schema: Schema, latex: ?string): Transform {
   const { selection } = tr;

package/src/ParagraphNodeSpec.js

@@ -1,5 +1,5 @@
 // @flow
-import clamp from './ui/clamp';
+
 import convertToCSSPTValue from './convertToCSSPTValue';
 import toCSSLineSpacing from './ui/toCSSLineSpacing';
 import { Node } from 'prosemirror-model';
@@ -150,11 +150,7 @@ export const getParagraphStyle = getStyle;
 
 export function convertMarginLeftToIndentValue(marginLeft: string): number {
   const ptValue = convertToCSSPTValue(marginLeft);
-  return clamp(
-    MIN_INDENT_LEVEL,
-    Math.floor(ptValue / INDENT_MARGIN_PT_SIZE),
-    MAX_INDENT_LEVEL
-  );
+  return Math.min(Math.max(Math.floor(ptValue / INDENT_MARGIN_PT_SIZE), MIN_INDENT_LEVEL), MAX_INDENT_LEVEL);
 }
 
 export default ParagraphNodeSpec;

package/src/TableBackgroundColorCommand.js

@@ -6,10 +6,10 @@ import { setCellAttr } from 'prosemirror-tables';
 import { Transform } from 'prosemirror-transform';
 import { EditorView } from 'prosemirror-view';
 
-import ColorEditor from './ui/ColorEditor';
-import { atAnchorRight } from './ui/PopUpPosition';
+import { ColorEditor } from '@modusoperandi/licit-ui-commands';
+import { atAnchorRight } from '@modusoperandi/licit-ui-commands';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
 const setCellBackgroundBlack = setCellAttr('background', '#000000');
 

package/src/TableBorderColorCommand.js

@@ -6,10 +6,10 @@ import { setCellAttr } from 'prosemirror-tables';
 import { Transform } from 'prosemirror-transform';
 import { EditorView } from 'prosemirror-view';
 
-import ColorEditor from './ui/ColorEditor';
-import { atAnchorRight } from './ui/PopUpPosition';
+import { ColorEditor } from '@modusoperandi/licit-ui-commands';
+import { atAnchorRight } from '@modusoperandi/licit-ui-commands';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
 const setCellBorderBlack = setCellAttr('borderColor', '#000000');
 

package/src/TableCellColorCommand.js

@@ -6,10 +6,10 @@ import { setCellAttr } from 'prosemirror-tables';
 import { Transform } from 'prosemirror-transform';
 import { EditorView } from 'prosemirror-view';
 
-import ColorEditor from './ui/ColorEditor';
-import { atAnchorRight } from './ui/PopUpPosition';
+import { ColorEditor } from '@modusoperandi/licit-ui-commands';
+import { atAnchorRight } from '@modusoperandi/licit-ui-commands';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 
 const setCellBackgroundBlack = setCellAttr('background', '#000000');
 

package/src/TableCellMenuPlugin.js

@@ -6,13 +6,13 @@ import { EditorView } from 'prosemirror-view';
 import * as React from 'react';
 
 import findActionableCell from './findActionableCell';
-import { atAnchorTopRight } from './ui/PopUpPosition';
+import { atAnchorTopRight } from '@modusoperandi/licit-ui-commands';
 import TableCellMenu from './ui/TableCellMenu';
 import bindScrollHandler from './ui/bindScrollHandler';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 import isElementFullyVisible from './ui/isElementFullyVisible';
 
-import './ui/czi-pop-up.css';
+import '@modusoperandi/licit-ui-commands/dist/ui/czi-pop-up.css';
 
 class TableCellTooltipView {
   _cellElement: null;

package/src/TableInsertCommand.js

@@ -7,10 +7,10 @@ import { Transform } from 'prosemirror-transform';
 import { EditorView } from 'prosemirror-view';
 import { Fragment } from 'prosemirror-model';
 import insertTable from './insertTable';
-import { atAnchorRight } from './ui/PopUpPosition';
+import { atAnchorRight } from '@modusoperandi/licit-ui-commands';
 import TableGridSizeEditor from './ui/TableGridSizeEditor';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
-import createPopUp from './ui/createPopUp';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
 import { PARAGRAPH } from './NodeNames';
 import type { TableGridSizeEditorValue } from './ui/TableGridSizeEditor';
 

package/src/TextInsertTabSpaceCommand.js

@@ -8,7 +8,7 @@ import { EditorView } from 'prosemirror-view';
 import { MARK_SPACER } from './MarkNames';
 import { HEADING, LIST_ITEM, PARAGRAPH } from './NodeNames';
 import { HAIR_SPACE_CHAR, SPACER_SIZE_TAB } from './SpacerMarkSpec';
-import applyMark from './applyMark';
+import { applyMark } from '@modusoperandi/licit-ui-commands';
 import { UICommand } from '@modusoperandi/licit-doc-attrs-step';
 
 function insertTabSpace(

package/src/client/CollabConnector.js

@@ -51,6 +51,21 @@ class CollabConnector extends SimpleConnector {
     };
   }
 
+  cleanUp = () => {
+    // remove collab plugin
+    if (this._connection) {
+      const cpIdx = this._editorState.plugins.findIndex((plugin) => {
+        return 'collab$' === plugin.spec.key.key;
+      });
+
+      if (-1 != cpIdx) {
+        this._editorState.plugins.splice(cpIdx, 1);
+      }
+
+      this._connection.close();
+    }
+  };
+
   onEdit = (transaction: Transform): void => {
     if (!this._connection.ready) {
       console.warn('not ready');
@@ -63,8 +78,8 @@ class CollabConnector extends SimpleConnector {
 
   // FS IRAD-1040 2020-09-02
   // Send the modified schema to server
-  updateSchema = (schema: Schema) => {
-    this._connection.updateSchema(schema);
+  updateSchema = (schema: Schema, data: any) => {
+    this._connection.updateSchema(schema, data);
   };
 }
 

package/src/client/EditorConnection.js

@@ -106,7 +106,7 @@ class EditorConnection {
 
     if (newEditState) {
       let sendable;
-      if (newEditState.doc.content.size > 40000) {
+      if (newEditState.doc.content.size > 4000000000000) {
         if (this.state.comm !== 'detached') {
           this.report.failure('Document too big. Detached.');
         }
@@ -132,6 +132,17 @@ class EditorConnection {
     }
   };
 
+  dispatchData(data: any) {
+    this.report.success();
+    this.backOff = 0;
+    this.dispatch({
+      type: 'loaded',
+      doc: this.getEffectiveSchema().nodeFromJSON(data),
+      version: data.version,
+      users: data.users,
+    });
+  }
+
   // Load the document from the server and start up
   start(): void {
     this.run(GET(this.url)).then(
@@ -242,7 +253,7 @@ class EditorConnection {
 
   // [FS] IRAD-1040 2020-09-02
   // Send the modified schema to server
-  updateSchema(schema: Schema) {
+  updateSchema(schema: Schema, input: any) {
     // to avoid cyclic reference error, use flatted string.
     const schemaFlatted = stringify(schema);
     this.run(POST(this.url + '/schema/', schemaFlatted, 'text/plain')).then(
@@ -250,7 +261,7 @@ class EditorConnection {
         console.log("collab server's schema updated");
         // [FS] IRAD-1040 2020-09-08
         this.schema = schema;
-        this.start();
+        this.start(input);
       },
       (err) => {
         this.report.failure(err);

package/src/client/Licit.js

@@ -14,8 +14,8 @@ import SimpleConnector from './SimpleConnector';
 import CollabConnector from './CollabConnector';
 import { EMPTY_DOC_JSON } from '../createEmptyEditorState';
 import type { EditorRuntime } from '../Types';
-import createPopUp from '../ui/createPopUp';
-import { atViewportCenter } from '../ui/PopUpPosition';
+import { createPopUp } from '@modusoperandi/licit-ui-commands';
+import { atViewportCenter } from '@modusoperandi/licit-ui-commands';
 import AlertInfo from '../ui/AlertInfo';
 import { SetDocAttrStep } from '@modusoperandi/licit-doc-attrs-step';
 import './licit.css';
@@ -73,7 +73,7 @@ class Licit extends React.Component<any, any> {
     this._editorView = null;
     this._skipSCU = true;
 
-    const noop = function () { };
+    const noop = function () {};
 
     // [FS] IRAD-981 2020-06-10
     // Component's configurations.
@@ -132,17 +132,17 @@ class Licit extends React.Component<any, any> {
     const setState = this.setState.bind(this);
     this._connector = collaborative
       ? new CollabConnector(
-        editorState,
-        setState,
-        {
-          docID,
-          collabServiceURL,
-        },
-        this._defaultEditorSchema,
-        this._defaultEditorPlugins,
-        // [FS] IRAD-1578 2021-09-27
-        this.onReady.bind(this)
-      )
+          editorState,
+          setState,
+          {
+            docID,
+            collabServiceURL,
+          },
+          this._defaultEditorSchema,
+          this._defaultEditorPlugins,
+          // [FS] IRAD-1578 2021-09-27
+          this.onReady.bind(this)
+        )
       : new SimpleConnector(editorState, setState);
 
     // FS IRAD-989 2020-18-06
@@ -168,7 +168,7 @@ class Licit extends React.Component<any, any> {
     // Get the modified schema from editorstate and send it to collab server
     if (this._connector.updateSchema) {
       // Use known editorState to update schema.
-      this._connector.updateSchema(editorState.schema);
+      this._connector.updateSchema(editorState.schema, data);
     }
   }
 
@@ -265,12 +265,16 @@ class Licit extends React.Component<any, any> {
 
   setContent = (content: any = {}): void => {
     // [FS] IRAD-1571 2021-09-27
-    // dispatch a transaction that MUST start from the view�s current state;
+    // dispatch a transaction that MUST start from the view’s current state;
     const editorState = this._editorView.state;
     const { doc, schema } = editorState;
     let { tr } = editorState;
     const document = schema.nodeFromJSON(content ? content : EMPTY_DOC_JSON);
 
+    // [FS] IRAD-1593 2021-10-12
+    // Reset lastKeyCode since the content is set dynamically and so lastKeyCode is invalid now.
+    this._editorView.lastKeyCode = null;
+
     const selection = TextSelection.create(doc, 0, doc.content.size);
 
     tr = tr.setSelection(selection).replaceSelectionWith(document, false);
@@ -278,8 +282,8 @@ class Licit extends React.Component<any, any> {
     // set the value for object metadata  and objectId
     tr = this.isNodeHasAttribute(document, ATTR_OBJMETADATA)
       ? tr.step(
-        new SetDocAttrStep(ATTR_OBJMETADATA, document.attrs.objectMetaData)
-      )
+          new SetDocAttrStep(ATTR_OBJMETADATA, document.attrs.objectMetaData)
+        )
       : tr;
     tr = this.isNodeHasAttribute(document, ATTR_OBJID)
       ? tr.step(new SetDocAttrStep(ATTR_OBJID, document.attrs.objectId))
@@ -289,58 +293,84 @@ class Licit extends React.Component<any, any> {
     this._editorView.dispatch(tr);
   };
 
+  hasDataChanged(nextData: any) {
+    let dataChanged = false;
+
+    // [FS] IRAD-1571 2021-09-27
+    // dispatch a transaction that MUST start from the view’s current state;
+    // [FS] IRAD-1589 2021-10-04
+    // Do a proper circular JSON comparison.
+    if (stringify(this.state.data) !== stringify(nextData)) {
+      const editorState = this._editorView.state;
+      const nextDoc = editorState.schema.nodeFromJSON(
+        nextData ? nextData : EMPTY_DOC_JSON
+      );
+      dataChanged = !nextDoc.eq(editorState.doc);
+    }
+
+    return dataChanged;
+  }
+
+  changeContent(data: any) {
+    if (this.hasDataChanged(data)) {
+      // FS IRAD-1592 2021-11-10
+      // Release here quickly, so that update doesn't care about at this point.
+      // data changed, so update document content
+      setTimeout(this.setContent.bind(this, data), 1);
+    }
+  }
+
   shouldComponentUpdate(nextProps: any, nextState: any) {
     // Only interested if properties are set from outside.
     if (!this._skipSCU) {
       this._skipSCU = false;
-      let dataChanged = false;
-
-      // [FS] IRAD-1571 2021-09-27
-      // dispatch a transaction that MUST start from the view�s current state;
-      // [FS] IRAD-1589 2021-10-04
-      // Do a proper circular JSON comparison.
-      if (stringify(this.state.data) !== stringify(nextState.data)) {
-        const editorState = this._editorView.state;
-        const nextDoc = editorState.schema.nodeFromJSON(
-          nextState.data ? nextState.data : EMPTY_DOC_JSON
-        );
-        dataChanged = !nextDoc.eq(editorState.doc);
-      }
 
-      if (dataChanged) {
-        // data changed, so update document content
-        this.setContent(nextState.data);
-      }
+      this.changeContent(nextState.data);
 
       if (this.state.docID !== nextState.docID) {
-        // Collaborative mode changed
-        const collabEditing = nextState.docID !== '';
-        const editorState = this._editorView.state;
-        const setState = this.setState.bind(this);
-        const docID = nextState.docID || '';
-        const collabServiceURL =
-          nextState.collabServiceURL || '/collaboration-service';
-        // create new connector
-        this._connector = collabEditing
-          ? new CollabConnector(
-            editorState,
-            setState,
-            {
-              docID,
-              collabServiceURL,
-            },
-            this._defaultEditorSchema,
-            this._defaultEditorPlugins,
-            // [FS] IRAD-1578 2021-09-27
-            this.onReady.bind(this)
-          )
-          : new SimpleConnector(editorState, setState);
+        setTimeout(this.setDocID.bind(this, nextState), 1);
       }
     }
 
     return true;
   }
 
+  setDocID(nextState: any) {
+    // Collaborative mode changed
+    const collabEditing = nextState.docID !== '';
+    const editorState = this._editorView.state;
+    const setState = this.setState.bind(this);
+    const docID = nextState.docID || '';
+    const collabServiceURL =
+      nextState.collabServiceURL || '/collaboration-service';
+
+    if (this._connector) {
+      this._connector.cleanUp();
+    }
+    // create new connector
+    this._connector = collabEditing
+      ? new CollabConnector(
+          editorState,
+          setState,
+          {
+            docID,
+            collabServiceURL,
+          },
+          this._defaultEditorSchema,
+          this._defaultEditorPlugins,
+          // [FS] IRAD-1578 2021-09-27
+          this.onReady.bind(this)
+        )
+      : new SimpleConnector(editorState, setState);
+
+    // FS IRAD-1592 2021-11-10
+    // Notify collab server
+    if (this._connector.updateSchema) {
+      // Use known editorState to update schema.
+      this._connector.updateSchema(editorState.schema);
+    }
+  }
+
   render(): React.Element<any> {
     const {
       editorState,
@@ -401,7 +431,18 @@ class Licit extends React.Component<any, any> {
 
       if (transaction.docChanged) {
         const docJson = transaction.doc.toJSON();
-        const isEmpty = this.isDocEmpty(docJson);
+        let isEmpty = false;
+
+        if (docJson.content && docJson.content.length === 1) {
+          if (
+            !docJson.content[0].content ||
+            (docJson.content[0].content &&
+              docJson.content[0].content[0].text &&
+              '' === docJson.content[0].content[0].text.trim())
+          ) {
+            isEmpty = true;
+          }
+        }
 
         // setCFlags is/was always the opposite of isEmpty.
         if (isEmpty) {
@@ -419,27 +460,6 @@ class Licit extends React.Component<any, any> {
       }
     }
   };
-
-  isDocEmpty(docJson: Object) {
-    let isEmpty = false;
-
-    if (docJson.content && docJson.content.length === 1) {
-      if (
-        !docJson.content[0].content ||
-        (docJson.content[0].content &&
-          // [FS] IRAD-1710 2022-03-04
-          // Empty if no content OR when the one & only text content is empty.
-          1 === docJson.content[0].content.length &&
-          'text' === docJson.content[0].content[0].type &&
-          docJson.content[0].content[0].text &&
-          '' === docJson.content[0].content[0].text)
-      ) {
-        isEmpty = true;
-      }
-    }
-    return isEmpty;
-  }
-
   // [FS] IRAD-1173 2021-02-25
   // Bug fix: Transaction mismatch error when a dialog is opened and keep typing.
   closeOpenedPopupModels() {
@@ -456,12 +476,8 @@ class Licit extends React.Component<any, any> {
     this._editorView = editorView;
     const tr = state.tr;
     const doc = state.doc;
-
-    // [FS] IRAD-1710 2022-03-04
-    if (!this.isDocEmpty(doc.toJSON())) {
-      const trx = tr.setSelection(TextSelection.create(doc, 0, doc.content.size));
-      dispatch(trx.scrollIntoView());
-    }
+    const trx = tr.setSelection(TextSelection.create(doc, 0, doc.content.size));
+    dispatch(trx.scrollIntoView());
 
     // [FS] IRAD-1578 2021-09-27
     // In collab mode, fire onRead only after getting the response from collab server.

package/src/client/Licit.test.js

@@ -3,7 +3,7 @@ import { configure, shallow } from 'enzyme';
 import Adapter from 'enzyme-adapter-react-16';
 import Licit from './Licit';
 import RichTextEditor from '../ui/RichTextEditor';
-import noop from '../noop';
+import { noop } from '@modusoperandi/licit-ui-commands';
 
 /**
  * Configure Jest to use react / enzyme
@@ -16,6 +16,17 @@ describe('<Licit />', () => {
   let wrapper;
   let licit;
 
+  // provide an empty document just to shut up that warning
+  const data = {
+    type: 'doc',
+    content: [
+      {
+        type: 'paragraph',
+        content: [{ type: 'text', text: ' ' }],
+      },
+    ],
+  };
+
   // Mocking the functions used in _onReady
   const fakeEditorView = {
     focus: noop,
@@ -24,6 +35,7 @@ describe('<Licit />', () => {
       doc: {
         content: { size: 10 },
         resolve: () => ({ min: () => 0, max: () => 10 }),
+        toJSON: () => data,
       },
       tr: {
         setSelection: () => fakeEditorView.state.tr,
@@ -33,16 +45,6 @@ describe('<Licit />', () => {
   };
 
   beforeEach(() => {
-    // provide an empty document just to shut up that warning
-    const data = {
-      type: 'doc',
-      content: [
-        {
-          type: 'paragraph',
-          content: [{ type: 'text', text: ' ' }],
-        },
-      ],
-    };
     wrapper = shallow(<Licit data={data} />);
     licit = wrapper.instance();
   });

package/src/client/SimpleConnector.js

@@ -47,7 +47,9 @@ class SimpleConnector {
 
   // FS IRAD-1040 2020-09-02
   // Send the modified schema to server
-  updateSchema = (schema: Schema) => {};
+  updateSchema = (schema: Schema, data: any) => {};
+
+  cleanUp = () => {};
 }
 
 export default SimpleConnector;

package/src/joinListNode.js

@@ -4,7 +4,7 @@ import { Schema } from 'prosemirror-model';
 import { TextSelection } from 'prosemirror-state';
 import { Transform } from 'prosemirror-transform';
 
-import isListNode from './isListNode';
+import { isListNode } from '@modusoperandi/licit-ui-commands';
 import joinDown from './joinDown';
 import joinUp from './joinUp';