@modusensus/dsh-mneme 0.8.1 → 0.8.3

package/test/sleep-scheduler-rearm.test.js

@@ -0,0 +1,89 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { createStore } from "../src/store.js";
+import { createService } from "../src/service.js";
+import { createSleepScheduler } from "../src/dream/sleep.js";
+
+// 回归（issue #187）：idle 计时器到点时若撞上 sleepMinIntervalHours（CD）未满，
+// maybeSchedule 返回 false 后没有任何东西重排——armIdleTimer 的回调把返回值丢掉、
+// idleTimer 已被置 null，"CD 到期"成了没有监听者的时刻，库里攒着待清理的新写入
+// 却什么都不发生，要等用户恰好再写一次才救回来。两个断言方向：
+//   1. 撞 CD 后必须按剩余窗口重排，CD 到点自行起跑；
+//   2. 调度器构造时就该挂表——重启后零写入也应有闹钟（同族缺陷：无表可 firing）。
+// 全程注入时钟/定时器，不依赖真实等待。
+
+function makeHarness(overrides = {}) {
+  let nowMs = 1_000_000;
+  const timers = [];
+  let seq = 1;
+  const store = createStore(":memory:");
+  const service = createService({ store, mirror: null, config: {} });
+  let runs = 0;
+  const sched = createSleepScheduler({
+    service,
+    config: { sleepModeEnabled: true, sleepIdleMinutes: 5, sleepMinIntervalHours: 1, ...overrides },
+    logger: { warn: () => {} },
+    onRun: async () => { runs++; return { ok: true }; },
+    now: () => nowMs,
+    setTimeoutFn: (fn, delay) => {
+      const t = { id: seq++, at: nowMs + delay, fn };
+      timers.push(t);
+      return t.id;
+    },
+    clearTimeoutFn: (id) => {
+      const i = timers.findIndex((t) => t.id === id);
+      if (i >= 0) timers.splice(i, 1);
+    }
+  });
+  // 触发最早到点的那个表；回调内部可能再挂新表，继续留在队列里等下一次触发。
+  const fireNext = async () => {
+    timers.sort((a, b) => a.at - b.at);
+    const t = timers.shift();
+    if (!t) throw new Error("no armed timer to fire");
+    nowMs = t.at;
+    await t.fn();
+  };
+  return {
+    sched,
+    store,
+    timers,
+    fireNext,
+    runs: () => runs,
+    now: () => nowMs,
+    write: () => { nowMs += 1000; sched.noteWrite(); }
+  };
+}
+
+test("sleep #187: CD collision re-arms a timer instead of dropping the round", async () => {
+  const h = makeHarness();
+  h.write();
+  await h.fireNext();
+  assert.equal(h.runs(), 1, "first run fires after the idle window");
+  const firstRunAt = h.now();
+
+  h.write(); // 落在 CD 窗口内的写入（默认 8h 时几乎必中）
+  await h.fireNext(); // idle 到点 → CD 未满 → 修复前：整轮被静默丢弃
+  assert.ok(h.timers.length > 0, "a timer must be re-armed after the CD collision");
+  await h.fireNext(); // 重排的表 → CD 到点 → 自行起跑
+  assert.equal(h.runs(), 2, "second run fires on its own at the CD boundary");
+  assert.ok(
+    h.now() >= firstRunAt + 3_600_000,
+    `second run must wait out the full min interval (fired at +${h.now() - firstRunAt}ms)`
+  );
+  h.store.close();
+});
+
+test("sleep #187: scheduler arms its first timer at construction (no write needed)", async () => {
+  const h = makeHarness();
+  assert.equal(h.timers.length, 1, "construction arms the idle timer");
+  await h.fireNext();
+  assert.equal(h.runs(), 1, "a quiet boot still reaches its first sleep cycle");
+  h.store.close();
+});
+
+test("sleep #187: dispose cancels the construction-armed timer", async () => {
+  const h = makeHarness();
+  await h.sched.dispose();
+  assert.equal(h.timers.length, 0, "dispose clears the armed timer");
+  h.store.close();
+});

package/test/sleep.test.js

@@ -165,8 +165,8 @@ test("sleep: dispose clears the timer and prevents further runs", async () => {
     setTimeoutFn: () => 1,
     clearTimeoutFn: () => { cleared = true; }
   });
-  sched.noteWrite(); // arm the idle timer so dispose has something to clear
-  assert.equal(cleared, false, "timer armed, not yet cleared");
+  // #187 起构造即挂表——dispose 必须能清掉这张（以及 noteWrite 重挂过的任何）表。
+  assert.equal(cleared, false, "timer armed at construction, not yet cleared");
   await sched.dispose();
   assert.equal(cleared, true, "idle timer cleared on dispose");
   assert.equal(sched.shouldRun(1_000_000 + 6 * 60000), false, "disposed never runs");

package/test/standalone-api.test.js

@@ -40,7 +40,7 @@ test("GET /health is open without a token; every other route 401s", async () =>
     assert.equal(health.status, 200);
     assert.deepEqual(await health.json(), { ok: true });
 
-    for (const path of ["/status", "/memories", "/memories/x", "/search?q=x"]) {
+    for (const path of ["/status", "/profile", "/rules", "/memories", "/memories/x", "/search?q=x"]) {
       const res = await fetch(`${base}${path}`);
       assert.equal(res.status, 401, `${path} requires a token`);
       assert.deepEqual(await res.json(), { error: "unauthorized" });
@@ -53,6 +53,39 @@ test("GET /health is open without a token; every other route 401s", async () =>
   }
 });
 
+test("GET /profile and /rules return saved settings", async () => {
+  const { base, auth, settings, close } = await setup();
+  try {
+    settings.setProfile("我是后端工程师");
+    settings.setRules(["先验证再修改", "默认使用中文回复"]);
+
+    const profile = await fetch(`${base}/profile`, { headers: auth });
+    assert.equal(profile.status, 200);
+    assert.deepEqual(await profile.json(), { profile: "我是后端工程师" });
+
+    const rules = await fetch(`${base}/rules`, { headers: auth });
+    assert.equal(rules.status, 200);
+    assert.deepEqual(await rules.json(), { rules: ["先验证再修改", "默认使用中文回复"] });
+  } finally {
+    close();
+  }
+});
+
+test("GET /profile and /rules return empty values when unset", async () => {
+  const { base, auth, close } = await setup();
+  try {
+    const profile = await fetch(`${base}/profile`, { headers: auth });
+    assert.equal(profile.status, 200);
+    assert.deepEqual(await profile.json(), { profile: "" });
+
+    const rules = await fetch(`${base}/rules`, { headers: auth });
+    assert.equal(rules.status, 200);
+    assert.deepEqual(await rules.json(), { rules: [] });
+  } finally {
+    close();
+  }
+});
+
 test("token is persisted into settings kv and reused across restarts", async () => {
   const store = createStore(":memory:");
   const service = createService({ store, mirror: null, config: {} });

package/test/store-vector-cache.test.js

@@ -0,0 +1,98 @@
+import test from "node:test";
+import assert from "node:assert/strict";
+import { createStore } from "../src/store.js";
+
+// 回归（issue #202）：检索路径的固定成本。此前 searchVector 每次调用
+// SELECT * 全表 + 逐行 JSON.parse（993 × 512 维 ≈ 48ms，余弦本身只占 3%），
+// all() 拖着 embedding 列（5k 行 ≈ 9.4MB）且 ORDER BY 无索引走临时 B 树。
+// 本批修复：updated_at 索引入 schema；all() 显式列清单排除 embedding；
+// searchVector 只取 id 列 + 解析缓存（setEmbedding 为单一失效点）+ Top-N 回表。
+
+function make() {
+  const store = createStore(":memory:");
+  return store;
+}
+
+test("#202: updated_at index is created on open (existing DBs included)", () => {
+  const store = make();
+  const row = store.db.prepare(
+    "SELECT name FROM sqlite_master WHERE type='index' AND name='idx_memories_updated'"
+  ).get();
+  assert.ok(row, "idx_memories_updated exists after open");
+  store.close();
+});
+
+test("#202: all() returns full rows (minus embedding) ordered by updated_at desc", () => {
+  const store = make();
+  store.save({ type: "project", title: "旧", content: "c1", importance: 3 });
+  store.save({ type: "decision", title: "新", content: "c2", importance: 3 });
+  const rows = store.all();
+  assert.equal(rows.length, 2);
+  assert.equal(rows[0].title, "新", "most recently updated first");
+  for (const row of rows) {
+    assert.equal(row.content?.length > 0, true, "content present");
+    assert.equal("embedding" in row, false, "embedding never leaks into row objects");
+  }
+  store.close();
+});
+
+test("#202: searchVector cache invalidates on setEmbedding rewrite", () => {
+  const store = make();
+  const { id } = store.save({ type: "project", title: "A", content: "a" });
+  store.setEmbedding(id, [1, 0, 0]);
+
+  // 第一次检索：缓存 v1（[1,0,0] 方向命中）
+  const hitV1 = store.searchVector([1, 0, 0], { limit: 5 });
+  assert.equal(hitV1[0]?.id, id, "v1 direction matches");
+
+  // 重写为正交向量后，旧方向必须不再命中、新方向命中——缓存失效点生效。
+  // （正交余弦=0，threshold=0 会连 0 分一起入选，所以用 0.5 的阈值区分。）
+  store.setEmbedding(id, [0, 1, 0]);
+  const hitStale = store.searchVector([1, 0, 0], { limit: 5, threshold: 0.5 });
+  assert.equal(hitStale.some((r) => r.id === id), false, "stale vector must not match after rewrite");
+  const hitV2 = store.searchVector([0, 1, 0], { limit: 5 });
+  assert.equal(hitV2[0]?.id, id, "new vector matches after rewrite");
+  store.close();
+});
+
+test("#202: setEmbedding(null) drops the row from vector search", () => {
+  const store = make();
+  const { id } = store.save({ type: "project", title: "A", content: "a" });
+  store.setEmbedding(id, [1, 0, 0]);
+  assert.equal(store.searchVector([1, 0, 0], { limit: 5 }).length, 1);
+  store.setEmbedding(id, null);
+  assert.equal(store.searchVector([1, 0, 0], { limit: 5 }).length, 0, "cleared embedding leaves the search set");
+  store.close();
+});
+
+test("#202: searchVector returns full memory rows with scores, sorted desc", () => {
+  const store = make();
+  const a = store.save({ type: "project", title: "标题A", content: "内容A", importance: 4 });
+  const b = store.save({ type: "decision", title: "标题B", content: "内容B", importance: 2 });
+  store.setEmbedding(a.id, [1, 0, 0]);
+  store.setEmbedding(b.id, [0.6, 0.8, 0]);
+
+  const hits = store.searchVector([1, 0, 0], { limit: 5 });
+  assert.equal(hits.length, 2);
+  assert.equal(hits[0].id, a.id, "closest vector first");
+  assert.ok(hits[0].score > hits[1].score, "descending scores");
+  for (const hit of hits) {
+    assert.ok(hit.title && hit.content, "full fields refetched for top hits");
+    assert.equal(typeof hit.score, "number");
+    assert.equal(hit.importance > 0, true, "non-score fields intact");
+  }
+  store.close();
+});
+
+test("#202: getParsedEmbedding / getEmbeddings reflect rewrites (dedup path cache)", () => {
+  const store = make();
+  const { id } = store.save({ type: "project", title: "A", content: "a" });
+  store.setEmbedding(id, [1, 2, 3]);
+  assert.deepEqual(store.getParsedEmbedding(id), [1, 2, 3]);
+  assert.deepEqual(store.getEmbeddings([id]).get(id), [1, 2, 3]);
+
+  store.setEmbedding(id, [4, 5, 6]);
+  assert.deepEqual(store.getParsedEmbedding(id), [4, 5, 6], "cache-first read sees the rewrite");
+  assert.deepEqual(store.getEmbeddings([id]).get(id), [4, 5, 6]);
+  store.close();
+});

package/test/tools-memory-get-schema.test.js

@@ -0,0 +1,65 @@
+// #184 回归：memory_get 的内联输出 schema 漏声明 v0.8.1 的 scope 来源三键
+// （agent_scope_source / workspace_scope_source / scope_decided_at），且
+// additionalProperties:false → toApiList 对被标注行条件展开这些键后，宿主
+// in-process 校验直接拒收（"invalid output"），表现为「个别 id 必失败、多数
+// 正常」。本文件用生产同款校验器（@deepseek-ai/dsh-tools 的
+// validateJsonSchemaValue）复现并防漂移；修复 = memory_get 复用与
+// list/search 共享的 MEMORY_ITEM_SCHEMA，不再维护内联副本。
+import test from "node:test";
+import assert from "node:assert/strict";
+import { validateJsonSchemaValue } from "@deepseek-ai/dsh-tools";
+import { createStore } from "../src/store.js";
+import { createService } from "../src/service.js";
+import { createTools, MEMORY_ITEM_SCHEMA } from "../src/tools.js";
+
+function setup() {
+  const store = createStore(":memory:");
+  const service = createService({ store, mirror: null, config: {} });
+  const registered = [];
+  const ctx = {
+    tools: {
+      register(def) {
+        registered.push(def);
+        return () => {};
+      }
+    }
+  };
+  createTools(ctx, service, {}, undefined);
+  const byName = Object.fromEntries(registered.map((def) => [def.name, def]));
+  return { store, service, byName };
+}
+
+// memory_get.execute 的返回 = { memory: toApiList([getById(id)])[0] }——契约
+// 测试直接对「toApiList 产出的 DTO ↔ 声明的 output schema」做校验（DTO 键的
+// 唯一来源就是 toApiList，execute 只是包装）。
+test("memory_get output validates for fully scope-annotated rows (#184)", () => {
+  const { store, service, byName } = setup();
+  const saved = store.save({
+    type: "preference",
+    title: "annotated row",
+    content: "带全量 scope 来源标注的记忆行",
+    source: "test",
+    agent_scope: "coder",
+    agent_scope_source: "auto",
+    workspace_scope: "proj-alpha",
+    workspace_scope_source: "auto",
+    scope_decided_at: "2026-09-15T00:00:00Z"
+  });
+  const get = byName.memory_get;
+  const dto = service.toApiList([store.getById(saved.id)])[0];
+  const res = { memory: dto };
+  assert.deepEqual(validateJsonSchemaValue(get.output.schema, res), []);
+});
+
+test("memory_get item schema reuses MEMORY_ITEM_SCHEMA (no inline copy) (#184)", () => {
+  const { byName } = setup();
+  const get = byName.memory_get;
+  // defineTool 编译会克隆 schema，恒等不成立——断言键集与严格性同源。
+  const compiled = get.output.schema.properties.memory;
+  assert.deepEqual(
+    Object.keys(compiled.properties).sort(),
+    Object.keys(MEMORY_ITEM_SCHEMA.properties).sort()
+  );
+  assert.equal(compiled.additionalProperties, false);
+  assert.deepEqual(compiled.required.sort(), ["content", "created_at", "id", "importance", "title", "type", "updated_at"]);
+});