@modusensus/dsh-mneme 0.14.0-beta.1 → 0.14.0-beta.2

package/test/persona-addressing.test.js

@@ -1,83 +1,83 @@
-// 修复一：人格寻址的兜底口径。default 卡的存在理由是「这一帧解析不到会话身份」，
-// 而不是「所有没建卡的 agent 都该拿到它」——后者会把某个人格无条件塞进外部 bot 的
-// 会话（DS Bot 那类：它自己带身份与设定，两处身份声明撞在同一帧里）。
-// 现状（personaStrictAddressing 缺省 = false）已由 test/persona-inject.test.js:113
-// 与 :124 钉住，本文件第一条照样锁它——这是 opt-in，不是把别人的行为改了。
-import test from "node:test";
-import assert from "node:assert/strict";
-import { createStore } from "../src/store.js";
-import { createService } from "../src/service.js";
-import { createInjector } from "../src/inject.js";
-import { createSettings } from "../src/settings.js";
-
-function setup(over = {}) {
-  const store = createStore(":memory:");
-  const service = createService({ store, mirror: null, config: {} });
-  const settings = createSettings(store.db);
-  const contexts = [];
-  const ctx = {
-    systemPrompt: {
-      context(def) {
-        contexts.push(def);
-        return () => {};
-      }
-    }
-  };
-  createInjector(ctx, service, settings, { maxInjectedItems: 3, importanceThreshold: 3, ...over });
-  return { store, settings, settingsCtx: contexts.find((c) => c.name === "user-settings") };
-}
-
-const withPreset = (agentPreset) => ({ agent: { session: { id: "s1", header: { agentPreset } } } });
-
-// 种子：default 卡（Amarre）开着 + 一张 zephyr 卡。
-function seed(settings, zephyrEnabled = true) {
-  settings.setPersona({ name: "Amarre", personality: "轻松幽默", enabled: true });
-  settings.setPersonaFor("zephyr", { name: "泽菲尔", personality: "冷危", enabled: zephyrEnabled });
-}
-
-test("缺省（开关关）：没建卡的身份仍落 default——本 PR 不改默认行为", () => {
-  const { store, settings, settingsCtx } = setup({ personaEnabled: true });
-  seed(settings);
-  const text = settingsCtx.text(withPreset("unknown-bot"));
-  assert.ok(text.includes("Amarre"), "personaStrictAddressing 缺省时行为逐字节不变");
-  store.close();
-});
-
-test("strict on：没建卡的身份不注入任何人格行", () => {
-  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
-  seed(settings);
-  settings.setProfile("用户是规划背景");
-  const text = settingsCtx.text(withPreset("unknown-bot"));
-  assert.ok(!text.includes("Amarre"), "外部身份不该收到别人的人格");
-  assert.ok(!text.includes("你的人格名字"), "无人格时整段人格行都不出现，不是留个空标签");
-  store.close();
-});
-
-test("strict on：显式关掉的卡不再回落 default——这让「关掉这张卡」第一次有意义", () => {
-  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
-  seed(settings, false);
-  const text = settingsCtx.text(withPreset("zephyr"));
-  assert.ok(!text.includes("泽菲尔"), "关掉的卡本身不注入");
-  assert.ok(!text.includes("Amarre"), "关掉之后落回 default 等于没关");
-  store.close();
-});
-
-test("strict on：解析不到身份（无 session.header）照旧用 default 卡", () => {
-  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
-  seed(settings);
-  const text = settingsCtx.text({});
-  assert.ok(text.includes("你的人格名字：Amarre"), "无名会话正是 default 卡的受众，strict 不许把它一起关掉");
-  store.close();
-});
-
-test("strict on：命中的卡照常注入，画像与规则不受影响", () => {
-  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
-  seed(settings);
-  settings.setProfile("用户是规划背景");
-  settings.setRules(["不提及用户名"]);
-  const hit = settingsCtx.text(withPreset("zephyr"));
-  assert.ok(hit.includes("你的人格名字：泽菲尔"), "身份命中时行为与现状一致");
-  assert.ok(hit.includes("- 用户画像：用户是规划背景"), "画像恒注入：本开关只管人格行");
-  assert.ok(hit.includes("- 规则：不提及用户名"), "规则恒注入：同上");
-  store.close();
-});
+// 修复一：人格寻址的兜底口径。default 卡的存在理由是「这一帧解析不到会话身份」，
+// 而不是「所有没建卡的 agent 都该拿到它」——后者会把某个人格无条件塞进外部 bot 的
+// 会话（DS Bot 那类：它自己带身份与设定，两处身份声明撞在同一帧里）。
+// 现状（personaStrictAddressing 缺省 = false）已由 test/persona-inject.test.js:113
+// 与 :124 钉住，本文件第一条照样锁它——这是 opt-in，不是把别人的行为改了。
+import test from "node:test";
+import assert from "node:assert/strict";
+import { createStore } from "../src/store.js";
+import { createService } from "../src/service.js";
+import { createInjector } from "../src/inject.js";
+import { createSettings } from "../src/settings.js";
+
+function setup(over = {}) {
+  const store = createStore(":memory:");
+  const service = createService({ store, mirror: null, config: {} });
+  const settings = createSettings(store.db);
+  const contexts = [];
+  const ctx = {
+    systemPrompt: {
+      context(def) {
+        contexts.push(def);
+        return () => {};
+      }
+    }
+  };
+  createInjector(ctx, service, settings, { maxInjectedItems: 3, importanceThreshold: 3, ...over });
+  return { store, settings, settingsCtx: contexts.find((c) => c.name === "user-settings") };
+}
+
+const withPreset = (agentPreset) => ({ agent: { session: { id: "s1", header: { agentPreset } } } });
+
+// 种子：default 卡（Amarre）开着 + 一张 zephyr 卡。
+function seed(settings, zephyrEnabled = true) {
+  settings.setPersona({ name: "Amarre", personality: "轻松幽默", enabled: true });
+  settings.setPersonaFor("zephyr", { name: "泽菲尔", personality: "冷危", enabled: zephyrEnabled });
+}
+
+test("缺省（开关关）：没建卡的身份仍落 default——本 PR 不改默认行为", () => {
+  const { store, settings, settingsCtx } = setup({ personaEnabled: true });
+  seed(settings);
+  const text = settingsCtx.text(withPreset("unknown-bot"));
+  assert.ok(text.includes("Amarre"), "personaStrictAddressing 缺省时行为逐字节不变");
+  store.close();
+});
+
+test("strict on：没建卡的身份不注入任何人格行", () => {
+  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
+  seed(settings);
+  settings.setProfile("用户是规划背景");
+  const text = settingsCtx.text(withPreset("unknown-bot"));
+  assert.ok(!text.includes("Amarre"), "外部身份不该收到别人的人格");
+  assert.ok(!text.includes("你的人格名字"), "无人格时整段人格行都不出现，不是留个空标签");
+  store.close();
+});
+
+test("strict on：显式关掉的卡不再回落 default——这让「关掉这张卡」第一次有意义", () => {
+  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
+  seed(settings, false);
+  const text = settingsCtx.text(withPreset("zephyr"));
+  assert.ok(!text.includes("泽菲尔"), "关掉的卡本身不注入");
+  assert.ok(!text.includes("Amarre"), "关掉之后落回 default 等于没关");
+  store.close();
+});
+
+test("strict on：解析不到身份（无 session.header）照旧用 default 卡", () => {
+  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
+  seed(settings);
+  const text = settingsCtx.text({});
+  assert.ok(text.includes("你的人格名字：Amarre"), "无名会话正是 default 卡的受众，strict 不许把它一起关掉");
+  store.close();
+});
+
+test("strict on：命中的卡照常注入，画像与规则不受影响", () => {
+  const { store, settings, settingsCtx } = setup({ personaEnabled: true, personaStrictAddressing: true });
+  seed(settings);
+  settings.setProfile("用户是规划背景");
+  settings.setRules(["不提及用户名"]);
+  const hit = settingsCtx.text(withPreset("zephyr"));
+  assert.ok(hit.includes("你的人格名字：泽菲尔"), "身份命中时行为与现状一致");
+  assert.ok(hit.includes("- 用户画像：用户是规划背景"), "画像恒注入：本开关只管人格行");
+  assert.ok(hit.includes("- 规则：不提及用户名"), "规则恒注入：同上");
+  store.close();
+});

package/test/persona-api.test.js

@@ -1,172 +1,172 @@
-// Persona API routes: internal (/api/dsh-mneme/persona, requireAuth on write)
-// and standalone (/persona behind the global Bearer gate).
-// Locks: GET reads current value; unauthorized writes are rejected; a corrupt
-// JSON body never lands in the store (design: reports/persona-page-design.md ②).
-// Call shapes mirror test/api.test.js (route registry + FakeRes) and
-// test/standalone-api.test.js (real server on port 0 + fetch).
-import test from "node:test";
-import assert from "node:assert/strict";
-import { EventEmitter } from "node:events";
-import { createStore } from "../src/store.js";
-import { createService } from "../src/service.js";
-import { createApi } from "../src/api.js";
-import { createSettings } from "../src/settings.js";
-import { createStandaloneApi } from "../src/api-standalone.js";
-
-class FakeRes extends EventEmitter {
-  constructor() { super(); this.statusCode = 200; this.body = ""; }
-  writeHead(code, headers) { this.statusCode = code; this.headers = headers; return this; }
-  end(text) { this.body = text ?? ""; this.emit("end"); return this; }
-}
-
-function req(path, method = "GET", body = null, headers = {}) {
-  const r = new EventEmitter();
-  r.url = path;
-  r.method = method;
-  r.headers = headers;
-  if (body !== null) {
-    process.nextTick(() => {
-      r.emit("data", Buffer.from(typeof body === "string" ? body : JSON.stringify(body)));
-      r.emit("end");
-    });
-  }
-  return r;
-}
-
-function setupInternal(apiToken = "") {
-  const store = createStore(":memory:");
-  const service = createService({ store, mirror: null, config: {} });
-  const settings = createSettings(store.db);
-  const commands = {
-    add: (def) => settings.addCommand(def),
-    remove: (id) => settings.removeCommand(id),
-    list: () => settings.listCommands()
-  };
-  const routes = [];
-  const ctx = {
-    webServer: {
-      register(route) {
-        routes.push(route);
-        return () => {};
-      }
-    }
-  };
-  createApi(ctx, service, settings, commands, undefined, undefined, apiToken, {});
-  const route = routes.find((r) => r.path === "/api/dsh-mneme/persona");
-  return { store, settings, route, apiToken };
-}
-
-// ---- internal API（宿主内 /api/dsh-mneme/*） --------------------------------
-
-test("internal GET /persona returns current persona without auth", async () => {
-  const { store, settings, route } = setupInternal();
-  settings.setPersona({ name: "Amarre", enabled: false });
-  const res = new FakeRes();
-  await route.handler(req("/api/dsh-mneme/persona"), res);
-  assert.equal(res.statusCode, 200);
-  assert.equal(JSON.parse(res.body).persona.default.name, "Amarre");
-  store.close();
-});
-
-test("internal PUT /persona without token is rejected and store untouched", async () => {
-  // setupInternal("t")：必须带 token 启动，无 token 的写请求才应被拒
-  // （apiToken 为空时 isAuthorized 恒放行——与 /profile 的既有语义一致）。
-  const { store, settings, route } = setupInternal("t");
-  const res = new FakeRes();
-  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { name: "evil" } }), res);
-  assert.equal(res.statusCode, 401);
-  assert.deepEqual(settings.getPersona(), { default: {}, byAgent: {}, bySession: {} });
-  store.close();
-});
-
-test("internal PUT /persona with token round-trips; corrupt JSON body does not land", async () => {
-  const { store, settings, route } = setupInternal("t");
-  const headers = { authorization: "Bearer t" };
-  const ok = new FakeRes();
-  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { name: "Amarre", enabled: true } }, headers), ok);
-  assert.equal(ok.statusCode, 200);
-  assert.equal(settings.getPersona().default.name, "Amarre");
-  const bad = new FakeRes();
-  await route.handler(req("/api/dsh-mneme/persona", "PUT", "not json", headers), bad);
-  // 路由层对坏 JSON 容错（parseBody 口径：坏体不清空库内值），原样回显现值
-  assert.equal(bad.statusCode, 200);
-  assert.equal(settings.getPersona().default.name, "Amarre");
-  store.close();
-});
-
-test("internal PUT /persona multi-card form replaces fully; legacy form merges default", async () => {
-  const { store, settings, route } = setupInternal("t");
-  const headers = { authorization: "Bearer t" };
-  // 先铺一张 byAgent 卡
-  settings.setPersonaFor("zephyr", { name: "泽菲尔", enabled: true });
-  // 旧形 PUT（单对象）：只动 default、byAgent 保留
-  const legacy = new FakeRes();
-  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { name: "Amarre-改", enabled: true } }, headers), legacy);
-  assert.equal(legacy.statusCode, 200);
-  assert.equal(settings.getPersona().default.name, "Amarre-改");
-  assert.equal(settings.getPersona().byAgent.zephyr.name, "泽菲尔", "legacy PUT keeps byAgent");
-  // 新形 PUT（多卡）：全量替换
-  const multi = new FakeRes();
-  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { default: { name: "默认卡", enabled: true }, byAgent: { zephyr: { name: "泽菲尔-新", enabled: true } } } }, headers), multi);
-  assert.equal(multi.statusCode, 200);
-  const got = settings.getPersona();
-  assert.equal(got.default.name, "默认卡");
-  assert.equal(got.byAgent.zephyr.name, "泽菲尔-新");
-  store.close();
-});
-
-// ---- standalone API（Bearer 数据面，真端口 + fetch） ------------------------
-
-async function setupStandalone() {
-  const store = createStore(":memory:");
-  const service = createService({ store, mirror: null, config: {} });
-  const settings = createSettings(store.db);
-  const api = createStandaloneApi({ service, store, config: {}, settings, logger: null, port: 0 });
-  await api.ready;
-  const base = `http://127.0.0.1:${api.port}`;
-  const auth = { authorization: `Bearer ${api.token}` };
-  return {
-    store, settings, base, auth,
-    close: () => {
-      api.server.closeIdleConnections?.();
-      api.server.close();
-      store.close();
-    }
-  };
-}
-
-test("standalone GET/PUT /persona behind Bearer gate round-trips", async () => {
-  const t = await setupStandalone();
-  try {
-    const get1 = await fetch(`${t.base}/persona`, { headers: t.auth });
-    assert.equal(get1.status, 200);
-    assert.deepEqual((await get1.json()).persona, { default: {}, byAgent: {}, bySession: {} });
-    const put = await fetch(`${t.base}/persona`, {
-      method: "PUT",
-      headers: { ...t.auth, "content-type": "application/json" },
-      body: JSON.stringify({ persona: { name: "Zelphi", enabled: false } })
-    });
-    assert.equal(put.status, 200);
-    assert.equal((await put.json()).persona.default.name, "Zelphi");
-    const bad = await fetch(`${t.base}/persona`, {
-      method: "PUT",
-      headers: { ...t.auth, "content-type": "application/json" },
-      body: "not json"
-    });
-    assert.equal(bad.status, 400);
-    assert.equal(t.settings.getPersona().default.name, "Zelphi");
-  } finally {
-    t.close();
-  }
-});
-
-test("standalone /persona without Bearer is 401", async () => {
-  const t = await setupStandalone();
-  try {
-    const res = await fetch(`${t.base}/persona`, { method: "PUT", body: "{}" });
-    assert.equal(res.status, 401);
-    assert.deepEqual(t.settings.getPersona(), { default: {}, byAgent: {}, bySession: {} });
-  } finally {
-    t.close();
-  }
-});
+// Persona API routes: internal (/api/dsh-mneme/persona, requireAuth on write)
+// and standalone (/persona behind the global Bearer gate).
+// Locks: GET reads current value; unauthorized writes are rejected; a corrupt
+// JSON body never lands in the store (design: reports/persona-page-design.md ②).
+// Call shapes mirror test/api.test.js (route registry + FakeRes) and
+// test/standalone-api.test.js (real server on port 0 + fetch).
+import test from "node:test";
+import assert from "node:assert/strict";
+import { EventEmitter } from "node:events";
+import { createStore } from "../src/store.js";
+import { createService } from "../src/service.js";
+import { createApi } from "../src/api.js";
+import { createSettings } from "../src/settings.js";
+import { createStandaloneApi } from "../src/api-standalone.js";
+
+class FakeRes extends EventEmitter {
+  constructor() { super(); this.statusCode = 200; this.body = ""; }
+  writeHead(code, headers) { this.statusCode = code; this.headers = headers; return this; }
+  end(text) { this.body = text ?? ""; this.emit("end"); return this; }
+}
+
+function req(path, method = "GET", body = null, headers = {}) {
+  const r = new EventEmitter();
+  r.url = path;
+  r.method = method;
+  r.headers = headers;
+  if (body !== null) {
+    process.nextTick(() => {
+      r.emit("data", Buffer.from(typeof body === "string" ? body : JSON.stringify(body)));
+      r.emit("end");
+    });
+  }
+  return r;
+}
+
+function setupInternal(apiToken = "") {
+  const store = createStore(":memory:");
+  const service = createService({ store, mirror: null, config: {} });
+  const settings = createSettings(store.db);
+  const commands = {
+    add: (def) => settings.addCommand(def),
+    remove: (id) => settings.removeCommand(id),
+    list: () => settings.listCommands()
+  };
+  const routes = [];
+  const ctx = {
+    webServer: {
+      register(route) {
+        routes.push(route);
+        return () => {};
+      }
+    }
+  };
+  createApi(ctx, service, settings, commands, undefined, undefined, apiToken, {});
+  const route = routes.find((r) => r.path === "/api/dsh-mneme/persona");
+  return { store, settings, route, apiToken };
+}
+
+// ---- internal API（宿主内 /api/dsh-mneme/*） --------------------------------
+
+test("internal GET /persona returns current persona without auth", async () => {
+  const { store, settings, route } = setupInternal();
+  settings.setPersona({ name: "Amarre", enabled: false });
+  const res = new FakeRes();
+  await route.handler(req("/api/dsh-mneme/persona"), res);
+  assert.equal(res.statusCode, 200);
+  assert.equal(JSON.parse(res.body).persona.default.name, "Amarre");
+  store.close();
+});
+
+test("internal PUT /persona without token is rejected and store untouched", async () => {
+  // setupInternal("t")：必须带 token 启动，无 token 的写请求才应被拒
+  // （apiToken 为空时 isAuthorized 恒放行——与 /profile 的既有语义一致）。
+  const { store, settings, route } = setupInternal("t");
+  const res = new FakeRes();
+  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { name: "evil" } }), res);
+  assert.equal(res.statusCode, 401);
+  assert.deepEqual(settings.getPersona(), { default: {}, byAgent: {}, bySession: {} });
+  store.close();
+});
+
+test("internal PUT /persona with token round-trips; corrupt JSON body does not land", async () => {
+  const { store, settings, route } = setupInternal("t");
+  const headers = { authorization: "Bearer t" };
+  const ok = new FakeRes();
+  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { name: "Amarre", enabled: true } }, headers), ok);
+  assert.equal(ok.statusCode, 200);
+  assert.equal(settings.getPersona().default.name, "Amarre");
+  const bad = new FakeRes();
+  await route.handler(req("/api/dsh-mneme/persona", "PUT", "not json", headers), bad);
+  // 路由层对坏 JSON 容错（parseBody 口径：坏体不清空库内值），原样回显现值
+  assert.equal(bad.statusCode, 200);
+  assert.equal(settings.getPersona().default.name, "Amarre");
+  store.close();
+});
+
+test("internal PUT /persona multi-card form replaces fully; legacy form merges default", async () => {
+  const { store, settings, route } = setupInternal("t");
+  const headers = { authorization: "Bearer t" };
+  // 先铺一张 byAgent 卡
+  settings.setPersonaFor("zephyr", { name: "泽菲尔", enabled: true });
+  // 旧形 PUT（单对象）：只动 default、byAgent 保留
+  const legacy = new FakeRes();
+  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { name: "Amarre-改", enabled: true } }, headers), legacy);
+  assert.equal(legacy.statusCode, 200);
+  assert.equal(settings.getPersona().default.name, "Amarre-改");
+  assert.equal(settings.getPersona().byAgent.zephyr.name, "泽菲尔", "legacy PUT keeps byAgent");
+  // 新形 PUT（多卡）：全量替换
+  const multi = new FakeRes();
+  await route.handler(req("/api/dsh-mneme/persona", "PUT", { persona: { default: { name: "默认卡", enabled: true }, byAgent: { zephyr: { name: "泽菲尔-新", enabled: true } } } }, headers), multi);
+  assert.equal(multi.statusCode, 200);
+  const got = settings.getPersona();
+  assert.equal(got.default.name, "默认卡");
+  assert.equal(got.byAgent.zephyr.name, "泽菲尔-新");
+  store.close();
+});
+
+// ---- standalone API（Bearer 数据面，真端口 + fetch） ------------------------
+
+async function setupStandalone() {
+  const store = createStore(":memory:");
+  const service = createService({ store, mirror: null, config: {} });
+  const settings = createSettings(store.db);
+  const api = createStandaloneApi({ service, store, config: {}, settings, logger: null, port: 0 });
+  await api.ready;
+  const base = `http://127.0.0.1:${api.port}`;
+  const auth = { authorization: `Bearer ${api.token}` };
+  return {
+    store, settings, base, auth,
+    close: () => {
+      api.server.closeIdleConnections?.();
+      api.server.close();
+      store.close();
+    }
+  };
+}
+
+test("standalone GET/PUT /persona behind Bearer gate round-trips", async () => {
+  const t = await setupStandalone();
+  try {
+    const get1 = await fetch(`${t.base}/persona`, { headers: t.auth });
+    assert.equal(get1.status, 200);
+    assert.deepEqual((await get1.json()).persona, { default: {}, byAgent: {}, bySession: {} });
+    const put = await fetch(`${t.base}/persona`, {
+      method: "PUT",
+      headers: { ...t.auth, "content-type": "application/json" },
+      body: JSON.stringify({ persona: { name: "Zelphi", enabled: false } })
+    });
+    assert.equal(put.status, 200);
+    assert.equal((await put.json()).persona.default.name, "Zelphi");
+    const bad = await fetch(`${t.base}/persona`, {
+      method: "PUT",
+      headers: { ...t.auth, "content-type": "application/json" },
+      body: "not json"
+    });
+    assert.equal(bad.status, 400);
+    assert.equal(t.settings.getPersona().default.name, "Zelphi");
+  } finally {
+    t.close();
+  }
+});
+
+test("standalone /persona without Bearer is 401", async () => {
+  const t = await setupStandalone();
+  try {
+    const res = await fetch(`${t.base}/persona`, { method: "PUT", body: "{}" });
+    assert.equal(res.status, 401);
+    assert.deepEqual(t.settings.getPersona(), { default: {}, byAgent: {}, bySession: {} });
+  } finally {
+    t.close();
+  }
+});