@module-federation/nextjs-mf 5.1.2 → 5.2.1

package/README.md

@@ -5,7 +5,7 @@ This plugin enables Module Federation on Next.js
 ### Supports
 
 - next ^11.x.x || ^12.x.x
-- Client side only, SSR is another package currently in beta
+- Client side only, SSR has a PR open. Help needed
 
 I highly recommend referencing this application which takes advantage of the best capabilities:
 https://github.com/module-federation/module-federation-examples
@@ -16,6 +16,8 @@ SSR support for federated applications is much harder, as such - it utilizes a d
 If you need SSR support, consider this package instead - it does everything that nextjs-mf does, and them some.
 https://app.privjs.com/buy/packageDetail?pkg=@module-federation/nextjs-ssr
 
+There is a pull request moving SSR into this repo and package - but it is not ready yet.
+
 ## Whats shared by default?
 
 Under the hood we share some next internals automatically
@@ -132,6 +134,7 @@ new NextFederationPlugin({
     exposePages: true, // `false` by default
     enableImageLoaderFix: true, // `false` by default
     enableUrlLoaderFix: true, // `false` by default
+    skipSharingNextInternals: true // `false` by default
   },
 });
 ```
@@ -139,6 +142,7 @@ new NextFederationPlugin({
 - `exposePages` – exposes automatically all nextjs pages for you and theirs `./pages-map`.
 - `enableImageLoaderFix` – adds public hostname to all assets bundled by `nextjs-image-loader`. So if you serve remoteEntry from `http://example.com` then all bundled assets will get this hostname in runtime. It's something like Base URL in HTML but for federated modules.
 - `enableUrlLoaderFix` – adds public hostname to all assets bundled by `url-loader`.
+- `skipSharingNextInternals` - skips sharing of common nextjs modules. Helpful when you would like explicit control over shared modules, such as a non-nextjs host with a federated nextjs child application.
 
 ## Demo
 

package/lib/NextFederationPlugin.js

@@ -220,13 +220,15 @@ class ChildFederation {
             },
             runtime: false,
             shared: {
-              ...externalizedShares,
+              ...(this._extraOptions.skipSharingNextInternals
+                ? {}
+                : externalizedShares),
               ...this._options.shared,
             },
           }),
           new webpack.web.JsonpTemplatePlugin(childOutput),
           new LoaderTargetPlugin('web'),
-          new LibraryPlugin('var'),
+          new LibraryPlugin(this._options.library.type),
           new webpack.DefinePlugin({
             'process.env.REMOTES': JSON.stringify(this._options.remotes),
             'process.env.CURRENT_HOST': JSON.stringify(this._options.name),
@@ -428,6 +430,14 @@ class NextFederationPlugin {
       );
       this._options.remotes = parsedRemotes;
     }
+    if(this._options.library) {
+      console.error('[mf] you cannot set custom library');
+    }
+    this._options.library = {
+      // assign remote name to object to avoid SWC mangling top level variable
+      type: 'window',
+      name: this._options.name,
+    };
   }
 
   apply(compiler) {

package/lib/loaders/helpers.js

@@ -23,8 +23,9 @@ module.exports.hasLoader = function hasLoader(rule, loaderName) {
       const loader = rule.use[i];
       // check exact name, eg "url-loader" or its path "node_modules/url-loader/dist/cjs.js"
       if (
-        loader.loader === loaderName ||
-        loader.loader.includes(`/${loaderName}/`)
+        loader.loader &&
+        (loader.loader === loaderName ||
+          loader.loader.includes(`/${loaderName}/`))
       ) {
         return true;
       }

package/package.json

@@ -1,7 +1,7 @@
 {
   "public": true,
   "name": "@module-federation/nextjs-mf",
-  "version": "5.1.2",
+  "version": "5.2.1",
   "description": "Module Federation helper for NextJS",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -11,7 +11,8 @@
   "scripts": {
     "demo": "yarn build && cd demo && yarn install && yarn dev",
     "prettier": "prettier --write \"**/*.{js,json,md,ts,tsx}\"",
-    "build": "rm -rf lib && cp -r ./src/ lib/ && rollup -c"
+    "build": "rm -rf lib && cp -r ./src/ lib/ && rollup -c",
+    "prepublishOnly": "yarn build"
   },
   "dependencies": {
     "chalk": "^4.0.0",