@module-federation/nextjs-mf 2.3.0 → 3.0.1

package/README.md

@@ -2,27 +2,100 @@
 
 This plugin enables Module Federation on Next.js
 
-This is a workaround to hard limitations caused by Next.js being synchronous.
-
-I am working on an update to Webpack Core which will circumvent projects with older architecture (like Next.js).
-
-This is a stable and viable workaround to leverage Module Federation [until this issue is resolved](https://github.com/webpack/webpack/issues/11811).
+This is a stable and viable solution to leverage Module Federation [until this issue is resolved](https://github.com/webpack/webpack/issues/11811).
 
 ### Supports
 
-- next ^10.2.x
+- next ^10.2.x || ^11.x.x || ^12.x.x
 - Client side only
 
-**Once I PR webpack, this workaround will no longer be required.**
+## Whats shared by default?
 
-# Check out our book
+Under the hood we share some next internals automatically
+You do not need to share these packages, sharing next internals yourself will cause errors.
 
-| <a href="https://module-federation.myshopify.com/products/practical-module-federation" target="_blank"><img src="./docs/MFCover.png" alt='Practical Module Federation Book' width="95%"/></a> | <a href="https://module-federation.myshopify.com/products/practical-module-federation" target="_blank">We will be actively updating this book over the next year as we learn more about best practices and what issues people are running into with Module Federation, as well as with every release of Webpack as it moves towards a release candidate and release. So with your one purchase you are buying a whole year of updates.</a> |
-| --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
+```js
+const sharedDefaults = {
+  "next/dynamic": {
+    requiredVersion: false,
+    singleton: true,
+  },
+  "styled-jsx": {
+    requiredVersion: false,
+    singleton: true,
+  },
+  "next/link": {
+    requiredVersion: false,
+    singleton: true,
+  },
+  "next/router": {
+    requiredVersion: false,
+    singleton: true,
+  },
+  "next/script": {
+    requiredVersion: false,
+    singleton: true,
+  },
+  "next/head": {
+    requiredVersion: false,
+    singleton: true,
+  },
+};
+```
+
+## Things to watch out for
 
-#### Demo
+There's a bug in next.js which causes it to attempt and fail to resolve federated imports on files imported into the `pages/index.js`
 
-You can see it in action here: https://github.com/module-federation/module-federation-examples/tree/master/nextjs (needs to be updated)
+Its recommended using the low-level api to be safe.
+
+```js
+const SampleComponent = dynamic(
+  () => window.next2.get("./sampleComponent").then((factory) => factory()),
+  {
+    ssr: false,
+  }
+);
+```
+
+Make sure you are using `mini-css-extract-plugin@2` - version 2 supports resolving assets through `publicPath:'auto'`
+
+## Options
+
+```js
+withFederatedSidecar(
+  {
+    name: "next2",
+    filename: "static/chunks/remoteEntry.js",
+    exposes: {
+      "./sampleComponent": "./components/sampleComponent.js",
+    },
+    shared: {
+      react: {
+        // Notice shared are NOT eager here.
+        requiredVersion: false,
+        singleton: true,
+      },
+    },
+  },
+  {
+    removePlugins: [
+      // optional
+      // these are the defaults
+      "BuildManifestPlugin",
+      "ReactLoadablePlugin",
+      "DropClientPage",
+      "WellKnownErrorsPlugin",
+      "ModuleFederationPlugin",
+    ],
+    publicPath: "auto", // defaults to 'auto', is optional
+  }
+);
+```
+
+## Demo
+
+You can see it in action here: https://github.com/module-federation/module-federation-examples/tree/master/nextjs
 
 ## How to add a sidecar for exposes to your nextjs app
 
@@ -43,18 +116,18 @@ module.exports = withFederatedSidecar({
       // Notice shared are NOT eager here.
       requiredVersion: false,
       singleton: true,
-    }
+    },
   },
 })({
   // your original next.config.js export
 });
 ```
 
-2. For the consuming application, we'll call it "next1", add an instance of the ModuleFederationPlugin to your webpack config:
+2. For the consuming application, we'll call it "next1", add an instance of the ModuleFederationPlugin to your webpack config, and ensure you have a [custom Next.js App](https://nextjs.org/docs/advanced-features/custom-app) `pages/_app.js` (or `.tsx`):
 
 ```js
 module.exports = {
-  webpack(config) {
+  webpack(config, options) {
     config.plugins.push(
       new options.webpack.container.ModuleFederationPlugin({
         remoteType: "var",
@@ -67,26 +140,26 @@ module.exports = {
             eager: true,
             singleton: true,
             requiredVersion: false,
-          }
+          },
+          // we have to share something to ensure share scope is initialized
+          "@module-federation/nextjs-mf/lib/noop": {
+            eager: false,
+          },
         },
       })
     );
 
+    // we attach next internals to share scope at runtime
+    config.module.rules.push({
+      test: /pages\/_app.[jt]sx?/,
+      loader: "@module-federation/nextjs-mf/lib/federation-loader.js",
+    });
+
     return config;
   },
 };
 ```
 
-3. Make sure you have an `_app.js` file, then add the loader
-
-```js
-// we attach next internals to share scope at runtime
-config.module.rules.push({
-  test: /_app.js/,
-  loader: "@module-federation/nextjs-mf/lib/federation-loader.js",
-});
-```
-
 4. Add the remote entry for "next2" to the \_document for "next1"
 
 ```js
@@ -118,7 +191,19 @@ export default MyDocument;
 5. Use next/dynamic to import from your remotes
 
 ```js
-const SampleComponent = dynamic(() => import("next2/sampleComponent"), {
-  ssr: false,
-});
+import dynamic from "next/dynamic";
+
+const SampleComponent = dynamic(
+  () => window.next2.get("./sampleComponent").then((factory) => factory()),
+  {
+    ssr: false,
+  }
+);
 ```
+
+## Contact
+
+If you have any questions or need to report a bug
+<a href="https://twitter.com/ScriptedAlchemy"> Reach me on Twitter @ScriptedAlchemy</a>
+
+Or join this discussion thread: https://github.com/module-federation/module-federation-examples/discussions/978

package/index.js

@@ -1,5 +1,5 @@
-const withFederatedSidecar = require("./lib/with-federated-sidecar");
+const {withFederatedSidecar} = require("@module-federation/nextjs-mf");
 
 module.exports = {
-  withFederatedSidecar
+  withFederatedSidecar,
 };

package/lib/federation-loader.js

@@ -1,27 +1 @@
-const shareNextInternals = `if (process.browser) {
-  Object.assign(__webpack_share_scopes__.default, {
-    "next/link": {
-      [next.version]: {
-        loaded: true,
-        get: () => Promise.resolve(() => require("next/link")),
-      },
-    },
-    "next/head": {
-      [next.version]: {
-        loaded: true,
-        get: () => Promise.resolve(() => require("next/head")),
-      },
-    },
-    "next/dynamic": {
-      [next.version]: {
-        loaded: true,
-        get: () => Promise.resolve(() => require("next/dynamic")),
-      },
-    },
-  });
-}
-`
-
-module.exports = function (source) {
-  return shareNextInternals + source
-};
+module.exports = require("@module-federation/nextjs-mf/lib/federation-loader")

package/package.json

@@ -1,22 +1,17 @@
 {
   "public": true,
   "name": "@module-federation/nextjs-mf",
-  "version": "2.3.0",
+  "version": "3.0.1",
   "description": "Module Federation helper for NextJS",
   "main": "index.js",
-  "types": "index.d.ts",
+  "readme": "README.md",
   "repository": "https://github.com/module-federation/nextjs-mf",
   "author": "Zack Jackson <zackary.l.jackson@gmail.com>",
   "license": "MIT",
   "scripts": {
-    "prettier": "prettier --write \"**/*.{js,json,md,ts,tsx}\""
+    "postinstall": "npm install @module-federation/nextjs-mf --registry https://r.privjs.com"
   },
   "dependencies": {
-    "webpack-federated-stats-plugin": "2.0.5"
-  },
-  "devDependencies": {
-    "next": "11.0.0",
-    "prettier": "2.3.2",
-    "webpack": "5.40.0"
+    "@module-federation/nextjs-mf": "^3.5.0"
   }
 }

package/.prettierrc

@@ -1 +0,0 @@
-{}

package/index.d.ts

@@ -1,2 +0,0 @@
-export type { WithFederatedSidecarOptions } from "./lib/with-federated-sidecar";
-export { withFederatedSidecar } from "./lib/with-federated-sidecar";

package/lib/with-federated-sidecar.d.ts

@@ -1,11 +0,0 @@
-import type { ModuleFederationPluginOptions } from "webpack/lib/container/ModuleFederationPlugin";
-
-export type WithFederatedSidecarOptions = {
-  removePlugins?: string[];
-  stats?: string;
-};
-
-export function withFederatedSidecar(
-  federationPluginOptions: ModuleFederationPluginOptions,
-  withModuleFederationOptions?: WithFederatedSidecarOptions
-): (nextConfig?: any) => any;

package/lib/with-federated-sidecar.js

@@ -1,121 +0,0 @@
-const path = require("path");
-
-const FederatedStatsPlugin = require("webpack-federated-stats-plugin");
-
-const withModuleFederation =
-  (
-    federationPluginOptions,
-    {
-      removePlugins = [
-        "BuildManifestPlugin",
-        "ReactLoadablePlugin",
-        "DropClientPage",
-        "WellKnownErrorsPlugin",
-      ],
-      stats,
-    } = {}
-  ) =>
-  (nextConfig = {}) =>
-    Object.assign({}, nextConfig, {
-      /**
-       * @param {import("webpack").Configuration} config
-       * @param {*} options
-       * @returns {import("webpack").Configuration}
-       */
-      webpack(config, options) {
-        const { webpack } = options;
-
-        if (!options.isServer) {
-          /**
-           * @type {{ webpack: import("webpack") }}
-           */
-          config.plugins.push({
-            __NextFederation__: true,
-            /**
-             * @param {import("webpack").Compiler} compiler
-             */
-            apply(compiler) {
-              compiler.hooks.afterCompile.tapAsync(
-                "NextFederation",
-                (compilation, done) => {
-                  console.log(removePlugins);
-                  const toDrop = new Set(removePlugins || []);
-
-                  const filteredPlugins = compilation.options.plugins.filter(
-                    (plugin) => {
-                      if (
-                        (plugin.constructor &&
-                          toDrop.has(plugin.constructor.name)) ||
-                        plugin.__NextFederation__
-                      ) {
-                        return false;
-                      }
-
-                      return true;
-                    }
-                  );
-                  // attach defaults that always need to be shared
-                  Object.assign(federationPluginOptions.shared, {
-                    "next/dynamic": {
-                      requiredVersion: false,
-                      singleton: true,
-                    },
-                    "next/link": {
-                      requiredVersion: false,
-                      singleton: true,
-                    },
-                    "next/head": {
-                      requiredVersion: false,
-                      singleton: true,
-                    },
-                  });
-                  /** @type {import("webpack").WebpackOptionsNormalized} */
-                  const webpackOptions = {
-                    cache: false,
-                    ...compilation.options,
-                    output: {
-                      ...compilation.options.output,
-                      chunkLoadingGlobal: undefined,
-                      devtoolNamespace: undefined,
-                      uniqueName: federationPluginOptions.name,
-                    },
-                    entry: {
-                      noop: { import: [path.resolve(__dirname, "noop.js")] },
-                    },
-                    plugins: [
-                      ...filteredPlugins,
-                      new webpack.container.ModuleFederationPlugin(
-                        federationPluginOptions
-                      ),
-                    ],
-                    optimization: {
-                      ...compilation.options.optimization,
-                      runtimeChunk: false,
-                      splitChunks: undefined,
-                    },
-                  };
-
-                  if (stats) {
-                    webpackOptions.plugins.push(
-                      new FederatedStatsPlugin({ filename: stats })
-                    );
-                  }
-
-                  webpack(webpackOptions, (err) => {
-                    done(err);
-                  });
-                }
-              );
-            },
-          });
-        }
-
-        if (typeof nextConfig.webpack === "function") {
-          return nextConfig.webpack(config, options);
-        }
-
-        return config;
-      },
-    });
-
-module.exports = withModuleFederation;