@modernpoacher/deps 2.2.38 → 2.2.39

package/bin/node/execute.mjs

@@ -126,15 +126,15 @@ async function isHeadDefaultBranch (directory) {
 async function getIgnoreFromConfiguration (directory) {
   log('getIgnoreFromConfiguration')
 
-  const CONFIGURATION = (
-    await hasConfiguration(directory)
-      ? await getConfiguration(directory)
-      : {}
-  )
+  if (await hasConfiguration(directory)) {
+    return (
+      getIgnore(
+        await getConfiguration(directory)
+      )
+    )
+  }
 
-  return (
-    getIgnore(CONFIGURATION)
-  )
+  return false
 }
 
 /**
@@ -147,15 +147,15 @@ async function getIgnoreFromConfiguration (directory) {
 async function getAuthorFromConfiguration (directory) {
   log('getAuthorFromConfiguration')
 
-  const CONFIGURATION = (
-    await hasConfiguration(directory)
-      ? await getConfiguration(directory)
-      : {}
-  )
+  if (await hasConfiguration(directory)) {
+    return (
+      getAuthor(
+        await getConfiguration(directory)
+      )
+    )
+  }
 
-  return (
-    getAuthor(CONFIGURATION)
-  )
+  return null
 }
 
 /**
@@ -168,13 +168,11 @@ async function getAuthorFromConfiguration (directory) {
 async function getAuthorFromGit (directory) {
   log('getAuthorFromGitConfig')
 
-  const GIT = {
-    name: await gitConfigUserName(directory),
-    email: await gitConfigUserEmail(directory)
-  }
-
   return (
-    getAuthor(GIT)
+    getAuthor({
+      name: await gitConfigUserName(directory),
+      email: await gitConfigUserEmail(directory)
+    })
   )
 }
 
@@ -188,15 +186,15 @@ async function getAuthorFromGit (directory) {
 async function getAuthorFromPackage (directory) {
   log('getAuthorFromPackage')
 
-  const PACKAGE = (
-    await hasPackage(directory)
-      ? await getPackage(directory)
-      : {}
-  )
+  if (await hasPackage(directory)) {
+    return (
+      getAuthor(
+        await getPackage(directory)
+      )
+    )
+  }
 
-  return (
-    getAuthor(PACKAGE)
-  )
+  return null
 }
 
 /**
@@ -209,15 +207,15 @@ async function getAuthorFromPackage (directory) {
 async function getMessageFromConfiguration (directory) {
   log('getMessageFromConfiguration')
 
-  const CONFIGURATION = (
-    await hasConfiguration(directory)
-      ? await getConfiguration(directory)
-      : {}
-  )
+  if (await hasConfiguration(directory)) {
+    return (
+      getMessage(
+        await getConfiguration(directory)
+      )
+    )
+  }
 
-  return (
-    getMessage(CONFIGURATION)
-  )
+  return null
 }
 
 /**
@@ -226,7 +224,7 @@ async function getMessageFromConfiguration (directory) {
  *  Ensures that the `author` is set either from the command line,
  *  configuration, package, or a default
  *
- *  Since it can be null `author` may not default in function arguments
+ *  Since it can be null `author` will not default in function arguments
  *  @param {string | { name: string; email: string }} author
  *  @param {string} directory
  *  @returns {Promise<string | { name: string; email: string }>}
@@ -241,7 +239,7 @@ async function toAuthor (author, directory) {
  *  Ensures that the `message` is set either from the command line,
  *  configuration, or a default
  *
- *  Since it can be null `message` may not default in function arguments
+ *  Since it can be null `message` will not default in function arguments
  *  @param {string | null} message
  *  @param {string} directory
  *  @returns {Promise<string>}
@@ -251,21 +249,21 @@ async function toMessage (message, directory) {
 }
 
 /**
+ *  @type {(v: string | undefined) => v is string}
  *  @param {string | undefined} v
  *  @returns {boolean}
  */
-export function filterDeps (v) { // de-falsy
+function filter (v) { // de-falsy
   return Boolean(v)
 }
 
 /**
- *  @param {string[]} a
- *  @param {string} v
- *  @returns {string[]}
+ * @param {string} alpha
+ * @param {string} omega
+ * @returns {number}
  */
-export function reduceDeps (a, v = '') { // de-dupe
-  if (!a.includes(v)) a.push(v)
-  return a
+function sort (alpha, omega) {
+  return alpha.localeCompare(omega)
 }
 
 /**
@@ -288,21 +286,12 @@ async function getPathList (directory) {
   return (
     array
       .map(dirname)
-      .sort()
+      .sort(sort)
   )
 }
 
 /**
- * @param {string} alpha
- * @param {string} omega
- * @returns {number}
- */
-function sort (alpha, omega) {
-  return alpha.localeCompare(omega)
-}
-
-/**
- *  @param {Array<string | undefined>} [directories]
+ *  @param {(string | undefined)[]} [directories]
  *  @returns {Promise<string[]>}
  */
 async function getDepsList (directories = []) {
@@ -313,16 +302,15 @@ async function getDepsList (directories = []) {
    *  @type {string[]}
    */
   const alpha = (
-    directories
-      .filter(Boolean)
-      .reduce(reduceDeps, [])
+    Array.from(new Set(directories))
+      .filter(filter)
       .sort(sort)
   )
 
   try {
     /**
      *  Recreate `directories` from `alpha`
-     *  @type {Array<string | undefined>}
+     *  @type {(string | undefined)[]}
      */
     const directories = (
       await Promise.all(
@@ -336,9 +324,8 @@ async function getDepsList (directories = []) {
      *  @type {string[]}
      */
     const omega = (
-      directories
-        .filter(Boolean)
-        .reduce(reduceDeps, [])
+      Array.from(new Set(directories))
+        .filter(filter)
         .sort(sort)
     )
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@modernpoacher/deps",
-  "version": "2.2.38",
+  "version": "2.2.39",
   "description": "Update NPM package dependencies from the command line",
   "keywords": [
     "deps",
@@ -54,7 +54,7 @@
     "deps-wipe": "bin/deps/wipe.sh"
   },
   "dependencies": {
-    "@sequencemedia/write": "^0.2.14",
+    "@sequencemedia/write": "^0.2.15",
     "commander": "^14.0.1",
     "debug": "^4.4.3",
     "glob": "^11.0.3",
@@ -62,8 +62,8 @@
     "supports-color": "^10.2.2"
   },
   "devDependencies": {
-    "@sequencemedia/eslint-config-standard": "^0.2.88",
-    "@sequencemedia/eslint-config-typescript": "^0.1.150",
+    "@sequencemedia/eslint-config-standard": "^0.2.89",
+    "@sequencemedia/eslint-config-typescript": "^0.1.151",
     "@sequencemedia/eslint-merge": "^0.0.54",
     "@types/chai": "^5.2.2",
     "@types/debug": "^4.1.12",
@@ -73,7 +73,7 @@
     "chai": "^6.2.0",
     "cross-env": "^10.1.0",
     "eslint": "^9.37.0",
-    "eslint-plugin-jsdoc": "^60.7.1",
+    "eslint-plugin-jsdoc": "^60.8.0",
     "globals": "^16.4.0",
     "husky": "^9.1.7",
     "mocha": "^11.7.4"