@modern-js/plugin-garfish 2.68.19-alpha.3 → 2.68.19-alpha.4

package/dist/cjs/runtime/utils/apps.js

@@ -55,13 +55,19 @@ function pathJoin(...args) {
   }, "");
   return res || "/";
 }
-function deepEqualExcludeFunctions(prev, next) {
+function deepEqualExcludeFunctions(prev, next, visited) {
   if (prev === next)
     return true;
   if (!prev || !next)
     return false;
   if (typeof prev !== "object" || typeof next !== "object")
     return false;
+  const visitedSet = visited !== null && visited !== void 0 ? visited : /* @__PURE__ */ new WeakSet();
+  if (visitedSet.has(prev) || visitedSet.has(next)) {
+    return true;
+  }
+  visitedSet.add(prev);
+  visitedSet.add(next);
   const prevKeys = Object.keys(prev).filter((key) => typeof prev[key] !== "function");
   const nextKeys = Object.keys(next).filter((key) => typeof next[key] !== "function");
   if (prevKeys.length !== nextKeys.length)
@@ -75,7 +81,7 @@ function deepEqualExcludeFunctions(prev, next) {
       continue;
     }
     if (typeof prevVal === "object" && typeof nextVal === "object") {
-      if (!deepEqualExcludeFunctions(prevVal, nextVal)) {
+      if (!deepEqualExcludeFunctions(prevVal, nextVal, visitedSet)) {
         return false;
       }
     } else if (prevVal !== nextVal) {
@@ -113,6 +119,8 @@ function getAppInstance(options, appInfo, manifest) {
     const useHistory = (_props_useHistory = props.useHistory) !== null && _props_useHistory !== void 0 ? _props_useHistory : context === null || context === void 0 ? void 0 : (_context_router3 = context.router) === null || _context_router3 === void 0 ? void 0 : _context_router3.useHistory;
     var _props_useHistory1;
     const useHref = (_props_useHistory1 = props.useHistory) !== null && _props_useHistory1 !== void 0 ? _props_useHistory1 : context === null || context === void 0 ? void 0 : (_context_router4 = context.router) === null || _context_router4 === void 0 ? void 0 : _context_router4.useHref;
+    const lastPropsUpdateKeyRef = (0, import_react.useRef)(0);
+    const isRemountingRef = (0, import_react.useRef)(false);
     const match = useRouteMatch === null || useRouteMatch === void 0 ? void 0 : useRouteMatch();
     const matchs = useMatches === null || useMatches === void 0 ? void 0 : useMatches();
     if (!useLocation) {
@@ -169,12 +177,24 @@ or directly pass the "basename":
       locationPathname
     ]);
     (0, import_react.useEffect)(() => {
+      if (previousPropsRef.current === props) {
+        return;
+      }
       const prevPropsForCompare = {
         ...previousPropsRef.current
       };
       const currentPropsForCompare = {
         ...props
       };
+      const ignoredKeysForRemount = [
+        "style",
+        "location",
+        "match",
+        "history",
+        "staticContext",
+        "guideState",
+        "guideConfig"
+      ];
       Object.keys(prevPropsForCompare).forEach((key) => {
         if (typeof prevPropsForCompare[key] === "function") {
           delete prevPropsForCompare[key];
@@ -185,11 +205,27 @@ or directly pass the "basename":
           delete currentPropsForCompare[key];
         }
       });
-      if (!deepEqualExcludeFunctions(prevPropsForCompare, currentPropsForCompare)) {
+      const prevPropsForDeepCompare = {};
+      const currentPropsForDeepCompare = {};
+      Object.keys(prevPropsForCompare).forEach((key) => {
+        if (!ignoredKeysForRemount.includes(key)) {
+          prevPropsForDeepCompare[key] = prevPropsForCompare[key];
+        }
+      });
+      Object.keys(currentPropsForCompare).forEach((key) => {
+        if (!ignoredKeysForRemount.includes(key)) {
+          currentPropsForDeepCompare[key] = currentPropsForCompare[key];
+        }
+      });
+      const propsEqual = deepEqualExcludeFunctions(prevPropsForDeepCompare, currentPropsForDeepCompare);
+      if (!propsEqual) {
         previousPropsRef.current = props;
         propsRef.current = props;
         propsUpdateCounterRef.current += 1;
         setPropsUpdateKey((prev) => prev + 1);
+      } else {
+        previousPropsRef.current = props;
+        propsRef.current = props;
       }
     }, [
       props,
@@ -320,6 +356,10 @@ or directly pass the "basename":
     (0, import_react.useEffect)(() => {
       var _appRef_current;
       const componetRenderMode = manifest === null || manifest === void 0 ? void 0 : manifest.componentRender;
+      if (propsUpdateKey === lastPropsUpdateKeyRef.current || isRemountingRef.current) {
+        return;
+      }
+      lastPropsUpdateKeyRef.current = propsUpdateKey;
       if (componetRenderMode && ((_appRef_current = appRef.current) === null || _appRef_current === void 0 ? void 0 : _appRef_current.mounted)) {
         const componentToUse = SubModuleComponent || componentRef.current;
         if (componentToUse) {
@@ -343,6 +383,9 @@ or directly pass the "basename":
             setTimeout(() => {
               var _appRef_current3;
               (_appRef_current3 = appRef.current) === null || _appRef_current3 === void 0 ? void 0 : _appRef_current3.show();
+              setTimeout(() => {
+                isRemountingRef.current = false;
+              }, 100);
             }, 10);
           }
         }

package/dist/esm/runtime/utils/apps.js

@@ -32,13 +32,19 @@ function pathJoin() {
   }, "");
   return res || "/";
 }
-function deepEqualExcludeFunctions(prev, next) {
+function deepEqualExcludeFunctions(prev, next, visited) {
   if (prev === next)
     return true;
   if (!prev || !next)
     return false;
   if ((typeof prev === "undefined" ? "undefined" : _type_of(prev)) !== "object" || (typeof next === "undefined" ? "undefined" : _type_of(next)) !== "object")
     return false;
+  var visitedSet = visited !== null && visited !== void 0 ? visited : /* @__PURE__ */ new WeakSet();
+  if (visitedSet.has(prev) || visitedSet.has(next)) {
+    return true;
+  }
+  visitedSet.add(prev);
+  visitedSet.add(next);
   var prevKeys = Object.keys(prev).filter(function(key2) {
     return typeof prev[key2] !== "function";
   });
@@ -59,7 +65,7 @@ function deepEqualExcludeFunctions(prev, next) {
         continue;
       }
       if ((typeof prevVal === "undefined" ? "undefined" : _type_of(prevVal)) === "object" && (typeof nextVal === "undefined" ? "undefined" : _type_of(nextVal)) === "object") {
-        if (!deepEqualExcludeFunctions(prevVal, nextVal)) {
+        if (!deepEqualExcludeFunctions(prevVal, nextVal, visitedSet)) {
           return false;
         }
       } else if (prevVal !== nextVal) {
@@ -111,6 +117,8 @@ function getAppInstance(options, appInfo, manifest) {
     var useHistory = (_props_useHistory = props.useHistory) !== null && _props_useHistory !== void 0 ? _props_useHistory : context === null || context === void 0 ? void 0 : (_context_router3 = context.router) === null || _context_router3 === void 0 ? void 0 : _context_router3.useHistory;
     var _props_useHistory1;
     var useHref = (_props_useHistory1 = props.useHistory) !== null && _props_useHistory1 !== void 0 ? _props_useHistory1 : context === null || context === void 0 ? void 0 : (_context_router4 = context.router) === null || _context_router4 === void 0 ? void 0 : _context_router4.useHref;
+    var lastPropsUpdateKeyRef = useRef(0);
+    var isRemountingRef = useRef(false);
     var match = useRouteMatch === null || useRouteMatch === void 0 ? void 0 : useRouteMatch();
     var matchs = useMatches === null || useMatches === void 0 ? void 0 : useMatches();
     if (!useLocation) {
@@ -165,8 +173,20 @@ or directly pass the "basename":
       locationPathname
     ]);
     useEffect(function() {
+      if (previousPropsRef.current === props) {
+        return;
+      }
       var prevPropsForCompare = _object_spread({}, previousPropsRef.current);
       var currentPropsForCompare = _object_spread({}, props);
+      var ignoredKeysForRemount = [
+        "style",
+        "location",
+        "match",
+        "history",
+        "staticContext",
+        "guideState",
+        "guideConfig"
+      ];
       Object.keys(prevPropsForCompare).forEach(function(key2) {
         if (typeof prevPropsForCompare[key2] === "function") {
           delete prevPropsForCompare[key2];
@@ -177,13 +197,29 @@ or directly pass the "basename":
           delete currentPropsForCompare[key2];
         }
       });
-      if (!deepEqualExcludeFunctions(prevPropsForCompare, currentPropsForCompare)) {
+      var prevPropsForDeepCompare = {};
+      var currentPropsForDeepCompare = {};
+      Object.keys(prevPropsForCompare).forEach(function(key2) {
+        if (!ignoredKeysForRemount.includes(key2)) {
+          prevPropsForDeepCompare[key2] = prevPropsForCompare[key2];
+        }
+      });
+      Object.keys(currentPropsForCompare).forEach(function(key2) {
+        if (!ignoredKeysForRemount.includes(key2)) {
+          currentPropsForDeepCompare[key2] = currentPropsForCompare[key2];
+        }
+      });
+      var propsEqual = deepEqualExcludeFunctions(prevPropsForDeepCompare, currentPropsForDeepCompare);
+      if (!propsEqual) {
         previousPropsRef.current = props;
         propsRef.current = props;
         propsUpdateCounterRef.current += 1;
         setPropsUpdateKey(function(prev) {
           return prev + 1;
         });
+      } else {
+        previousPropsRef.current = props;
+        propsRef.current = props;
       }
     }, [
       props,
@@ -371,6 +407,10 @@ or directly pass the "basename":
     useEffect(function() {
       var _appRef_current;
       var componetRenderMode = manifest === null || manifest === void 0 ? void 0 : manifest.componentRender;
+      if (propsUpdateKey === lastPropsUpdateKeyRef.current || isRemountingRef.current) {
+        return;
+      }
+      lastPropsUpdateKeyRef.current = propsUpdateKey;
       if (componetRenderMode && ((_appRef_current = appRef.current) === null || _appRef_current === void 0 ? void 0 : _appRef_current.mounted)) {
         var componentToUse = SubModuleComponent || componentRef.current;
         if (componentToUse) {
@@ -394,6 +434,9 @@ or directly pass the "basename":
             setTimeout(function() {
               var _appRef_current3;
               (_appRef_current3 = appRef.current) === null || _appRef_current3 === void 0 ? void 0 : _appRef_current3.show();
+              setTimeout(function() {
+                isRemountingRef.current = false;
+              }, 100);
             }, 10);
           }
         }

package/dist/esm-node/runtime/utils/apps.js

@@ -21,13 +21,19 @@ function pathJoin(...args) {
   }, "");
   return res || "/";
 }
-function deepEqualExcludeFunctions(prev, next) {
+function deepEqualExcludeFunctions(prev, next, visited) {
   if (prev === next)
     return true;
   if (!prev || !next)
     return false;
   if (typeof prev !== "object" || typeof next !== "object")
     return false;
+  const visitedSet = visited !== null && visited !== void 0 ? visited : /* @__PURE__ */ new WeakSet();
+  if (visitedSet.has(prev) || visitedSet.has(next)) {
+    return true;
+  }
+  visitedSet.add(prev);
+  visitedSet.add(next);
   const prevKeys = Object.keys(prev).filter((key) => typeof prev[key] !== "function");
   const nextKeys = Object.keys(next).filter((key) => typeof next[key] !== "function");
   if (prevKeys.length !== nextKeys.length)
@@ -41,7 +47,7 @@ function deepEqualExcludeFunctions(prev, next) {
       continue;
     }
     if (typeof prevVal === "object" && typeof nextVal === "object") {
-      if (!deepEqualExcludeFunctions(prevVal, nextVal)) {
+      if (!deepEqualExcludeFunctions(prevVal, nextVal, visitedSet)) {
         return false;
       }
     } else if (prevVal !== nextVal) {
@@ -79,6 +85,8 @@ function getAppInstance(options, appInfo, manifest) {
     const useHistory = (_props_useHistory = props.useHistory) !== null && _props_useHistory !== void 0 ? _props_useHistory : context === null || context === void 0 ? void 0 : (_context_router3 = context.router) === null || _context_router3 === void 0 ? void 0 : _context_router3.useHistory;
     var _props_useHistory1;
     const useHref = (_props_useHistory1 = props.useHistory) !== null && _props_useHistory1 !== void 0 ? _props_useHistory1 : context === null || context === void 0 ? void 0 : (_context_router4 = context.router) === null || _context_router4 === void 0 ? void 0 : _context_router4.useHref;
+    const lastPropsUpdateKeyRef = useRef(0);
+    const isRemountingRef = useRef(false);
     const match = useRouteMatch === null || useRouteMatch === void 0 ? void 0 : useRouteMatch();
     const matchs = useMatches === null || useMatches === void 0 ? void 0 : useMatches();
     if (!useLocation) {
@@ -135,12 +143,24 @@ or directly pass the "basename":
       locationPathname
     ]);
     useEffect(() => {
+      if (previousPropsRef.current === props) {
+        return;
+      }
       const prevPropsForCompare = {
         ...previousPropsRef.current
       };
       const currentPropsForCompare = {
         ...props
       };
+      const ignoredKeysForRemount = [
+        "style",
+        "location",
+        "match",
+        "history",
+        "staticContext",
+        "guideState",
+        "guideConfig"
+      ];
       Object.keys(prevPropsForCompare).forEach((key) => {
         if (typeof prevPropsForCompare[key] === "function") {
           delete prevPropsForCompare[key];
@@ -151,11 +171,27 @@ or directly pass the "basename":
           delete currentPropsForCompare[key];
         }
       });
-      if (!deepEqualExcludeFunctions(prevPropsForCompare, currentPropsForCompare)) {
+      const prevPropsForDeepCompare = {};
+      const currentPropsForDeepCompare = {};
+      Object.keys(prevPropsForCompare).forEach((key) => {
+        if (!ignoredKeysForRemount.includes(key)) {
+          prevPropsForDeepCompare[key] = prevPropsForCompare[key];
+        }
+      });
+      Object.keys(currentPropsForCompare).forEach((key) => {
+        if (!ignoredKeysForRemount.includes(key)) {
+          currentPropsForDeepCompare[key] = currentPropsForCompare[key];
+        }
+      });
+      const propsEqual = deepEqualExcludeFunctions(prevPropsForDeepCompare, currentPropsForDeepCompare);
+      if (!propsEqual) {
         previousPropsRef.current = props;
         propsRef.current = props;
         propsUpdateCounterRef.current += 1;
         setPropsUpdateKey((prev) => prev + 1);
+      } else {
+        previousPropsRef.current = props;
+        propsRef.current = props;
       }
     }, [
       props,
@@ -286,6 +322,10 @@ or directly pass the "basename":
     useEffect(() => {
       var _appRef_current;
       const componetRenderMode = manifest === null || manifest === void 0 ? void 0 : manifest.componentRender;
+      if (propsUpdateKey === lastPropsUpdateKeyRef.current || isRemountingRef.current) {
+        return;
+      }
+      lastPropsUpdateKeyRef.current = propsUpdateKey;
       if (componetRenderMode && ((_appRef_current = appRef.current) === null || _appRef_current === void 0 ? void 0 : _appRef_current.mounted)) {
         const componentToUse = SubModuleComponent || componentRef.current;
         if (componentToUse) {
@@ -309,6 +349,9 @@ or directly pass the "basename":
             setTimeout(() => {
               var _appRef_current3;
               (_appRef_current3 = appRef.current) === null || _appRef_current3 === void 0 ? void 0 : _appRef_current3.show();
+              setTimeout(() => {
+                isRemountingRef.current = false;
+              }, 100);
             }, 10);
           }
         }

package/package.json

@@ -15,7 +15,7 @@
     "modern",
     "modern.js"
   ],
-  "version": "2.68.19-alpha.3",
+  "version": "2.68.19-alpha.4",
   "jsnext:source": "./src/cli/index.ts",
   "types": "./dist/types/cli/index.d.ts",
   "typesVersions": {
@@ -70,8 +70,8 @@
     "garfish": "^1.8.1",
     "react-loadable": "^5.5.0",
     "@modern-js/plugin-v2": "2.68.18",
-    "@modern-js/utils": "2.68.18",
-    "@modern-js/runtime-utils": "2.68.18"
+    "@modern-js/runtime-utils": "2.68.18",
+    "@modern-js/utils": "2.68.18"
   },
   "peerDependencies": {
     "@modern-js/runtime": "^2.68.18",
@@ -93,13 +93,13 @@
     "react-dom": "^18.3.1",
     "react-router-dom": "6.27.0",
     "typescript": "^5",
-    "@modern-js/app-tools": "2.68.18",
     "@scripts/build": "2.66.0",
+    "@modern-js/app-tools": "2.68.18",
+    "@modern-js/core": "2.68.18",
+    "@modern-js/types": "2.68.18",
     "@modern-js/runtime": "2.68.18",
     "@modern-js/plugin-router-v5": "2.68.18",
-    "@modern-js/types": "2.68.18",
-    "@scripts/jest-config": "2.66.0",
-    "@modern-js/core": "2.68.18"
+    "@scripts/jest-config": "2.66.0"
   },
   "sideEffects": false,
   "publishConfig": {