@modern-js/node-bundle-require 1.3.0 → 1.3.1

package/.eslintrc.js

@@ -0,0 +1,8 @@
+module.exports = {
+  root: true,
+  extends: ['@modern-js'],
+  parserOptions: {
+    tsconfigRootDir: __dirname,
+    project: ['./tsconfig.json'],
+  },
+};

package/CHANGELOG.md

@@ -1,5 +1,16 @@
 # @modern-js/node-bundle-require
 
+## 1.3.1
+
+### Patch Changes
+
+- b8599d09: fix: failed to generate webpack cache
+- 6cffe99d: chore:
+  remove react eslint rules for `modern-js` rule set.
+  add .eslintrc for each package to speed up linting
+- 04ae5262: chore: bump @modern-js/utils to v1.4.1 in dependencies
+- 60f7d8bf: feat: add tests dir to npmignore
+
 ## 1.3.0
 
 ### Minor Changes

package/dist/js/modern/index.js

@@ -1,15 +1,29 @@
 import { fs } from '@modern-js/utils';
 import { bundle } from "./bundle";
 export { bundle };
+
+function deleteRequireCache(path) {
+  if (require.cache[path]) {
+    delete require.cache[path];
+  }
+
+  if (module.children) {
+    module.children = module.children.filter(item => item.filename !== path);
+  }
+}
+
 export async function bundleRequire(filepath, options) {
   const configFile = await bundle(filepath, options);
   let mod;
   const req = (options === null || options === void 0 ? void 0 : options.require) || require;
 
   try {
-    mod = await req(configFile);
+    mod = await req(configFile); // Webpack will check require history for persistent cache.
+    // If webpack can not resolve the file, the previous cache pack will become invalid.
+    // The bundled file is temporary, so we should clear the require history to avoid breaking the webpack cache.
+
+    deleteRequireCache(configFile);
   } finally {
-    // Remove the configFile after executed
     fs.unlinkSync(configFile);
   }
 

package/dist/js/node/index.js

@@ -15,15 +15,28 @@ var _utils = require("@modern-js/utils");
 
 var _bundle = require("./bundle");
 
+function deleteRequireCache(path) {
+  if (require.cache[path]) {
+    delete require.cache[path];
+  }
+
+  if (module.children) {
+    module.children = module.children.filter(item => item.filename !== path);
+  }
+}
+
 async function bundleRequire(filepath, options) {
   const configFile = await (0, _bundle.bundle)(filepath, options);
   let mod;
   const req = (options === null || options === void 0 ? void 0 : options.require) || require;
 
   try {
-    mod = await req(configFile);
+    mod = await req(configFile); // Webpack will check require history for persistent cache.
+    // If webpack can not resolve the file, the previous cache pack will become invalid.
+    // The bundled file is temporary, so we should clear the require history to avoid breaking the webpack cache.
+
+    deleteRequireCache(configFile);
   } finally {
-    // Remove the configFile after executed
     _utils.fs.unlinkSync(configFile);
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@modern-js/node-bundle-require",
-  "version": "1.3.0",
+  "version": "1.3.1",
   "description": "The meta-framework suite designed from scratch for frontend-focused modern web development.",
   "homepage": "https://modernjs.dev",
   "bugs": "https://github.com/modern-js-dev/modern.js/issues",
@@ -44,7 +44,7 @@
     "nanoid": "^3.3.2"
   },
   "devDependencies": {
-    "@modern-js/utils": "^1.4.0",
+    "@modern-js/utils": "^1.5.0",
     "@scripts/build": "0.0.0",
     "@scripts/jest-config": "0.0.0",
     "@types/jest": "^26.0.9",

package/tests/.eslintrc.js

@@ -1,6 +0,0 @@
-module.exports = {
-  extends: '@modern-js',
-  parserOptions: {
-    project: require.resolve('./tsconfig.json'),
-  },
-};

package/tests/fixture/a.ts

@@ -1,2 +0,0 @@
-export const filename: string = __filename;
-export const showFileName = () => filename;

package/tests/fixture/input.ts

@@ -1,5 +0,0 @@
-import * as a from './a';
-
-export default {
-  a,
-};

package/tests/index.test.ts

@@ -1,27 +0,0 @@
-import path from 'path';
-import { bundleRequire } from '../src';
-import { EXTERNAL_REGEXP } from '../src/bundle';
-
-test('require', async () => {
-  const result = await bundleRequire(
-    path.join(__dirname, './fixture/input.ts'),
-  );
-  // when tsconfig.json sets `compilerOptions.target` to `es5`
-  // normally it will met error
-  // So we need to manually set esbuild's target to esnext to avoid that
-  // These two cases above use ES6+ ability, to test whether esbuild successfuly
-  // works on non-ES5 files
-  // reference: https://github.com/evanw/esbuild/releases/tag/v0.12.6
-  expect(result.default.a.filename.endsWith('a.ts')).toEqual(true);
-  expect(result.default.a.showFileName().endsWith('a.ts')).toEqual(true);
-});
-
-describe('external regexp', () => {
-  expect(EXTERNAL_REGEXP.test('./test')).toBeFalsy();
-  expect(EXTERNAL_REGEXP.test('/test')).toBeFalsy();
-  expect(EXTERNAL_REGEXP.test('c:/foo')).toBeTruthy();
-  expect(EXTERNAL_REGEXP.test('C:/foo')).toBeTruthy();
-  expect(EXTERNAL_REGEXP.test('c:/node_modules/foo')).toBeTruthy();
-  expect(EXTERNAL_REGEXP.test('foo')).toBeTruthy();
-  expect(EXTERNAL_REGEXP.test('/test/node_modules')).toBeFalsy();
-});

package/tests/modern-app-env.d.ts

@@ -1,2 +0,0 @@
-/// <reference types="@modern-js/module-tools/types" />
-/// <reference types="@modern-js/plugin-testing/types" />

package/tests/tsconfig.json

@@ -1,10 +0,0 @@
-{
-  "extends": "@modern-js/tsconfig/base",
-  "compilerOptions": {
-    "declaration": false,
-    "target": "es5",
-    "jsx": "preserve",
-    "baseUrl": "./",
-    "paths": {}
-  }
-}