@modern-js/core 1.4.6 → 1.6.1

package/tests/config.test.ts

@@ -26,7 +26,7 @@ jest.mock('@modern-js/utils', () => ({
 
 describe('config', () => {
   /**
-   * Typescript Type annotations cannot be used for esbuild-jest
+   * TypeScript Type annotations cannot be used for esbuild-jest
    * test files that use jest.mock('@some/module')
    * refer to this esbuild-jest issue:
    * https://github.com/aelbore/esbuild-jest/issues/57

package/tests/initWatcher.test.ts

@@ -8,7 +8,7 @@ const mockAppDirectory = path.join(__dirname, './fixtures/index-test');
 const mockConfigDir = './config';
 const mockSrcDirectory = path.join(mockAppDirectory, './src');
 
-describe('initWatcher', () => {
+describe.skip('initWatcher', () => {
   afterAll(() => {
     const file = path.join(mockSrcDirectory, './index.ts');
     if (fs.existsSync(file)) {

package/tests/loadPlugin.test.ts

@@ -1,4 +1,5 @@
 import path from 'path';
+import { CliPlugin } from '../src';
 import { loadPlugins, getAppPlugins } from '../src/loadPlugins';
 
 describe('load plugins', () => {
@@ -33,14 +34,10 @@ describe('load plugins', () => {
       {
         cli: {
           name: 'a',
-          pluginPath: path.join(fixture, './test-plugin-a.js'),
         },
-        cliPkg: path.join(fixture, './test-plugin-a.js'),
       },
       {
-        server: {
-          pluginPath: path.join(fixture, './test-plugin-b.js'),
-        },
+        server: './test-plugin-b',
         serverPkg: './test-plugin-b',
       },
     ]);
@@ -56,22 +53,8 @@ describe('load plugins', () => {
       plugins: [{ cli: ['./test-plugin-c', 'c'] }, ['./test-plugin-c', 'c2']],
     });
 
-    expect(plugins).toEqual([
-      {
-        cli: {
-          name: 'c',
-          pluginPath: path.join(fixture, './test-plugin-c.js'),
-        },
-        cliPkg: './test-plugin-c',
-      },
-      {
-        cli: {
-          name: 'c2',
-          pluginPath: path.join(fixture, './test-plugin-c.js'),
-        },
-        cliPkg: './test-plugin-c',
-      },
-    ]);
+    expect(plugins[0].cli!.name).toEqual('c');
+    expect(plugins[1].cli!.name).toEqual('c2');
   });
 
   test('should load user string plugin successfully', () => {
@@ -88,33 +71,11 @@ describe('load plugins', () => {
       {
         cli: {
           name: 'a',
-          pluginPath: path.join(fixture, './test-plugin-a.js'),
         },
-        cliPkg: path.join(fixture, './test-plugin-a.js'),
       },
     ]);
   });
 
-  test('should call transformPlugin', () => {
-    const fixture = path.resolve(
-      __dirname,
-      './fixtures/load-plugin/user-plugins',
-    );
-
-    const options = {
-      transformPlugin: jest.fn(),
-    };
-    options.transformPlugin.mockImplementation((plugins, _) => plugins);
-
-    loadPlugins(
-      fixture,
-      { plugins: [{ cli: path.join(fixture, './test-plugin-a.js') }] },
-      options,
-    );
-
-    expect(options.transformPlugin).toHaveBeenCalled();
-  });
-
   test(`should throw error when plugin not found `, () => {
     const fixture = path.resolve(__dirname, './fixtures/load-plugin/not-found');
 
@@ -124,4 +85,32 @@ describe('load plugins', () => {
       });
     }).toThrowError(/^Can not find plugin /);
   });
+
+  test(`should load new plugin array correctly`, () => {
+    const appDirectory = path.resolve(
+      __dirname,
+      './fixtures/load-plugin/user-plugins',
+    );
+    const plugin = (): CliPlugin => ({
+      name: 'foo',
+    });
+    const userConfig = { plugins: [plugin()] };
+    const loadedPlugins = loadPlugins(appDirectory, userConfig);
+
+    expect(loadedPlugins[0].cli?.name).toEqual('foo');
+  });
+
+  test(`should load new plugin object correctly`, () => {
+    const appDirectory = path.resolve(
+      __dirname,
+      './fixtures/load-plugin/user-plugins',
+    );
+    const plugin = (): CliPlugin => ({
+      name: 'foo',
+    });
+    const userConfig = { plugins: { cli: [plugin()] } };
+    const loadedPlugins = loadPlugins(appDirectory, userConfig);
+
+    expect(loadedPlugins[0].cli?.name).toEqual('foo');
+  });
 });

package/tests/pluginAPI.test.ts

@@ -0,0 +1,19 @@
+import { CliPlugin, manager } from '../src';
+
+describe('pluginAPI', () => {
+  it('api.setAppContext', done => {
+    const plugin = (): CliPlugin => ({
+      setup(api) {
+        api.setAppContext({
+          ...api.useAppContext(),
+          packageName: 'foo',
+        });
+
+        expect(api.useAppContext().packageName).toEqual('foo');
+        done();
+      },
+    });
+
+    manager.clone().usePlugin(plugin).init();
+  });
+});