@modern-js-app/eslint-config 1.2.5 → 1.2.8

package/CHANGELOG.md

@@ -1,5 +1,38 @@
 # @modern-js-app/eslint-config
 
+## 1.2.8
+
+### Patch Changes
+
+- 6cffe99d: chore:
+  remove react eslint rules for `modern-js` rule set.
+  add .eslintrc for each package to speed up linting
+- Updated dependencies [6cffe99d]
+- Updated dependencies [04ae5262]
+- Updated dependencies [60f7d8bf]
+  - @modern-js/babel-preset-app@1.2.7
+
+## 1.2.7
+
+### Patch Changes
+
+- d6522e85: feat: remove max-params and max-statements rule
+- Updated dependencies [17d0cc46]
+  - @modern-js/babel-preset-app@1.2.6
+
+## 1.2.6
+
+### Patch Changes
+
+- 8e737893: feat: disable promise/prefer-await-to-then
+- 8e737893: feat: disable require-atomic-updates
+- a2761eb7: fix: exclude modern.config.ts from with type rules
+- 8e737893: feat: disable no-shadow
+- 8e737893: feat: disable @typescript-eslint/no-base-to-string
+- 8e737893: feat: disable filenames/match-exported
+- Updated dependencies [9d4a005b]
+  - @modern-js/babel-preset-app@1.2.5
+
 ## 1.2.5
 
 ### Patch Changes

package/base.js

@@ -1,5 +1,4 @@
-/* eslint-disable max-lines, no-magic-numbers */
-
+/* eslint-disable max-lines */
 const { jsExtensions } = require('./utils');
 
 module.exports = {
@@ -9,7 +8,6 @@ module.exports = {
     ecmaVersion: 8,
     ecmaFeatures: {
       impliedStrict: true,
-      jsx: true,
     },
     sourceType: 'module',
     babelOptions: {
@@ -36,10 +34,6 @@ module.exports = {
   plugins: [
     // https://www.npmjs.com/package/@babel/eslint-plugin
     '@babel',
-    // https://www.npmjs.com/package/eslint-plugin-react
-    'react',
-    // https://www.npmjs.com/package/eslint-plugin-react-hooks
-    'react-hooks',
     // https://www.npmjs.com/package/eslint-plugin-import
     'import',
     // https://www.npmjs.com/package/eslint-plugin-eslint-comments
@@ -59,7 +53,6 @@ module.exports = {
   extends: [
     // https://eslint.org/docs/user-guide/configuring#using-eslintrecommended
     'eslint:recommended',
-    'plugin:react/recommended',
     'plugin:import/errors',
     'plugin:import/warnings',
     'plugin:eslint-comments/recommended',
@@ -97,7 +90,7 @@ module.exports = {
 
     /*
      * https://eslint.org/docs/rules/no-debugger
-     * @TIPS: for non-VSCode users, please use `debugger // eslint-disable-line`
+     * @TIPS: for non-VS Code users, please use `debugger // eslint-disable-line`
      *        instead of `debugger` to avoid it to be removed by IDE's autoFixOnSave feature
      */
     'no-debugger': 'error',
@@ -155,10 +148,6 @@ module.exports = {
     'no-unsafe-finally': 'error',
     // https://eslint.org/docs/rules/no-unsafe-negation
     'no-unsafe-negation': 'error',
-    // https://eslint.org/docs/rules/require-atomic-updates
-    // @bug https://github.com/eslint/eslint/issues/11899
-    'require-atomic-updates': 'warn',
-    // 'require-atomic-updates': 'error',
     // https://eslint.org/docs/rules/use-isnan
     'use-isnan': 'error',
     // https://eslint.org/docs/rules/valid-typeof
@@ -427,17 +416,6 @@ module.exports = {
       // @CUSTOM
     ],
 
-    /*
-     * https://eslint.org/docs/rules/no-shadow
-     * "no-shadow": "off",
-     */
-    'no-shadow': [
-      'error',
-      {
-        builtinGlobals: false,
-        allow: [],
-      },
-    ],
     // https://eslint.org/docs/rules/no-shadow-restricted-names
     'no-shadow-restricted-names': 'error',
     // https://eslint.org/docs/rules/no-undef
@@ -634,28 +612,11 @@ module.exports = {
         skipComments: true,
       },
     ],
-    // https://eslint.org/docs/rules/max-lines-per-function
-    'max-lines-per-function': 'off',
 
     /*
-     * 'max-lines-per-function': [
-     *   'error',
-     *   {
-     *     max: 50,
-     *     skipBlankLines: true,
-     *     skipComments: true,
-     *     IIFEs: true,
-     *   },
-     * ],
      * https://eslint.org/docs/rules/max-nested-callbacks
      */
     'max-nested-callbacks': ['warn', 4],
-    // https://eslint.org/docs/rules/max-params
-    'max-params': ['warn', 4],
-    // https://eslint.org/docs/rules/max-statements
-    'max-statements': ['warn', 20],
-    // https://eslint.org/docs/rules/max-statements-per-line
-    'max-statements-per-line': ['error', { max: 1 }],
     // https://eslint.org/docs/rules/multiline-comment-style
     // @TODO bug:
     // // class Foo {
@@ -998,166 +959,6 @@ module.exports = {
       },
     ],
 
-    /*
-     * react
-     * https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/boolean-prop-naming.md
-     */
-    'react/boolean-prop-naming': [
-      'error',
-      {
-        propTypeNames: ['bool'],
-        rule: '^(is|has|should)[A-Z]([A-Za-z0-9]?)+',
-      },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/button-has-type.md
-    'react/button-has-type': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/default-props-match-prop-types.md
-    'react/default-props-match-prop-types': 'error',
-
-    /*
-     * https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/display-name.md
-     * @TODO
-     * @TIPS
-     * for stateless component: use named function for now
-     * const Dialog = ({ children }) => (
-     *   <div className="dialog">{children}</div>
-     * )
-     * ->
-     * const Dialog = function Dialog({ children }) {
-     *   return (
-     *     <div className="dialog">{children}</div>
-     *   )
-     * }
-     * issues:
-     * https://github.com/yannickcr/eslint-plugin-react/issues/1297
-     * https://github.com/yannickcr/eslint-plugin-react/issues/412
-     * feedback:
-     * - 把一个render 作为props传入组件还是比较常见的
-     * - 嗯ok，这个规则现在的性价比是不太高了…
-     */
-    'react/display-name': 'off',
-    /*
-     * @CUSTOM
-     * "react/forbid-prop-types": [
-     *   "error",
-     *   {
-     *     "forbid": [],
-     *     "allowInPropTypes": []
-     *   }
-     * ],
-     * https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/forbid-foreign-prop-types.md
-     */
-    'react/forbid-foreign-prop-types': 'error',
-
-    /*
-     * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-access-state-in-setstate.md
-     * @TIPS
-     * this.setState({value: this.state.value + 1});
-     * ->
-     * this.setState(prevState => ({value: prevState.value + 1}));
-     */
-    'react/no-access-state-in-setstate': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-array-index-key.md
-    'react/no-array-index-key': 'warn',
-    /*
-     * https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-danger.md
-     * @TIPS
-     * explicitly declare `eslint-disable` when truly necessary
-     */
-    'react/no-danger': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-did-mount-set-state.md
-    'react/no-did-mount-set-state': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-multi-comp.md
-    'react/no-multi-comp': ['error', { ignoreStateless: true }],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-redundant-should-component-update.md
-    'react/no-redundant-should-component-update': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-typos.md
-    'react/no-typos': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-this-in-sfc.md
-    'react/no-this-in-sfc': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unsafe.md
-    'react/no-unsafe': ['error', { checkAliases: true }],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-unused-prop-types.md
-    'react/no-unused-prop-types': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-will-update-set-state.md
-    'react/no-will-update-set-state': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/prefer-es6-class.md
-    'react/prefer-es6-class': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/prefer-stateless-function.md
-    'react/prefer-stateless-function': [
-      'error',
-      { ignorePureComponents: false },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/prop-types.md
-    'react/prop-types': [
-      'error',
-      {
-        skipUndeclared: true,
-        ignore: ['children', 'className'],
-      },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/react-in-jsx-scope.md
-    // react 17
-    'react/react-in-jsx-scope': 'off',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/require-default-props.md
-    'react/require-default-props': [
-      'error',
-      { forbidDefaultForRequired: true },
-    ],
-
-    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/self-closing-comp.md
-    'react/self-closing-comp': [
-      'error',
-      {
-        component: true,
-        html: false,
-      },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/style-prop-object.md
-    'react/style-prop-object': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/void-dom-elements-no-children.md
-    'react/void-dom-elements-no-children': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-filename-extension.md
-    'react/jsx-filename-extension': [
-      'error',
-      { extensions: ['.jsx', '.tsx', '.mjsx', '.cjsx'] },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-handler-names.md
-    'react/jsx-handler-names': [
-      'error',
-      {
-        eventHandlerPrefix: '',
-        // eventHandlerPrefix: 'handle',
-        eventHandlerPropPrefix: 'on',
-      },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-bind.md
-    'react/jsx-no-bind': [
-      'error',
-      {
-        ignoreRefs: true,
-        allowArrowFunctions: true,
-      },
-    ],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-duplicate-props.md
-    'react/jsx-no-duplicate-props': ['error', { ignoreCase: true }],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md
-    'react/jsx-no-target-blank': 'off',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-undef.md
-    'react/jsx-no-undef': ['error', { allowGlobals: true }],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md
-    'react/jsx-pascal-case': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unused-state.md
-    'react/no-unused-state': 'error',
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/state-in-constructor.md
-    'react/state-in-constructor': ['error', 'never'],
-    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/static-property-placement.md
-    'react/static-property-placement': 'error',
-    // https://reactjs.org/docs/hooks-rules.html
-    'react-hooks/rules-of-hooks': 'error',
-    // https://github.com/facebook/react/issues/16006
-    'react-hooks/exhaustive-deps': 'off',
-
     /*
      * import
      * Static analysis
@@ -1363,8 +1164,6 @@ module.exports = {
      * use Camel Case for others
      */
     'filenames/match-regex': ['error', '^[\\[\\]_a-zA-Z0-9.-]+$'],
-    // https://www.npmjs.com/package/eslint-plugin-filenames#matching-exported-values-match-exported
-    'filenames/match-exported': ['error', ['kebab', 'camel', 'pascal']],
     // https://www.npmjs.com/package/eslint-plugin-filenames#dont-allow-indexjs-files-no-index
     'filenames/no-index': 'off',
 
@@ -1394,12 +1193,6 @@ module.exports = {
     // https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/valid-params.md
     'promise/valid-params': 'error',
 
-    /*
-     * https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/prefer-await-to-then.md
-     * @CUSTOM
-     */
-    'promise/prefer-await-to-then': 'error',
-
     /*
      * https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/prefer-await-to-callbacks.md
      * @CUSTOM
@@ -1476,71 +1269,11 @@ module.exports = {
     'node/prefer-promises/dns': 'off',
     // https://github.com/mysticatea/eslint-plugin-node/blob/v9.0.0/docs/rules/prefer-promises/fs.md
     'node/prefer-promises/fs': 'off',
-
-    /*
-     * JSDoc
-     * @TIPS
-     * if your block comments are not JSDoc,
-     * change `/**` into `/*`
-     * https://github.com/gajus/eslint-plugin-jsdoc#check-alignment
-     */
-    // 'jsdoc/check-alignment': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#check-examples
-    // 'jsdoc/check-examples': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#check-indentation
-    // 'jsdoc/check-indentation': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#check-param-names
-    // 'jsdoc/check-param-names': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#check-syntax
-    // 'jsdoc/check-syntax': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#check-tag-names
-    // 'jsdoc/check-tag-names': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#check-types
-    // 'jsdoc/check-types': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#implements-on-classes
-    // 'jsdoc/implements-on-classes': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#match-description
-    // 'jsdoc/match-description': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#newline-after-description
-    // 'jsdoc/newline-after-description': ['error', 'always'],
-    // // https://github.com/gajus/eslint-plugin-jsdoc#no-types
-    // 'jsdoc/no-types': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#no-undefined-types
-    // 'jsdoc/no-undefined-types': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-description-complete-sentence
-    // 'jsdoc/require-description-complete-sentence': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-description
-    // 'jsdoc/require-description': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-example
-    // 'jsdoc/require-example': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-hyphen-before-param-description
-    // 'jsdoc/require-hyphen-before-param-description': ['error', 'always'],
-    // // https://github.com/gajus/eslint-plugin-jsdoc#eslint-plugin-jsdoc-rules-require-jsdoc
-    // 'jsdoc/require-jsdoc': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-param-description
-    // 'jsdoc/require-param-description': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-param-name
-    // 'jsdoc/require-param-name': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-param-type
-    // 'jsdoc/require-param-type': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-param
-    // 'jsdoc/require-param': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-returns-check
-    // 'jsdoc/require-returns-check': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-returns-description
-    // 'jsdoc/require-returns-description': 'error',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-returns-type
-    // 'jsdoc/require-returns-type': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#require-returns
-    // 'jsdoc/require-returns': 'off',
-    // // https://github.com/gajus/eslint-plugin-jsdoc#valid-types
-    // 'jsdoc/valid-types': 'off',
   },
   settings: {
     'import/resolver': 'webpack',
     'import/extensions': jsExtensions,
     'import/ignore': ['\\.coffee$'],
-    react: { version: '16.0' },
   },
   // https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns
   // https://eslint.org/docs/user-guide/migrating-to-6.0.0#-overrides-in-an-extended-config-file-can-now-be-overridden-by-a-parent-config-file
@@ -1564,7 +1297,6 @@ module.exports = {
       files: ['**/pages/**/_*', '**/pages/**/index.*', '**/pages/**/\\[**'],
       rules: {
         'filenames/match-regex': 'off',
-        'filenames/match-exported': 'off',
       },
     },
     {
@@ -1584,4 +1316,4 @@ module.exports = {
     },
   ],
 };
-/* eslint-enable max-lines, no-magic-numbers */
+/* eslint-enable max-lines */

package/index.js

@@ -1,4 +1,4 @@
 module.exports = {
   // https://eslint.org/docs/user-guide/configuring#extending-configuration-files
-  extends: ['./base.js', './ts.withType.js', './prettier'],
+  extends: ['./base.js', './react', './ts', './ts.withType.js', './prettier'],
 };

package/jest.config.js

@@ -2,7 +2,6 @@ const sharedConfig = require('@scripts/jest-config');
 
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
-  // eslint-disable-next-line node/no-unsupported-features/es-syntax
   ...sharedConfig,
   rootDir: __dirname,
 };

package/lite.js

@@ -1,4 +1,4 @@
 module.exports = {
   // https://eslint.org/docs/user-guide/configuring#extending-configuration-files
-  extends: ['./base.js', './ts.js', './prettier'],
+  extends: ['./base.js', './react', './ts.js', './prettier'],
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@modern-js-app/eslint-config",
-  "version": "1.2.5",
+  "version": "1.2.8",
   "description": "The meta-framework suite designed from scratch for frontend-focused modern web development.",
   "homepage": "https://modernjs.dev",
   "bugs": "https://github.com/modern-js-dev/modern.js/issues",
@@ -32,9 +32,10 @@
     "prettier": "^2.5.1"
   },
   "dependencies": {
-    "@modern-js/babel-preset-app": "^1.2.0"
+    "@modern-js/babel-preset-app": "^1.2.7"
   },
   "devDependencies": {
+    "@scripts/build": "0.0.0",
     "eslint": "^7.32.0",
     "eslint-find-rules": "^3.4.0",
     "eslint-index": "^1.5.0"

package/react.js

@@ -0,0 +1,123 @@
+module.exports = {
+  // https://eslint.org/docs/user-guide/configuring#specifying-parser-options
+  parserOptions: {
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+  // https://eslint.org/docs/user-guide/configuring#configuring-plugins
+  plugins: [
+    // https://www.npmjs.com/package/eslint-plugin-react
+    'react',
+    // https://www.npmjs.com/package/eslint-plugin-react-hooks
+    'react-hooks',
+  ],
+  // https://eslint.org/docs/user-guide/configuring#extending-configuration-files
+  extends: ['plugin:react/recommended', 'plugin:react/jsx-runtime'],
+
+  settings: {
+    react: { version: '16.0' },
+  },
+
+  rules: {
+    /*
+     * https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/display-name.md
+     * @TODO
+     * @TIPS
+     * for stateless component: use named function for now
+     * const Dialog = ({ children }) => (
+     *   <div className="dialog">{children}</div>
+     * )
+     * ->
+     * const Dialog = function Dialog({ children }) {
+     *   return (
+     *     <div className="dialog">{children}</div>
+     *   )
+     * }
+     * issues:
+     * https://github.com/yannickcr/eslint-plugin-react/issues/1297
+     * https://github.com/yannickcr/eslint-plugin-react/issues/412
+     * feedback:
+     * - 把一个render 作为props传入组件还是比较常见的
+     * - 嗯ok，这个规则现在的性价比是不太高了…
+     */
+    'react/display-name': 'off',
+    /*
+     * https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-access-state-in-setstate.md
+     * @TIPS
+     * this.setState({value: this.state.value + 1});
+     * ->
+     * this.setState(prevState => ({value: prevState.value + 1}));
+     */
+    'react/no-access-state-in-setstate': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-array-index-key.md
+    'react/no-array-index-key': 'warn',
+    /*
+     * https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-danger.md
+     * @TIPS
+     * explicitly declare `eslint-disable` when truly necessary
+     */
+    'react/no-danger': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-did-mount-set-state.md
+    'react/no-did-mount-set-state': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-redundant-should-component-update.md
+    'react/no-redundant-should-component-update': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-typos.md
+    'react/no-typos': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-this-in-sfc.md
+    'react/no-this-in-sfc': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unsafe.md
+    'react/no-unsafe': ['error', { checkAliases: true }],
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-unused-prop-types.md
+    'react/no-unused-prop-types': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/no-will-update-set-state.md
+    'react/no-will-update-set-state': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/prefer-stateless-function.md
+    'react/prefer-stateless-function': [
+      'warn',
+      { ignorePureComponents: false },
+    ],
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/prop-types.md
+    'react/prop-types': [
+      'error',
+      {
+        skipUndeclared: true,
+        ignore: ['children', 'className'],
+      },
+    ],
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/require-default-props.md
+    'react/require-default-props': [
+      'error',
+      { forbidDefaultForRequired: true },
+    ],
+
+    // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/self-closing-comp.md
+    'react/self-closing-comp': [
+      'error',
+      {
+        component: true,
+        html: false,
+      },
+    ],
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/style-prop-object.md
+    'react/style-prop-object': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/void-dom-elements-no-children.md
+    'react/void-dom-elements-no-children': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-target-blank.md
+    'react/jsx-no-target-blank': 'off',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-undef.md
+    'react/jsx-no-undef': ['error', { allowGlobals: true }],
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-pascal-case.md
+    'react/jsx-pascal-case': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unused-state.md
+    'react/no-unused-state': 'error',
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/state-in-constructor.md
+    'react/state-in-constructor': ['error', 'never'],
+    // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/static-property-placement.md
+    'react/static-property-placement': 'error',
+    // https://reactjs.org/docs/hooks-rules.html
+    'react-hooks/rules-of-hooks': 'error',
+    // https://github.com/facebook/react/issues/16006
+    'react-hooks/exhaustive-deps': 'off',
+  },
+};

package/ts.js

@@ -1,4 +1,3 @@
-/* eslint-disable max-lines */
 const { jsExtensions } = require('./utils');
 
 module.exports = {
@@ -391,15 +390,6 @@ module.exports = {
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-redeclare.md
         'no-redeclare': 'off',
         '@typescript-eslint/no-redeclare': ['error', { builtinGlobals: true }],
-        // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md
-        'no-shadow': 'off',
-        '@typescript-eslint/no-shadow': [
-          'error',
-          {
-            builtinGlobals: false,
-            allow: [],
-          },
-        ],
 
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/space-before-function-paren.md
         'space-before-function-paren': 'off',
@@ -418,4 +408,3 @@ module.exports = {
     },
   ],
 };
-/* eslint-enable max-lines */

package/ts.withType.js

@@ -2,7 +2,8 @@ module.exports = {
   overrides: [
     {
       files: ['*.ts', '*.d.ts', '*.tsx'],
-      extends: ['./ts'],
+      // modern.config.ts is usually not included in tsconfig.json
+      excludedFiles: ['modern.config.ts'],
       parserOptions: {
         ecmaFeatures: { jsx: true },
         // don't set tsconfigRootDir, using the path relative to the cwd
@@ -23,11 +24,6 @@ module.exports = {
         ],
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-assertion.md
         '@typescript-eslint/no-unnecessary-type-assertion': 'error',
-        // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/restrict-template-expressions.md
-        '@typescript-eslint/restrict-template-expressions': [
-          'error',
-          { allowNumber: true, allowAny: true },
-        ],
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-base-to-string.md
         '@typescript-eslint/no-base-to-string': 'error',
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-boolean-literal-compare.md