@modern-js-app/eslint-config 1.2.5 → 1.2.6

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @modern-js-app/eslint-config
 
+## 1.2.6
+
+### Patch Changes
+
+- 8e737893: feat: disable promise/prefer-await-to-then
+- 8e737893: feat: disable require-atomic-updates
+- a2761eb7: fix: exclude modern.config.ts from with type rules
+- 8e737893: feat: disable no-shadow
+- 8e737893: feat: disable @typescript-eslint/no-base-to-string
+- 8e737893: feat: disable filenames/match-exported
+- Updated dependencies [9d4a005b]
+  - @modern-js/babel-preset-app@1.2.5
+
 ## 1.2.5
 
 ### Patch Changes

package/base.js

@@ -97,7 +97,7 @@ module.exports = {
 
     /*
      * https://eslint.org/docs/rules/no-debugger
-     * @TIPS: for non-VSCode users, please use `debugger // eslint-disable-line`
+     * @TIPS: for non-VS Code users, please use `debugger // eslint-disable-line`
      *        instead of `debugger` to avoid it to be removed by IDE's autoFixOnSave feature
      */
     'no-debugger': 'error',
@@ -155,10 +155,6 @@ module.exports = {
     'no-unsafe-finally': 'error',
     // https://eslint.org/docs/rules/no-unsafe-negation
     'no-unsafe-negation': 'error',
-    // https://eslint.org/docs/rules/require-atomic-updates
-    // @bug https://github.com/eslint/eslint/issues/11899
-    'require-atomic-updates': 'warn',
-    // 'require-atomic-updates': 'error',
     // https://eslint.org/docs/rules/use-isnan
     'use-isnan': 'error',
     // https://eslint.org/docs/rules/valid-typeof
@@ -427,17 +423,6 @@ module.exports = {
       // @CUSTOM
     ],
 
-    /*
-     * https://eslint.org/docs/rules/no-shadow
-     * "no-shadow": "off",
-     */
-    'no-shadow': [
-      'error',
-      {
-        builtinGlobals: false,
-        allow: [],
-      },
-    ],
     // https://eslint.org/docs/rules/no-shadow-restricted-names
     'no-shadow-restricted-names': 'error',
     // https://eslint.org/docs/rules/no-undef
@@ -1363,8 +1348,6 @@ module.exports = {
      * use Camel Case for others
      */
     'filenames/match-regex': ['error', '^[\\[\\]_a-zA-Z0-9.-]+$'],
-    // https://www.npmjs.com/package/eslint-plugin-filenames#matching-exported-values-match-exported
-    'filenames/match-exported': ['error', ['kebab', 'camel', 'pascal']],
     // https://www.npmjs.com/package/eslint-plugin-filenames#dont-allow-indexjs-files-no-index
     'filenames/no-index': 'off',
 
@@ -1394,12 +1377,6 @@ module.exports = {
     // https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/valid-params.md
     'promise/valid-params': 'error',
 
-    /*
-     * https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/prefer-await-to-then.md
-     * @CUSTOM
-     */
-    'promise/prefer-await-to-then': 'error',
-
     /*
      * https://github.com/xjamundx/eslint-plugin-promise/blob/master/docs/rules/prefer-await-to-callbacks.md
      * @CUSTOM
@@ -1564,7 +1541,6 @@ module.exports = {
       files: ['**/pages/**/_*', '**/pages/**/index.*', '**/pages/**/\\[**'],
       rules: {
         'filenames/match-regex': 'off',
-        'filenames/match-exported': 'off',
       },
     },
     {

package/index.js

@@ -1,4 +1,4 @@
 module.exports = {
   // https://eslint.org/docs/user-guide/configuring#extending-configuration-files
-  extends: ['./base.js', './ts.withType.js', './prettier'],
+  extends: ['./base.js', './ts', './ts.withType.js', './prettier'],
 };

package/jest.config.js

@@ -2,7 +2,6 @@ const sharedConfig = require('@scripts/jest-config');
 
 /** @type {import('@jest/types').Config.InitialOptions} */
 module.exports = {
-  // eslint-disable-next-line node/no-unsupported-features/es-syntax
   ...sharedConfig,
   rootDir: __dirname,
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@modern-js-app/eslint-config",
-  "version": "1.2.5",
+  "version": "1.2.6",
   "description": "The meta-framework suite designed from scratch for frontend-focused modern web development.",
   "homepage": "https://modernjs.dev",
   "bugs": "https://github.com/modern-js-dev/modern.js/issues",
@@ -32,7 +32,7 @@
     "prettier": "^2.5.1"
   },
   "dependencies": {
-    "@modern-js/babel-preset-app": "^1.2.0"
+    "@modern-js/babel-preset-app": "^1.2.5"
   },
   "devDependencies": {
     "eslint": "^7.32.0",

package/ts.js

@@ -1,4 +1,3 @@
-/* eslint-disable max-lines */
 const { jsExtensions } = require('./utils');
 
 module.exports = {
@@ -391,15 +390,6 @@ module.exports = {
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-redeclare.md
         'no-redeclare': 'off',
         '@typescript-eslint/no-redeclare': ['error', { builtinGlobals: true }],
-        // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-shadow.md
-        'no-shadow': 'off',
-        '@typescript-eslint/no-shadow': [
-          'error',
-          {
-            builtinGlobals: false,
-            allow: [],
-          },
-        ],
 
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/space-before-function-paren.md
         'space-before-function-paren': 'off',
@@ -418,4 +408,3 @@ module.exports = {
     },
   ],
 };
-/* eslint-enable max-lines */

package/ts.withType.js

@@ -2,7 +2,8 @@ module.exports = {
   overrides: [
     {
       files: ['*.ts', '*.d.ts', '*.tsx'],
-      extends: ['./ts'],
+      // modern.config.ts is usually not included in tsconfig.json
+      excludedFiles: ['modern.config.ts'],
       parserOptions: {
         ecmaFeatures: { jsx: true },
         // don't set tsconfigRootDir, using the path relative to the cwd
@@ -23,11 +24,6 @@ module.exports = {
         ],
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-type-assertion.md
         '@typescript-eslint/no-unnecessary-type-assertion': 'error',
-        // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/restrict-template-expressions.md
-        '@typescript-eslint/restrict-template-expressions': [
-          'error',
-          { allowNumber: true, allowAny: true },
-        ],
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-base-to-string.md
         '@typescript-eslint/no-base-to-string': 'error',
         // https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-unnecessary-boolean-literal-compare.md