@mnemoverse/mcp-memory-server 0.8.0 → 0.8.1

package/dist/teaching.js

@@ -19,57 +19,151 @@
  * - Active polarity: no "only when the user explicitly asks" gating.
  * - Mentions every tool family: read/write/stats/feedback, delete, rooms, vault.
  */
-export const SERVER_INSTRUCTIONS = "You own this long-term memory. It persists across sessions and every AI tool this user connects (Claude, ChatGPT, editors). Use it as a habit: call memory_read before answering anything that may have come up before, and memory_write the moment you learn a durable fact, preference, or decision — don't wait to be asked. Rate recalls with memory_feedback so good ones surface faster; memory_stats shows counts; memory_list_recent: newest first; prune with memory_delete; memory_delete_domain wipes a domain, only with user go-ahead. Rooms (memory_create_room, memory_invite_to_room, memory_join_room, memory_list_rooms) share memory with others; vault_list names stored secrets by alias, never values. Never store passwords, API keys, payment data, MFA codes, government IDs, or health records.";
+export const SERVER_INSTRUCTIONS = "You own this long-term memory. It persists across sessions and every AI tool this user connects. Use it as a habit: memory_read before answering anything that may have come up; memory_write the moment you learn a durable fact, preference or decision — don't wait to be asked. Shared rooms are SEPARATE stores: to read one, pass its address as domain (memory_list_rooms); unscoped reads never cover rooms. Rate recalls with memory_feedback; memory_stats shows counts; memory_list_recent is newest-first; memory_delete prunes; memory_delete_domain wipes a domain, only with user go-ahead. Rooms: memory_create_room, memory_invite_to_room, memory_join_room. vault_list names secrets by alias, never values. Never store passwords, API keys, payment data, MFA codes, government IDs, or health records.";
 /** The pre-existing zero-result message — kept as the fail-open fallback. */
 export const NO_MATCH_MESSAGE = "No memories found for this query.";
 /** Hint for an UNSCOPED no-match against a non-empty store: widen the query.
  *  (No drop-the-filter clause — none was set; advising to remove a filter that
  *  does not exist nudges the model into confabulating state.) */
 export const NO_MATCH_HINT = " Try a broader query.";
-/** Hint for a DOMAIN-SCOPED no-match: here a filter genuinely exists, so
- *  suggesting to drop it is honest and actionable. */
-export const NO_MATCH_SCOPED_HINT = " Try a broader query, or drop the domain filter to search all domains.";
 /**
- * First-contact greeting: shown ONLY when a read comes back empty AND the
- * store holds zero memories — i.e. the very first read of this account's life.
- * Seeds the ANSWER, not the store: one functional paragraph that says what
- * this store is, how to save the first memory, and one next step. It can never
- * appear again once anything is stored (total_atoms > 0 takes the other branch).
+ * Hint for a DOMAIN-SCOPED no-match: widen the query, or try another domain —
+ * and NEVER drop the scope.
+ *
+ * This doc used to read "here a filter genuinely exists, so suggesting to drop
+ * it is honest and actionable", which described a draft that no longer exists:
+ * the clause "…or drop the domain filter to search all domains" was deleted, and
+ * a test now forbids it. The advice was actively harmful when the domain is a
+ * room — an unscoped read does not cover rooms at all, so dropping the filter is
+ * the one move guaranteed to lose the content the reader is hunting, and it is
+ * the step that cost two agents a day on 2026-08-07.
+ */
+export const NO_MATCH_SCOPED_HINT = " Try a broader query, or a different domain.";
+/**
+ * The honest line for an account whose OWN domains are empty but whose rooms
+ * are not — an invited teammate whose every memory lives in shared rooms.
+ *
+ * Without this, such a caller was greeted with EMPTY_STORE_WELCOME: "your
+ * memory is empty, nothing has been saved yet, which is why this search
+ * returned nothing" — three false clauses, immediately contradicted by the
+ * scope note appended underneath, in the same payload (review, 2026-08-08).
+ * That reader is precisely the person from the incident this release is about.
+ *
+ * ENDS WITH A COLON, so it is only ever emitted together with the disclosure
+ * that follows it. That pairing used to be two independent decisions and they
+ * disagreed: this line was chosen from a flag counting ALL rooms while the
+ * disclosure was built from the LIVE ones, so an account whose only room was
+ * archived received the colon and nothing after it. Both now come out of the
+ * same {@link RoomScope} arm, and the arm that has nothing to disclose has no
+ * `note` field to forget.
+ */
+export const EMPTY_PERSONAL_STORE_WITH_ROOMS = "Nothing in your own domains — they hold no memories yet. That is not the whole picture:";
+/**
+ * The same situation with the room probe UNANSWERED. Says the one true thing —
+ * the personal store measured zero and the rest could not be checked — and
+ * deliberately does NOT say "nothing has been saved yet", which was reachable
+ * here and is a claim about a scope this client failed to reach.
+ */
+export const EMPTY_PERSONAL_STORE_ROOMS_UNCHECKED = "Nothing in your own domains — they hold no memories yet. Whether that is the whole picture could not be checked:";
+/**
+ * First-contact greeting: shown ONLY when a read comes back empty, the personal
+ * store holds zero memories, AND the room probe answered that there are no rooms
+ * — i.e. the very first read of this account's life, established rather than
+ * assumed. Seeds the ANSWER, not the store: one functional paragraph that says
+ * what this store is, how to save the first memory, and one next step.
  */
 export const EMPTY_STORE_WELCOME = "Your long-term memory is empty — nothing has been saved yet, which is why this search returned nothing. " +
     "This store is your own persistent memory: whatever you save survives across sessions and across every AI tool this user has connected. " +
     'Save the first memory now with memory_write, e.g. content: "User prefers TypeScript strict mode" — future sessions will recall it with memory_read.';
 /**
- * Decide what a zero-result memory_read should say.
+ * Compile-time exhaustiveness. Adding a state to `RoomScope` / `NamedScope`
+ * without answering for it here is a type error, which is the point: the state
+ * this release exists to fix ("we could not check") was reachable precisely
+ * because it had no arm of its own and fell into the falsy one. Returns the
+ * neutral message rather than throwing, so an unreachable branch can never take
+ * a handler down.
+ */
+function noStateLeftUnhandled(state) {
+    void state;
+    return NO_MATCH_MESSAGE;
+}
+/** The disclosure a room state owes the reader — "" only for the state whose
+ *  type says there is nothing to disclose. */
+function roomsTail(rooms) {
+    return "note" in rooms ? rooms.note : "";
+}
+/**
+ * Assemble the WHOLE answer for a zero-result read: the head sentence and the
+ * disclosure that belongs with it, in one place.
+ *
+ * They are assembled together on purpose. While the head came from here and the
+ * tail was concatenated by the caller, the two could be — and were — derived
+ * from different facts: a head promising "that is not the whole picture:" with
+ * an empty tail after it, and a first-contact greeting under a tail admitting
+ * the room list could not be fetched. Every arm below returns a complete answer,
+ * so a head cannot outlive the evidence for it.
  *
- * DOMAIN-SCOPED reads (`scopedToDomain` — the caller passed a `domain` arg,
- * e.g. a shared room) never greet and never probe: the stats call measures the
- * PERSONAL store, so on a scoped read it could claim "the store is empty"
- * about a domain that has memories the query merely missed (review finding).
- * The scoped copy suggests dropping the filter — honest, one actually exists.
+ * A NAMED scope never greets and never probes stats: that probe measures the
+ * PERSONAL store, so on a scoped read it could claim "the store is empty" about
+ * a domain whose memories the query merely missed. Its four arms are the four
+ * things we can know about the name.
  *
- * UNSCOPED reads make ONE stats call (only ever on the zero-result path) to
- * distinguish "store is truly empty" from "no match for this query":
- * - total_atoms === 0     → EMPTY_STORE_WELCOME (first-contact greeting)
- * - total_atoms > 0       → no-match + the broaden hint (no filter clause)
- * - stats throws/malformed → the plain old no-match message (fail-open to the
- *   pre-greeting behavior; never surfaces an error, never writes anything)
+ * An UNSCOPED scope makes ONE stats call, on this path only:
+ * - stats unreachable / no number → the plain no-match message + the disclosure
+ * - total_atoms > 0               → no-match + broaden hint + the disclosure
+ * - total_atoms === 0             → one head per room state, each with its own
+ *   disclosure; only `rooms.state === "none"` may claim the memory is empty,
+ *   because only there has the claim been established.
  */
-export async function buildReadEmptyResponse(fetchStats, scopedToDomain = false) {
-    if (scopedToDomain)
-        return NO_MATCH_MESSAGE + NO_MATCH_SCOPED_HINT;
+export async function buildReadEmptyResponse(fetchStats, scope) {
+    if (scope.kind === "named") {
+        const named = scope.named;
+        switch (named.state) {
+            case "present":
+                // The store is there; the query missed. The hint suggests a wider query
+                // or another domain and never suggests dropping the scope — when the
+                // domain is a room, dropping it is the one move that guarantees the
+                // content stays hidden (the 2026-08-07 incident).
+                return NO_MATCH_MESSAGE + NO_MATCH_SCOPED_HINT;
+            case "no-such-domain":
+            case "no-such-room":
+                // A SPECIFIC diagnosis replaces the generic advice; it does not follow
+                // it. Printed the other way round, a model reading top-down went off to
+                // widen a query against a store that does not exist.
+                return NO_MATCH_MESSAGE + named.note;
+            case "unchecked":
+                // Not a diagnosis — an admission. So the generic advice stays, and the
+                // admission is added rather than substituted. This is the case that used
+                // to be spelled exactly like "present".
+                return NO_MATCH_MESSAGE + NO_MATCH_SCOPED_HINT + named.note;
+            default:
+                return noStateLeftUnhandled(named);
+        }
+    }
+    const rooms = scope.rooms;
     let totalAtoms;
     try {
         totalAtoms = (await fetchStats())?.total_atoms;
     }
     catch {
-        return NO_MATCH_MESSAGE;
+        return NO_MATCH_MESSAGE + roomsTail(rooms);
     }
-    if (totalAtoms === 0)
-        return EMPTY_STORE_WELCOME;
-    if (typeof totalAtoms === "number" && totalAtoms > 0) {
-        return NO_MATCH_MESSAGE + NO_MATCH_HINT;
+    if (typeof totalAtoms !== "number")
+        return NO_MATCH_MESSAGE + roomsTail(rooms);
+    if (totalAtoms > 0)
+        return NO_MATCH_MESSAGE + NO_MATCH_HINT + roomsTail(rooms);
+    // The personal bucket measured zero. `total_atoms` counts ONE org, so what
+    // that means for the account depends entirely on the rooms.
+    switch (rooms.state) {
+        case "none":
+            return EMPTY_STORE_WELCOME;
+        case "live":
+        case "archived-only":
+            return EMPTY_PERSONAL_STORE_WITH_ROOMS + rooms.note;
+        case "unknown":
+            return EMPTY_PERSONAL_STORE_ROOMS_UNCHECKED + rooms.note;
+        default:
+            return noStateLeftUnhandled(rooms);
     }
-    return NO_MATCH_MESSAGE;
 }
 //# sourceMappingURL=teaching.js.map

package/dist/teaching.js.map

@@ -1 +1 @@
-{"version":3,"file":"teaching.js","sourceRoot":"","sources":["../src/teaching.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH;;;;;;;;;GASG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAC9B,2xBAA2xB,CAAC;AAE9xB,6EAA6E;AAC7E,MAAM,CAAC,MAAM,gBAAgB,GAAG,mCAAmC,CAAC;AAEpE;;iEAEiE;AACjE,MAAM,CAAC,MAAM,aAAa,GAAG,uBAAuB,CAAC;AAErD;sDACsD;AACtD,MAAM,CAAC,MAAM,oBAAoB,GAC/B,wEAAwE,CAAC;AAE3E;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAC9B,0GAA0G;IAC1G,yIAAyI;IACzI,qJAAqJ,CAAC;AAExJ;;;;;;;;;;;;;;;GAeG;AACH,MAAM,CAAC,KAAK,UAAU,sBAAsB,CAC1C,UAAmD,EACnD,cAAc,GAAG,KAAK;IAEtB,IAAI,cAAc;QAAE,OAAO,gBAAgB,GAAG,oBAAoB,CAAC;IACnE,IAAI,UAA8B,CAAC;IACnC,IAAI,CAAC;QACH,UAAU,GAAG,CAAC,MAAM,UAAU,EAAE,CAAC,EAAE,WAAW,CAAC;IACjD,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,gBAAgB,CAAC;IAC1B,CAAC;IACD,IAAI,UAAU,KAAK,CAAC;QAAE,OAAO,mBAAmB,CAAC;IACjD,IAAI,OAAO,UAAU,KAAK,QAAQ,IAAI,UAAU,GAAG,CAAC,EAAE,CAAC;QACrD,OAAO,gBAAgB,GAAG,aAAa,CAAC;IAC1C,CAAC;IACD,OAAO,gBAAgB,CAAC;AAC1B,CAAC"}
+{"version":3,"file":"teaching.js","sourceRoot":"","sources":["../src/teaching.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAIH;;;;;;;;;GASG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAC9B,8xBAA8xB,CAAC;AAEjyB,6EAA6E;AAC7E,MAAM,CAAC,MAAM,gBAAgB,GAAG,mCAAmC,CAAC;AAEpE;;iEAEiE;AACjE,MAAM,CAAC,MAAM,aAAa,GAAG,uBAAuB,CAAC;AAErD;;;;;;;;;;;GAWG;AACH,MAAM,CAAC,MAAM,oBAAoB,GAC/B,8CAA8C,CAAC;AAEjD;;;;;;;;;;;;;;;;;GAiBG;AACH,MAAM,CAAC,MAAM,+BAA+B,GAC1C,yFAAyF,CAAC;AAE5F;;;;;GAKG;AACH,MAAM,CAAC,MAAM,oCAAoC,GAC/C,kHAAkH,CAAC;AAErH;;;;;;GAMG;AACH,MAAM,CAAC,MAAM,mBAAmB,GAC9B,0GAA0G;IAC1G,yIAAyI;IACzI,qJAAqJ,CAAC;AAExJ;;;;;;;GAOG;AACH,SAAS,oBAAoB,CAAC,KAAY;IACxC,KAAK,KAAK,CAAC;IACX,OAAO,gBAAgB,CAAC;AAC1B,CAAC;AAED;8CAC8C;AAC9C,SAAS,SAAS,CAAC,KAAgB;IACjC,OAAO,MAAM,IAAI,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC;AAC3C,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;GAsBG;AACH,MAAM,CAAC,KAAK,UAAU,sBAAsB,CAC1C,UAAmD,EACnD,KAAgB;IAEhB,IAAI,KAAK,CAAC,IAAI,KAAK,OAAO,EAAE,CAAC;QAC3B,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC;QAC1B,QAAQ,KAAK,CAAC,KAAK,EAAE,CAAC;YACpB,KAAK,SAAS;gBACZ,wEAAwE;gBACxE,qEAAqE;gBACrE,oEAAoE;gBACpE,kDAAkD;gBAClD,OAAO,gBAAgB,GAAG,oBAAoB,CAAC;YACjD,KAAK,gBAAgB,CAAC;YACtB,KAAK,cAAc;gBACjB,uEAAuE;gBACvE,wEAAwE;gBACxE,qDAAqD;gBACrD,OAAO,gBAAgB,GAAG,KAAK,CAAC,IAAI,CAAC;YACvC,KAAK,WAAW;gBACd,uEAAuE;gBACvE,yEAAyE;gBACzE,wCAAwC;gBACxC,OAAO,gBAAgB,GAAG,oBAAoB,GAAG,KAAK,CAAC,IAAI,CAAC;YAC9D;gBACE,OAAO,oBAAoB,CAAC,KAAK,CAAC,CAAC;QACvC,CAAC;IACH,CAAC;IAED,MAAM,KAAK,GAAG,KAAK,CAAC,KAAK,CAAC;IAC1B,IAAI,UAA8B,CAAC;IACnC,IAAI,CAAC;QACH,UAAU,GAAG,CAAC,MAAM,UAAU,EAAE,CAAC,EAAE,WAAW,CAAC;IACjD,CAAC;IAAC,MAAM,CAAC;QACP,OAAO,gBAAgB,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC;IAC7C,CAAC;IACD,IAAI,OAAO,UAAU,KAAK,QAAQ;QAAE,OAAO,gBAAgB,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC;IAC/E,IAAI,UAAU,GAAG,CAAC;QAAE,OAAO,gBAAgB,GAAG,aAAa,GAAG,SAAS,CAAC,KAAK,CAAC,CAAC;IAE/E,2EAA2E;IAC3E,4DAA4D;IAC5D,QAAQ,KAAK,CAAC,KAAK,EAAE,CAAC;QACpB,KAAK,MAAM;YACT,OAAO,mBAAmB,CAAC;QAC7B,KAAK,MAAM,CAAC;QACZ,KAAK,eAAe;YAClB,OAAO,+BAA+B,GAAG,KAAK,CAAC,IAAI,CAAC;QACtD,KAAK,SAAS;YACZ,OAAO,oCAAoC,GAAG,KAAK,CAAC,IAAI,CAAC;QAC3D;YACE,OAAO,oBAAoB,CAAC,KAAK,CAAC,CAAC;IACvC,CAAC;AACH,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mnemoverse/mcp-memory-server",
-  "version": "0.8.0",
+  "version": "0.8.1",
   "description": "Hosted persistent memory for AI agents that learns which facts help and lets the rest fade — one key across Claude Code, Cursor, VS Code & ChatGPT, no infra to run",
   "type": "module",
   "bin": {
@@ -15,11 +15,12 @@
     "package.json"
   ],
   "scripts": {
-    "build": "tsc",
+    "build": "node -e \"require('fs').rmSync('dist',{recursive:true,force:true})\" && tsc",
     "dev": "tsc --watch",
     "start": "node dist/index.js",
     "test": "vitest run",
     "test:watch": "vitest",
+    "typecheck:test": "tsc -p tsconfig.test.json",
     "generate:configs": "node scripts/generate-configs.mjs",
     "verify:configs": "node scripts/generate-configs.mjs --check",
     "check:release-sync": "node scripts/check-release-sync.mjs",