@mnci/cli 4.3.1 → 4.3.2

package/dist/cli.js

@@ -861,7 +861,7 @@ var AFFECTED_OR_ALL_GUARD = `node -e "const cp=require('node:child_process');con
 var PACK_APPS_GUARD = `node -e "const fs=require('node:fs');fs.mkdirSync('dist/drop',{recursive:true});const hasProjectJson=fs.globSync('apps/*/project.json').length>0;const hasInlineNx=fs.globSync('apps/*/package.json').some((f)=>{try{return Boolean(JSON.parse(fs.readFileSync(f,'utf8')).nx)}catch{return false}});const hasCsproj=fs.globSync('apps/*/*.csproj').length>0;if(!hasProjectJson&&!hasInlineNx&&!hasCsproj){console.log('No apps to pack - skipping.');process.exit(0)}process.exit(require('node:child_process').spawnSync('npx nx run-many -t package',{stdio:'inherit',shell:true}).status ?? 1)"`;
 var SHALLOW_CLONE_GUARD = `node -e "const r=require('node:child_process').spawnSync('git',['rev-parse','--is-shallow-repository'],{encoding:'utf8'});if(r.status!==0){console.error('Could not determine whether this checkout has full history (git rev-parse --is-shallow-repository failed) - refusing to release. '+(r.stderr||'').trim());process.exit(1)}if(r.stdout.trim()==='true'){console.error('This checkout is a shallow clone. nx release resolves the current version of each package from its git tag, and silently falls back to the permanently-stale on-disk version when a tag cannot be found - which can propose, and publish, a version DOWNGRADE. Fetch full history before releasing - set fetchDepth (Azure) or fetch-depth (GitHub) to 0.');process.exit(1)}"`;
 function releaseGuard(pythonPublishEnv, nugetPublishEnv) {
-  return String.raw`node -e "const fs=require('node:fs'),cp=require('node:child_process');const npmCount=fs.globSync('packages/*/package.json').length;const csharpCount=fs.globSync('packages/*/*.csproj').length;const pythonCount=fs.globSync('python-packages/*/pyproject.toml').length;const hasNpm=npmCount>0;const hasPython=pythonCount>0;const hasCsharp=csharpCount>0;if(!hasNpm&&!hasPython&&!hasCsharp){console.log('Nothing to release - skipping.');process.exit(0)}const specifier=process.env.RELEASE_SPECIFIER||'';let releaseCmd='npx nx release --yes';if(specifier){if(!/^(major|minor|patch|\d+\.\d+\.\d+(-[0-9A-Za-z.-]+)?)$/.test(specifier)){console.error('RELEASE_SPECIFIER value \''+specifier+'\' is invalid - use major, minor, patch, or an exact version like 1.2.3.');process.exit(1)}const releaseProjectCount=npmCount+csharpCount+pythonCount;if(/^(major|minor|patch)$/.test(specifier)&&releaseProjectCount>1){console.error('RELEASE_SPECIFIER is a keyword (\''+specifier+'\') but this workspace has '+releaseProjectCount+' releasable packages - a keyword under-bumps interdependent packages, because nx computes the dependency-bump pass from a stale cached version. Set RELEASE_SPECIFIER to an exact version instead, or clear it.');process.exit(1)}releaseCmd='npx nx release '+specifier+' --yes'}const env={...process.env};${pythonPublishEnv}${nugetPublishEnv}process.exit(cp.spawnSync(releaseCmd,{stdio:'inherit',shell:true,env}).status ?? 1)"`;
+  return String.raw`node -e "const fs=require('node:fs'),cp=require('node:child_process');const npmCount=fs.globSync('packages/*/package.json').length;const csharpCount=fs.globSync('packages/*/*.csproj').length;const pythonCount=fs.globSync('python-packages/*/pyproject.toml').length;const dartCount=fs.globSync('packages/*/pubspec.yaml').length;const hasNpm=npmCount>0;const hasPython=pythonCount>0;const hasCsharp=csharpCount>0;const hasDart=dartCount>0;if(!hasNpm&&!hasPython&&!hasCsharp&&!hasDart){console.log('Nothing to release - skipping.');process.exit(0)}const specifier=process.env.RELEASE_SPECIFIER||'';let releaseCmd='npx nx release --yes';if(specifier){if(!/^(major|minor|patch|\d+\.\d+\.\d+(-[0-9A-Za-z.-]+)?)$/.test(specifier)){console.error('RELEASE_SPECIFIER value \''+specifier+'\' is invalid - use major, minor, patch, or an exact version like 1.2.3.');process.exit(1)}const releaseProjectCount=npmCount+csharpCount+pythonCount+dartCount;if(/^(major|minor|patch)$/.test(specifier)&&releaseProjectCount>1){console.error('RELEASE_SPECIFIER is a keyword (\''+specifier+'\') but this workspace has '+releaseProjectCount+' releasable packages - a keyword under-bumps interdependent packages, because nx computes the dependency-bump pass from a stale cached version. Set RELEASE_SPECIFIER to an exact version instead, or clear it.');process.exit(1)}releaseCmd='npx nx release '+specifier+' --yes'}const env={...process.env};${pythonPublishEnv}${nugetPublishEnv}process.exit(cp.spawnSync(releaseCmd,{stdio:'inherit',shell:true,env}).status ?? 1)"`;
 }
 function pythonPublishEnvFragment(pythonPublishUrl2) {
   return pythonPublishUrl2 ? `if(hasPython){env.TWINE_REPOSITORY_URL='${pythonPublishUrl2}';env.TWINE_USERNAME='AzureArtifacts';env.TWINE_PASSWORD=Buffer.from(process.env.PAT,'base64').toString()}` : "";
@@ -1742,6 +1742,12 @@ var SOURCEMAP_PATH_TRANSFORM = [
 var DECLARATION_SPECIFIER_PLUGIN_MARKER = "name: 'mnci-normalise-declaration-specifiers'";
 var DECLARATION_SPECIFIER_EXTENSION_MARKER = "bareRelativeSpecifier";
 var DECLARATION_SPECIFIER_DIRECTORY_MARKER = "resolveSpecifierSuffix";
+function hasDeclarationSpecifierPlugin(config) {
+  return config.includes(DECLARATION_SPECIFIER_PLUGIN_MARKER);
+}
+function hasDirectoryAwareDeclarationSpecifiers(config) {
+  return config.includes(DECLARATION_SPECIFIER_DIRECTORY_MARKER);
+}
 var DECLARATION_SPECIFIER_PLUGIN = [
   "      {",
   "        name: 'mnci-normalise-declaration-specifiers',",
@@ -4098,6 +4104,7 @@ function checkNpmrc(workspaceRoot, registry, scope) {
 function checkVersionActions(workspaceRoot) {
   const candidates = [
     ...(0, import_node_fs9.globSync)("packages/*/pubspec.yaml", { cwd: workspaceRoot }),
+    ...(0, import_node_fs9.globSync)("packages/*/*.csproj", { cwd: workspaceRoot }),
     ...(0, import_node_fs9.globSync)("python-packages/*/pyproject.toml", { cwd: workspaceRoot })
   ].map((manifest) => toPosix2(manifest));
   return candidates.flatMap((manifest) => {
@@ -4226,6 +4233,44 @@ function checkRollupSourceMaps(workspaceRoot) {
     ];
   });
 }
+function checkDeclarationSpecifiers(workspaceRoot) {
+  const configs = (0, import_node_fs9.globSync)(["packages/*/rollup.config.cjs", "libs/*/rollup.config.cjs"], {
+    cwd: workspaceRoot
+  }).map((config) => toPosix2(config));
+  return configs.flatMap((relativePath) => {
+    const configPath = (0, import_node_path15.join)(workspaceRoot, relativePath);
+    if (!fileExists(configPath)) {
+      return [];
+    }
+    const resolved = resolveRollupConfigText(configPath);
+    if (!hasDeclarationSpecifierPlugin(resolved)) {
+      return [
+        {
+          check: `${relativePath} normalises declaration specifiers`,
+          ok: false,
+          detail: "no mnci-normalise-declaration-specifiers plugin \u2014 the emitted .d.ts files keep the extensionless imports tsconfig.lib.json allows, which a nodenext consumer cannot resolve",
+          // Deliberately NOT `mnci upgrade`, which would send the user in a
+          // circle: `upgradeDeclarationSpecifierPlugins` only rewrites a
+          // plugin that is already there, and `repairDeclarationSpecifiers`
+          // is anchored on the generator's own placeholder comment, which a
+          // config in this state no longer has. Verified by running the
+          // command against exactly this shape — it no-ops. Naming a command
+          // that silently does nothing is the failure mode this file's own
+          // source-map check already goes out of its way to avoid.
+          remedy: "add the plugin to withNx's second argument by hand (copy it from a freshly `mnci add npm-lib`'d project) \u2014 `mnci upgrade` only updates a plugin that is already present, it cannot restore a missing one"
+        }
+      ];
+    }
+    return [
+      {
+        check: `${relativePath} resolves directory barrels in declarations`,
+        ok: hasDirectoryAwareDeclarationSpecifiers(resolved),
+        detail: "the plugin appends .js to every bare specifier, including ones naming a directory barrel, which needs /index.js \u2014 the named file is never emitted, so every export behind it publishes as `any` with nothing reporting it",
+        remedy: "run `mnci upgrade`, which replaces the plugin body with the current one"
+      }
+    ];
+  });
+}
 function collectFindings(workspaceRoot) {
   const nxJsonPath = (0, import_node_path15.join)(workspaceRoot, "nx.json");
   if (!fileExists(nxJsonPath)) {
@@ -4242,6 +4287,7 @@ function collectFindings(workspaceRoot) {
     checkNpmrc(workspaceRoot, nxJson.mnci?.registry, nxJson.mnci?.scope),
     checkNoRootRuntimeDependencies(workspaceRoot),
     ...checkRollupSourceMaps(workspaceRoot),
+    ...checkDeclarationSpecifiers(workspaceRoot),
     ...checkVersionActions(workspaceRoot),
     ...checkTargetFilesExist(workspaceRoot),
     checkSync(workspaceRoot)