@mnci/cli 4.17.1 → 4.17.3

package/README.md

@@ -1521,7 +1521,7 @@ pipeline installs `golangci-lint` itself (see below).
   test file's import). That matters because the pipeline verifies only the
   affected projects on a pull request: a missing edge would let a lib change
   pass without testing the apps that use it. The e2e pins the edges and the
-  affected sets (russoedu/MoNecromanCi#260), since they are the plugin's
+  affected sets (MoNecromanCI/MoNecromanCi#260), since they are the plugin's
   behaviour rather than mnci's.
 - **Lint is `golangci-lint`, pinned deliberately.** The plugin's `lint`
   executor defaults to `go fmt`, which only reformats — a green lint step
@@ -1572,7 +1572,7 @@ pipeline installs `golangci-lint` itself (see below).
     `linux-arm64` and `windows-arm64` are not built: they need an Intel macOS
     runner, an arm Linux runner or a cross-compiler. The legs are fixed in the
     generated pipeline today, so adding one means editing a file `mnci upgrade`
-    rewrites (russoedu/MoNecromanCi#269 is about giving that a safe place).
+    rewrites (MoNecromanCI/MoNecromanCi#269 is about giving that a safe place).
   - **Releasing one.** With `--release` as well, each leg, on a push to main and
     after the `ci` job has tagged, runs
     `node tools/go-app-release.cjs assets --native`, which builds

package/dist/cli.js

@@ -2405,7 +2405,7 @@ function writeProjectReadme(projectRoot, projectName, testRunner) {
     [
       `# ${projectName}`,
       "",
-      "Generated by [MoNecromanCI](https://github.com/russoedu/MoNecromanCi).",
+      "Generated by [MoNecromanCI](https://github.com/MoNecromanCI/MoNecromanCi).",
       "",
       "## Building",
       "",
@@ -4560,6 +4560,7 @@ function addReactInternalLib(workspaceRoot, name, stack) {
 var import_node_fs15 = require("fs");
 var import_node_path19 = require("path");
 var VSCODE_EXTENSION_SCRIPT_PATH = "tools/vscode-extension.cjs";
+var VSCODE_ENGINE_FLOOR = "1.96.0";
 var VSCODE_SIDECAR_TARGETS = {
   "win32-x64": "windows-amd64",
   "win32-arm64": "windows-arm64",
@@ -4753,20 +4754,20 @@ function mapVscodeToStub(projectRoot, testRunner) {
 ${indent}${mapping}`));
 }
 function ensureVscodeToolchain(workspaceRoot) {
-  const missing = ["@types/vscode", "@vscode/vsce"].filter((name) => !hasPlugin(workspaceRoot, name));
-  if (missing.length === 0) {
-    return;
+  const toInstall = [`@types/vscode@~${VSCODE_ENGINE_FLOOR}`];
+  if (!hasPlugin(workspaceRoot, "@vscode/vsce")) {
+    toInstall.push("@vscode/vsce");
   }
-  logger.step(`Installing the VS Code extension toolchain (${missing.join(", ")})`);
-  if (runShell("npm", ["install", "--save-dev", ...missing, "--no-audit", "--no-fund"], workspaceRoot) !== 0) {
-    throw new Error(`npm install of ${missing.join(", ")} failed`);
+  logger.step(`Installing the VS Code extension toolchain (${toInstall.join(", ")})`);
+  if (runShell("npm", ["install", "--save-dev", ...toInstall, "--no-audit", "--no-fund"], workspaceRoot) !== 0) {
+    throw new Error(`npm install of ${toInstall.join(", ")} failed`);
   }
 }
 function defaultPublisher(workspaceRoot) {
   const { name } = readJson((0, import_node_path19.join)(workspaceRoot, "package.json"));
   return (name ?? "publisher").replace(/^@/, "").split("/", 1)[0];
 }
-function reshapeManifest(projectRoot, name, publisher, typesVersion) {
+function reshapeManifest(projectRoot, name, publisher) {
   const manifestPath = (0, import_node_path19.join)(projectRoot, "package.json");
   const manifest = readJson(manifestPath);
   const { nx = {}, ...rest } = manifest;
@@ -4793,7 +4794,7 @@ function reshapeManifest(projectRoot, name, publisher, typesVersion) {
       displayName: name,
       version: rest.version ?? "0.0.1",
       publisher,
-      engines: { vscode: `^${typesVersion}` },
+      engines: { vscode: `^${VSCODE_ENGINE_FLOOR}` },
       categories: ["Other"],
       main: "./dist/main.js",
       activationEvents: [],
@@ -4926,8 +4927,7 @@ function addVscodeExtension(workspaceRoot, name, stack, options = {}) {
   runNodeApp(workspaceRoot, name, stack, "none");
   ensureVscodeToolchain(workspaceRoot);
   const projectRoot = (0, import_node_path19.join)(workspaceRoot, "apps", name);
-  const typesVersion = readJson((0, import_node_path19.join)(workspaceRoot, "node_modules/@types/vscode/package.json")).version;
-  reshapeManifest(projectRoot, name, options.publisher ?? defaultPublisher(workspaceRoot), typesVersion);
+  reshapeManifest(projectRoot, name, options.publisher ?? defaultPublisher(workspaceRoot));
   addVscodeTypes((0, import_node_path19.join)(projectRoot, "tsconfig.app.json"));
   addVscodeTypes((0, import_node_path19.join)(projectRoot, "tsconfig.spec.json"));
   writeFileEnsured((0, import_node_path19.join)(projectRoot, "src/main.ts"), vscodeExtensionMain(name));