@mnci/cli 4.12.1 → 4.12.3

package/README.md

@@ -1460,7 +1460,10 @@ extension:
   command. Tagged `type:vscode-extension`, and `nx.name` pins the Nx project name
   to the folder, so `name` (the Marketplace id is `<publisher>.<name>`) and
   `displayName` are yours to change: packages stay `<project>[-<target>].vsix`
-  and every script, task and launch entry keeps working.
+  and every script, task and launch entry keeps working. Run `npm install` after a
+  rename and commit the lock with it: `apps/*` is an npm workspace, the lock records
+  the app by `name`, and CI's `npm ci` refuses a lock that names a package no
+  manifest does (`mnci add` refreshes it for the name it writes, #251).
 - **`src/main.ts`**, not `extension.ts`: the slice rules allow only `index` and
   `main` at the root of `src`.
 - **Unit tests run against a stub of `vscode`**, `test/vscode.stub.ts`, mapped by

package/dist/cli.js

@@ -2331,6 +2331,7 @@ const VERSION_TAG = /<Version>([^<]*)<\\/Version>/
  */
 function findCsproj (tree, root) {
   const name = tree.children(root).find((entry) => entry.endsWith('.csproj'))
+
   return name ? posix.join(root, name) : null
 }
 
@@ -3815,6 +3816,9 @@ var VSCODE_SIDECAR_TARGETS = {
   "darwin-x64": "darwin-amd64",
   "darwin-arm64": "darwin-arm64"
 };
+function scriptObjectLiteral(map) {
+  return `{ ${Object.entries(map).map(([key, value]) => `'${key}': '${value}'`).join(", ")} }`;
+}
 var VSCODE_EXTENSION_SCRIPT = String.raw`#!/usr/bin/env node
 // Written by mnci: 'mnci add vscode-extension' creates it and 'mnci upgrade'
 // rewrites it, so local edits do not survive an upgrade.
@@ -3830,7 +3834,7 @@ const { spawnSync } = require('node:child_process')
 const { cpSync, existsSync, mkdirSync, readFileSync, rmSync } = require('node:fs')
 const { basename, dirname, join, resolve } = require('node:path')
 
-const TARGETS = ${JSON.stringify(VSCODE_SIDECAR_TARGETS)}
+const TARGETS = ${scriptObjectLiteral(VSCODE_SIDECAR_TARGETS)}
 const DROP = resolve('dist/drop')
 const VSCE_FLAGS = ['--no-dependencies', '--skip-license', '--allow-missing-repository']
 
@@ -3908,7 +3912,7 @@ const manifest = JSON.parse(readFileSync(join(projectRoot, 'package.json'), 'utf
 const project = basename(resolve(projectRoot))
 // nx release --dry-run hands the publish target --dryRun=true and sets NX_DRY_RUN
 // (measured on Nx 23), so a dry run never reaches the Marketplace, token or not.
-const dryRun = rest.some(argument => /^--dry-?run(=true)?$/i.test(argument)) || process.env.NX_DRY_RUN === 'true'
+const dryRun = rest.some(argument => /^--dry-?run(?:=true)?$/i.test(argument)) || process.env.NX_DRY_RUN === 'true'
 if (command === 'package') packageExtension(projectRoot, manifest, sidecar)
 else if (command === 'publish') publishExtension(manifest, sidecar, dryRun)
 else fail('Unknown command ' + command + ' - expected package or publish.')
@@ -4154,6 +4158,11 @@ function pinVscodeExtensionProjectNames(workspaceRoot) {
   }
   return updated;
 }
+function refreshLockFile(workspaceRoot, name) {
+  if (runShell("npm", ["install", "--package-lock-only", "--no-audit", "--no-fund"], workspaceRoot) !== 0) {
+    logger.warn(`Could not refresh package-lock.json after reshaping ${name}'s manifest. Run 'npm install' before committing.`);
+  }
+}
 function addVscodeExtension(workspaceRoot, name, stack, options = {}) {
   const { sidecar } = options;
   if (sidecar !== void 0 && !fileExists((0, import_node_path15.join)(workspaceRoot, "apps", sidecar, "project.json"))) {
@@ -4179,6 +4188,7 @@ function addVscodeExtension(workspaceRoot, name, stack, options = {}) {
   removeGeneratedEslintConfig(workspaceRoot, `apps/${name}`);
   registerProjectCommands(workspaceRoot, name, { build: true });
   addDebugLaunch(workspaceRoot, name);
+  refreshLockFile(workspaceRoot, name);
 }
 
 // src/dependency-management/sync-dependencies.use-case.ts