@mnci/cli 4.10.6 → 4.10.8

package/README.md

@@ -1371,8 +1371,21 @@ pipeline installs `golangci-lint` itself (see below).
   generators, in that order — `convert-to-one-mod` refuses once `go.work`
   lists any module, so it has to happen before the first Go project exists.
   Every Go project then shares that module and imports its siblings as
-  `<module>/libs/<name>`, with no per-project manifests and no `replace`
-  directives.
+  `<module>/libs/<name>/<slice>`, with no per-project manifests and no
+  `replace` directives.
+- **A Go library is a capability of slice packages.** The plugin's library
+  generator writes `<name>.go` at the project root, which makes the root
+  package the whole library. mnci replaces it with a root `doc.go` and moves
+  the sample into one starter slice package (`libs/markdown-workspace/
+  markdownworkspace/markdown_workspace_use_case.go`), the Go spelling of the
+  `<kebab>.<role>.ts` files the TypeScript scaffolds get. Rename the starter
+  after the outcome it delivers and add one package per further outcome.
+- **`test` and `lint` reach every slice package.** The plugin's executors run
+  `go test ./...` and `golangci-lint run ./...` from the project root
+  (measured on `@nx-go/nx-go` 4.1.1), so mnci passes no package list. The e2e
+  plants a failing test and a lint finding in a nested package and asserts
+  both fail the project target, so a plugin change that stopped recursing
+  would surface there rather than as a silently green lib.
 - **The `go.work` multi-module layout was rejected deliberately.** Besides
   splitting dependencies across per-project manifests, it is brittle: a
   single stale `use` entry — a project directory removed by hand — makes
@@ -1407,9 +1420,12 @@ build` links statically, so the binary in the drop already contains
 - **CI** runs Go through the same `nx run-many -t lint,test,build` as
   everything else. Two guarded steps precede it: `go mod download` (so a
   network failure reads as a dependency failure rather than a confusing
-  build error), and a `golangci-lint` install via `go install` — no package
-  manager, no sudo, same command on every agent OS — whose `GOPATH/bin` is
-  then added to `PATH` for later steps. All three skip cleanly when the
+  build error), and a `golangci-lint` install whose `GOPATH/bin` is then added
+  to `PATH` for later steps. The linter is **pinned** (`GOLANGCI_LINT_VERSION`)
+  and installed from its prebuilt release, verified against the release's
+  SHA-256 checksums, in about a second; compiling it with `go install` took
+  over a minute per run. Any download or verification failure falls back to
+  `go install` at the same pinned version. All three skip cleanly when the
   workspace has no root `go.mod`, and the linter install also skips when the
   agent already provides it.
 
@@ -1473,7 +1489,7 @@ build agents, so the generated pipeline installs it itself (see below).
   under the agent's home directory: the SDK ships dozens of its own
   `pubspec.yaml` files, which inside the tree would pollute pub's resolution and
   give Nx thousands of extra files to glob. The SDK version is **pinned**
-  (unlike `golangci-lint`'s `@latest`) because it determines the Dart version,
+  (as is `golangci-lint`'s) because it determines the Dart version,
   and pub workspaces need Dart 3.6+. Three guarded steps precede the build —
   install, add to `PATH`, and one root `flutter pub get` — and all three skip
   cleanly when the workspace has no root `pubspec.yaml`; the install also skips

package/dist/cli.js

@@ -614,7 +614,7 @@ var ESLINT_PEER_OVERRIDES = {
   // both — and forcing those to v5 breaks them. So the blast radius is one
   // dependency edge per named parent, and a test asserts there is no top-level
   // entry.
-  "nx": { "brace-expansion": "^5.0.9", "smol-toml": "^1.7.1" },
+  "nx": { "brace-expansion": "^5.0.9", "smol-toml": "^1.7.1", "axios": "^1.20.0" },
   "@nx/js": { "brace-expansion": "^5.0.9" },
   "@nx/eslint": { "brace-expansion": "^5.0.9" },
   "@nx/eslint-plugin": { "brace-expansion": "^5.0.9" },
@@ -857,7 +857,7 @@ function vscodeWorkspace(workspaceName, existingTasks, existingLaunch, existingS
     (configuration) => !String(configuration.name ?? "").startsWith(LAUNCH_CONFIG_PREFIX)
   );
   const settings = { ...existingSettings, ...vscodeSettings() };
-  return JSON.stringify(
+  return toJson(
     {
       folders: [{ path: ".", name: workspaceName }],
       settings,
@@ -870,9 +870,7 @@ function vscodeWorkspace(workspaceName, existingTasks, existingLaunch, existingS
         version: existingLaunch?.version ?? "0.2.0",
         configurations: [...launchConfigurations(workspaceName), ...userConfigurations]
       }
-    },
-    null,
-    2
+    }
   );
 }
 var ROOT_SCRIPTS = {
@@ -1005,7 +1003,8 @@ var PYTHON_INSTALL_GUARD = `node -e "if(!require('node:fs').existsSync('requirem
 var PYTHON_WORKSPACE_INSTALL_GUARD = `node -e "const fs=require('node:fs'),path=require('node:path');const editableDirs=[...fs.globSync('apps/*/pyproject.toml'),...fs.globSync('python-packages/*/pyproject.toml'),...fs.globSync('libs/*/pyproject.toml')].map((p)=>path.dirname(p));const requirementsFiles=fs.globSync('apps/*/requirements.txt');if(editableDirs.length===0&&requirementsFiles.length===0){console.log('No Python projects - skipping.');process.exit(0)}const args=['-m','pip','install','--quiet',...editableDirs.flatMap((d)=>['-e',d]),...requirementsFiles.flatMap((f)=>['-r',f])];const py=process.platform==='win32'?'python':'python3';process.exit(require('node:child_process').spawnSync(py,args,{stdio:'inherit'}).status ?? 1)"`;
 var PIP_AUDIT_GUARD = `node -e "if(!require('node:fs').existsSync('requirements-dev.txt')){console.log('No Python projects - skipping.');process.exit(0)}const py=process.platform==='win32'?'python':'python3';require('node:child_process').spawnSync(py,['-m','pip_audit'],{stdio:'inherit'});process.exit(0)"`;
 var GO_MODULE_DOWNLOAD_GUARD = `node -e "if(!require('node:fs').existsSync('go.mod')){console.log('No Go projects - skipping.');process.exit(0)}process.exit(require('node:child_process').spawnSync('go',['mod','download'],{stdio:'inherit'}).status ?? 1)"`;
-var GOLANGCI_LINT_INSTALL_GUARD = `node -e "const fs=require('node:fs'),cp=require('node:child_process');if(!fs.existsSync('go.mod')){console.log('No Go projects - skipping.');process.exit(0)}if(cp.spawnSync('golangci-lint',['--version'],{stdio:'ignore'}).status===0){console.log('golangci-lint already installed - skipping.');process.exit(0)}process.exit(cp.spawnSync('go',['install','github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest'],{stdio:'inherit'}).status ?? 1)"`;
+var GOLANGCI_LINT_VERSION = "2.14.0";
+var GOLANGCI_LINT_INSTALL_GUARD = `node -e "const fs=require('node:fs'),cp=require('node:child_process'),path=require('node:path'),os=require('node:os'),crypto=require('node:crypto');if(!fs.existsSync('go.mod')){console.log('No Go projects - skipping.');process.exit(0)}if(cp.spawnSync('golangci-lint',['--version'],{stdio:'ignore'}).status===0){console.log('golangci-lint already installed - skipping.');process.exit(0)}const v='${GOLANGCI_LINT_VERSION}';const fallback=reason=>{console.log('Prebuilt golangci-lint '+v+' unavailable ('+reason+') - building it with go install instead.');process.exit(cp.spawnSync('go',['install','github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v'+v],{stdio:'inherit'}).status ?? 1)};const plat={linux:'linux',darwin:'darwin',win32:'windows'}[process.platform],arch={x64:'amd64',arm64:'arm64'}[process.arch];if(!plat||!arch)fallback('no prebuilt release for '+process.platform+'/'+process.arch);const gopath=cp.spawnSync('go',['env','GOPATH'],{encoding:'utf8'});if(gopath.status!==0)fallback('go env GOPATH failed');const name='golangci-lint-'+v+'-'+plat+'-'+arch,file=name+(plat==='windows'?'.zip':'.tar.gz'),base='https://github.com/golangci/golangci-lint/releases/download/v'+v+'/';const get=async u=>{const r=await fetch(u,{signal:AbortSignal.timeout(60000)});if(!r.ok)throw new Error('HTTP '+r.status+' for '+u);return Buffer.from(await r.arrayBuffer())};(async()=>{` + String.raw`const sums=(await get(base+'golangci-lint-'+v+'-checksums.txt')).toString('utf8').split('\n').map(l=>l.trim().split(' ').filter(Boolean));` + `const entry=sums.find(p=>p[1]===file);if(!entry)throw new Error(file+' is not in the release checksums');const archive=await get(base+file);if(crypto.createHash('sha256').update(archive).digest('hex')!==entry[0])throw new Error('checksum mismatch for '+file);const tmp=fs.mkdtempSync(path.join(os.tmpdir(),'golangci-lint-')),archivePath=path.join(tmp,file);fs.writeFileSync(archivePath,archive);const tar=plat==='windows'?path.join(process.env.SystemRoot||'','System32','tar.exe'):'tar';const x=cp.spawnSync(tar,['-xf',archivePath,'-C',tmp],{stdio:'inherit'});if(x.status!==0)throw new Error('could not extract '+file);const exe='golangci-lint'+(plat==='windows'?'.exe':''),bin=path.join(gopath.stdout.trim(),'bin');fs.mkdirSync(bin,{recursive:true});fs.copyFileSync(path.join(tmp,name,exe),path.join(bin,exe));fs.chmodSync(path.join(bin,exe),0o755);fs.rmSync(tmp,{recursive:true,force:true});console.log('golangci-lint '+v+' installed from its checksum-verified prebuilt release into '+bin)})().catch(error=>fallback(error.message))"`;
 var GO_TOOL_PATH_PRELUDE = "const fs=require('node:fs'),cp=require('node:child_process');if(!fs.existsSync('go.mod')){console.log('No Go projects - skipping.');process.exit(0)}const r=cp.spawnSync('go',['env','GOPATH'],{encoding:'utf8'});if(r.status!==0){console.log('Could not resolve GOPATH - skipping.');process.exit(0)}const bin=require('node:path').join(r.stdout.trim(),'bin');";
 var GO_TOOL_PATH_AZURE = `node -e "${GO_TOOL_PATH_PRELUDE}console.log('##vso[task.prependpath]'+bin)"`;
 var GO_TOOL_PATH_GITHUB = `node -e "${GO_TOOL_PATH_PRELUDE}if(!process.env.GITHUB_PATH){console.log('Not running in GitHub Actions - skipping.');process.exit(0)}fs.appendFileSync(process.env.GITHUB_PATH,bin+${String.raw`'\n'`})"`;
@@ -1240,8 +1239,9 @@ ${npmAuthenticateStep}  - script: npm ci
     displayName: Download Go module dependencies
 
   # golangci-lint is what the generated Go lint target actually runs (the
-  # plugin's own default is 'go fmt', which only reformats). 'go install'
-  # drops it in GOPATH/bin, which is not on PATH by default on a hosted
+  # plugin's own default is 'go fmt', which only reformats). The pinned,
+  # checksum-verified prebuilt release lands in GOPATH/bin (go install at the
+  # same version is the fallback), which is not on PATH by default on a hosted
   # agent \u2014 so prepend it for every later step in the job.
   - script: ${GOLANGCI_LINT_INSTALL_GUARD}
     displayName: Install golangci-lint
@@ -1495,9 +1495,10 @@ jobs:
         name: Download Go module dependencies
 
       # golangci-lint is what the generated Go lint target actually runs (the
-      # plugin's own default is 'go fmt', which only reformats). 'go install'
-      # drops it in GOPATH/bin, which is not on PATH by default on a hosted
-      # runner \u2014 so publish it for every later step in the job.
+      # plugin's own default is 'go fmt', which only reformats). The pinned,
+      # checksum-verified prebuilt release lands in GOPATH/bin (go install at the
+      # same version is the fallback), which is not on PATH by default on a
+      # hosted runner \u2014 so publish it for every later step in the job.
       - run: ${GOLANGCI_LINT_INSTALL_GUARD}
         name: Install golangci-lint
 
@@ -1760,6 +1761,10 @@ function removeNxScaffolding(workspaceRoot) {
 }
 function removeNxAuthoredAgentFiles(workspaceRoot) {
   (0, import_node_fs2.rmSync)((0, import_node_path2.join)(workspaceRoot, NX_CLAUDE_SETTINGS), { force: true });
+  const claudeDirectory = (0, import_node_path2.join)(workspaceRoot, (0, import_node_path2.dirname)(NX_CLAUDE_SETTINGS));
+  if ((0, import_node_fs2.existsSync)(claudeDirectory) && (0, import_node_fs2.readdirSync)(claudeDirectory).length === 0) {
+    (0, import_node_fs2.rmSync)(claudeDirectory, { recursive: true, force: true });
+  }
   for (const name of NX_AUTHORED_AGENT_FILES) {
     const path = (0, import_node_path2.join)(workspaceRoot, name);
     if (!(0, import_node_fs2.existsSync)(path)) continue;
@@ -2638,6 +2643,65 @@ function goStartTarget(name) {
     options: { command: "go run .", cwd: `apps/${name}` }
   };
 }
+function goLibraryIdentifiers(projectName) {
+  const words = projectName.split(/[^a-z0-9]+/i).filter((word) => word.length > 0);
+  return {
+    packageName: words.join("").toLowerCase(),
+    functionName: words.map((word) => word.charAt(0).toUpperCase() + word.slice(1)).join(""),
+    fileStem: words.join("_").toLowerCase()
+  };
+}
+function reshapeGoLibraryScaffold(projectRoot, projectName) {
+  const { packageName, functionName, fileStem } = goLibraryIdentifiers(projectName);
+  (0, import_node_fs5.rmSync)((0, import_node_path6.join)(projectRoot, `${projectName}.go`), { force: true });
+  (0, import_node_fs5.rmSync)((0, import_node_path6.join)(projectRoot, `${projectName}_test.go`), { force: true });
+  const files = [
+    [
+      "doc.go",
+      `// Package ${packageName} is the ${projectName} capability. Its code lives in the
+// slice packages below this directory, one package per outcome.
+package ${packageName}
+`
+    ],
+    [
+      (0, import_node_path6.join)(packageName, "doc.go"),
+      `// Package ${packageName} is the starter slice of ${projectName}: rename it after
+// the outcome it delivers, and add one package per further outcome.
+package ${packageName}
+`
+    ],
+    [
+      (0, import_node_path6.join)(packageName, `${fileStem}_use_case.go`),
+      `package ${packageName}
+
+// ${functionName} is the generator's sample behaviour, kept so the slice builds and tests.
+func ${functionName}(name string) string {
+	return "${functionName} " + name
+}
+`
+    ],
+    [
+      (0, import_node_path6.join)(packageName, `${fileStem}_use_case_test.go`),
+      `package ${packageName}
+
+import "testing"
+
+func Test${functionName}(t *testing.T) {
+	if got := ${functionName}("works"); got != "${functionName} works" {
+		t.Fatalf("got %q", got)
+	}
+}
+`
+    ]
+  ];
+  for (const [relativePath, content] of files) {
+    const path = (0, import_node_path6.join)(projectRoot, relativePath);
+    if (!fileExists(path)) {
+      writeFileEnsured(path, content);
+    }
+  }
+  return packageName;
+}
 function prepareGo(workspaceRoot) {
   ensureGo(workspaceRoot);
   warnIfNoGolangciLint(workspaceRoot);
@@ -2706,10 +2770,11 @@ function addGoLib(workspaceRoot, name) {
     test: goTestTarget(),
     lint: goLintTarget()
   });
+  const slice = reshapeGoLibraryScaffold((0, import_node_path6.join)(workspaceRoot, "packages", name), name);
   registerProjectCommands(workspaceRoot, name, { build: false });
   const module2 = goModulePath(workspaceRoot);
   if (module2) {
-    logger.step(`Import it as ${module2}/packages/${name}`);
+    logger.step(`Import its starter slice as ${module2}/packages/${name}/${slice}`);
   }
 }
 function addGoInternalLib(workspaceRoot, name) {
@@ -2729,10 +2794,11 @@ function addGoInternalLib(workspaceRoot, name) {
     test: goTestTarget(),
     lint: goLintTarget()
   });
+  const slice = reshapeGoLibraryScaffold((0, import_node_path6.join)(workspaceRoot, "libs", name), name);
   registerProjectCommands(workspaceRoot, name, { build: false });
   const module2 = goModulePath(workspaceRoot);
   if (module2) {
-    logger.step(`Import it as ${module2}/libs/${name}`);
+    logger.step(`Import its starter slice as ${module2}/libs/${name}/${slice}`);
   }
 }
 
@@ -5271,7 +5337,25 @@ function runDoctor(workspaceRoot) {
 var import_node_fs13 = require("fs");
 var import_node_path20 = require("path");
 var NEVER_COPIED = /* @__PURE__ */ new Set([".git", "node_modules"]);
-var EXISTING_WINS = /* @__PURE__ */ new Set(["README.md", "LICENSE", "LICENSE.md", "LICENSE.txt"]);
+var AGENT_AND_CI_ENTRIES = [
+  "AGENTS.md",
+  "CLAUDE.md",
+  ".claude",
+  ".agents",
+  ".codex",
+  ".cursor",
+  ".gemini",
+  ".opencode",
+  "opencode.json",
+  ".github"
+];
+var EXISTING_WINS = /* @__PURE__ */ new Set([
+  "README.md",
+  "LICENSE",
+  "LICENSE.md",
+  "LICENSE.txt",
+  ...AGENT_AND_CI_ENTRIES
+]);
 var PREFLIGHT_BLOCKERS = [
   "package.json",
   "nx.json",
@@ -5398,27 +5482,30 @@ async function runNew(name, options) {
   const stack = await resolveStack(options);
   const nxCloud = options.nxCloud ?? (options.yes ? false : await promptNxCloud());
   const stagingParent = adoptTarget === void 0 ? process.cwd() : (0, import_node_fs14.mkdtempSync)((0, import_node_path21.join)((0, import_node_os.tmpdir)(), "mnci-new-"));
-  logger.step(`Creating Nx workspace '${workspaceName}' (preset: ts)`);
-  runNpx(
-    [
-      "--yes",
-      "create-nx-workspace@latest",
-      workspaceName,
-      "--preset=ts",
-      "--pm=npm",
-      nxCloud ? `--nxCloud=${nxCloudProviderValue(ci)}` : "--nxCloud=skip",
-      "--no-interactive"
-    ],
-    stagingParent
-  );
   let workspaceRoot = (0, import_node_path21.join)(stagingParent, workspaceName);
-  if (adoptTarget !== void 0) {
-    logger.step(`Adopting ${adoptTarget} (keeping its .git)`);
-    const adoption = adoptGeneratedWorkspace(workspaceRoot, adoptTarget);
-    for (const kept of adoption.kept) logger.detail(`kept the existing ${kept}`);
-    if (adoption.mergedGitignore) logger.detail("merged the generated .gitignore into the existing one");
-    (0, import_node_fs14.rmSync)(stagingParent, { recursive: true, force: true });
-    workspaceRoot = adoptTarget;
+  try {
+    logger.step(`Creating Nx workspace '${workspaceName}' (preset: ts)`);
+    runNpx(
+      [
+        "--yes",
+        "create-nx-workspace@latest",
+        workspaceName,
+        "--preset=ts",
+        "--pm=npm",
+        nxCloud ? `--nxCloud=${nxCloudProviderValue(ci)}` : "--nxCloud=skip",
+        "--no-interactive"
+      ],
+      stagingParent
+    );
+    if (adoptTarget !== void 0) {
+      logger.step(`Adopting ${adoptTarget} (keeping its .git)`);
+      const adoption = adoptGeneratedWorkspace(workspaceRoot, adoptTarget);
+      for (const kept of adoption.kept) logger.detail(`kept the existing ${kept}`);
+      if (adoption.mergedGitignore) logger.detail("merged the generated .gitignore into the existing one");
+      workspaceRoot = adoptTarget;
+    }
+  } finally {
+    if (adoptTarget !== void 0) (0, import_node_fs14.rmSync)(stagingParent, { recursive: true, force: true });
   }
   logger.step(
     "Applying MoNecromanCI overlay (VS Code workspace, release config, .npmrc, commitlint, pipeline, stack)"