@mnci/cli 1.15.7 → 1.15.9

package/README.md

@@ -145,7 +145,13 @@ that would just fail felt worse than being upfront that it doesn't exist yet.
 2. Patches `nx.json` with the release opinion (the only config Nx has no
    default for): independent versioning from **conventional commits**,
    `{projectName}@{version}` tags, **tag-only git** (`commit: false`) — nothing
-   is ever pushed to `main`; future runs resolve versions from tag names.
+   is ever pushed to `main`; future runs resolve versions from tag names. Also
+   fills in `namedInputs.sharedGlobals` with the root config files
+   (`eslint.config.mjs`, `tsconfig.base.json`, `package.json`), without which
+   `nx affected` on a pull request is blind to them: they live in no project, so
+   changing one marked only the root pseudo-project — which has no
+   lint/typecheck/test/build target — and the affected-scoped verify step ran
+   nothing at all while reporting green.
 3. Writes `eslint.config.mjs` (three lines importing `@mnci/eslint-config` —
    the whole linting opinion, in one root config), `.prettierrc.json` +
    `.prettierignore`, `.npmrc` (publish auth — see **Publish auth** below),
@@ -169,7 +175,8 @@ this existed; nothing let an already-generated workspace pick one up.
 `mnci upgrade`, run from the workspace root, closes that gap: it resolves the
 same options `new` would have and calls the exact same `applyOverlay` `new`
 itself calls — the one function that does every bit of `mnci`-owned file
-writing (`nx.json`'s `release`/`sync`/`generators`/`mnci` blocks, `.npmrc`,
+writing (`nx.json`'s `release`/`sync`/`generators`/`namedInputs.sharedGlobals`/
+`mnci` blocks, `.npmrc`,
 `eslint.config.mjs`, `.prettierrc.json`, `commitlint.config.mjs`,
 `.husky/commit-msg`, the CI pipeline file(s), the
 `<workspace-name>.code-workspace` file, and the curated root `package.json`

package/dist/cli.js

@@ -1329,6 +1329,20 @@ function withEslintPlugin(nxJson) {
   const registered = plugins.some((entry) => pluginName(entry) === ESLINT_PLUGIN_CONFIG.plugin);
   return registered ? { ...nxJson, plugins } : { ...nxJson, plugins: [...plugins, ESLINT_PLUGIN_CONFIG] };
 }
+var SHARED_GLOBAL_INPUTS = [
+  "{workspaceRoot}/eslint.config.mjs",
+  "{workspaceRoot}/tsconfig.base.json",
+  "{workspaceRoot}/package.json"
+];
+function withSharedGlobals(nxJson) {
+  const namedInputs = nxJson.namedInputs ?? {};
+  const existing = namedInputs.sharedGlobals ?? [];
+  const missing = SHARED_GLOBAL_INPUTS.filter((entry) => !existing.includes(entry));
+  return {
+    ...nxJson,
+    namedInputs: { ...namedInputs, sharedGlobals: [...existing, ...missing] }
+  };
+}
 function withReleaseConfig(nxJson, ci) {
   return { ...nxJson, defaultBase: "main", release: releaseConfig(ci) };
 }
@@ -1350,7 +1364,10 @@ var ESLINT_CONFIG_VERSION = "^0.1.0";
 function eslintConfigSpec() {
   return process.env.MNCI_ESLINT_CONFIG_SPEC ?? ESLINT_CONFIG_VERSION;
 }
-var ESLINT_VERSION = "^9.39.0";
+var ESLINT_VERSION = "^10.8.0";
+var ESLINT_PEER_OVERRIDES = {
+  "eslint-plugin-jsx-a11y": { eslint: "$eslint" }
+};
 function eslintToolchainDependencies(nxVersion) {
   return {
     eslint: ESLINT_VERSION,
@@ -2004,7 +2021,7 @@ function applyOverlay(workspaceRoot, options) {
   };
   const sync = { ...nxJson.sync, ...SYNC_CONFIG };
   const mnci = { ...nxJson.mnci, ...mnciConfig(options) };
-  const patched = withEslintPlugin(withReleaseConfig(nxJson, options.ci));
+  const patched = withSharedGlobals(withEslintPlugin(withReleaseConfig(nxJson, options.ci)));
   writeFileEnsured(nxJsonPath, toJson({ ...patched, generators, sync, mnci }));
   const manifestPath = (0, import_node_path11.join)(workspaceRoot, "package.json");
   const manifest = readJson(manifestPath);
@@ -2020,9 +2037,19 @@ function applyOverlay(workspaceRoot, options) {
     ...eslintToolchainDependencies(existingDevDeps?.nx ?? "latest"),
     prettier: PRETTIER_VERSION
   };
+  const overrides = {
+    ...manifest.overrides,
+    ...ESLINT_PEER_OVERRIDES
+  };
   writeFileEnsured(
     manifestPath,
-    toJson({ ...manifest, name: `${options.scope}/source`, scripts, devDependencies: devDeps })
+    toJson({
+      ...manifest,
+      name: `${options.scope}/source`,
+      scripts,
+      devDependencies: devDeps,
+      overrides
+    })
   );
   writeFileEnsured((0, import_node_path11.join)(workspaceRoot, ".npmrc"), npmrcContent(options.registry, options.scope));
   writeFileEnsured((0, import_node_path11.join)(workspaceRoot, "commitlint.config.mjs"), COMMITLINT_CONFIG);
@@ -2056,7 +2083,7 @@ function applyOverlay(workspaceRoot, options) {
 }
 
 // src/commands/doctor.ts
-var SUPPORTED_ESLINT_MAJOR = ESLINT_VERSION.replace(/^\D*/, "").split(".")[0];
+var SUPPORTED_ESLINT_MAJOR = ESLINT_VERSION.replace(/^\D*/, "").split(".", 1)[0];
 function checkEslintConfigs(workspaceRoot) {
   const rootConfigs = (0, import_node_fs7.globSync)("eslint.config.{js,mjs,cjs,ts,mts,cts}", { cwd: workspaceRoot });
   const projectConfigs = (0, import_node_fs7.globSync)("{apps,libs,packages}/*/eslint.config.{js,mjs,cjs,ts,mts,cts}", {
@@ -2089,7 +2116,7 @@ function checkPrettierConfig(workspaceRoot) {
 function checkEslintPlugin(nxJson) {
   const plugins = nxJson.plugins ?? [];
   const registered = plugins.some(
-    (entry) => typeof entry === "string" ? entry === "@nx/eslint/plugin" : entry.plugin === "@nx/eslint/plugin"
+    (entry) => (typeof entry === "string" ? entry : entry.plugin) === "@nx/eslint/plugin"
   );
   return {
     check: "@nx/eslint/plugin registered",
@@ -2105,7 +2132,7 @@ function checkResolvedEslint(workspaceRoot) {
   }
   try {
     const { version } = readJson(manifestPath);
-    const major = version.split(".")[0];
+    const major = version.split(".", 1)[0];
     return {
       check: `resolved eslint is ${SUPPORTED_ESLINT_MAJOR}.x`,
       ok: major === SUPPORTED_ESLINT_MAJOR,
@@ -2150,7 +2177,6 @@ function checkVersionActions(workspaceRoot) {
       const projectJson = readJson(projectJsonPath);
       hasOverride = Boolean(projectJson.release?.version?.versionActions);
     } catch {
-      hasOverride = false;
     }
     return [
       {
@@ -2407,15 +2433,15 @@ function runUpgrade(workspaceRoot, options) {
 // src/commands/interactive.ts
 async function runInteractive() {
   const inWorkspace = fileExists((0, import_node_path15.join)(process.cwd(), "nx.json"));
-  const newChoice = { name: "Create a new monorepo", value: "new" };
-  const addChoice = { name: "Add a project to this workspace", value: "add" };
-  const upgradeChoice = {
+  const choiceNew = { name: "Create a new monorepo", value: "new" };
+  const choiceAdd = { name: "Add a project to this workspace", value: "add" };
+  const choiceUpgrade = {
     name: "Upgrade this workspace (re-apply the latest overlay)",
     value: "upgrade"
   };
   const action = await (0, import_prompts8.select)({
     message: "What would you like to do?",
-    choices: inWorkspace ? [addChoice, upgradeChoice, newChoice] : [newChoice, addChoice, upgradeChoice]
+    choices: inWorkspace ? [choiceAdd, choiceUpgrade, choiceNew] : [choiceNew, choiceAdd, choiceUpgrade]
   });
   if (action === "new") {
     await runNew(void 0, {});
@@ -2538,7 +2564,7 @@ async function main() {
     checkForUpdate(cliVersion);
     const arguments_ = new Set(process.argv.slice(2));
     const requestedVersionFlag = arguments_.has("-v") || arguments_.has("--version");
-    if (process.stdout.isTTY && !requestedVersionFlag) {
+    if (!requestedVersionFlag && process.stdout.isTTY) {
       logger.info(`mnci v${cliVersion}`);
     }
     await program.parseAsync(process.argv);