@mmnto/totem 1.27.0 → 1.28.1

package/dist/stale-manifest.test.js

@@ -0,0 +1,164 @@
+/**
+ * Tests for `detectStaleManifest` + `staleManifestError`
+ * (mmnto-ai/totem#1811, ADR-101).
+ *
+ * Two parallel paths drive the design:
+ *   - Tree-sitter miss + cohort matches (semver-minor) → null detection,
+ *     caller falls through to the original `TotemParseError`.
+ *   - Tree-sitter miss + cohort missing/mismatched → detection object,
+ *     caller surfaces a structured `STALE_MANIFEST` nudge.
+ *
+ * Both paths use a stubbed engine version + manifest reader so the
+ * test does not depend on the real package.json or filesystem.
+ */
+import { describe, expect, it } from 'vitest';
+import { detectStaleManifest, staleManifestError } from './stale-manifest.js';
+const STUB_ENGINE = '1.27.0';
+const stubResolve = () => STUB_ENGINE;
+function makeReader(manifest) {
+    if (manifest === null)
+        return () => null;
+    if (typeof manifest === 'string')
+        return () => manifest;
+    return () => JSON.stringify(manifest);
+}
+describe('detectStaleManifest', () => {
+    it('returns null when cohort major.minor matches the engine (happy path)', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: makeReader({ version: 1, cohort: '1.27.0', packs: [] }),
+        });
+        expect(result).toBeNull();
+    });
+    it('tolerates patch drift (1.27.0 manifest vs 1.27.5 engine)', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: () => '1.27.5',
+            readManifest: makeReader({ version: 1, cohort: '1.27.0', packs: [] }),
+        });
+        expect(result).toBeNull();
+    });
+    it('flags minor bump (1.26.x → 1.27.x)', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: makeReader({ version: 1, cohort: '1.26.5', packs: [] }),
+        });
+        expect(result).toEqual({
+            reason: 'cohort-mismatch',
+            manifestCohort: '1.26.5',
+            engineVersion: STUB_ENGINE,
+        });
+    });
+    it('flags major bump (1.x → 2.x)', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: () => '2.0.0',
+            readManifest: makeReader({ version: 1, cohort: '1.27.0', packs: [] }),
+        });
+        expect(result).toEqual({
+            reason: 'cohort-mismatch',
+            manifestCohort: '1.27.0',
+            engineVersion: '2.0.0',
+        });
+    });
+    it('flags missing manifest (ENOENT path)', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: makeReader(null),
+        });
+        expect(result).toEqual({ reason: 'no-manifest', engineVersion: STUB_ENGINE });
+    });
+    it('flags pre-1.27.0 manifest without cohort field', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: makeReader({ version: 1, packs: [] }),
+        });
+        expect(result).toEqual({ reason: 'no-cohort', engineVersion: STUB_ENGINE });
+    });
+    it('flags malformed cohort (not semver) as no-cohort with the malformed value preserved', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: makeReader({ version: 1, cohort: 'not-a-semver', packs: [] }),
+        });
+        expect(result).toEqual({
+            reason: 'no-cohort',
+            manifestCohort: 'not-a-semver',
+            engineVersion: STUB_ENGINE,
+        });
+    });
+    it('treats unparseable JSON as no-manifest (defensive fallback)', () => {
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: () => '{ not valid json',
+        });
+        expect(result).toEqual({ reason: 'no-manifest', engineVersion: STUB_ENGINE });
+    });
+    it('treats schema-invalid manifest as no-manifest (defensive fallback)', () => {
+        // Wrong type for `version` → fails schema, treated as missing.
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: stubResolve,
+            readManifest: makeReader({ version: '1', packs: [] }),
+        });
+        expect(result).toEqual({ reason: 'no-manifest', engineVersion: STUB_ENGINE });
+    });
+    it('returns null when engineVersion is not semver-valid (defensive fallback; mmnto-ai/totem#1829)', () => {
+        // Defensive against a malformed `@mmnto/totem` package.json that
+        // somehow escapes `resolveEngineVersion`'s sentinel fallback.
+        // Without this guard, `semver.major(engineVersion)` would throw
+        // when the cohort comparison ran. Caller falls through to the
+        // original TotemParseError unmasked. Source-level validation in
+        // resolveEngineVersion is tracked as mmnto-ai/totem#1829.
+        const result = detectStaleManifest({
+            workingDirectory: '/fake',
+            resolveVersion: () => 'not-a-semver',
+            readManifest: makeReader({ version: 1, cohort: '1.26.0', packs: [] }),
+        });
+        expect(result).toBeNull();
+    });
+});
+describe('staleManifestError', () => {
+    it('wraps every detection class in a STALE_MANIFEST TotemError pointing at --packs-only', () => {
+        const detection = {
+            reason: 'cohort-mismatch',
+            manifestCohort: '1.26.0',
+            engineVersion: '1.27.0',
+        };
+        const err = staleManifestError(detection, {
+            file: 'src/main.rs',
+            extension: '.rs',
+            ruleHash: 'abc123',
+        });
+        expect(err.code).toBe('STALE_MANIFEST');
+        expect(err.message).toMatch(/1\.26\.0/);
+        expect(err.message).toMatch(/1\.27\.0/);
+        expect(err.message).toMatch(/main\.rs/);
+        expect(err.recoveryHint).toMatch(/--packs-only/);
+    });
+    it('reports no-manifest cleanly when cohort is absent from the message', () => {
+        const detection = { reason: 'no-manifest', engineVersion: '1.27.0' };
+        const err = staleManifestError(detection, {
+            file: 'lib.rs',
+            extension: '.rs',
+            ruleHash: 'def456',
+        });
+        expect(err.message).toMatch(/missing or unreadable/);
+        expect(err.message).toMatch(/def456/);
+    });
+    it('reports no-cohort with the pre-1.27.0 framing', () => {
+        const detection = { reason: 'no-cohort', engineVersion: '1.27.0' };
+        const err = staleManifestError(detection, {
+            file: 'a.rs',
+            extension: '.rs',
+            ruleHash: 'xyz789',
+        });
+        expect(err.message).toMatch(/pre-1\.27\.0/);
+    });
+});
+//# sourceMappingURL=stale-manifest.test.js.map

package/dist/stale-manifest.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"stale-manifest.test.js","sourceRoot":"","sources":["../src/stale-manifest.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAE9C,OAAO,EAAE,mBAAmB,EAAE,kBAAkB,EAAE,MAAM,qBAAqB,CAAC;AAE9E,MAAM,WAAW,GAAG,QAAQ,CAAC;AAC7B,MAAM,WAAW,GAAG,GAAG,EAAE,CAAC,WAAW,CAAC;AAEtC,SAAS,UAAU,CAAC,QAAgC;IAClD,IAAI,QAAQ,KAAK,IAAI;QAAE,OAAO,GAAG,EAAE,CAAC,IAAI,CAAC;IACzC,IAAI,OAAO,QAAQ,KAAK,QAAQ;QAAE,OAAO,GAAG,EAAE,CAAC,QAAQ,CAAC;IACxD,OAAO,GAAG,EAAE,CAAC,IAAI,CAAC,SAAS,CAAC,QAAQ,CAAC,CAAC;AACxC,CAAC;AAED,QAAQ,CAAC,qBAAqB,EAAE,GAAG,EAAE;IACnC,EAAE,CAAC,sEAAsE,EAAE,GAAG,EAAE;QAC9E,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACtE,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC5B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0DAA0D,EAAE,GAAG,EAAE;QAClE,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,GAAG,EAAE,CAAC,QAAQ;YAC9B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACtE,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC5B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,GAAG,EAAE;QAC5C,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACtE,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;YACrB,MAAM,EAAE,iBAAiB;YACzB,cAAc,EAAE,QAAQ;YACxB,aAAa,EAAE,WAAW;SAC3B,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8BAA8B,EAAE,GAAG,EAAE;QACtC,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,GAAG,EAAE,CAAC,OAAO;YAC7B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACtE,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;YACrB,MAAM,EAAE,iBAAiB;YACzB,cAAc,EAAE,QAAQ;YACxB,aAAa,EAAE,OAAO;SACvB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sCAAsC,EAAE,GAAG,EAAE;QAC9C,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,UAAU,CAAC,IAAI,CAAC;SAC/B,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,aAAa,EAAE,aAAa,EAAE,WAAW,EAAE,CAAC,CAAC;IAChF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,GAAG,EAAE;QACxD,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACpD,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,WAAW,EAAE,aAAa,EAAE,WAAW,EAAE,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qFAAqF,EAAE,GAAG,EAAE;QAC7F,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,cAAc,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SAC5E,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC;YACrB,MAAM,EAAE,WAAW;YACnB,cAAc,EAAE,cAAc;YAC9B,aAAa,EAAE,WAAW;SAC3B,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,GAAG,EAAE,CAAC,kBAAkB;SACvC,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,aAAa,EAAE,aAAa,EAAE,WAAW,EAAE,CAAC,CAAC;IAChF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC5E,+DAA+D;QAC/D,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,WAAW;YAC3B,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,GAAG,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACtD,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,aAAa,EAAE,aAAa,EAAE,WAAW,EAAE,CAAC,CAAC;IAChF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+FAA+F,EAAE,GAAG,EAAE;QACvG,iEAAiE;QACjE,8DAA8D;QAC9D,gEAAgE;QAChE,8DAA8D;QAC9D,gEAAgE;QAChE,0DAA0D;QAC1D,MAAM,MAAM,GAAG,mBAAmB,CAAC;YACjC,gBAAgB,EAAE,OAAO;YACzB,cAAc,EAAE,GAAG,EAAE,CAAC,cAAc;YACpC,YAAY,EAAE,UAAU,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,MAAM,EAAE,QAAQ,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;SACtE,CAAC,CAAC;QACH,MAAM,CAAC,MAAM,CAAC,CAAC,QAAQ,EAAE,CAAC;IAC5B,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAClC,EAAE,CAAC,qFAAqF,EAAE,GAAG,EAAE;QAC7F,MAAM,SAAS,GAAG;YAChB,MAAM,EAAE,iBAA0B;YAClC,cAAc,EAAE,QAAQ;YACxB,aAAa,EAAE,QAAQ;SACxB,CAAC;QACF,MAAM,GAAG,GAAG,kBAAkB,CAAC,SAAS,EAAE;YACxC,IAAI,EAAE,aAAa;YACnB,SAAS,EAAE,KAAK;YAChB,QAAQ,EAAE,QAAQ;SACnB,CAAC,CAAC;QACH,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,gBAAgB,CAAC,CAAC;QACxC,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;QACxC,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;QACxC,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;QACxC,MAAM,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC5E,MAAM,SAAS,GAAG,EAAE,MAAM,EAAE,aAAsB,EAAE,aAAa,EAAE,QAAQ,EAAE,CAAC;QAC9E,MAAM,GAAG,GAAG,kBAAkB,CAAC,SAAS,EAAE;YACxC,IAAI,EAAE,QAAQ;YACd,SAAS,EAAE,KAAK;YAChB,QAAQ,EAAE,QAAQ;SACnB,CAAC,CAAC;QACH,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,uBAAuB,CAAC,CAAC;QACrD,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC;IACxC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,MAAM,SAAS,GAAG,EAAE,MAAM,EAAE,WAAoB,EAAE,aAAa,EAAE,QAAQ,EAAE,CAAC;QAC5E,MAAM,GAAG,GAAG,kBAAkB,CAAC,SAAS,EAAE;YACxC,IAAI,EAAE,MAAM;YACZ,SAAS,EAAE,KAAK;YAChB,QAAQ,EAAE,QAAQ;SACnB,CAAC,CAAC;QACH,MAAM,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC,OAAO,CAAC,cAAc,CAAC,CAAC;IAC9C,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/store/lance-schema.d.ts

@@ -16,10 +16,10 @@ export declare const StoredChunkSchema: z.ZodObject<{
     metadata: z.ZodString;
 }, "strip", z.ZodTypeAny, {
     type: "code" | "session_log" | "spec" | "lesson";
-    filePath: string;
     strategy: string;
     content: string;
     contextPrefix: string;
+    filePath: string;
     label: string;
     startLine: number;
     endLine: number;
@@ -27,10 +27,10 @@ export declare const StoredChunkSchema: z.ZodObject<{
     metadata: string;
 }, {
     type: "code" | "session_log" | "spec" | "lesson";
-    filePath: string;
     strategy: string;
     content: string;
     contextPrefix: string;
+    filePath: string;
     label: string;
     startLine: number;
     endLine: number;

package/dist/types.d.ts

@@ -161,7 +161,7 @@ export declare const LessonFrontmatterSchema: z.ZodObject<{
     }, {
         globs?: string[] | undefined;
     }>>;
-    appliesTo: z.ZodDefault<z.ZodEffects<z.ZodArray<z.ZodEnum<["mutator", "boundary", "aggregator", "hot-path", "boundary-test", "infrastructure", "presentation", "any"]>, "many">, ("any" | "mutator" | "boundary" | "aggregator" | "hot-path" | "boundary-test" | "infrastructure" | "presentation")[], unknown>>;
+    appliesTo: z.ZodDefault<z.ZodEffects<z.ZodArray<z.ZodEnum<["mutator", "boundary", "aggregator", "hot-path", "boundary-test", "infrastructure", "presentation", "any"]>, "many">, ("mutator" | "boundary" | "aggregator" | "hot-path" | "boundary-test" | "infrastructure" | "presentation" | "any")[], unknown>>;
     ecosystem: z.ZodOptional<z.ZodObject<{
         frameworks: z.ZodOptional<z.ZodArray<z.ZodString, "many">>;
         version: z.ZodOptional<z.ZodString>;
@@ -188,7 +188,7 @@ export declare const LessonFrontmatterSchema: z.ZodObject<{
     type: "trap";
     severity: "error" | "warning";
     tags: string[];
-    appliesTo: ("any" | "mutator" | "boundary" | "aggregator" | "hot-path" | "boundary-test" | "infrastructure" | "presentation")[];
+    appliesTo: ("mutator" | "boundary" | "aggregator" | "hot-path" | "boundary-test" | "infrastructure" | "presentation" | "any")[];
     lifecycle: "nursery" | "stable" | "deprecated";
     category?: "security" | "architecture" | "style" | "performance" | undefined;
     scope?: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mmnto/totem",
-  "version": "1.27.0",
+  "version": "1.28.1",
   "description": "Persistent memory and context layer for AI agents",
   "type": "module",
   "main": "./dist/index.js",