@mmnto/pack-rust-architecture 1.23.0

package/.totemignore

@@ -0,0 +1,4 @@
+scripts/
+.github/**
+**/*.test.*
+**/*.spec.*

package/LICENSE

@@ -0,0 +1,190 @@
+                                 Apache License
+                           Version 2.0, January 2004
+                        http://www.apache.org/licenses/
+
+   TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
+
+   1. Definitions.
+
+      "License" shall mean the terms and conditions for use, reproduction,
+      and distribution as defined by Sections 1 through 9 of this document.
+
+      "Licensor" shall mean the copyright owner or entity authorized by
+      the copyright owner that is granting the License.
+
+      "Legal Entity" shall mean the union of the acting entity and all
+      other entities that control, are controlled by, or are under common
+      control with that entity. For the purposes of this definition,
+      "control" means (i) the power, direct or indirect, to cause the
+      direction or management of such entity, whether by contract or
+      otherwise, or (ii) ownership of fifty percent (50%) or more of the
+      outstanding shares, or (iii) beneficial ownership of such entity.
+
+      "You" (or "Your") shall mean an individual or Legal Entity
+      exercising permissions granted by this License.
+
+      "Source" form shall mean the preferred form for making modifications,
+      including but not limited to software source code, documentation
+      source, and configuration files.
+
+      "Object" form shall mean any form resulting from mechanical
+      transformation or translation of a Source form, including but
+      not limited to compiled object code, generated documentation,
+      and conversions to other media types.
+
+      "Work" shall mean the work of authorship, whether in Source or
+      Object form, made available under the License, as indicated by a
+      copyright notice that is included in or attached to the work
+      (an example is provided in the Appendix below).
+
+      "Derivative Works" shall mean any work, whether in Source or Object
+      form, that is based on (or derived from) the Work and for which the
+      editorial revisions, annotations, elaborations, or other modifications
+      represent, as a whole, an original work of authorship. For the purposes
+      of this License, Derivative Works shall not include works that remain
+      separable from, or merely link (or bind by name) to the interfaces of,
+      the Work and Derivative Works thereof.
+
+      "Contribution" shall mean any work of authorship, including
+      the original version of the Work and any modifications or additions
+      to that Work or Derivative Works thereof, that is intentionally
+      submitted to the Licensor for inclusion in the Work by the copyright owner
+      or by an individual or Legal Entity authorized to submit on behalf of
+      the copyright owner. For the purposes of this definition, "submitted"
+      means any form of electronic, verbal, or written communication sent
+      to the Licensor or its representatives, including but not limited to
+      communication on electronic mailing lists, source code control systems,
+      and issue tracking systems that are managed by, or on behalf of, the
+      Licensor for the purpose of discussing and improving the Work, but
+      excluding communication that is conspicuously marked or otherwise
+      designated in writing by the copyright owner as "Not a Contribution."
+
+      "Contributor" shall mean Licensor and any individual or Legal Entity
+      on behalf of whom a Contribution has been received by the Licensor and
+      subsequently incorporated within the Work.
+
+   2. Grant of Copyright License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      copyright license to reproduce, prepare Derivative Works of,
+      publicly display, publicly perform, sublicense, and distribute the
+      Work and such Derivative Works in Source or Object form.
+
+   3. Grant of Patent License. Subject to the terms and conditions of
+      this License, each Contributor hereby grants to You a perpetual,
+      worldwide, non-exclusive, no-charge, royalty-free, irrevocable
+      (except as stated in this section) patent license to make, have made,
+      use, offer to sell, sell, import, and otherwise transfer the Work,
+      where such license applies only to those patent claims licensable
+      by such Contributor that are necessarily infringed by their
+      Contribution(s) alone or by combination of their Contribution(s)
+      with the Work to which such Contribution(s) was submitted. If You
+      institute patent litigation against any entity (including a
+      cross-claim or counterclaim in a lawsuit) alleging that the Work
+      or a Contribution incorporated within the Work constitutes direct
+      or contributory patent infringement, then any patent licenses
+      granted to You under this License for that Work shall terminate
+      as of the date such litigation is filed.
+
+   4. Redistribution. You may reproduce and distribute copies of the
+      Work or Derivative Works thereof in any medium, with or without
+      modifications, and in Source or Object form, provided that You
+      meet the following conditions:
+
+      (a) You must give any other recipients of the Work or
+          Derivative Works a copy of this License; and
+
+      (b) You must cause any modified files to carry prominent notices
+          stating that You changed the files; and
+
+      (c) You must retain, in the Source form of any Derivative Works
+          that You distribute, all copyright, patent, trademark, and
+          attribution notices from the Source form of the Work,
+          excluding those notices that do not pertain to any part of
+          the Derivative Works; and
+
+      (d) If the Work includes a "NOTICE" text file as part of its
+          distribution, then any Derivative Works that You distribute must
+          include a readable copy of the attribution notices contained
+          within such NOTICE file, excluding any notices that do not
+          pertain to any part of the Derivative Works, in at least one
+          of the following places: within a NOTICE text file distributed
+          as part of the Derivative Works; within the Source form or
+          documentation, if provided along with the Derivative Works; or,
+          within a display generated by the Derivative Works, if and
+          wherever such third-party notices normally appear. The contents
+          of the NOTICE file are for informational purposes only and
+          do not modify the License. You may add Your own attribution
+          notices within Derivative Works that You distribute, alongside
+          or as an addendum to the NOTICE text from the Work, provided
+          that such additional attribution notices cannot be construed
+          as modifying the License.
+
+      You may add Your own copyright statement to Your modifications and
+      may provide additional or different license terms and conditions
+      for use, reproduction, or distribution of Your modifications, or
+      for any such Derivative Works as a whole, provided Your use,
+      reproduction, and distribution of the Work otherwise complies with
+      the conditions stated in this License.
+
+   5. Submission of Contributions. Unless You explicitly state otherwise,
+      any Contribution intentionally submitted for inclusion in the Work
+      by You to the Licensor shall be under the terms and conditions of
+      this License, without any additional terms or conditions.
+      Notwithstanding the above, nothing herein shall supersede or modify
+      the terms of any separate license agreement you may have executed
+      with Licensor regarding such Contributions.
+
+   6. Trademarks. This License does not grant permission to use the trade
+      names, trademarks, service marks, or product names of the Licensor,
+      except as required for reasonable and customary use in describing the
+      origin of the Work and reproducing the content of the NOTICE file.
+
+   7. Disclaimer of Warranty. Unless required by applicable law or
+      agreed to in writing, Licensor provides the Work (and each
+      Contributor provides its Contributions) on an "AS IS" BASIS,
+      WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+      implied, including, without limitation, any warranties or conditions
+      of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
+      PARTICULAR PURPOSE. You are solely responsible for determining the
+      appropriateness of using or redistributing the Work and assume any
+      risks associated with Your exercise of permissions under this License.
+
+   8. Limitation of Liability. In no event and under no legal theory,
+      whether in tort (including negligence), contract, or otherwise,
+      unless required by applicable law (such as deliberate and grossly
+      negligent acts) or agreed to in writing, shall any Contributor be
+      liable to You for damages, including any direct, indirect, special,
+      incidental, or consequential damages of any character arising as a
+      result of this License or out of the use or inability to use the
+      Work (including but not limited to damages for loss of goodwill,
+      work stoppage, computer failure or malfunction, or any and all
+      other commercial damages or losses), even if such Contributor
+      has been advised of the possibility of such damages.
+
+   9. Accepting Warranty or Additional Liability. While redistributing
+      the Work or Derivative Works thereof, You may choose to offer,
+      and charge a fee for, acceptance of support, warranty, indemnity,
+      or other liability obligations and/or rights consistent with this
+      License. However, in accepting such obligations, You may act only
+      on Your own behalf and on Your sole responsibility, not on behalf
+      of any other Contributor, and only if You agree to indemnify,
+      defend, and hold each Contributor harmless for any liability
+      incurred by, or claims asserted against, such Contributor by reason
+      of your accepting any such warranty or additional liability.
+
+   END OF TERMS AND CONDITIONS
+
+   Copyright 2025-2026 Matt Sutton / Memento AI (mmnto-ai)
+
+   Licensed under the Apache License, Version 2.0 (the "License");
+   you may not use this file except in compliance with the License.
+   You may obtain a copy of the License at
+
+       http://www.apache.org/licenses/LICENSE-2.0
+
+   Unless required by applicable law or agreed to in writing, software
+   distributed under the License is distributed on an "AS IS" BASIS,
+   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+   See the License for the specific language governing permissions and
+   limitations under the License.

package/README.md

@@ -0,0 +1,71 @@
+# @mmnto/pack-rust-architecture
+
+Baseline architectural lessons for Rust + Bevy ECS consumers. ADR-097 Stage 1 pilot under the `@mmnto` scope (sister to `@mmnto/pack-agent-security`).
+
+## Status
+
+ADR-097 Stage 1 alpha pilot. 8 lessons in 4 tiers, sourced from `mmnto-ai/liquid-city` PR #134's review cycle (6 lessons via `totem review-learn` extraction) plus 2 hand-authored seeds for Bucket B1 + B2 territory that didn't surface from automated extraction. Compilation to `compiled-rules.json` runs in the totem CLI workspace; the `lessons/` directory holds source-of-truth markdown for human review and re-compile.
+
+## Coverage
+
+The pack targets Rust + Bevy ECS consumers. Rules split across four tiers:
+
+| Tier                    | Count | Universality                 | Examples                                                                                                                                   |
+| ----------------------- | ----- | ---------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------ |
+| Numeric safety          | 3     | Any Rust + linalg/grid code  | Float-to-int overflow → DoS guards; `linvel.norm()` → `f32::INFINITY` finiteness checks; runtime+const-assert pairing for tuning constants |
+| Compile-time discipline | 1     | Any Rust                     | Float arithmetic methods (`.floor()`, `.ceil()`, `.sqrt()`, etc.) are non-const; rewrite as direct ops + cast                              |
+| Bevy ECS                | 3     | Bevy consumers               | `Local<Vec<T>>` hot-path allocation pattern; schedule edges as producer-consumer contracts; multi-archetype determinism fixtures           |
+| Testing discipline      | 1     | Any test-fixture parity work | Test world builders mirror production install order                                                                                        |
+
+Each lesson is self-contained markdown with citation anchors back to the genesis evidence (PR / round-number / file-path), enabling consumers to drill into the underlying CR/GCA review threads where the architectural invariant was originally surfaced.
+
+## Lesson manifest
+
+| Hash              | Tier                    | Title                                                               |
+| ----------------- | ----------------------- | ------------------------------------------------------------------- |
+| `lesson-2d305b47` | Numeric safety          | `linvel.norm()` overflow despite finite components                  |
+| `lesson-d020574f` | Numeric safety          | Float stride loop-bound overflow / DoS                              |
+| `lesson-c79543ba` | Numeric safety          | Tuning constants need declaration-site const-asserts                |
+| `lesson-de45dee2` | Compile-time discipline | Float arithmetic methods are unavailable in Rust const-eval         |
+| `lesson-8cefba95` | Bevy ECS                | Bevy hot-path: `Local<Vec<T>>` instead of per-tick collect          |
+| `lesson-b25f0c4a` | Bevy ECS                | Bevy schedule edges encode producer-consumer contracts              |
+| `lesson-691fbb72` | Bevy ECS                | Determinism test must use 2+ archetypes for sort to be load-bearing |
+| `lesson-9bc7ac4a` | Testing discipline      | Test world builders must install resources/map in production order  |
+
+## Coverage boundaries (honest framing)
+
+This pack is a baseline, not a comprehensive Rust + Bevy lint suite. The 8 lessons capture the highest-signal architectural invariants surfaced by one consumer's review cycles (slice-6 spawn dispersion + vehicle-agent collision in `mmnto-ai/liquid-city`). A Rust consumer with no Bevy footprint will find ~50% direct applicability (the 4 Rust-universal lessons); a Rust + Bevy consumer with determinism requirements will find ~100% applicability.
+
+## Install
+
+Add to `totem.config.ts`:
+
+```typescript
+extends: [
+  '@mmnto/pack-rust-architecture',
+],
+```
+
+Plus `pnpm add -D -w @mmnto/pack-rust-architecture` per ADR-085 Layer 1 adoption.
+
+## Substrate gap (v0.1)
+
+This pack is the first non-trivial consumer of the ADR-097 § 10 Pack v0.1 substrate, and as such it surfaces a known gap in the substrate that v0.1 papers over with a side-channel:
+
+`PackRegistrationAPI.registerLanguage(extension, lang, wasmLoader)` wires the **web-tree-sitter** side of the engine — `loadGrammar` (`ast-classifier.ts`), `ast-query.ts` (code-element extraction), `ast-gate.ts` (lite-build dispatch), and the lite-build wasm-shim. The runtime hot path for ast-grep rule matching, however, is `@ast-grep/napi`, which has its own `registerDynamicLanguage` API that the substrate does not surface. At `@ast-grep/napi@0.42.0` only `Lang.Html`, `Lang.JavaScript`, `Lang.Tsx`, `Lang.Css`, and `Lang.TypeScript` are built-in; non-built-in languages are unreachable from `parse(name, source)` until `registerDynamicLanguage` is called with the parser binding (e.g., from `@ast-grep/lang-rust`).
+
+**v0.1 workaround (this pack):** `register.cjs` invokes `napi.registerDynamicLanguage({ rust })` directly, alongside the substrate's `api.registerLanguage('.rs', 'rust', wasmLoader)` call. The pack imports `@ast-grep/lang-rust` (parser binding) and `@ast-grep/napi` (the engine's napi instance) directly. The dual registration ensures Rust ast-grep rules dispatch correctly through both paths.
+
+**Visible debt:** This side-channel is documented as time-boxed precedent in [`mmnto-ai/totem#1774`](https://github.com/mmnto-ai/totem/issues/1774), gated on N≥2 pack consumers before the API shape locks. Once a second non-trivial pack lands, `registerNapiLanguage` will be lifted into `PackRegistrationAPI` and this pack will migrate to the API-driven path. Future packs that copy the side-channel pattern should link back to that ticket so the visible-debt tally stays accurate.
+
+## Provenance
+
+- **Initial corpus:** PR `mmnto-ai/liquid-city#134` review cycle (R1-R11 across 12.4h, 11 review rounds, 39 inline comments).
+- **Extraction tooling:** `totem review-learn` (Sonnet 4.6 LLM, ~30s per cycle, ~10k tokens).
+- **Manual seeding:** Lessons `de45dee2` (B1) and `b25f0c4a` (B2) hand-authored for Rust const-eval limits and Bevy schedule-edge invariants that didn't surface from automated extraction. Cited evidence: PRs `mmnto-ai/liquid-city#132` R1 (B1) and `mmnto-ai/liquid-city#125` R6 + `mmnto-ai/liquid-city#134` task 5 (B2).
+- **Curation:** lc-Claude (LC lane) selected the 8-lesson active set per universality × architectural-invariant × enforceability scoring; dev-Gemini (synthesis lane) confirmed the selection.
+- **Audit trail:** `audits/internal/2026-04-30-ecosystem-churn-diagnosis.md` (totem-strategy disk) holds the cross-agent diagnostic thread that produced this pack.
+
+## License
+
+MIT. Same as the Totem monorepo.

package/compiled-rules.json

@@ -0,0 +1,20 @@
+{
+  "version": 1,
+  "rules": [
+    {
+      "lessonHash": "8cefba950774bcf0",
+      "lessonHeading": "Per-tick heap allocation in ECS system hot paths",
+      "pattern": "",
+      "message": "Per-tick `query.iter().collect()` in an ECS system body allocates a fresh Vec every frame, causing avoidable allocator pressure on the hot path. Use a `Local<Vec<T>>` system parameter with `.clear()` then `.extend(...)` at the top of the system, and iterate via `.iter().copied()`. This keeps the system allocation-free after the first tick while preserving identical semantics.",
+      "engine": "ast-grep",
+      "astGrepPattern": "$Q.iter().collect()",
+      "fileGlobs": ["**/*.rs"],
+      "badExample": "fn hot_system(query: Query<&Transform>) {\n    let v: Vec<_> = query.iter().collect();\n}",
+      "goodExample": "fn cold_system(query: Query<&Transform>, mut buf: Local<Vec<Transform>>) {\n    buf.clear();\n    buf.extend(query.iter().copied());\n}",
+      "severity": "warning",
+      "compiledAt": "2026-05-01T00:00:00.000Z",
+      "createdAt": "2026-05-01T00:00:00.000Z",
+      "unverified": true
+    }
+  ]
+}

package/package.json

@@ -0,0 +1,45 @@
+{
+  "name": "@mmnto/pack-rust-architecture",
+  "version": "1.23.0",
+  "private": false,
+  "description": "Baseline architectural lessons for Rust + Bevy ECS consumers. ADR-097 Stage 1 pilot. Numeric safety, compile-time discipline, ECS hot-path patterns, schedule edges, determinism fixtures, test-vs-production parity.",
+  "license": "MIT",
+  "main": "./register.cjs",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/mmnto-ai/totem.git",
+    "directory": "packages/pack-rust-architecture"
+  },
+  "homepage": "https://github.com/mmnto-ai/totem#readme",
+  "bugs": "https://github.com/mmnto-ai/totem/issues",
+  "files": [
+    "register.cjs",
+    "tree-sitter-rust.wasm",
+    "compiled-rules.json",
+    ".totemignore",
+    "README.md"
+  ],
+  "exports": {
+    ".": "./register.cjs",
+    "./compiled-rules.json": "./compiled-rules.json",
+    "./tree-sitter-rust.wasm": "./tree-sitter-rust.wasm",
+    "./.totemignore": "./.totemignore",
+    "./package.json": "./package.json"
+  },
+  "peerDependencies": {
+    "@ast-grep/napi": "^0.42.0"
+  },
+  "dependencies": {
+    "@ast-grep/lang-rust": "^0.0.7"
+  },
+  "devDependencies": {
+    "@ast-grep/napi": "^0.42.0",
+    "@vscode/tree-sitter-wasm": "^0.3.1",
+    "vitest": "^3.0.0",
+    "@mmnto/totem": "1.23.0"
+  },
+  "scripts": {
+    "build": "node scripts/copy-wasm.cjs",
+    "test": "vitest run"
+  }
+}

package/register.cjs

@@ -0,0 +1,45 @@
+// @mmnto/pack-rust-architecture — ADR-097 § 10 registration entry.
+//
+// Synchronous CJS callback per ADR-097 § 5 Q5. Wires Rust into both engine
+// language paths so ast-grep rules scoped to `.rs` files dispatch correctly:
+//
+//   1. Web-tree-sitter side via the official PackRegistrationAPI surface
+//      (`api.registerLanguage`). Powers `loadGrammar`, `ast-query.ts`,
+//      `ast-gate.ts`, and the lite-build wasm-shim path.
+//
+//   2. @ast-grep/napi side via direct `registerDynamicLanguage` invocation
+//      (the side-channel). Powers the engine's hot path for ast-grep rule
+//      matching (`matchAstGrepPattern`, `rule-engine.ts`). At
+//      @ast-grep/napi@0.42.0 only Html / JavaScript / Tsx / Css / TypeScript
+//      are built-in Lang variants, so non-built-in languages must be
+//      registered via the napi-specific API which the substrate does not
+//      yet expose.
+//
+// The dual registration is a v0.1 pattern — see "Substrate gap (v0.1)" in
+// the README and mmnto-ai/totem#1774 for the planned lift into
+// `PackRegistrationAPI.registerNapiLanguage` (gated on N≥2 pack consumers
+// before the API shape locks).
+
+'use strict';
+
+const path = require('node:path');
+
+/** @type {import('@mmnto/totem').PackRegisterCallback} */
+function register(api) {
+  // (1) Web-tree-sitter side via the substrate API (ADR-097 § 10).
+  api.registerLanguage('.rs', 'rust', () => path.join(__dirname, 'tree-sitter-rust.wasm'));
+
+  // (2) @ast-grep/napi side via the v0.1 side-channel. See mmnto-ai/totem#1774
+  //     for the planned lift into PackRegistrationAPI.registerNapiLanguage.
+  //
+  //     Idempotent: registerDynamicLanguage no-ops on a name that's already
+  //     registered, so re-running this callback (e.g., test fixtures, repeat
+  //     boots) is safe.
+  const rust = require('@ast-grep/lang-rust');
+  const { registerDynamicLanguage } = require('@ast-grep/napi');
+  registerDynamicLanguage({ rust });
+}
+
+module.exports = register;
+module.exports.register = register;
+module.exports.default = register;