@mmerterden/multi-agent-toolkit-mcp 3.1.0 → 3.1.1

package/CHANGELOG.md

@@ -15,6 +15,25 @@ Releases before this file exists are recorded in the git tags and commit history
 
 ---
 
+## 3.1.1
+
+### Fixed
+
+- `android_launch_time` reported `cold_start: true` on every call. It force-stops
+  the package first, which kills the process but leaves the page cache warm, so
+  the start it measures is cold only some of the time. Android 10 replaced
+  `ThisTime` with `LaunchState` (COLD, WARM, HOT, UNKNOWN), which is the
+  platform's own verdict on the start it just performed, and the tool was
+  ignoring it while asserting the answer itself. The result now carries
+  `launch_state` and derives `cold_start` from it. Below Android 10 nothing
+  reports a launch state, so `cold_start` is `null` there rather than a claim
+  nothing checked. A failed launch now surfaces its `Error:` line instead of
+  returning null timings that read like a measurement.
+- The parser moved to `tools/launch-time/` with a suite covering the Android 10+
+  and pre-10 output shapes, a warm start, a failed launch and non-string input.
+  It could not be tested where it was: `index.js` connects its transport at
+  import time, so nothing in it is reachable from a test.
+
 ## Unreleased
 
 ## 3.1.0

package/index.js

@@ -28,6 +28,7 @@ import {
   validateApp,
 } from "./tools/ios-testflight/index.js";
 import { DESIGN_TOOLS, handleDesign } from "./tools/design-check/index.js";
+import { parseLaunchOutput } from "./tools/launch-time/index.js";
 import { interactiveElements } from "./tools/ui-inspect/index.js";
 import { selectCrashReports } from "./tools/crash-logs/index.js";
 import {
@@ -829,7 +830,7 @@ const ANDROID_TOOLS = [
   { name: "android_open_url", description: "Open URL or deep link on Android", inputSchema: { type: "object", properties: { url: { type: "string" }, device_id: { type: "string" } }, required: ["url"] } },
   { name: "android_clear_app_data", description: "Clear all data for Android app", inputSchema: { type: "object", properties: { package_name: { type: "string" }, device_id: { type: "string" } }, required: ["package_name"] } },
   { name: "android_accessibility_audit", description: "Audit Android app accessibility: missing contentDescription, small touch targets (<48dp), missing resource-id. Use scope to filter by resource-id prefix.", inputSchema: { type: "object", properties: { device_id: { type: "string" }, scope: { type: "string", description: "Filter: only audit elements whose resource-id contains this prefix (e.g. 'login_', 'com.example:id/login_'). Omit to audit all." } } } },
-  { name: "android_launch_time", description: "Measure Android app cold launch time (TotalTime in ms)", inputSchema: { type: "object", properties: { package_name: { type: "string" }, activity: { type: "string" }, device_id: { type: "string" } }, required: ["package_name"] } },
+  { name: "android_launch_time", description: "Measure Android app launch time: force-stops the package, starts it with am start -W, and reports TotalTime/WaitTime in ms plus the platform's own LaunchState (COLD/WARM/HOT). Below Android 10 there is no LaunchState and cold_start is null rather than assumed.", inputSchema: { type: "object", properties: { package_name: { type: "string" }, activity: { type: "string" }, device_id: { type: "string" } }, required: ["package_name"] } },
   { name: "android_apk_audit", description: "Audit APK/AAB for Play Store compliance: debug flag, target SDK, permissions, signing, ProGuard", inputSchema: { type: "object", properties: { apk_path: { type: "string", description: "Path to .apk file" } }, required: ["apk_path"] } },
   { name: "android_list_crashes", description: "Dump the Android crash log buffer (`adb logcat -b crash -d`), tail-bounded. Empty output means no crashes since the buffer was last cleared.", inputSchema: { type: "object", properties: { lines: { type: "number", description: "Max lines returned, from the end (default 200)" }, device_id: { type: "string" } } } },
   { name: "android_set_orientation", description: "Rotate the Android screen to portrait or landscape. Disables accelerometer rotation and pins user_rotation, so the device stays put until rotation is re-enabled. Accounts for the device's natural orientation (detected via wm size), so landscape-natural tablets rotate correctly too. No iOS counterpart: simctl exposes no rotation lever.", inputSchema: { type: "object", properties: { orientation: { type: "string", enum: ["portrait", "landscape"] }, device_id: { type: "string" } }, required: ["orientation"] } },
@@ -1020,9 +1021,19 @@ async function handleAndroid(name, args, ctx = {}) {
       run(`adb ${df} shell am force-stop ${sanitizeId(args.package_name)}`);
       const activity = sanitizeId(args.activity || `${args.package_name}/.MainActivity`);
       const result = run(`adb ${df} shell am start -W -n ${activity} 2>&1`);
-      const totalTime = result.match(/TotalTime:\s*(\d+)/)?.[1];
-      const waitTime = result.match(/WaitTime:\s*(\d+)/)?.[1];
-      return JSON.stringify({ package: args.package_name, cold_start: true, total_time_ms: totalTime ? parseInt(totalTime) : null, wait_time_ms: waitTime ? parseInt(waitTime) : null, raw: result }, null, 2);
+      const parsed = parseLaunchOutput(result);
+      return JSON.stringify({
+        package: args.package_name,
+        // The platform's own verdict, not ours: force-stop kills the process but
+        // leaves the page cache warm, so this is a cold start only sometimes.
+        // null means the device is below Android 10 and never reported one.
+        launch_state: parsed.launchState,
+        cold_start: parsed.coldStart,
+        total_time_ms: parsed.totalTimeMs,
+        wait_time_ms: parsed.waitTimeMs,
+        error: parsed.error,
+        raw: result,
+      }, null, 2);
     }
     case "android_apk_audit": {
       const p = args.apk_path;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mmerterden/multi-agent-toolkit-mcp",
-  "version": "3.1.0",
+  "version": "3.1.1",
   "description": "MCP server for iOS Simulator, Android Emulator and headless web control. 84 tools: device automation (tap/swipe/type), accessibility audits, visual diff, crash logs, App Store / Play Store pre-submission compliance. Runs standalone over stdio with any MCP client.",
   "type": "module",
   "main": "index.js",
@@ -10,7 +10,7 @@
   },
   "scripts": {
     "start": "node index.js",
-    "test": "node --test tools/design-check/__tests__/design-check.test.mjs tools/design-check/__tests__/plan-determinism.test.mjs tools/ios-app-store-audit/__tests__/app-store-audit.test.mjs tools/ios-testflight/__tests__/testflight.test.mjs tools/ui-inspect/__tests__/ui-inspect.test.mjs tools/crash-logs/__tests__/crash-logs.test.mjs tools/offload/__tests__/offload.test.mjs __tests__/server-tools.test.mjs __tests__/injection.test.mjs",
+    "test": "node --test tools/design-check/__tests__/design-check.test.mjs tools/design-check/__tests__/plan-determinism.test.mjs tools/ios-app-store-audit/__tests__/app-store-audit.test.mjs tools/ios-testflight/__tests__/testflight.test.mjs tools/ui-inspect/__tests__/ui-inspect.test.mjs tools/crash-logs/__tests__/crash-logs.test.mjs tools/launch-time/__tests__/launch-time.test.mjs tools/offload/__tests__/offload.test.mjs __tests__/server-tools.test.mjs __tests__/injection.test.mjs",
     "gates": "bash scripts/gates.sh"
   },
   "keywords": [

package/tools/launch-time/index.js

@@ -0,0 +1,53 @@
+/**
+ * launch-time - parse `am start -W` output.
+ *
+ * Lives here rather than inline in index.js because index.js connects its
+ * transport at import time and cannot be loaded by a test.
+ *
+ * The handler force-stops the package first, which kills the process but leaves
+ * the page cache warm, so it produces a cold start only some of the time. The
+ * tool used to report `cold_start: true` unconditionally, which is an assertion
+ * about something the platform already measures: Android 10 replaced `ThisTime`
+ * with `LaunchState`, one of COLD, WARM, HOT or UNKNOWN, and that is the
+ * system's own verdict on the start it just performed. Below Android 10 there is
+ * no LaunchState line, and the honest answer there is "unknown" rather than a
+ * claim nothing checked.
+ */
+
+const LAUNCH_STATES = new Set(["COLD", "WARM", "HOT", "UNKNOWN"]);
+
+/**
+ * @param {string} raw - stdout+stderr of `am start -W -n <activity>`
+ * @returns {{status: string|null, launchState: string|null, coldStart: boolean|null,
+ *            activity: string|null, totalTimeMs: number|null, waitTimeMs: number|null,
+ *            error: string|null}}
+ */
+export function parseLaunchOutput(raw) {
+  const text = typeof raw === "string" ? raw : "";
+  const field = (name) => text.match(new RegExp(`^\\s*${name}:\\s*(.+?)\\s*$`, "m"))?.[1] ?? null;
+  const intField = (name) => {
+    const v = text.match(new RegExp(`^\\s*${name}:\\s*(\\d+)\\s*$`, "m"))?.[1];
+    return v === undefined ? null : parseInt(v, 10);
+  };
+
+  const rawState = field("LaunchState");
+  const launchState = rawState && LAUNCH_STATES.has(rawState.toUpperCase())
+    ? rawState.toUpperCase()
+    : null;
+
+  // `am start` reports a failure on a line of its own and still exits 0, so a
+  // missing TotalTime with an Error line is a failed launch, not a parse miss.
+  const errorLine = text.match(/^\s*Error:\s*(.+?)\s*$/m)?.[1] ?? null;
+
+  return {
+    status: field("Status"),
+    launchState,
+    // COLD is the only state that is a cold start. Below Android 10 nothing
+    // reports it, so null means "not measured", never "no".
+    coldStart: launchState === null ? null : launchState === "COLD",
+    activity: field("Activity"),
+    totalTimeMs: intField("TotalTime"),
+    waitTimeMs: intField("WaitTime"),
+    error: errorLine,
+  };
+}