@mmerterden/multi-agent-pipeline 20.28.0 → 20.30.0

package/pipeline/scripts/autopilot-runner.mjs

@@ -82,6 +82,7 @@ import { runMain } from "../lib/fatal.mjs";
 import { LIVE_STATUSES, resolveClaudeBin } from "../lib/claude-sessions.mjs";
 import { invokedDirectly } from "../lib/invoked-directly.mjs";
 import { readRegularJson } from "../lib/regular-file.mjs";
+import { completionGaps } from "../lib/run-completion.mjs";
 import { messages, outputLanguage } from "../lib/user-facing.mjs";
 import {
   ARTIFACTS_SUBDIR,
@@ -1152,7 +1153,10 @@ export function prFromState(state) {
  *
  * "finished with no PR" is deliberately not "failed": a run can stop
  * legitimately without opening one, and calling that a failure would put a
- * healthy item into the retry path.
+ * healthy item into the retry path. It is only that when the state earns it
+ * (lib/run-completion.mjs): a `complete` written below the mode's last phase,
+ * without Phase 4 evidence or without a plan-coverage verdict is
+ * `stopped-incomplete`, which is retried, not filed as finished.
  */
 export function outcomeFor(supervised, state, prUrl) {
   if (prUrl) return OUTCOME.PR_OPENED;
@@ -1166,7 +1170,9 @@ export function outcomeFor(supervised, state, prUrl) {
   if (rateLimited({ row: supervised.lastRow, state })) return OUTCOME.RATE_LIMITED;
   if (state && state.verificationFailed) return OUTCOME.VERIFICATION_FAILED;
   const status = state && state.status;
-  if (status === "complete" || status === "completed") return OUTCOME.COMPLETED_NO_PR;
+  if (status === "complete" || status === "completed") {
+    return completionGaps(state).length ? OUTCOME.STOPPED_INCOMPLETE : OUTCOME.COMPLETED_NO_PR;
+  }
   if (status === "failed") return OUTCOME.FAILED;
   return state ? `stopped-${status || "unknown"}` : OUTCOME.NO_STATE;
 }

package/pipeline/scripts/confirm-command.mjs

@@ -0,0 +1,70 @@
+#!/usr/bin/env node
+/**
+ * confirm-command.mjs  -  carry the user's yes for one command to agent-guard.
+ *
+ * agent-guard asks before a write a person must confirm (closing an issue, a
+ * PR body that closes one, a Jira transition POST). In bypassPermissions and
+ * dontAsk no permission prompt is raised, so the guard denies and says to ask
+ * the user with AskUserQuestion. On a yes, this records it: a file named by the
+ * sha256 of the exact command under <log root>/confirmations/. The next time
+ * agent-guard sees that exact command it consumes the record and lets it run;
+ * a record older than ten minutes, or for any other command, does nothing.
+ *
+ * Attended only. Under MULTI_AGENT_UNATTENDED=1 nobody gave an answer, so the
+ * script refuses (exit 2) and agent-guard never reads a record there.
+ *
+ * Usage:  confirm-command.mjs --command '<the exact command>'
+ * Exit:   0 recorded, 2 usage or unattended, 3 could not write
+ *
+ * @module pipeline/scripts/confirm-command
+ */
+
+import { createHash } from "node:crypto";
+import { mkdirSync, writeFileSync } from "node:fs";
+import { homedir } from "node:os";
+import { join } from "node:path";
+
+import { runMain } from "../lib/fatal.mjs";
+import { invokedDirectly } from "../lib/invoked-directly.mjs";
+import { isUnattended } from "../lib/unattended.mjs";
+
+/** Where records live; agent-guard's _guard_rules.confirmations_dir agrees. */
+export function confirmationsDir(env = process.env) {
+  const root = env.LOGS_ROOT || join(homedir(), ".claude", "logs", "multi-agent");
+  return join(root, "confirmations");
+}
+
+/** The record path for one command. */
+export function recordPath(command, env = process.env) {
+  const digest = createHash("sha256").update(command, "utf8").digest("hex");
+  return join(confirmationsDir(env), `${digest}.json`);
+}
+
+function main() {
+  const argv = process.argv.slice(2);
+  const i = argv.indexOf("--command");
+  const command = i === -1 ? undefined : argv[i + 1];
+  if (typeof command !== "string" || !command) {
+    process.stderr.write("usage: confirm-command.mjs --command '<the exact command>'\n");
+    process.exitCode = 2;
+    return;
+  }
+  if (isUnattended()) {
+    process.stderr.write("confirm-command: refused, nobody can confirm in an unattended run\n");
+    process.exitCode = 2;
+    return;
+  }
+  try {
+    mkdirSync(confirmationsDir(), { recursive: true, mode: 0o700 });
+    writeFileSync(recordPath(command), `${JSON.stringify({ at: new Date().toISOString() })}\n`, {
+      mode: 0o600,
+    });
+  } catch (err) {
+    process.stderr.write(`confirm-command: ${err.message}\n`);
+    process.exitCode = 3;
+    return;
+  }
+  process.stdout.write("confirm-command: recorded for 10 minutes, one use\n");
+}
+
+if (invokedDirectly(import.meta.url)) runMain("confirm-command", main, { code: 3 });