@mmerterden/multi-agent-pipeline 20.17.2 → 20.18.0

package/CHANGELOG.md

@@ -16,6 +16,19 @@ Internal file-layout changes that don't affect the slash-command surface are sti
 
 ## [Unreleased]
 
+## [20.18.0] - 2026-10-09
+
+### Added
+
+- Apple's Xcode-provided skills are linked from the machine's own Xcode 27.1 or later (`xcrun agent plugin path`), never shipped in this package. The installer keeps a local directory marketplace (`~/.claude/xcode-apple-marketplace`, plugin `xcode-integration@xcode-apple`) at the installed Xcode build for Claude Code, and copies the same skills beside the stack plugin skills for Copilot CLI and as refs for Codex CLI when the iOS toolkit is delivered, with a manifest for refresh and uninstall. No Xcode, an older one or a failing `xcrun` links nothing and fails nothing. `MULTI_AGENT_SKIP_XCODE_SKILLS=1` (and the existing `MULTI_AGENT_SKIP_MCP_REGISTER=1`) skip the link for hermetic installs.
+- `/multi-agent:stack` turns `xcode-integration@xcode-apple` on with `ios` and off without it, once the link exists.
+- doctor check `xcode-skills`: SKIP without the Xcode plugin, INFO when available but not linked, WARN when the link is older than the installed Xcode build.
+- `ios-iphone-duo` routes the code scan to Apple's `app-resizability` first, and covers the scene-based life cycle (required from iOS 27 for apps built with the latest SDK), legacy layout guides, `keyboardLayoutGuide` and stored insets for machines without it.
+
+### Changed
+
+- Uninstall removes the Claude Code link (plugin, marketplace and directory) and the delivered copies, since nothing refreshes them without the pipeline.
+
 ## [20.17.2] - 2026-10-08
 
 ### Added

package/docs/facts.json

@@ -1,7 +1,7 @@
 {
   "$comment": "Generated by pipeline/scripts/gen-facts.mjs. Do not hand-edit: the site reads this, and a number edited here instead of at its source is the drift this file removes.",
-  "generatedAt": "2026-10-08",
-  "version": "20.17.2",
+  "generatedAt": "2026-10-09",
+  "version": "20.18.0",
   "phaseSchema": 2,
   "phases": [
     {

package/install/_mcp-register.mjs

@@ -119,7 +119,7 @@ function hostConfig(host) {
  * @param {"claude"|"codex"|"copilot"} host
  * @returns {string}
  */
-function resolveCli(host) {
+export function resolveCli(host) {
   const { candidates } = hostConfig(host);
   for (const c of candidates) {
     if (c.includes("/") && existsSync(c)) return c;

package/install/_xcode-skills.mjs

@@ -0,0 +1,263 @@
+/**
+ * Apple's Xcode-provided skills, linked from the machine's own Xcode.
+ *
+ * Xcode 27.1 and later materialize an agent plugin (`xcode-integration`: Apple's
+ * skills for app resizability and iPhone Duo, SwiftUI, App Intents, accessibility
+ * audits, String Catalog translation, test modernization and more, plus Xcode's
+ * MCP bridge) and print its path with `xcrun agent plugin path`. These skills are
+ * the reference for the topics they cover, so iOS work routes to them first.
+ *
+ * Nothing of Apple's is shipped here. Each host gets the content its own Xcode
+ * produced, refreshed whenever the Xcode build changes:
+ *
+ * - **Claude Code** loads it as a plugin from a local directory marketplace
+ *   (`xcode-apple`). A directory marketplace is read in place, so a refresh is a
+ *   re-copy into that directory; the next session sees it.
+ * - **Copilot CLI** has no plugin loader, so the skills are copied into its flat
+ *   skills directory, the same delivery the stack plugins get.
+ * - **Codex CLI** takes Xcode's Codex-format skills as reference files beside the
+ *   stack plugin skills: it lists plugin skills without their descriptions and
+ *   truncates its skills block once it overflows.
+ *
+ * No developer tools, an Xcode older than 27.1, a failing `xcrun` or a failed
+ * copy means nothing is linked and the pipeline's own skills cover the topics.
+ * The install never fails over it: every outcome is returned, never thrown.
+ *
+ * @module install/_xcode-skills
+ */
+
+import { existsSync, readdirSync, readFileSync, writeFileSync } from "fs";
+import { join } from "path";
+
+import { copyDir, ensureDir, isDryRun, wipeDir } from "./_common.mjs";
+import { resolveCli } from "./_mcp-register.mjs";
+import {
+  BUILD_STAMP,
+  CLAUDE_MARKETPLACE_DIR,
+  XCODE_MARKETPLACE,
+  XCODE_PLUGIN,
+  XCODE_PLUGIN_ID,
+  XCODE_SKILLS_MANIFEST,
+  claudeLinkedBuild,
+  defaultRun,
+  resolveXcodePlugin,
+  xcodeSkillsStatus,
+} from "../pipeline/lib/xcode-plugin.mjs";
+
+export {
+  CLAUDE_MARKETPLACE_DIR,
+  XCODE_MARKETPLACE,
+  XCODE_PLUGIN,
+  XCODE_PLUGIN_ID,
+  XCODE_SKILLS_MANIFEST,
+  resolveXcodePlugin,
+  xcodeSkillsStatus,
+};
+
+/**
+ * Hermetic installs skip the link: it shells out to `xcrun` and to the host CLI,
+ * so the result would depend on the machine. The layout smokes already set the
+ * MCP opt-out, and Apple's plugin carries an MCP server of its own.
+ */
+export function xcodeLinkDisabled(env = process.env) {
+  return env.MULTI_AGENT_SKIP_XCODE_SKILLS === "1" || env.MULTI_AGENT_SKIP_MCP_REGISTER === "1";
+}
+
+const firstLine = (e) =>
+  (
+    `${e?.stderr ?? ""}${e?.stdout ?? ""}${e?.message ?? ""}`.split("\n").find((l) => l.trim()) ||
+    "unknown error"
+  ).trim();
+
+function marketplaceJson(build) {
+  return {
+    name: XCODE_MARKETPLACE,
+    owner: { name: "Xcode on this Mac" },
+    metadata: {
+      description: `Apple's Xcode-provided skills, copied from this Mac's Xcode (build ${build}).`,
+    },
+    plugins: [
+      {
+        name: XCODE_PLUGIN,
+        source: `./${XCODE_PLUGIN}`,
+        description: "Apple's skills and Xcode MCP bridge, as Xcode ships them.",
+      },
+    ],
+  };
+}
+
+/**
+ * Bring Claude Code's `xcode-apple` marketplace to the installed Xcode build and
+ * make sure the plugin is installed at user scope.
+ *
+ * User scope enables it in every repo, as the stack plugins are when installed
+ * that way; `/multi-agent:stack` turns it off for a repo whose stack is not iOS.
+ *
+ * Idempotent: the copy is skipped when the stamp names this build, and both CLI
+ * calls succeed on an existing marketplace or install. The stamp is written only
+ * after both succeed, so a failed link never reads as current.
+ *
+ * @param {string} home
+ * @param {{run?: (cmd: string, args: string[]) => string, cli?: string, env?: object}} [opts]
+ * @returns {{status: "linked"|"refreshed"|"current"|"unavailable"|"skipped"|"failed", build?: string, skills?: number, reason?: string}}
+ */
+export function linkClaudeXcodePlugin(home, { run = defaultRun, cli, env = process.env } = {}) {
+  if (xcodeLinkDisabled(env)) return { status: "skipped", reason: "opted out" };
+  const plugin = resolveXcodePlugin("claude", { run, env });
+  if (!plugin) return { status: "unavailable", reason: "no Xcode agent plugin on this Mac" };
+
+  const mpDir = join(home, CLAUDE_MARKETPLACE_DIR);
+  const target = join(mpDir, XCODE_PLUGIN);
+  const previous = claudeLinkedBuild(home);
+  const fresh = previous === plugin.build && existsSync(join(target, ".claude-plugin"));
+
+  if (isDryRun()) {
+    console.log(`    [dry-run] would link ${XCODE_PLUGIN_ID} from Xcode ${plugin.build}`);
+    return { status: "skipped", reason: "dry-run", build: plugin.build };
+  }
+
+  try {
+    if (!fresh) {
+      wipeDir(join(mpDir, BUILD_STAMP));
+      ensureDir(join(mpDir, ".claude-plugin"));
+      wipeDir(target);
+      copyDir(plugin.path, target);
+      writeFileSync(
+        join(mpDir, ".claude-plugin", "marketplace.json"),
+        JSON.stringify(marketplaceJson(plugin.build), null, 2) + "\n",
+      );
+    }
+  } catch (e) {
+    return { status: "failed", reason: `copy failed: ${firstLine(e)}`, build: plugin.build };
+  }
+
+  const claude = cli || resolveCli("claude");
+  try {
+    run(claude, ["plugin", "marketplace", "add", mpDir]);
+    run(claude, ["plugin", "install", XCODE_PLUGIN_ID, "--scope", "user"]);
+  } catch (e) {
+    const reason = e?.code === "ENOENT" ? "claude not on PATH" : firstLine(e);
+    return { status: "failed", reason, build: plugin.build };
+  }
+
+  try {
+    if (!fresh) writeFileSync(join(mpDir, BUILD_STAMP), plugin.build + "\n");
+  } catch (e) {
+    return { status: "failed", reason: `stamp not written: ${firstLine(e)}`, build: plugin.build };
+  }
+
+  const status = fresh ? "current" : previous ? "refreshed" : "linked";
+  return { status, build: plugin.build, skills: plugin.skills.length };
+}
+
+function readManifest(dest) {
+  try {
+    const names = JSON.parse(readFileSync(join(dest, XCODE_SKILLS_MANIFEST), "utf8"));
+    return Array.isArray(names) ? names : [];
+  } catch {
+    return [];
+  }
+}
+
+function existingDirs(dest) {
+  try {
+    return readdirSync(dest, { withFileTypes: true })
+      .filter((e) => e.isDirectory())
+      .map((e) => e.name);
+  } catch {
+    return [];
+  }
+}
+
+/**
+ * Copy Apple's skills into a flat skills directory (Copilot) or refs directory
+ * (Codex), one directory per skill, replacing what an earlier pass delivered.
+ *
+ * A name already present in `dest` that an earlier pass did not deliver - a
+ * pipeline skill, a stack plugin skill, or one the user wrote - is never
+ * overwritten: Apple's skill goes in as `xcode-<name>` instead, and is left out
+ * if that name is taken too.
+ *
+ * @param {object} opts
+ * @param {string} opts.dest
+ * @param {string} opts.label - host label for log lines
+ * @param {"claude"|"codex"} [opts.format] - which of Xcode's plugin formats to copy
+ * @param {Set<string>} [opts.taken] - names this install delivers into `dest`
+ * @param {boolean} [opts.enabled] - false removes an earlier delivery (the repo is not iOS)
+ * @param {(from: string, to: string) => void} [opts.copy]
+ * @param {(cmd: string, args: string[]) => string} [opts.run]
+ * @param {object} [opts.env]
+ * @returns {{status: "delivered"|"unavailable"|"skipped"|"failed", build?: string, delivered: string[], reason?: string}}
+ */
+export function deliverXcodeSkills(opts) {
+  const {
+    dest,
+    label,
+    format = "claude",
+    taken: takenByInstall = new Set(),
+    enabled = true,
+    copy = (from, to) => copyDir(from, to),
+    run = defaultRun,
+    env = process.env,
+  } = opts;
+  const previous = readManifest(dest);
+  const ours = new Set(previous);
+  const taken = new Set([
+    ...takenByInstall,
+    ...existingDirs(dest).filter((name) => !ours.has(name)),
+  ]);
+
+  try {
+    const clear = () => {
+      for (const name of previous) if (!taken.has(name)) wipeDir(join(dest, name));
+      if (!isDryRun() && previous.length) writeFileSync(join(dest, XCODE_SKILLS_MANIFEST), "[]\n");
+    };
+
+    if (!enabled) {
+      clear();
+      return { status: "skipped", delivered: [] };
+    }
+    if (xcodeLinkDisabled(env)) return { status: "skipped", delivered: [] };
+    const plugin = resolveXcodePlugin(format, { run, env });
+    if (!plugin) {
+      clear();
+      console.log(`    -> ${label}: no Xcode agent plugin on this Mac; Apple's skills not linked`);
+      return { status: "unavailable", delivered: [] };
+    }
+
+    for (const name of previous) if (!taken.has(name)) wipeDir(join(dest, name));
+    const delivered = [];
+    let skipped = 0;
+    for (const name of plugin.skills) {
+      const deliveredName = !taken.has(name)
+        ? name
+        : !taken.has(`xcode-${name}`)
+          ? `xcode-${name}`
+          : null;
+      if (!deliveredName) {
+        skipped++;
+        continue;
+      }
+      const to = join(dest, deliveredName);
+      ensureDir(dest);
+      wipeDir(to);
+      if (!isDryRun()) copy(join(plugin.path, "skills", name), to);
+      delivered.push(deliveredName);
+    }
+    if (isDryRun()) {
+      console.log(
+        `    [dry-run] would link ${delivered.length} Apple skill(s) from Xcode ${plugin.build} into ${dest}`,
+      );
+      return { status: "skipped", build: plugin.build, delivered };
+    }
+    writeFileSync(join(dest, XCODE_SKILLS_MANIFEST), JSON.stringify(delivered, null, 2) + "\n");
+    console.log(
+      `    -> ${label}: ${delivered.length} Apple skill(s) linked from Xcode ${plugin.build}` +
+        (skipped ? ` (${skipped} left out: both names taken)` : ""),
+    );
+    return { status: "delivered", build: plugin.build, delivered };
+  } catch (e) {
+    console.log(`    -> ${label}: Apple's skills not linked: ${firstLine(e)}`);
+    return { status: "failed", delivered: [], reason: firstLine(e) };
+  }
+}