@mmerterden/multi-agent-pipeline 20.16.0 → 20.17.1

package/pipeline/skills/shared/core/valven-rules/SKILL.md

@@ -1,62 +0,0 @@
----
-name: valven-rules
-description: "Delivery-flow rules from the metrics Valven reports: PR size, one concern per PR, tests with source, issue keys, no WIP commits, rework, PR body, small hotfixes. Use when developing, committing or reviewing a change held to these rules, or splitting a branch into stacked PRs."
-user-invocable: false
-metadata:
-  language: en
-  standards-registry: references/rules.yml
----
-
-# valven-rules
-
-The registry is `references/rules.yml`. It holds two blocks:
-
-| Block | Who checks it | Read by |
-|---|---|---|
-| `gate_rules` | `scripts/valven-gate.mjs`, from the diff, the commit subjects, the branch name and the PR body | the gate only |
-| `rules` | the reviewers, as judgement | `skill-conformance.mjs`, which puts them in `${CRITERIA}` |
-
-Measured rules stay out of `rules` on purpose: a reviewer asked for a verdict on a line count
-either recounts it or guesses, and both are worse than the number the script already has.
-
-## Where it runs
-
-| Point | Command | A violation |
-|---|---|---|
-| Phase 1 Step 6 | plan estimates lines per task against `VLV-SIZE-01` | the plan proposes stacked slices before any code exists |
-| Phase 2 exit, Gate 6 | `valven-gate.mjs --mode dev` | blocks the handoff to Review; size findings set `state.valven.splitRequired` |
-| Phase 4, before push | `valven-gate.mjs --mode commit`, then `valven-split.mjs` when a split is required | the branch ships as stacked pull requests, one per slice |
-| Phase 3 Step 3.0 and `/multi-agent:review` | `valven-gate.mjs --mode review` | findings merge into triage with `tag: valven`; an accepted one sets NEEDS WORK |
-
-## Build on one branch, ship as small pull requests
-
-Work happens on one branch. When the gate reports `VLV-SIZE-01`, `VLV-SIZE-02` or
-`VLV-SCOPE-01`, `valven-split.mjs` plans slices of at most the size budget:
-
-1. Pure renames and moves go first, as their own slice.
-2. Each test file travels with the source file it pairs with.
-3. Slices follow layer order: models and services, then view models and use cases, then views,
-   then everything else.
-4. A single file larger than the budget becomes its own slice and is reported, never cut.
-
-`--apply` materialises the plan as stacked branches `<branch>-p1` .. `<branch>-pN`: `-p1` from the
-base, each next one from the previous. The top of the stack has the same tree as the original
-branch, which the script verifies before it reports success. Each slice is built before its
-pull request opens; a slice that does not build is merged into its neighbour and the plan is
-re-run.
-
-## Old work moves, it is not rebased
-
-`VLV-AGE-01`, `VLV-BEHIND-01` and `VLV-TRACE-03` mean the branch carries old or foreign work.
-`valven-port.mjs --apply` cuts `<branch>-v2` from the current base tip and applies the net change
-with `git apply --3way` as one commit; a conflict rolls back and names the paths. Port first, then
-split. Contract: `multi-agent-refs/features/valven.md`, "Old work".
-
-## Thresholds
-
-Defaults live in `gate_rules`. `prefs.global.valven.thresholds` overrides them per rule ID, for
-example `{"VLV-SIZE-01": {"important_over": 300}}`. `prefs.global.valven.enabled: false` turns the
-gate off; the run then logs `valven: disabled by prefs` so a skipped check never reads as a pass.
-
-A rule the gate cannot measure (no checkout for the rework blame, no PR body in branch mode) is
-reported as `not-measured` with the reason.