@mmerterden/multi-agent-pipeline 19.0.0 → 19.1.1

package/pipeline/scripts/validate-analysis-doc.mjs

@@ -27,7 +27,7 @@
 //   - Manual scenarios (Section 15.7): every MT- row carries a BR- id.
 //   - Variant coverage (Section 6.X): every axis row states the full axis and
 //     the subset this screen uses; half a row cannot be audited.
-//   - Traceability (Full mode only, Locked 31): every BR-<slug>-NN id defined in
+//   - Traceability (Full mode only, Locked 30): every BR-<slug>-NN id defined in
 //     the Business Rules area is referenced again later (test / acceptance /
 //     analytics). A define-only rule is a WARN (heuristic).
 //   - No whole-section "TBD" / "Not applicable" placeholder bodies (Locked 2);
@@ -43,7 +43,7 @@
 import { readFileSync } from "node:fs";
 import { runMain } from "../lib/fatal.mjs";
 
-// A repo-less run (Locked 35) still splits by channel, derived from the evidence:
+// A repo-less run (Locked 34) still splits by channel, derived from the evidence:
 // "mobile" and "web" are its platform values. "none" is the narrower case where the
 // evidence describes no interface at all. All three are real values, not missing ones.
 // "web" is the pre-"web" spelling, still accepted so older documents validate.
@@ -63,7 +63,7 @@ const REQUIRED_SECTIONS = [
   { key: "references", any: ["References", "Referanslar"] },
 ];
 
-// Corporate profile backbone (Locked 33). These render even with zero evidence,
+// Corporate profile backbone (Locked 32). These render even with zero evidence,
 // carrying N/A or EKLENECEK, so their absence is a structural failure rather
 // than a legitimate omission.
 const CORPORATE_SECTIONS = [
@@ -290,7 +290,7 @@ function main() {
     // The development layer is legitimately absent when no repo was selected,
     // so requiring it there would fail every stack-optional document.
     .filter((sec) => !(noPlatform && REPO_DEPENDENT_KEYS.has(sec.key)));
-  const rule = profile === "corporate" ? "Locked 33" : "Locked 2";
+  const rule = profile === "corporate" ? "Locked 32" : "Locked 2";
   for (const sec of requiredSections) {
     if (!sec.any.some((kw) => headingBlob.includes(kw))) {
       errors.push(`missing required section (${rule}): ${sec.key}`);
@@ -316,7 +316,7 @@ function main() {
   //
   // It ran only in the corporate profile until now, which made the global one the
   // profile where an inline marker could point at nothing. Two documents already
-  // told it to: Locked 36 says an unstamped gap fails the dispatch gate with no
+  // told it to: Locked 35 says an unstamped gap fails the dispatch gate with no
   // profile clause, and analysis/render.md routes an external-dependency gap to
   // `AS-NN` in Section 20 for every run. The check was the only side that
   // disagreed. Nothing changes for a document that carries no markers: every loop
@@ -341,13 +341,13 @@ function main() {
       // A gap that names no id cannot be traced to an owner, which is the whole
       // point of admitting it.
       if (!/\bAS-\d{2,3}\b/.test(lines[i])) {
-        errors.push(`line ${i + 1}: EKLENECEK carries no AS-NN reference (Locked 33)`);
+        errors.push(`line ${i + 1}: EKLENECEK carries no AS-NN reference (Locked 32)`);
       }
     }
     for (const id of referencedIds) {
       if (!definedIds.has(id)) {
         errors.push(
-          `${id} is referenced in the body but not defined in Risks and Open Questions (Locked 33)`,
+          `${id} is referenced in the body but not defined in Risks and Open Questions (Locked 32)`,
         );
       }
     }
@@ -358,7 +358,7 @@ function main() {
         const row = risksBlock.split("\n").find((l) => l.includes(id)) || "";
         if (!/(no body reference|govde referansi yok)/i.test(row)) {
           errors.push(
-            `${id} is defined in Risks and Open Questions but never referenced in the body (Locked 33)`,
+            `${id} is defined in Risks and Open Questions but never referenced in the body (Locked 32)`,
           );
         }
       }
@@ -394,7 +394,7 @@ function main() {
         const owner = cells[oi] || "";
         if (!owner || /^(-|\?|TBD|EKLENECEK|N\/A)$/i.test(owner)) {
           const id = (row.match(/\bAS-\d{2,3}\b/) || ["a row"])[0];
-          errors.push(`${id} names no owner in Risks and Open Questions (Locked 36)`);
+          errors.push(`${id} names no owner in Risks and Open Questions (Locked 35)`);
         }
       }
     } else if (rows.some((l) => /\bAS-\d{2,3}\b/.test(l))) {
@@ -439,7 +439,7 @@ function main() {
         }
       }
       for (const id of [...openMarkers].sort()) {
-        errors.push(`status: final but ${id} is still open (Locked 36 closure gate)`);
+        errors.push(`status: final but ${id} is still open (Locked 35 closure gate)`);
       }
       const stillOpen =
         risksStatusIdx >= 0
@@ -489,7 +489,7 @@ function main() {
     if (mode === "full") {
       const matrixStart = lines.findIndex((l) => /^#{2,4}\s/.test(l) && MATRIX_HEADING.test(l));
       if (matrixStart === -1) {
-        errors.push("corporate Full mode requires the requirement traceability matrix (Locked 33)");
+        errors.push("corporate Full mode requires the requirement traceability matrix (Locked 32)");
       } else {
         let matrixBlock = "";
         for (let i = matrixStart + 1; i < lines.length; i++) {
@@ -577,7 +577,7 @@ function main() {
       headingBlobLower.includes("ui-test");
     if (!hasUi) {
       errors.push(
-        "front-matter ui_tests: true but no Section 15.6 UI test scenarios found (Locked 31)",
+        "front-matter ui_tests: true but no Section 15.6 UI test scenarios found (Locked 30)",
       );
     }
   }
@@ -600,7 +600,7 @@ function main() {
   // It is Section 15 in the global profile and Section 19 in the corporate one;
   // the check matches on the title, so only the stack-optional case needs an
   // exemption - there the whole development layer is legitimately absent
-  // (Locked 35) and there is no repo for a test to run against yet.
+  // (Locked 34) and there is no repo for a test to run against yet.
   if (mode === "full" && !noPlatform) {
     const hasTestPlan = ["Test Planı", "Test Plani", "Test Plan"].some((kw) =>
       headingBlob.includes(kw),
@@ -614,7 +614,7 @@ function main() {
         warns.push(`${msg} - allowed for backend only when no contract testing is planned`);
       } else {
         errors.push(
-          `missing Section 15 Test Plan; Full mode dev reads it as the RED input (Locked 31)`,
+          `missing Section 15 Test Plan; Full mode dev reads it as the RED input (Locked 30)`,
         );
       }
     } else {
@@ -624,7 +624,7 @@ function main() {
         headingBlobLower.includes("unit test");
       if (!hasUnit && /BR-[a-z0-9]+(?:-[a-z0-9]+)*-\d+/i.test(text)) {
         errors.push(
-          "Section 15 has no unit-test sub-table while business rules are defined (Locked 31)",
+          "Section 15 has no unit-test sub-table while business rules are defined (Locked 30)",
         );
       }
     }
@@ -755,7 +755,7 @@ function main() {
       const tested = new Set((testBody.join("\n").match(idRx) || []).map((x) => x.toUpperCase()));
       for (const id of defined) {
         if (!tested.has(id)) {
-          errors.push(`business rule ${id} has no Section 15 test scenario (Locked 31)`);
+          errors.push(`business rule ${id} has no Section 15 test scenario (Locked 30)`);
         }
       }
     }
@@ -763,7 +763,7 @@ function main() {
 
   mark("rule-to-test");
 
-  // 2h. Redesign mode (Locked 37). Eight checks, live only when the front-matter
+  // 2h. Redesign mode (Locked 36). Eight checks, live only when the front-matter
   // opts in. The contract they enforce is analysis/redesign.md, which loads only
   // on a redesign run; what is here is the enforcement, not the explanation.
   const redesign = String(parsed?.fm?.redesign || "false").toLowerCase() === "true";
@@ -787,7 +787,7 @@ function main() {
       [epBody, "4.6 Endpoint Mapping"],
       [dlBody, "9.5 Difference List"],
     ]) {
-      if (!body) errors.push(`redesign: true but Section ${name} is missing (Locked 37)`);
+      if (!body) errors.push(`redesign: true but Section ${name} is missing (Locked 36)`);
     }
 
     const STATUSES = ["Moved", "Partial", "Missing", "New", "Out of scope"];
@@ -804,7 +804,7 @@ function main() {
       // the row that was not marked.
       if (!/:\d+\b/.test(evidence) && !certainty.includes("uncertain")) {
         errors.push(
-          `current-behaviour row ${id} cites no file:line and is not marked uncertain (Locked 37)`,
+          `current-behaviour row ${id} cites no file:line and is not marked uncertain (Locked 36)`,
         );
       }
       // 3. A rule that lives only in a shared module legitimately reads this way,
@@ -825,14 +825,14 @@ function main() {
       // 4. A controlled vocabulary decaying into free text.
       if (!status) {
         errors.push(
-          `difference-list row ${id} has status "${statusCell}"; expected one of ${STATUSES.join(" / ")} (Locked 37)`,
+          `difference-list row ${id} has status "${statusCell}"; expected one of ${STATUSES.join(" / ")} (Locked 36)`,
         );
         continue;
       }
       // 5. The reason the mode exists: a behaviour v2 drops with no decision.
       if ((status === "Missing" || status === "Partial") && !/\bAS-\d{2,3}\b/.test(row)) {
         errors.push(
-          `difference-list row ${id} is ${status} with no AS-NN open question (Locked 37)`,
+          `difference-list row ${id} is ${status} with no AS-NN open question (Locked 36)`,
         );
       }
     }
@@ -866,7 +866,7 @@ function main() {
       const cellCount = (line) =>
         line.trim().replace(/^\|/, "").replace(/\|$/, "").split("|").length;
       if (!header) {
-        errors.push("Section 4.6 has no v1/v2 header row (Locked 37)");
+        errors.push("Section 4.6 has no v1/v2 header row (Locked 36)");
       } else {
         const cols = cellCount(header);
         for (const row of tableDataRows(epBody)) {
@@ -925,7 +925,7 @@ function main() {
 
   // 4. Placeholder whole-section bodies (Locked 2).
   // Not a defect in the corporate profile: there N/A and EKLENECEK are how a
-  // backbone section reports "considered, nothing to state" (Locked 33), and the
+  // backbone section reports "considered, nothing to state" (Locked 32), and the
   // EKLENECEK-to-open-question pairing above is what keeps them honest.
   if (profile === "global" && /^\s*(TBD|Not applicable|N\/A)\s*$/im.test(text)) {
     warns.push(
@@ -992,7 +992,7 @@ function main() {
     for (const [id, n] of counts) {
       if (n < 2) {
         warns.push(
-          `business rule ${id} is defined but never referenced downstream (test/acceptance/analytics) - Locked 31 traceability`,
+          `business rule ${id} is defined but never referenced downstream (test/acceptance/analytics) - Locked 30 traceability`,
         );
       }
     }
@@ -1007,7 +1007,7 @@ function main() {
     if (!/^\|\s*MT-[a-z0-9-]+/i.test(line)) continue;
     if (!/BR-[a-z0-9]+(?:-[a-z0-9]+)*-\d+/i.test(line)) {
       const id = (line.match(/MT-[a-z0-9-]+/i) || ["MT row"])[0];
-      errors.push(`manual scenario ${id} has no BR- id (Section 15.7 / Locked 31)`);
+      errors.push(`manual scenario ${id} has no BR- id (Section 15.7 / Locked 30)`);
     }
   }
 
@@ -1034,13 +1034,188 @@ function main() {
     if (/^-+$/.test(cells[1]) || /Bile\u015fen|Component/i.test(cells[1])) continue;
     if (!cells[3] || !cells[4]) {
       errors.push(
-        `variant row "${cells[1]}" is missing the all-values or used-here column (Section 6.X / Locked 29)`,
+        `variant row "${cells[1]}" is missing the all-values or used-here column (Section 6.X / Locked 28)`,
       );
     }
   }
 
   mark("variant-coverage");
 
+  // 2h. Locked 13, 14, 15, 17, 18 and 21.
+  //
+  // Each checks a SHAPE the template prescribes. None judges content: a gate
+  // that guesses at meaning fails honest documents, and a gate people learn to
+  // ignore is worse than the prose it replaced.
+  //
+  // Each is keyed off a structure only a real document carries, so a minimal
+  // document is skipped rather than failed. "Section 4 exists" is not evidence
+  // that anybody wrote scenarios, and "Section 4 has a 4.1 sub-heading" is.
+
+  // Locked 13: Section 4 scenarios are Gherkin, not prose.
+  const storiesBody = sectionBody(allLines, [
+    "Kullanıcı Hikayeleri",
+    "Kullanici Hikayeleri",
+    "User Stories",
+  ]);
+  if (storiesBody) {
+    const blocks = [];
+    let inFence = false;
+    let isGherkin = false;
+    let buf = [];
+    for (const line of storiesBody) {
+      if (line.trim().startsWith("```")) {
+        if (!inFence) {
+          inFence = true;
+          isGherkin = /^```\s*gherkin/i.test(line.trim());
+          buf = [];
+        } else {
+          if (isGherkin) blocks.push(buf.join("\n"));
+          inFence = false;
+        }
+        continue;
+      }
+      if (inFence && isGherkin) buf.push(line);
+    }
+    // Scenarios are 4.1 to 4.3. 4.4 is the business-rule table, and a redesign
+    // run adds 4.5 and up (Locked 36: current behaviour, endpoint mapping,
+    // difference list) - none of which is a scenario, so "everything except
+    // 4.4" would demand Gherkin of three tables.
+    const scenarioHeads = storiesBody.filter((l) => /^#{3}\s+4\.[1-3]\b/.test(l));
+    if (scenarioHeads.length && !blocks.length) {
+      errors.push(
+        `Section 4 has ${scenarioHeads.length} scenario sub-section(s) and no \`\`\`gherkin block; plain-prose user stories are rejected (Locked 13)`,
+      );
+    }
+    blocks.forEach((b, i) => {
+      const missing = ["Given", "When", "Then"].filter(
+        (k) => !new RegExp(`(^|\\n)\\s*${k}\\b`).test(b),
+      );
+      if (missing.length) {
+        errors.push(`Section 4 gherkin block ${i + 1} states no ${missing.join(", ")} (Locked 13)`);
+      }
+    });
+  }
+
+  mark("gherkin-scenarios", storiesBody ? undefined : "no User Stories section");
+
+  // Locked 14: Goals and Non-Goals are paired. A goal with an empty counterpart
+  // cell is the failure the decision names - omission cannot be read as
+  // exclusion, so the column has to say what is NOT covered.
+  const goalsBody = sectionBody(allLines, [
+    "Hedefler ve Karşı Hedefler",
+    "Hedefler ve Karsi Hedefler",
+    "Goals and Non-Goals",
+    "Goals",
+  ]);
+  let goalRows = 0;
+  if (goalsBody) {
+    for (const row of tableDataRows(goalsBody)) {
+      const cells = row
+        .split("|")
+        .map((c) => c.trim())
+        .filter((c, i, a) => i !== 0 && i !== a.length - 1);
+      if (cells.length < 2) continue;
+      goalRows++;
+      if (!cells[1] || cells[1] === "-") {
+        errors.push(`goal "${cells[0].slice(0, 40)}" has no paired non-goal (Locked 14)`);
+      }
+    }
+  }
+
+  mark("goals-paired", goalRows ? undefined : "no Goals/Non-Goals table");
+
+  // Locked 15: a new asset that is not SVG owes a rationale. The decision
+  // allows Lottie and optimized PNG - it does not allow them silently.
+  const assetsBody = sectionBody(allLines, ["Asset Envanteri", "Asset Inventory"]);
+  let assetRows = 0;
+  if (assetsBody) {
+    for (const row of tableDataRows(assetsBody)) {
+      const cells = row
+        .split("|")
+        .map((c) => c.trim())
+        .filter((c, i, a) => i !== 0 && i !== a.length - 1);
+      if (cells.length < 5) continue;
+      assetRows++;
+      const [name, format, existing, , notes] = cells;
+      const isNew = /^(no|hayır|hayir)\b/i.test(existing);
+      if (!isNew) continue;
+      if (/\bsvg\b/i.test(format)) continue;
+      if (!notes || !/\S/.test(notes.replace(/^new,?\s*/i, ""))) {
+        errors.push(
+          `new asset "${name.slice(0, 40)}" is ${format} rather than SVG and states no exception rationale (Locked 15)`,
+        );
+      }
+    }
+  }
+
+  mark("asset-format", assetRows ? undefined : "no Asset Inventory table");
+
+  // Locked 17: "other errors" is the phrase the decision exists to reject. An
+  // exhaustive list cannot be checked for exhaustiveness from inside the
+  // document, but the admission that it is not exhaustive can.
+  const apiBody = sectionBody(allLines, ["API Kontratları", "API Kontratlari", "API Contracts"]);
+  if (apiBody) {
+    const VAGUE = [
+      /\bother errors?\b/i,
+      /\bvarious \dxx\b/i,
+      /\bdiğer hatalar\b/i,
+      /\bdiger hatalar\b/i,
+      /\betc\.?\s*\|/i,
+    ];
+    for (const line of apiBody) {
+      const hit = VAGUE.find((rx) => rx.test(line));
+      if (hit) {
+        errors.push(
+          `Section 9 stands in for a status code instead of listing it: "${line.trim().slice(0, 60)}" (Locked 17)`,
+        );
+      }
+    }
+  }
+
+  mark("api-variants-exhaustive", apiBody ? undefined : "no API Contracts section");
+
+  // Locked 18: screenshots are embedded, not linked. A remote image survives
+  // exactly as long as whatever serves it, and the document outlives that.
+  const designBody = sectionBody(allLines, [
+    "Tasarım Referansı",
+    "Tasarim Referansi",
+    "Design Reference",
+  ]);
+  if (designBody) {
+    for (const line of designBody) {
+      const m = /!\[[^\]]*\]\((https?:\/\/[^)]+)\)/.exec(line);
+      if (m) {
+        errors.push(
+          `Section 5 links a remote screenshot instead of embedding a local file: ${m[1].slice(0, 60)} (Locked 18)`,
+        );
+      }
+    }
+  }
+
+  mark("screenshots-embedded", designBody ? undefined : "no Design Reference section");
+
+  // Locked 21: References sit at the bottom. The reader sees goals, flow and
+  // design before sources, which is only true if no numbered section follows.
+  const topNums = [];
+  let refNum = null;
+  for (const line of allLines) {
+    const m = /^##\s+(\d+)\.\s+(.*)$/.exec(line);
+    if (!m) continue;
+    const n = Number(m[1]);
+    topNums.push(n);
+    if (/Referanslar|References/i.test(m[2])) refNum = n;
+  }
+  if (refNum !== null && topNums.length) {
+    const highest = Math.max(...topNums);
+    if (refNum !== highest) {
+      errors.push(
+        `References is Section ${refNum} but Section ${highest} follows it, and sources go last (Locked 21)`,
+      );
+    }
+  }
+
+  mark("references-last", refNum === null ? "no References section" : undefined);
+
   // Report
   if (report) {
     const width = Math.max(...checkRows.map((r) => r.id.length));

package/pipeline/scripts/verify-citations.mjs

@@ -6,7 +6,7 @@
  * Two surfaces in this pipeline require a citation and neither has ever checked
  * one. `reviewer-output.schema.json` makes `file` and `line` required on every
  * finding; `analysis-spec.schema.json` carries `repoEvidence` entries of
- * `{name, file, line, tag}` and `analysis/locked.md` (Locked 37) asks for
+ * `{name, file, line, tag}` and `analysis/locked.md` (Locked 36) asks for
  * `repo/file:line` on every current-behaviour row. The only check that existed
  * was `validate-analysis-doc.mjs`'s `/:\d+\b/` - a test that the row LOOKS like
  * a citation, satisfied by `Foo.swift:9999` in a repo with no Foo.swift.

package/pipeline/scripts/write-state.mjs

@@ -441,6 +441,38 @@ async function main() {
     const tmp = `${dirname(path)}/.${basename(path)}.${process.pid}.tmp`;
     writeFileSync(tmp, JSON.stringify(next, null, 2) + "\n");
     renameSync(tmp, path); // atomic on POSIX
+
+    // The check above is a time-of-check, this is the time-of-use. No POSIX
+    // call renames a file conditionally on still holding a lock, so between
+    // stillOurs() and renameSync() there is a window - narrow, but real, and it
+    // widens exactly when the machine is loaded enough for a holder to be
+    // descheduled past the reclaim ceiling.
+    //
+    // Reading the file back closes it after the fact rather than before: our
+    // rev is the one we just wrote, so a different rev on disk means another
+    // writer's rename landed on top of ours. That is the difference between
+    // reporting success while losing an update - the one outcome this script
+    // exists to prevent - and refusing loudly enough for the caller to retry.
+    try {
+      const landed = JSON.parse(readFileSync(path, "utf-8"));
+      if (landed?.rev !== next.rev) {
+        console.error(
+          `write-state: our update was overwritten between the write and this check ` +
+            `(wrote rev ${next.rev}, found rev ${landed?.rev}). Re-read the state and retry.`,
+        );
+        releaseLock(path);
+        process.exit(4);
+      }
+    } catch (err) {
+      // An unreadable file here is not our write failing - it is the state
+      // being clobbered by something that is not this writer. Saying so beats
+      // exiting 0 over a file we can no longer parse.
+      console.error(
+        `write-state: the state was unreadable immediately after our write  -  ${err.message}`,
+      );
+      releaseLock(path);
+      process.exit(4);
+    }
   } catch (err) {
     console.error(`write-state: ${err.message}`);
     releaseLock(path);

package/pipeline/skills/.skill-manifest.json

@@ -1,15 +1,15 @@
 {
   "schemaVersion": "1.0.0",
-  "generatedAt": "2026-09-18T07:17:50Z",
+  "generatedAt": "2026-09-20T20:24:07Z",
   "skillCount": 216,
   "entries": [
     {
       "path": "shared/core/apple-archive-compliance/SKILL.md",
-      "sha256": "e5c38c240a674903acf3f32e5b492a4a6c5dc438a323bb3ca9adc361b41a6884"
+      "sha256": "6675a53441f2f3bedc82284998f402bd51fa251c7491a595e12c6c4016830337"
     },
     {
       "path": "shared/core/google-play-compliance/SKILL.md",
-      "sha256": "49412b53af57ba31fe7d19983144043a2333249d075ff90a9fde9a9d3482ce83"
+      "sha256": "2229d7b732b0523142b9c467049931b1d100343c1e318428f49e3fea73fc39ec"
     },
     {
       "path": "shared/core/multi-agent-analysis-jira/SKILL.md",
@@ -253,7 +253,7 @@
     },
     {
       "path": "shared/core/multi-agent/SKILL.md",
-      "sha256": "849a2c7db9fb779d9919c7ed6cf3e0c3c6fd105ff961c45af31055ad21fd181c"
+      "sha256": "9ab7af2ffb01f8eb0fae624ae40ea9ff2f6d69ad61544bd266b1b97f60eb4a0f"
     },
     {
       "path": "shared/external/accessibility-compliance-accessibility-audit/SKILL.md",
@@ -669,7 +669,7 @@
     },
     {
       "path": "shared/external/signal-community/SKILL.md",
-      "sha256": "98a5883811a58a352f229efaa2ff785bcb7f8174988a5d6cc8d0d57cabc569cf"
+      "sha256": "d5989a85c39856e451ce5e5f9dd5a250be02067c56e47b8667a4f2d78014a89c"
     },
     {
       "path": "shared/external/skill-creator/SKILL.md",

package/pipeline/skills/shared/core/apple-archive-compliance/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: apple-archive-compliance
 language: en
-description: "Apple App Store Review compliance  -  wraps the multi-agent-toolkit-mcp `ios_app_store_audit` tool (18-rule deep scan) with ITMS error code mapping + EN/TR humanizer templates. Consumed by: /multi-agent:test 'store-ready' (primary dispatch), Phase 4 Security Auditor (catalog cross-ref on Info.plist / PrivacyInfo / entitlements diffs), /multi-agent:review (PR citation), /multi-agent:channels (PR body auto-augmentation). Wiring enforced by smoke-compliance-skills.sh. Use when an .xcarchive needs an App Store review check before submission, or a rejection has to be diagnosed."
+description: "Apple App Store Review compliance  -  wraps the multi-agent-toolkit-mcp `ios_app_store_audit` tool (18-rule deep scan) with ITMS error code mapping + EN/TR humanizer templates. Consumed by: /multi-agent:test 'store-ready' (primary dispatch), Phase 3 Security Auditor (catalog cross-ref on Info.plist / PrivacyInfo / entitlements diffs), /multi-agent:review (PR citation), /multi-agent:channels (PR body auto-augmentation). Wiring enforced by smoke-compliance-skills.sh. Use when an .xcarchive needs an App Store review check before submission, or a rejection has to be diagnosed."
 user-invocable: true
 argument-hint: '[archive-path] [--threshold=error|warning|info] [--format=markdown|json] [--lang=en|tr]   -  no-arg: picks most recent .xcarchive from ~/Library/Developer/Xcode/Archives/'
 standards-registry: references/rules.yml
@@ -18,7 +18,7 @@ Pre-submission compliance check for iOS `.xcarchive` bundles. Wraps the [`ios_ap
 | Consumer | How it uses this skill |
 |---|---|
 | `/multi-agent:test "store-ready"` (iOS) | Main entry point  -  runs the binary, renders the full report |
-| Phase 4 Security Auditor (iOS review) | Reads the rule catalog for cross-reference when diff touches Info.plist, PrivacyInfo.xcprivacy, or entitlements |
+| Phase 3 Security Auditor (iOS review) | Reads the rule catalog for cross-reference when diff touches Info.plist, PrivacyInfo.xcprivacy, or entitlements |
 | `/multi-agent:review` | On iOS diffs, cites guideline refs next to flagged symbols |
 | `/multi-agent:channels` | When PR touches release-relevant files, appends compliance warnings to PR body |
 
@@ -208,7 +208,7 @@ sim-test.md's "store-ready" scenario on iOS:
 4. Render humanizer template per `--lang` flag (default `en`; `promptLanguage` is locked to `"en"`)
 5. Exit with `1` if any blockers, `0` otherwise (CI-friendly)
 
-### Phase 4 Security Auditor (optional, on-demand)
+### Phase 3 Security Auditor (optional, on-demand)
 
 When reviewing an iOS PR, if diff touches ANY of:
 - `*/Info.plist`
@@ -261,12 +261,12 @@ multi-agent-test "store-ready" --format=json --auto-pick
 mcp__multi-agent-toolkit__ios_app_store_audit({ archive_path: "~/Library/Developer/Xcode/Archives/2026-04-21/MyApp.xcarchive", rules: "all" })
 ```
 
-### Phase 4 Security Auditor (catalog cross-ref, no binary invocation)
+### Phase 3 Security Auditor (catalog cross-ref, no binary invocation)
 
 When a Phase 3 review diff touches iOS release-relevant paths (`Info.plist`, `PrivacyInfo.xcprivacy`, `*.entitlements`, `AppDelegate.swift`, `project.pbxproj`), the security-auditor persona loads this skill's 18-rule catalog and cites matching ruleIDs next to its findings. No binary invocation at review time  -  catalog reads are free.
 
 ```
-# Example finding from Phase 4 Security Auditor (wired in v5.8.1):
+# Example finding from Phase 3 Security Auditor (wired in v5.8.1):
 [BLOCKING] Info.plist: new NSCameraUsageDescription without justification
   (apple-archive-compliance / info-plist  -  Guideline 5.1.1)
   File: MyApp/Info.plist:42
@@ -312,7 +312,7 @@ The appended section is structured:
 ## Version history
 
 - **v5.8.0**  -  Skill introduced. Wraps the (now-retired) standalone ArchiveGuard binary, 17-rule catalog, EN+TR humanizer. Primary consumer only (`/multi-agent:test "store-ready"`).
-- **v5.8.1**  -  3 additional consumer surfaces wired (Phase 4 Security Auditor cross-ref, `/multi-agent:review` citation, `/multi-agent:channels` PR-body auto-augmentation). Regression-locked by `smoke-compliance-skills.sh` (45 assertions).
+- **v5.8.1**  -  3 additional consumer surfaces wired (Phase 3 Security Auditor cross-ref, `/multi-agent:review` citation, `/multi-agent:channels` PR-body auto-augmentation). Regression-locked by `smoke-compliance-skills.sh` (45 assertions).
 - **v6.0.0**  -  `language: en` frontmatter tag; 4-consumer Examples section expanded.
 - **v8.4.0**  -  Migrated off the standalone ArchiveGuard Swift binary. Backend is now the `ios_app_store_audit` tool inside `@mmerterden/multi-agent-toolkit-mcp` ≥ v2.4 (full Node port of the 17 rules). All four consumer surfaces unchanged; rule IDs and JSON output shape preserved for backward compatibility. Rule catalog now points to `multi-agent-toolkit-mcp/tools/ios-app-store-audit/rules/`. ArchiveGuard repo deprecated.
 - **Unreleased**  -  Catalog grows to 18 rules: adds `sdk-floor` (ITMS-90725, iOS 26 / Xcode 26 build floor in force since 2026-04-28), which nothing previously checked. `embedded-sdk`'s missing-framework-privacy-manifest finding moves from a `5.1.1` WARNING to `ITMS-91061` ERROR, an enforced rejection since 2025-02-12  -  archives that used to pass with a warning now fail. Requires `@mmerterden/multi-agent-toolkit-mcp` ≥ v3.0.0.

package/pipeline/skills/shared/core/google-play-compliance/SKILL.md

@@ -1,7 +1,7 @@
 ---
 name: google-play-compliance
 language: en
-description: "Google Play Store publication compliance  -  bundletool + aapt2 + apksigner orchestration + 21-rule policy catalog with Play Console error codes + humanizer templates. Consumed by: /multi-agent:test 'store-ready' (primary dispatch), Phase 4 Security Auditor (catalog cross-ref on AndroidManifest / build.gradle / proguard / signing diffs), /multi-agent:review (PR citation), /multi-agent:channels (PR body auto-augmentation). Wiring enforced by smoke-compliance-skills.sh. Use when an .aab or .apk needs a Play policy check before upload, or a Play rejection has to be diagnosed."
+description: "Google Play Store publication compliance  -  bundletool + aapt2 + apksigner orchestration + 21-rule policy catalog with Play Console error codes + humanizer templates. Consumed by: /multi-agent:test 'store-ready' (primary dispatch), Phase 3 Security Auditor (catalog cross-ref on AndroidManifest / build.gradle / proguard / signing diffs), /multi-agent:review (PR citation), /multi-agent:channels (PR body auto-augmentation). Wiring enforced by smoke-compliance-skills.sh. Use when an .aab or .apk needs a Play policy check before upload, or a Play rejection has to be diagnosed."
 user-invocable: true
 argument-hint: '[bundle-path] [--threshold=error|warning|info] [--format=markdown|json] [--lang=en|tr]   -  no-arg: picks most recent .aab from app/build/outputs/bundle/release/'
 standards-registry: references/rules.yml
@@ -18,7 +18,7 @@ Pre-submission compliance check for Android App Bundle (`.aab`) and APK artifact
 | Consumer | How it uses this skill |
 |---|---|
 | `/multi-agent:test "store-ready"` (Android) | Main entry point  -  runs the tools, renders the full report |
-| Phase 4 Security Auditor (Android review) | Reads the rule catalog for cross-reference when diff touches AndroidManifest.xml, gradle config, or signing |
+| Phase 3 Security Auditor (Android review) | Reads the rule catalog for cross-reference when diff touches AndroidManifest.xml, gradle config, or signing |
 | `/multi-agent:review` | On Android diffs, cites Play policy refs next to flagged changes (e.g. new `MANAGE_EXTERNAL_STORAGE` without justification) |
 | `/multi-agent:channels` | When PR is release-relevant, appends compliance warnings to PR body |
 
@@ -232,7 +232,7 @@ sim-test.md's "store-ready" scenario on Android:
 5. Render humanizer template per `--lang` flag (default `en`; `promptLanguage` is locked to `"en"`)
 6. Exit with `1` if any blockers, `0` otherwise (CI-friendly)
 
-### Phase 4 Security Auditor (optional, on-demand)
+### Phase 3 Security Auditor (optional, on-demand)
 
 When reviewing an Android PR, if diff touches ANY of:
 - `**/AndroidManifest.xml` (permissions / exported / targetSdk)
@@ -286,12 +286,12 @@ multi-agent-test "store-ready" --last-version-code=142 --auto-pick
 /multi-agent:test "store-ready" --format=json --auto-pick
 ```
 
-### Phase 4 Security Auditor (catalog cross-ref, no tool invocation)
+### Phase 3 Security Auditor (catalog cross-ref, no tool invocation)
 
 When a Phase 3 review diff touches Android release-relevant paths (`AndroidManifest.xml`, `build.gradle(.kts)`, `proguard-rules.pro`, `network_security_config.xml`), the security-auditor persona loads this skill's 21-rule policy catalog and cites matching ruleIDs next to its findings. No bundletool / aapt2 / apksigner invocation at review time  -  catalog reads are free.
 
 ```
-# Example finding from Phase 4 Security Auditor (wired in v5.8.1):
+# Example finding from Phase 3 Security Auditor (wired in v5.8.1):
 [BLOCKING] AndroidManifest.xml: new MANAGE_EXTERNAL_STORAGE permission added
   (google-play-compliance / dangerous-permissions  -  Policy  -  Permissions)
   File: app/src/main/AndroidManifest.xml:12
@@ -345,5 +345,5 @@ The appended section is structured:
 ## Version history
 
 - **v5.8.0**  -  Skill introduced. Orchestrates bundletool + aapt2 + apksigner, 21-rule catalog, EN+TR humanizer. Primary consumer only (`/multi-agent:test "store-ready"`).
-- **v5.8.1**  -  3 additional consumer surfaces wired (Phase 4 Security Auditor cross-ref, `/multi-agent:review` citation, `/multi-agent:channels` PR-body auto-augmentation). Regression-locked by `smoke-compliance-skills.sh` (45 assertions).
+- **v5.8.1**  -  3 additional consumer surfaces wired (Phase 3 Security Auditor cross-ref, `/multi-agent:review` citation, `/multi-agent:channels` PR-body auto-augmentation). Regression-locked by `smoke-compliance-skills.sh` (45 assertions).
 - **v6.0.0**  -  `language: en` frontmatter tag; 4-consumer Examples section expanded.

package/pipeline/skills/shared/core/multi-agent/SKILL.md

@@ -204,28 +204,29 @@ This works across sessions because:
 
 Every agent persona under `$HOME/.claude/agents/*.md` declares a `preferredModel` frontmatter field. The orchestrator MUST honor it on every dispatch, on both Claude Code and Copilot CLI  -  cross-CLI parity is enforced by `smoke-cross-cli-behavior.sh`.
 
-| Persona | `preferredModel` | Rationale (condensed) |
-|---|---|---|
-| `explorer` | `sonnet` | Scan/pattern work, cost-efficient without quality loss |
-| `code-reviewer` | `fable` | Reviewer 1; Phase 3 sets Reviewer 2 `opus`, Reviewer 3 `sonnet` |
-| `security-auditor` | `opus` | False-negative cost is high; opus reduces miss rate |
-| `ios-architect` | `fable` | Deep module/protocol/migration reasoning |
-| `android-architect` | `fable` | Gradle modules, Compose stability, Hilt graphs |
-| `backend-architect` | `fable` | API + migration + scaling reasoning |
+Each persona file carries its own `modelRationale`; this is the rung only.
 
-**Dispatch contract (pseudo-code):**
+| Persona | `preferredModel` |
+|---|---|
+| `explorer` | `sonnet` |
+| `code-reviewer` | `fable` (Reviewer 1; Phase 3 sets Reviewer 2 `opus`, Reviewer 3 `sonnet`) |
+| `security-auditor` | `opus` |
+| `ios-architect` / `android-architect` / `backend-architect` | `fable` |
+
+**Dispatch contract:**
 
 ```bash
 persona_file="$HOME/.claude/agents/${persona}.md"
 pref_model="$(awk '/^preferredModel:/ {print $2; exit}' "$persona_file")"
-override="${PHASE_MODEL_OVERRIDE:-}"   # set by orchestrator per-dispatch (e.g. Phase 3 Reviewer 3 → sonnet)
-resolved_model="${override:-${pref_model:-opus}}"
+override="${PHASE_MODEL_OVERRIDE:-}"   # per-dispatch, e.g. Phase 3 Reviewer 3 → sonnet
+routed="${override:-$("$HOME/.claude/lib/model-dispatch.sh" subagent --persona "$persona" --phase "$currentPhase" --task-kind "$taskType" --default "${pref_model:-opus}" 2>/dev/null)}"
+resolved_model="${routed:-${pref_model:-opus}}"
 
 export CLAUDE_CODE_SUBAGENT_MODEL="$resolved_model"
-# Claude Code honors the env var; Copilot CLI reads the same env + passes as --model flag.
+# Claude Code honors the env var; Copilot CLI also passes it as --model.
 ```
 
-**Precedence:** per-dispatch `PHASE_MODEL_OVERRIDE` > persona `preferredModel` > global default (`opus`).
+**Precedence:** per-dispatch `PHASE_MODEL_OVERRIDE` > `prefs.global.modelRouting` rule > persona `preferredModel` > global default (`opus`). Routing here is Anthropic-only: features/model-fallback.md "Routing at dispatch".
 
 **Observability:** emit `phase.agent.dispatch` OTel span with `{persona, resolved_model, override_source}` attributes when `MULTI_AGENT_OTEL_SPANS=1` (see `phase-tracker.sh`).
 

package/pipeline/skills/shared/external/NOTICE-swift-ios-skills.md

@@ -38,4 +38,4 @@ alarmkit, app-clips, app-intents, app-store-optimization, app-store-review, appl
 
 avkit, core-data, cryptokit, ios-simulator, pdfkit, swift-api-design-guidelines, swift-architecture, swift-formatstyle, swift-security, swiftlint
 
-Note: `swift-security` is a superset of the older standalone `ios-security` skill; `ios-security` is kept because Phase 4 review references it. Candidate for retirement in a later pass.
+Note: `swift-security` is a superset of the older standalone `ios-security` skill; `ios-security` is kept because Phase 3 review references it. Candidate for retirement in a later pass.