@mmerterden/multi-agent-pipeline 18.0.0 → 19.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +183 -0
- package/README.md +34 -18
- package/README.tr.md +14 -16
- package/docs/adr/0002-instruction-driven-flag.md +1 -0
- package/docs/adr/0005-lazy-phase-docs.md +11 -1
- package/docs/adr/0008-installer-modularization-and-secret-leak-defense.md +1 -0
- package/docs/adr/0010-own-code-graph.md +1 -0
- package/docs/adr/0014-six-phase-consolidation.md +134 -0
- package/docs/adr/README.md +2 -1
- package/docs/architecture.md +37 -38
- package/docs/best-practices.md +1 -1
- package/docs/ecosystem.md +37 -26
- package/docs/engineering.md +1 -1
- package/docs/facts.json +45 -0
- package/docs/features.md +54 -53
- package/docs/performance.md +5 -5
- package/docs/recovery-guide.md +9 -9
- package/docs/token-budget-history.md +3 -1
- package/index.js +2 -2
- package/install/_codex-agents.mjs +1 -1
- package/install/templates/claude-hooks.json +1 -1
- package/install/templates/codex-instructions.md +1 -1
- package/install/templates/copilot-instructions.md +28 -28
- package/manifest.json +209 -193
- package/package.json +2 -2
- package/pipeline/agents/dev-critic.md +3 -3
- package/pipeline/commands/figma-to-swiftui.md +1 -1
- package/pipeline/commands/multi-agent/SKILL.md +8 -8
- package/pipeline/commands/multi-agent/analysis/SKILL.md +9 -9
- package/pipeline/commands/multi-agent/autopilot/SKILL.md +7 -7
- package/pipeline/commands/multi-agent/channels/SKILL.md +15 -15
- package/pipeline/commands/multi-agent/diff-explain/SKILL.md +6 -6
- package/pipeline/commands/multi-agent/garbage-collect/SKILL.md +1 -1
- package/pipeline/commands/multi-agent/graph/SKILL.md +1 -1
- package/pipeline/commands/multi-agent/help/SKILL.md +62 -62
- package/pipeline/commands/multi-agent/language/SKILL.md +2 -2
- package/pipeline/commands/multi-agent/local/SKILL.md +11 -11
- package/pipeline/commands/multi-agent/local-autopilot/SKILL.md +13 -13
- package/pipeline/commands/multi-agent/log/SKILL.md +2 -2
- package/pipeline/commands/multi-agent/manual-test/SKILL.md +9 -9
- package/pipeline/commands/multi-agent/model/SKILL.md +69 -0
- package/pipeline/commands/multi-agent/refactor/SKILL.md +3 -3
- package/pipeline/commands/multi-agent/resume/SKILL.md +4 -4
- package/pipeline/commands/multi-agent/resume-local/SKILL.md +19 -17
- package/pipeline/commands/multi-agent/review/SKILL.md +1 -1
- package/pipeline/commands/multi-agent/route-off/SKILL.md +36 -0
- package/pipeline/commands/multi-agent/route-on/SKILL.md +74 -0
- package/pipeline/commands/multi-agent/route-status/SKILL.md +56 -0
- package/pipeline/commands/multi-agent/setup/SKILL.md +2 -2
- package/pipeline/commands/multi-agent/status/SKILL.md +5 -5
- package/pipeline/commands/multi-agent/steer/SKILL.md +2 -2
- package/pipeline/commands/multi-agent/sync/SKILL.md +12 -13
- package/pipeline/commands/multi-agent/test/SKILL.md +1 -1
- package/pipeline/lib/credential-inventory.sh +1 -1
- package/pipeline/lib/fetch-fortify.sh +1 -1
- package/pipeline/lib/model-rung.sh +142 -0
- package/pipeline/lib/phase-schema.mjs +88 -0
- package/pipeline/lib/plan-todos.sh +5 -5
- package/pipeline/lib/route-state.sh +161 -0
- package/pipeline/lib/run-paths.sh +2 -2
- package/pipeline/multi-agent-refs/_account-picker.md +1 -1
- package/pipeline/multi-agent-refs/_dev-context.md +1 -1
- package/pipeline/multi-agent-refs/_input-parser.md +1 -1
- package/pipeline/multi-agent-refs/analysis/evidence.md +0 -9
- package/pipeline/multi-agent-refs/analysis/intake.md +1 -1
- package/pipeline/multi-agent-refs/analysis/locked.md +21 -22
- package/pipeline/multi-agent-refs/analysis/render.md +1 -1
- package/pipeline/multi-agent-refs/analysis/synthesis.md +12 -6
- package/pipeline/multi-agent-refs/android-guide.md +1 -1
- package/pipeline/multi-agent-refs/audit-guide.md +13 -13
- package/pipeline/multi-agent-refs/channels/issue-comment.md +2 -2
- package/pipeline/multi-agent-refs/channels/jira.md +3 -3
- package/pipeline/multi-agent-refs/channels/pr.md +4 -4
- package/pipeline/multi-agent-refs/channels/wiki.md +1 -1
- package/pipeline/multi-agent-refs/component-dispatch.md +3 -3
- package/pipeline/multi-agent-refs/cross-cli-contract.md +31 -6
- package/pipeline/multi-agent-refs/features/autopilot-circuit-breaker.md +4 -4
- package/pipeline/multi-agent-refs/features/code-graph.md +5 -5
- package/pipeline/multi-agent-refs/features/design-conformance.md +1 -1
- package/pipeline/multi-agent-refs/features/dev-critic.md +3 -3
- package/pipeline/multi-agent-refs/features/doctor.md +2 -2
- package/pipeline/multi-agent-refs/features/external-context-injection.md +3 -3
- package/pipeline/multi-agent-refs/features/maturity-followup.md +3 -3
- package/pipeline/multi-agent-refs/features/model-fallback.md +5 -5
- package/pipeline/multi-agent-refs/features/plan-todos.md +1 -1
- package/pipeline/multi-agent-refs/features/repo-map.md +1 -1
- package/pipeline/multi-agent-refs/features/review-delta.md +3 -3
- package/pipeline/multi-agent-refs/features/review-multi-repo.md +1 -1
- package/pipeline/multi-agent-refs/features/scope-check.md +4 -4
- package/pipeline/multi-agent-refs/features/skill-conformance.md +2 -2
- package/pipeline/multi-agent-refs/features/stack-skill-routing.md +1 -1
- package/pipeline/multi-agent-refs/features/verify-by-test.md +4 -4
- package/pipeline/multi-agent-refs/features/visual-evidence.md +19 -19
- package/pipeline/multi-agent-refs/features/worktree-finalize.md +6 -6
- package/pipeline/multi-agent-refs/issue-jira-triad.md +10 -10
- package/pipeline/multi-agent-refs/knowledge.md +11 -11
- package/pipeline/multi-agent-refs/multi-repo-integration-build.md +13 -13
- package/pipeline/multi-agent-refs/payload-contracts.md +8 -8
- package/pipeline/multi-agent-refs/phases/log-format.md +10 -10
- package/pipeline/multi-agent-refs/phases/modes.md +30 -30
- package/pipeline/multi-agent-refs/phases/operations.md +8 -8
- package/pipeline/multi-agent-refs/phases/phase-0-init.md +24 -24
- package/pipeline/multi-agent-refs/phases/phase-1-plan.md +599 -0
- package/pipeline/multi-agent-refs/phases/{phase-3-dev.md → phase-2-dev.md} +129 -49
- package/pipeline/multi-agent-refs/phases/{phase-4-review.md → phase-3-review.md} +225 -107
- package/pipeline/multi-agent-refs/phases/{phase-6-commit.md → phase-4-commit.md} +23 -23
- package/pipeline/multi-agent-refs/phases/{phase-7-report.md → phase-5-report.md} +29 -29
- package/pipeline/multi-agent-refs/phases.md +44 -48
- package/pipeline/multi-agent-refs/picker-contract.md +1 -1
- package/pipeline/multi-agent-refs/progress-contract.md +6 -6
- package/pipeline/multi-agent-refs/readiness-review.md +1 -1
- package/pipeline/multi-agent-refs/rules.md +7 -7
- package/pipeline/multi-agent-refs/swiftui-guide.md +2 -2
- package/pipeline/multi-agent-refs/tracker-contract.md +31 -32
- package/pipeline/multi-agent-refs/wiki-capture.md +14 -14
- package/pipeline/preferences-template.json +9 -1
- package/pipeline/rules/outside-the-pipeline.md +1 -1
- package/pipeline/schemas/agent-state.schema.json +50 -50
- package/pipeline/schemas/analysis-output.schema.json +2 -2
- package/pipeline/schemas/autopilot-config.schema.json +1 -1
- package/pipeline/schemas/code-graph.schema.json +1 -1
- package/pipeline/schemas/criteria-manifest.schema.json +1 -1
- package/pipeline/schemas/dev-critic-output.schema.json +1 -1
- package/pipeline/schemas/diff-risk.schema.json +1 -1
- package/pipeline/schemas/migrations/prefs-2.4.0-to-2.5.0.mjs +2 -2
- package/pipeline/schemas/migrations/prefs-2.6.0-to-2.7.0.mjs +31 -0
- package/pipeline/schemas/migrations/state-2.1.0-to-2.2.0.mjs +129 -0
- package/pipeline/schemas/phases.json +105 -0
- package/pipeline/schemas/plan-todos.schema.json +5 -5
- package/pipeline/schemas/planning-output.schema.json +1 -1
- package/pipeline/schemas/prefs.schema.json +100 -56
- package/pipeline/schemas/reviewer-output.schema.json +3 -3
- package/pipeline/schemas/route-config.schema.json +74 -0
- package/pipeline/schemas/scope-check.schema.json +1 -1
- package/pipeline/schemas/test-gap.schema.json +1 -1
- package/pipeline/schemas/token-budget.json +12 -18
- package/pipeline/schemas/triage-output.schema.json +6 -6
- package/pipeline/scripts/README.md +3 -3
- package/pipeline/scripts/_code-graph.mjs +2 -2
- package/pipeline/scripts/_run-paths.mjs +2 -2
- package/pipeline/scripts/_smoke-root.sh +1 -1
- package/pipeline/scripts/aggregate-metrics.mjs +1 -1
- package/pipeline/scripts/capture-flush.sh +8 -8
- package/pipeline/scripts/capture-resume.sh +3 -3
- package/pipeline/scripts/classify-plan-safety.mjs +1 -1
- package/pipeline/scripts/diff-explain.mjs +1 -1
- package/pipeline/scripts/doctor.mjs +2 -2
- package/pipeline/scripts/gc-abandoned.sh +3 -3
- package/pipeline/scripts/gc-tmp.sh +1 -1
- package/pipeline/scripts/gc-worktrees.sh +1 -1
- package/pipeline/scripts/gen-facts.mjs +175 -0
- package/pipeline/scripts/gen-mode-dispatch.mjs +32 -37
- package/pipeline/scripts/gen-ref-toc.mjs +1 -1
- package/pipeline/scripts/graph-report.mjs +1 -1
- package/pipeline/scripts/jira-attach.sh +1 -1
- package/pipeline/scripts/learn-from-transcripts.mjs +1 -1
- package/pipeline/scripts/learning-curve.mjs +2 -2
- package/pipeline/scripts/log-metric.sh +17 -4
- package/pipeline/scripts/memory-save.sh +1 -1
- package/pipeline/scripts/migrate-prefs.mjs +22 -5
- package/pipeline/scripts/phase-banner.sh +20 -20
- package/pipeline/scripts/phase-tracker.sh +7 -7
- package/pipeline/scripts/plan-coverage-gate.mjs +2 -2
- package/pipeline/scripts/render-agent-log-cost.sh +1 -1
- package/pipeline/scripts/render-work-summary.sh +3 -3
- package/pipeline/scripts/review-file-filter.mjs +1 -1
- package/pipeline/scripts/run-aggregator.mjs +13 -6
- package/pipeline/scripts/run-metrics.mjs +1 -1
- package/pipeline/scripts/runs-index.mjs +11 -1
- package/pipeline/scripts/smoke-cross-cli-behavior.sh +6 -6
- package/pipeline/scripts/smoke-schema-validation.sh +26 -7
- package/pipeline/scripts/token-budget-report.mjs +13 -2
- package/pipeline/scripts/triage-memory.mjs +2 -2
- package/pipeline/scripts/validate-analysis-doc.mjs +73 -17
- package/pipeline/scripts/validate-planning.mjs +1 -1
- package/pipeline/scripts/validate-reviewer.mjs +1 -1
- package/pipeline/scripts/validate-state.mjs +45 -5
- package/pipeline/scripts/validate-triage.mjs +3 -3
- package/pipeline/scripts/worktree-finalize.sh +5 -5
- package/pipeline/skills/.skill-manifest.json +37 -21
- package/pipeline/skills/.skills-index.json +49 -5
- package/pipeline/skills/shared/README.md +10 -6
- package/pipeline/skills/shared/core/apple-archive-compliance/SKILL.md +2 -2
- package/pipeline/skills/shared/core/google-play-compliance/SKILL.md +2 -2
- package/pipeline/skills/shared/core/multi-agent/SKILL.md +69 -71
- package/pipeline/skills/shared/core/multi-agent-autopilot/SKILL.md +3 -3
- package/pipeline/skills/shared/core/multi-agent-channels/SKILL.md +14 -14
- package/pipeline/skills/shared/core/multi-agent-diff-explain/SKILL.md +5 -5
- package/pipeline/skills/shared/core/multi-agent-graph/SKILL.md +1 -1
- package/pipeline/skills/shared/core/multi-agent-help/SKILL.md +25 -23
- package/pipeline/skills/shared/core/multi-agent-language/SKILL.md +2 -2
- package/pipeline/skills/shared/core/multi-agent-local/SKILL.md +2 -2
- package/pipeline/skills/shared/core/multi-agent-local-autopilot/SKILL.md +8 -8
- package/pipeline/skills/shared/core/multi-agent-manual-test/SKILL.md +6 -6
- package/pipeline/skills/shared/core/multi-agent-model/SKILL.md +71 -0
- package/pipeline/skills/shared/core/multi-agent-refactor/SKILL.md +3 -3
- package/pipeline/skills/shared/core/multi-agent-resume/SKILL.md +1 -1
- package/pipeline/skills/shared/core/multi-agent-resume-local/SKILL.md +7 -7
- package/pipeline/skills/shared/core/multi-agent-route-off/SKILL.md +39 -0
- package/pipeline/skills/shared/core/multi-agent-route-on/SKILL.md +76 -0
- package/pipeline/skills/shared/core/multi-agent-route-status/SKILL.md +59 -0
- package/pipeline/skills/shared/core/multi-agent-setup/SKILL.md +1 -1
- package/pipeline/skills/shared/core/multi-agent-status/SKILL.md +5 -5
- package/pipeline/skills/shared/core/multi-agent-steer/SKILL.md +2 -2
- package/pipeline/skills/shared/core/multi-agent-sync/SKILL.md +6 -5
- package/pipeline/skills/skills-index.md +8 -4
- package/pipeline/multi-agent-refs/phases/phase-1-analysis.md +0 -263
- package/pipeline/multi-agent-refs/phases/phase-2-planning.md +0 -344
- package/pipeline/multi-agent-refs/phases/phase-5-test.md +0 -182
|
@@ -19,16 +19,16 @@ Standalone audit commands - runs directly via Bash, **no MCP server dependency
|
|
|
19
19
|
**These audits are on-demand.** They run when:
|
|
20
20
|
|
|
21
21
|
1. User explicitly requests: `/multi-agent test "accessibility"`, `/multi-agent test "store-ready"`
|
|
22
|
-
2. User asks during Phase
|
|
22
|
+
2. User asks during the Phase 3 user test: "run accessibility audit", "check store compliance"
|
|
23
23
|
3. Pipeline suggests and user confirms: "UI changes detected - want to run accessibility audit?"
|
|
24
24
|
|
|
25
|
-
**Pipeline never runs audits without user intent.** Phase
|
|
25
|
+
**Pipeline never runs audits without user intent.** Phase 3 does code-level review (free, automatic) and the device-level audit only when requested - both live in Review now, at different steps, which is why "Review ran" does not mean a device was touched.
|
|
26
26
|
|
|
27
27
|
---
|
|
28
28
|
|
|
29
29
|
### iOS Accessibility Audit
|
|
30
30
|
|
|
31
|
-
**When**: Phase
|
|
31
|
+
**When**: Phase 3 user test - user requests, app is running on simulator
|
|
32
32
|
**What it checks**: Missing labels, small tap targets (<44pt), missing identifiers
|
|
33
33
|
|
|
34
34
|
**How to run** (requires ui-tree-dumper.swift in project or ~/.claude/scripts/):
|
|
@@ -73,7 +73,7 @@ Accessibility Audit:
|
|
|
73
73
|
|
|
74
74
|
### Android Accessibility Audit
|
|
75
75
|
|
|
76
|
-
**When**: Phase
|
|
76
|
+
**When**: Phase 3 user test - user requests, app is running on emulator
|
|
77
77
|
**What it checks**: Missing contentDescription, small touch targets (<48dp), missing resource-id
|
|
78
78
|
|
|
79
79
|
```bash
|
|
@@ -98,7 +98,7 @@ cat /tmp/_audit_ui.xml
|
|
|
98
98
|
|
|
99
99
|
### iOS Biometric Test
|
|
100
100
|
|
|
101
|
-
**When**: Phase
|
|
101
|
+
**When**: Phase 3 user test - auth flow testing
|
|
102
102
|
|
|
103
103
|
```bash
|
|
104
104
|
DEVICE_ID=$(xcrun simctl list devices booted -j | python3 -c "import sys,json; devs=json.load(sys.stdin)['devices']; print(next(d['udid'] for ds in devs.values() for d in ds if d['state']=='Booted'))")
|
|
@@ -119,7 +119,7 @@ xcrun simctl keychain $DEVICE_ID biometric-match --face --no-match
|
|
|
119
119
|
|
|
120
120
|
### Android Launch Time
|
|
121
121
|
|
|
122
|
-
**When**: Phase
|
|
122
|
+
**When**: Phase 3 user test - performance baseline
|
|
123
123
|
|
|
124
124
|
```bash
|
|
125
125
|
# Force stop first (cold start)
|
|
@@ -143,7 +143,7 @@ adb shell am start -W -n {package_name}/.MainActivity 2>&1
|
|
|
143
143
|
|
|
144
144
|
### iOS Archive Audit (App Store Compliance)
|
|
145
145
|
|
|
146
|
-
**When**: Phase
|
|
146
|
+
**When**: Phase 4 - release branches only, user confirms
|
|
147
147
|
**Input**: Path to .xcarchive
|
|
148
148
|
|
|
149
149
|
```bash
|
|
@@ -198,7 +198,7 @@ ls "$APP_DIR/Frameworks/" 2>/dev/null
|
|
|
198
198
|
|
|
199
199
|
### Android APK Audit (Play Store Compliance)
|
|
200
200
|
|
|
201
|
-
**When**: Phase
|
|
201
|
+
**When**: Phase 4 - release branches only, user confirms
|
|
202
202
|
**Input**: Path to .apk
|
|
203
203
|
|
|
204
204
|
```bash
|
|
@@ -238,11 +238,11 @@ unzip -l "$APK" 2>/dev/null | grep "classes.*\.dex" | wc -l
|
|
|
238
238
|
|
|
239
239
|
| Phase | What Happens | Method |
|
|
240
240
|
| ---------------- | --------------------------------------------------- | ------------------------------- |
|
|
241
|
-
| Phase
|
|
242
|
-
| Phase
|
|
243
|
-
| Phase
|
|
244
|
-
| Phase
|
|
245
|
-
| Phase
|
|
241
|
+
| Phase 3 (Review) | Accessibility check - **code-level only** | AI reads source code, no device |
|
|
242
|
+
| Phase 3 (user test) | Accessibility audit - **device-level, on-demand** | Bash commands above |
|
|
243
|
+
| Phase 3 (user test) | Biometric test - **on-demand** | `xcrun simctl keychain` |
|
|
244
|
+
| Phase 3 (user test) | Launch time - **on-demand** | `adb shell am start -W` |
|
|
245
|
+
| Phase 4 (Commit) | Archive/APK audit - **release branches, on-demand** | Bash commands above |
|
|
246
246
|
|
|
247
247
|
### Graceful Degradation
|
|
248
248
|
|
|
@@ -124,10 +124,10 @@ Token resolution: `gh auth status` for the active GitHub account selected in Pha
|
|
|
124
124
|
|
|
125
125
|
## Pairing with the Progress flag updater
|
|
126
126
|
|
|
127
|
-
Every issue comment post is paired with `$HOME/.claude/scripts/update-issue-progress.sh "$TASK_ID"` in the same Phase
|
|
127
|
+
Every issue comment post is paired with `$HOME/.claude/scripts/update-issue-progress.sh "$TASK_ID"` in the same Phase 5 step. Order: comment FIRST (so the timestamp marks the run), flags SECOND (so the body diff is one logical change).
|
|
128
128
|
|
|
129
129
|
```bash
|
|
130
|
-
# Phase
|
|
130
|
+
# Phase 5 Step 5 - issue channel
|
|
131
131
|
gh issue comment "$ISSUE_NUMBER" --repo "$ORG/$REPO" --body-file /tmp/channels-$TASK_ID-issue.md
|
|
132
132
|
bash $HOME/.claude/scripts/update-issue-progress.sh "$TASK_ID"
|
|
133
133
|
```
|
|
@@ -42,7 +42,7 @@ it is the PR body (`channels/pr.md`).
|
|
|
42
42
|
|
|
43
43
|
**`summary`** - 2-5 sentences in `outputLanguage`. What changed, why, and the user-visible impact. No "we", no marketing tone. Past tense (the work is done at the time the comment goes up).
|
|
44
44
|
|
|
45
|
-
**Visual evidence inside these sections.** When `state.visualEvidence` carries artefacts, they render INSIDE `summary` and `test_scenarios` - never as a section of their own, which the fixed section order forbids. Phase
|
|
45
|
+
**Visual evidence inside these sections.** When `state.visualEvidence` carries artefacts, they render INSIDE `summary` and `test_scenarios` - never as a section of their own, which the fixed section order forbids. Phase 4 Step 2.9 has already uploaded them and written the returned name to `visualEvidence.*[].jiraFilename`: reference that name, and call `jira-attach.sh <issue> <file>...` only for an artefact whose `jiraFilename` is absent. Uploading unconditionally here attaches every file a second time whenever the comment is re-rendered - which is exactly what a post-hoc `/multi-agent:channels` run does.
|
|
46
46
|
|
|
47
47
|
- `summary`, after its sentences: one line naming the pair in `outputLanguage` (`Düzeltme öncesi / Düzeltme sonrası`), then the thumbnails on the next line - `!<file>-before.png|thumbnail! !<file>-after.png|thumbnail!`.
|
|
48
48
|
- `test_scenarios`, under the scenario the recording demonstrates: `!<file>-flow.mp4!` plus one line stating the tier used.
|
|
@@ -191,7 +191,7 @@ The adapter prepends the linked PR URL on the **first line** so reviewers can ju
|
|
|
191
191
|
```
|
|
192
192
|
PR: https://github.com/<org>/<repo>/pull/4321
|
|
193
193
|
|
|
194
|
-
Phase
|
|
194
|
+
Phase 3 review accepted 2 findings...
|
|
195
195
|
```
|
|
196
196
|
|
|
197
197
|
In multi-repo mode, `channels-multi-repo.sh render-jira <state> <body>` prepends a bulleted `* PR:` list - primary first, extras after. Single-repo tasks fall through to the unchanged body.
|
|
@@ -255,6 +255,6 @@ When the **Wiki** adapter writes pages on the same run AND `prefs.global.wikiToJ
|
|
|
255
255
|
- UTF-8 in, UTF-8 out - the body file is UTF-8 and `--data-binary` ships its bytes verbatim. Never round-trip the body through `unicode_escape`, `latin-1`, or any re-encode step, and never hand-roll a Python/curl helper that re-decodes it: that mangles Turkish chars (ç ş ı ö ü ğ) into mojibake (`Çözüm` → `Ãözüm`). Use the `jq --rawfile` + `--data-binary @file` path above as-is. Same rule for the PR / Confluence / Wiki adapters.
|
|
256
256
|
- Section order is fixed: `summary` → `test_scenarios` → `context_refs`. Never insert sections between them; never reorder.
|
|
257
257
|
- Humanizer pass runs **after** body assembly and **before** wiki-markup conversion. Tone target: informal but technical. No marketing voice, no "we are excited", no "I have...".
|
|
258
|
-
- **No decorative glyphs anywhere in the comment body** - neither emotive ( ) nor status glyphs ([done] [pending] failed skipped active ). The comment is plain technical prose. Status is written in words: `[done]` / `[pending]`, and `done · active · failed · skipped · pending` in the phase strip. This applies to every channel, not only Jira - see `channels/README` note in `phase-
|
|
258
|
+
- **No decorative glyphs anywhere in the comment body** - neither emotive ( ) nor status glyphs ([done] [pending] failed skipped active ). The comment is plain technical prose. Status is written in words: `[done]` / `[pending]`, and `done · active · failed · skipped · pending` in the phase strip. This applies to every channel, not only Jira - see `channels/README` note in `phase-5-report.md`.
|
|
259
259
|
- Body content language follows `prefs.global.outputLanguage`. Code identifiers, file paths, type names, branch names, and the wiki-markup syntax stay verbatim. The `promptLanguage="en"` lock means any LLM prompt that produces the body is in English; the body itself is then rendered in the user's language.
|
|
260
260
|
- Adapter failures are non-blocking - a missing token or 401 returns `skipped`/`failed`, the loop keeps going for PR / Confluence / Wiki.
|
|
@@ -45,7 +45,7 @@ all - it is the section whose absence over there is the point.
|
|
|
45
45
|
|
|
46
46
|
**`technical`** - the account for someone holding the diff: a short paragraph on the mechanism (what the code was actually doing wrong, or what the new code does), then the per-file bullets, then one line of diff stat (`2 files, 8 deletions, 0 insertions`). Where a change is safe for a reason that is not obvious from the diff - an equality relation preserved, an invariant kept, a call site left alone deliberately - that reason belongs here in a sentence, because it is the question the reviewer would otherwise ask in a comment. Tables are welcome when several symbols share a property worth listing side by side.
|
|
47
47
|
|
|
48
|
-
The bullet list is one item per logically distinct change. Each bullet starts with the touched component and ends with a one-line "what". The source is `$WORKTREE/.pipeline/scope-check.json` `files[].reason` (Phase
|
|
48
|
+
The bullet list is one item per logically distinct change. Each bullet starts with the touched component and ends with a one-line "what". The source is `$WORKTREE/.pipeline/scope-check.json` `files[].reason` (Phase 2 Step 3.7): a file the dev could not justify there is a file this list cannot describe either, so the bullet quotes the gate output instead of inventing a reason. Use the stack's native file extensions / module paths - the example below shows the **shape**, not a stack lock-in:
|
|
49
49
|
|
|
50
50
|
```markdown
|
|
51
51
|
## Changes
|
|
@@ -135,7 +135,7 @@ The base sha matters because "it builds" is a claim about a merge base, and the
|
|
|
135
135
|
|
|
136
136
|
Pick commands for the project's stack - the pipeline supports iOS (Swift/Xcode), Android (Gradle), web (npm/pnpm/yarn) and backend (pytest/jest/go test/etc). Multi-repo PRs (one PR per repo) emit the commands for that repo's stack only - never mix iOS + Android commands into a single PR body.
|
|
137
137
|
|
|
138
|
-
**`risk`** - only when `state.diffRisk.signals` (Phase
|
|
138
|
+
**`risk`** - only when `state.diffRisk.signals` (Phase 3 Step 1.75) contains a high-stakes signal. Four fixed lines, each answered, never left as a placeholder; the source is Phase 1 `touchedAreas` plus the signals themselves, and when a signal is present the absence of this section is a Phase 4 Step 3 blocker:
|
|
139
139
|
|
|
140
140
|
```markdown
|
|
141
141
|
## Risk and Security
|
|
@@ -146,7 +146,7 @@ Pick commands for the project's stack - the pipeline supports iOS (Swift/Xcode
|
|
|
146
146
|
- Rollback: feature flag <name> | git revert <sha> | none, and why
|
|
147
147
|
```
|
|
148
148
|
|
|
149
|
-
**`visuals`** - only when `state.visualEvidence.required`. What this section can show depends on where the artefacts are hosted, which Phase
|
|
149
|
+
**`visuals`** - only when `state.visualEvidence.required`. What this section can show depends on where the artefacts are hosted, which Phase 4 resolves into `state.visualEvidence.host`. Render the form for that host and no other.
|
|
150
150
|
|
|
151
151
|
**`host: jira`.** Filenames, never URLs. A Jira attachment URL is auth-gated and renders as a broken image for anyone reading the PR outside a Jira session, and a broken image is worse than a filename because it looks like the evidence is missing.
|
|
152
152
|
|
|
@@ -192,7 +192,7 @@ Pick commands for the project's stack - the pipeline supports iOS (Swift/Xcode
|
|
|
192
192
|
|
|
193
193
|
**Video is Jira-only.** On a GitHub-hosted run no recording is made and none is published: an mp4 behind a blob link is a download, not something a reviewer opens mid-review, and paying for a recording nobody watches is worse than saying plainly that there is none. The gap line carries that reason.
|
|
194
194
|
|
|
195
|
-
Every `state.visualEvidence.gaps[]` entry becomes its own line with the reason instead of a filename (`- Before: none - the ticket carries no image attachment`). Phase
|
|
195
|
+
Every `state.visualEvidence.gaps[]` entry becomes its own line with the reason instead of a filename (`- Before: none - the ticket carries no image attachment`). Phase 4 Step 3 blocks on a required artefact that is neither listed nor explained. Contract: `$HOME/.claude/multi-agent-refs/features/visual-evidence.md`.
|
|
196
196
|
|
|
197
197
|
**`dependencies`** - only when `Package.swift` / `Podfile` / `build.gradle` / `package.json` changed. Each entry: `package@old → new - reason`.
|
|
198
198
|
|
|
@@ -64,4 +64,4 @@ Adapter implementation chooses the right git push target + commit message format
|
|
|
64
64
|
- Screenshots cover light/dark + LTR/RTL - wiki adapter refuses to commit if any quadrant is missing.
|
|
65
65
|
- Body content language follows `prefs.global.outputLanguage`. Code identifiers, file paths, type names, design token names, and Markdown formatting stay verbatim across languages (wiki pages are `.md` files - "wiki markup" in this doc set means Jira's dialect, which never appears here). The template (this doc) is English because `promptLanguage="en"` is locked.
|
|
66
66
|
- No decorative/emotive emoji or smileys ( ) in the page prose. Only functional/structural marks a fixed template defines are allowed.
|
|
67
|
-
- Autopilot always pauses at the channels menu (per `phase-
|
|
67
|
+
- Autopilot always pauses at the channels menu (per `phase-5-report.md` autopilot contract) - even in autopilot mode the user gets to confirm wiki scope.
|
|
@@ -13,7 +13,7 @@
|
|
|
13
13
|
|
|
14
14
|
> **TLDR** - When `taskType === "component"` (Figma URL in task description or instruction-driven figma workflow), multi-agent Phase 3 **does not run the TDD loop**. It delegates the entire phase to the enabled `ai-<platform>-toolkit` **marketplace plugin's** component skill (`create-component`, falling back to `create-ui-component`) via the Skill tool. Implementation lives in the plugin; multi-agent's job is classification, dispatch, and state report. The pipeline no longer bundles its own `figma-to-component` orchestrator - component skills live in one place, the plugin marketplace.
|
|
15
15
|
|
|
16
|
-
This doc is referenced from `$HOME/.claude/multi-agent-refs/phases/phase-
|
|
16
|
+
This doc is referenced from `$HOME/.claude/multi-agent-refs/phases/phase-2-dev.md`. Keeping it separate lets `phase-2-dev.md` remain tight (it's already the largest phase doc) and gives the orchestrator-report contract a stable URL for both Claude-side and Copilot-side implementations.
|
|
17
17
|
|
|
18
18
|
## Entry conditions
|
|
19
19
|
|
|
@@ -122,9 +122,9 @@ On failure (the plugin skill returns an unrecoverable build/test error, or the d
|
|
|
122
122
|
|
|
123
123
|
## Short-run behaviour
|
|
124
124
|
|
|
125
|
-
When the Phase 0 Step 7.5 depth picker answered Short (`state.onlyDevelop === true`), the dispatch layer passes `mode: "dev"` so the plugin skill can elide unit tests and wiki (structural + snapshot still required; wiki deferred to Phase
|
|
125
|
+
When the Phase 0 Step 7.5 depth picker answered Short (`state.onlyDevelop === true`), the dispatch layer passes `mode: "dev"` so the plugin skill can elide unit tests and wiki (structural + snapshot still required; wiki deferred to Phase 5). If the plugin does not honor a `mode` hint, dispatch simply skips the post-build wiki step itself.
|
|
126
126
|
|
|
127
|
-
Phase
|
|
127
|
+
Phase 3 runs in a Short run as it does in a Full one, and its reviewer count is **not** Phase 3's concern - the Step 1.77 scope gate decides that from diff risk, independently of `mode`. What the dispatch layer owes Phase 4 is the record of which plugin skill it delegated to, appended to `state.telemetry.skillCalls[]`, so the review can check the delivered component against the criteria that skill imposes.
|
|
128
128
|
|
|
129
129
|
## Cross-CLI behaviour (intentional divergence)
|
|
130
130
|
|
|
@@ -1,9 +1,10 @@
|
|
|
1
1
|
# Cross-CLI Contract (Claude Code · Copilot CLI · Codex CLI)
|
|
2
2
|
|
|
3
3
|
<!-- toc -->
|
|
4
|
-
- [1. Command Inventory (
|
|
4
|
+
- [1. Command Inventory (60 commands)](#1-command-inventory-60-commands)
|
|
5
5
|
- [2. Canonical Placeholder Vocabulary](#2-canonical-placeholder-vocabulary)
|
|
6
6
|
- [2.6 Intentional structural divergence - thin dispatcher vs inlined orchestrator](#26-intentional-structural-divergence---thin-dispatcher-vs-inlined-orchestrator)
|
|
7
|
+
- [2.7 One command, three different meanings: `/multi-agent:model`](#27-one-command-three-different-meanings-multi-agentmodel)
|
|
7
8
|
- [3. Frontmatter Transform Rules (Claude ↔ Copilot)](#3-frontmatter-transform-rules-claude-copilot)
|
|
8
9
|
- [4. Progress Signalling Parity](#4-progress-signalling-parity)
|
|
9
10
|
- [5. Argument Parsing Invariants](#5-argument-parsing-invariants)
|
|
@@ -19,16 +20,17 @@
|
|
|
19
20
|
|
|
20
21
|
---
|
|
21
22
|
|
|
22
|
-
## 1. Command Inventory (
|
|
23
|
+
## 1. Command Inventory (60 commands)
|
|
23
24
|
|
|
24
25
|
```
|
|
25
26
|
analysis, analysis-jira, analysis-resolve, autopilot, autopilot-off,
|
|
26
27
|
autopilot-on, autopilot-status, build-optimize, channels, complaint-analysis,
|
|
27
28
|
create-jira, design-check, diff-explain, doctor, feedback, forget,
|
|
28
29
|
garbage-collect, graph, help, ios-coding-standard, issue, jira, kill,
|
|
29
|
-
language, local, local-autopilot, log, manual-test, prune-logs,
|
|
30
|
+
language, local, local-autopilot, log, manual-test, model, prune-logs,
|
|
30
31
|
prune-prompts, purge, refactor, resume, resume-local, review,
|
|
31
|
-
review-analysis, review-issue, review-jira,
|
|
32
|
+
review-analysis, review-issue, review-jira, route-off, route-on,
|
|
33
|
+
route-status, routines, save, scan, search,
|
|
32
34
|
setup, stack, status, steer, store-ready, sync, test, test-accessibility,
|
|
33
35
|
test-dark-mode, test-dynamic-type, test-screenshots, testflight-validation,
|
|
34
36
|
uninstall, update
|
|
@@ -199,7 +201,7 @@ on skill directories would demand exactly the layout that breaks it.
|
|
|
199
201
|
|
|
200
202
|
**What must stay identical** (byte-level) across the two files:
|
|
201
203
|
|
|
202
|
-
- Phase canonical labels (Phase 0-
|
|
204
|
+
- Phase canonical labels (Phase 0-5)
|
|
203
205
|
- Input parsing table (Section 5 of this doc)
|
|
204
206
|
- Routing decisions for each input type
|
|
205
207
|
- Placeholder vocabulary (Section 2 of this doc)
|
|
@@ -216,7 +218,7 @@ Future changes that break an item in the "stay identical" list must update **bot
|
|
|
216
218
|
|
|
217
219
|
### Panel diversity per host
|
|
218
220
|
|
|
219
|
-
Phase
|
|
221
|
+
Phase 3 runs three reviewers everywhere, but the diversity those three buy is not the
|
|
220
222
|
same on every host. Copilot CLI gets cross-VENDOR disagreement for free: GPT-5.4 sits
|
|
221
223
|
beside two Claude models. Claude Code and Codex each run a one-vendor panel - three
|
|
222
224
|
Anthropic models on one, three OpenAI models on the other - so the same three-way
|
|
@@ -236,6 +238,29 @@ members available there are closer to each other than Fable and Sonnet are. That
|
|
|
236
238
|
weaker axis, not an equivalent one, and treating it as equivalent is the error this
|
|
237
239
|
section exists to prevent.
|
|
238
240
|
|
|
241
|
+
## 2.7 One command, three different meanings: `/multi-agent:model`
|
|
242
|
+
|
|
243
|
+
Most commands do the same thing on all three hosts. This one does not, and the
|
|
244
|
+
divergence is stated here rather than discovered at runtime, because a command
|
|
245
|
+
that quietly no-ops is worse than one that says it cannot act.
|
|
246
|
+
|
|
247
|
+
| Host | What `model on|off` does | Why |
|
|
248
|
+
|---|---|---|
|
|
249
|
+
| Claude Code | live switch: flips `modelFallback.fableEnabled` and realigns `costBudget.pricingModel` | the only host where the `fable` rung is Fable 5 |
|
|
250
|
+
| Copilot CLI | writes the preference, changes no dispatch | Fable 5 is not offered there; its personas never sat on this rung |
|
|
251
|
+
| Codex CLI | writes the preference, changes no dispatch, **deliberately** | the `fable` rung on Codex means `gpt-5.6 @ xhigh` - a different model on a different account. A knob named after an Anthropic model must not silently retune a Codex run |
|
|
252
|
+
|
|
253
|
+
`model-rung.sh` prints which of the three it is on every invocation. The rule it
|
|
254
|
+
follows: report the host's actual behaviour, never claim a change that did not
|
|
255
|
+
happen.
|
|
256
|
+
|
|
257
|
+
The routing trio (`route-on`, `route-off`, `route-status`) has no such split -
|
|
258
|
+
it writes `prefs.global.modelRouting` identically everywhere. Its honest limit is
|
|
259
|
+
different and applies on every host: a subagent cannot be dispatched to a
|
|
260
|
+
non-Anthropic model, because subagent dispatch belongs to the host. External
|
|
261
|
+
providers are reachable only where the pipeline makes the HTTP call itself
|
|
262
|
+
(`bulk-read.sh`, `research_ask`). `route-status` prints that on every run.
|
|
263
|
+
|
|
239
264
|
## 3. Frontmatter Transform Rules (Claude ↔ Copilot)
|
|
240
265
|
|
|
241
266
|
Each file has a different frontmatter schema. The sync flow transforms between them:
|
|
@@ -9,7 +9,7 @@
|
|
|
9
9
|
- [Two more things a long-running runner needs](#two-more-things-a-long-running-runner-needs)
|
|
10
10
|
<!-- /toc -->
|
|
11
11
|
|
|
12
|
-
**Pattern**: autopilot runs with zero interaction, which is exactly when a silent failure loop is most expensive - an agent can burn a budget re-attempting the same broken fix, or thrash between two phases, with nobody watching. A circuit-breaker converts "keep going no matter what" into "keep going until a defined unsafe condition, then halt and hand back to the user." This is the sanctioned autopilot pause (same class as the Phase
|
|
12
|
+
**Pattern**: autopilot runs with zero interaction, which is exactly when a silent failure loop is most expensive - an agent can burn a budget re-attempting the same broken fix, or thrash between two phases, with nobody watching. A circuit-breaker converts "keep going no matter what" into "keep going until a defined unsafe condition, then halt and hand back to the user." This is the sanctioned autopilot pause (same class as the Phase 5 channels pause): the run stops, records why, and waits for an explicit `resume`.
|
|
13
13
|
|
|
14
14
|
**Gated by `prefs.global.autopilotCircuitBreaker`** (`enabled` default true, `identicalFindingCycles` default 2, `maxReworkCycles` default 3; `schemas/prefs.schema.json`). Halting is always safe, so the breaker itself defaults on. Disable per-run only with an explicit override. Complements, does not replace, the existing autopilot safety rules (build-fail max 3 retries, Phase 4 blocking-finding rework, destructive-op confirmations).
|
|
15
15
|
|
|
@@ -23,7 +23,7 @@ Any one trips the breaker. All are evaluated from `agent-state.json` + telemetry
|
|
|
23
23
|
| 2 | **Identical repeated failure** | same normalized build-error signature, or the same Phase 4 finding fingerprint, recurs across consecutive Phase 3 rework cycles | 2 cycles |
|
|
24
24
|
| 3 | **Rework storm** | Phase 4 -> Phase 3 rework cycles exceed the cap (distinct from the build-retry cap) | `maxReworkCycles` = 3 |
|
|
25
25
|
| 4 | **Cost drift** | cumulative spend crosses the `costBudget` ceiling, or the projected next-phase spend would exceed it, after model-fallback has already downgraded | `costBudget` ceiling |
|
|
26
|
-
| 5 | **Merge/rebase conflict** | Phase
|
|
26
|
+
| 5 | **Merge/rebase conflict** | Phase 4 push blocked by a conflict that requires history reconciliation | any conflict |
|
|
27
27
|
|
|
28
28
|
Trigger 2 is the key addition over the plain build-retry cap: a build can "fail differently" three times (legitimate iteration) or "fail identically" twice (stuck). Only the identical-failure case is a stall; the retry cap catches the rest.
|
|
29
29
|
|
|
@@ -31,12 +31,12 @@ Trigger 2 is the key addition over the plain build-retry cap: a build can "fail
|
|
|
31
31
|
|
|
32
32
|
| Trigger | Evaluated by | Status |
|
|
33
33
|
|---|---|---|
|
|
34
|
-
| 2, finding half | `review-delta.mjs` exit 3 at Phase
|
|
34
|
+
| 2, finding half | `review-delta.mjs` exit 3 at Phase 3 Step 3.8: a blocking/important finding whose `fingerprint` (finding-fingerprint.mjs) stays in the accepted set for `identicalFindingCycles` consecutive rounds | **code** (v16.20.0) |
|
|
35
35
|
| 3 | Phase 3 re-entry item 6: the `retryCount === 3` hard-kill records the trip | **code** (v16.20.0) |
|
|
36
36
|
| 2, build-error half | needs a build-log signature normaliser | documented behaviour, no script yet |
|
|
37
37
|
| 1 | needs checkpoint-to-checkpoint artifact diffing | documented behaviour, no script yet |
|
|
38
38
|
| 4 | belongs to `cost-budget-check.mjs` | documented behaviour, no script yet |
|
|
39
|
-
| 5 | Phase
|
|
39
|
+
| 5 | Phase 4 push | documented behaviour, no script yet |
|
|
40
40
|
|
|
41
41
|
State shape: `state.circuitBreaker = {tripped, trigger, detail, checkpoint: {phase, step, iteration}, trippedAt, counters: {identicalFindingCycles, reworkCycles}}` (`schemas/agent-state.schema.json`). The per-round classification the finding half reads lives in `state.reviewIterations[i].delta` (`new`, `stillPresent`, `resolved`, `downgraded`, `recurrence`, `plateau`). `smoke-autopilot-circuit-breaker.sh` asserts the schema fields, the scripts and the phase wiring, not only this prose.
|
|
42
42
|
|
|
@@ -1,8 +1,8 @@
|
|
|
1
|
-
## Code Graph (Phase 1 Step 2.6 + Phase
|
|
1
|
+
## Code Graph (Phase 1 Step 2.6 + Phase 5 Step 3)
|
|
2
2
|
|
|
3
3
|
<!-- toc -->
|
|
4
4
|
- [Phase 1 Step 2.6 - query before dispatching Explore](#phase-1-step-26---query-before-dispatching-explore)
|
|
5
|
-
- [Phase
|
|
5
|
+
- [Phase 5 Step 3 - refresh after the branch changed code](#phase-5-step-3---refresh-after-the-branch-changed-code)
|
|
6
6
|
- [What the report answers that a file-level view cannot](#what-the-report-answers-that-a-file-level-view-cannot)
|
|
7
7
|
- [The graph is drawable, and one place already asks for it](#the-graph-is-drawable-and-one-place-already-asks-for-it)
|
|
8
8
|
<!-- /toc -->
|
|
@@ -10,7 +10,7 @@
|
|
|
10
10
|
A deterministic, LLM-free map of what a repo declares and what refers to what,
|
|
11
11
|
written to `~/.claude/knowledge/<project>/code-graph.json`. Gated by
|
|
12
12
|
`prefs.global.codeGraph.enabled` (default `false`); with it off, Phase 1 and
|
|
13
|
-
Phase
|
|
13
|
+
Phase 5 behave exactly as they did before. Design, trade and measurements:
|
|
14
14
|
`docs/adr/0010-own-code-graph.md`.
|
|
15
15
|
|
|
16
16
|
### Phase 1 Step 2.6 - query before dispatching Explore
|
|
@@ -38,7 +38,7 @@ at a graph that was never built. Pass it.
|
|
|
38
38
|
|
|
39
39
|
Build when there is no graph at all, and when `baseCommit` no longer matches
|
|
40
40
|
HEAD. The missing case is the one that matters in practice: `architecture.md`
|
|
41
|
-
and its siblings are written in Phase
|
|
41
|
+
and its siblings are written in Phase 5, which is the phase a run is least
|
|
42
42
|
likely to reach, so a repo can have a long history of tasks and an empty
|
|
43
43
|
knowledge directory. The graph must not inherit that. `--status` exits 1 on a
|
|
44
44
|
missing file, and that exit means build, not skip.
|
|
@@ -56,7 +56,7 @@ already spells out. Measured on a 4,300-file Swift app at a fixed 30k retrieval
|
|
|
56
56
|
budget, it roughly doubled coverage at under half the cost on domain-word
|
|
57
57
|
questions and lost narrowly to `grep -lw` on exact type names.
|
|
58
58
|
|
|
59
|
-
### Phase
|
|
59
|
+
### Phase 5 Step 3 - refresh after the branch changed code
|
|
60
60
|
|
|
61
61
|
Runs when `prefs.global.codeGraph.enabled` and `prefs.global.codeGraph.autoRefresh`
|
|
62
62
|
are both true.
|
|
@@ -21,7 +21,7 @@ Derived generically from an upstream corporate screen-QA tool (recorded in
|
|
|
21
21
|
catalogs and product examples are not, and were not taken - section 7 says what
|
|
22
22
|
replaces them.
|
|
23
23
|
|
|
24
|
-
Consumers: `/multi-agent:design-check` (the runner), Phase
|
|
24
|
+
Consumers: `/multi-agent:design-check` (the runner), Phase 3 review when a UI
|
|
25
25
|
diff is under review, and `features/visual-evidence.md` when a capture has to
|
|
26
26
|
prove a fix. Gate: `smoke-design-conformance.sh`.
|
|
27
27
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
|
-
# Feature: Dev Critic (Phase
|
|
1
|
+
# Feature: Dev Critic (Phase 2 Step 3.5 Evaluator-Optimizer)
|
|
2
2
|
|
|
3
|
-
**Pattern**: Anthropic's evaluator-optimizer from "Building Effective Agents" (Dec 2024). Generator (Phase
|
|
3
|
+
**Pattern**: Anthropic's evaluator-optimizer from "Building Effective Agents" (Dec 2024). Generator (Phase 2 Dev) and critic (`agents/dev-critic.md`) loop on deterministic criteria already written in `rules/*.md` before any Phase 3 reviewer call.
|
|
4
4
|
|
|
5
5
|
**Gated by `prefs.global.devCritic.enabled`** (default: `false`). When enabled, after the generator's last edit and BEFORE Phase 4:
|
|
6
6
|
|
|
@@ -25,7 +25,7 @@
|
|
|
25
25
|
|
|
26
26
|
## Telemetry
|
|
27
27
|
|
|
28
|
-
Each critic call emits `dev_critic.call` with `iteration`, `pass`, `gates_failed`, `blocking`, `important`, `duration_ms`, `tokens_in/out`. Phase
|
|
28
|
+
Each critic call emits `dev_critic.call` with `iteration`, `pass`, `gates_failed`, `blocking`, `important`, `duration_ms`, `tokens_in/out`. Phase 5 cost rollup lists these as `phase 3.5` line items so the net saving (Phase 3 reviewer/triage calls avoided) is measurable.
|
|
29
29
|
|
|
30
30
|
## Off by default reason
|
|
31
31
|
|
|
@@ -153,7 +153,7 @@ after the user has already answered the pickers.
|
|
|
153
153
|
### identity
|
|
154
154
|
|
|
155
155
|
A git identity resolves for the account the run would commit as. WARN: the run
|
|
156
|
-
reaches Phase
|
|
156
|
+
reaches Phase 4 and stops there.
|
|
157
157
|
|
|
158
158
|
### hook-coverage
|
|
159
159
|
|
|
@@ -246,7 +246,7 @@ file it was writing at the time.
|
|
|
246
246
|
|
|
247
247
|
Worktrees left under `<repo>/.worktrees/` in the repository the caller is
|
|
248
248
|
standing in. WARN at five or more, or at 2 GB. A finished task removes its own
|
|
249
|
-
worktree at PR time, but a run that stops before Phase
|
|
249
|
+
worktree at PR time, but a run that stops before Phase 4 never reaches that
|
|
250
250
|
step and nothing else collects it: the finalizer only runs on success, and
|
|
251
251
|
`gc-worktrees` only sweeps entries git has already forgotten. Each survivor is
|
|
252
252
|
a full second checkout, so the total is measured in gigabytes rather than
|
|
@@ -54,7 +54,7 @@ ticket that referenced nothing. The run then produced a plan from a partial pict
|
|
|
54
54
|
reported success, and the user found out by reading the output.
|
|
55
55
|
|
|
56
56
|
So on exit `3`, classify the stderr and surface an `AskUserQuestion` before continuing.
|
|
57
|
-
The classification is the same shape the Phase
|
|
57
|
+
The classification is the same shape the Phase 4 remote gate uses, because the failures
|
|
58
58
|
are the same failures:
|
|
59
59
|
|
|
60
60
|
| stderr signal | Diagnosis | Question offers |
|
|
@@ -78,14 +78,14 @@ Rules that make this actionable rather than decorative:
|
|
|
78
78
|
"planned without Crashlytics, user's choice at <ts>" in the analysis doc's limitations
|
|
79
79
|
section instead of leaving a silent hole.
|
|
80
80
|
5. **Autopilot still reports.** Autopilot takes "continue without this source" without
|
|
81
|
-
asking, but the skipped source is logged and carried into the Phase
|
|
81
|
+
asking, but the skipped source is logged and carried into the Phase 5 report. An
|
|
82
82
|
autopilot run that quietly planned from a partial picture is the same defect with a
|
|
83
83
|
flag on it.
|
|
84
84
|
|
|
85
85
|
Failures remain non-fatal at Phase 1 by default - the agent still runs analysis. What
|
|
86
86
|
changed is that the user learns about it while the choice is still theirs to make.
|
|
87
87
|
|
|
88
|
-
**Graylog specifics.** `fetch-graylog.sh` degrades to empty on any network/VPN failure: it emits a normalized empty object and exits `0`, so an unreachable host reads as `{status:"skipped", reason:"vpn-unreachable"}` and never blocks. **Exiting `0` is not permission to stay quiet.** The payload carries `degraded: true` and a `degradeReason`; when it does, log one line naming the host and the reason, and carry it into the Phase
|
|
88
|
+
**Graylog specifics.** `fetch-graylog.sh` degrades to empty on any network/VPN failure: it emits a normalized empty object and exits `0`, so an unreachable host reads as `{status:"skipped", reason:"vpn-unreachable"}` and never blocks. **Exiting `0` is not permission to stay quiet.** The payload carries `degraded: true` and a `degradeReason`; when it does, log one line naming the host and the reason, and carry it into the Phase 5 report. Logs are advisory, so this never asks a question and never blocks - but "I searched the logs and found nothing" and "I never reached the log server" are different statements, and only one of them is true. Only a genuine auth rejection on a reachable host exits `3` (marked `failed`, still non-fatal here). `state.graylogContext` is prepended to the analysis prompt inside the **Referenced External Sources** section as diagnostic context that is **advisory only** - the agent may use it to orient on a reported error, but code remains ground truth, and there is no Phase 3 review gate for logs.
|
|
89
89
|
|
|
90
90
|
## Prompt injection shape
|
|
91
91
|
|
|
@@ -128,15 +128,15 @@ maturity step has `currentPhase: 0`, so resuming would start at Phase 1 and skip
|
|
|
128
128
|
the check - the halt would be permanent in the one direction that matters.
|
|
129
129
|
|
|
130
130
|
So resume reads `state.waitingFor` first: when it names a step, the run re-enters
|
|
131
|
-
THAT step rather than the next phase. `waitingFor` already existed and Phase
|
|
131
|
+
THAT step rather than the next phase. `waitingFor` already existed and Phase 5's
|
|
132
132
|
channels pause already documented itself as resumable through it
|
|
133
|
-
(`phases/phase-
|
|
133
|
+
(`phases/phase-5-report.md`), while `resume/SKILL.md` never mentioned the field -
|
|
134
134
|
so that pause had the same gap and this fixes both.
|
|
135
135
|
|
|
136
136
|
| `waitingFor` | Re-entry |
|
|
137
137
|
|---|---|
|
|
138
138
|
| `maturity` | Phase 0, the maturity step, with the item re-fetched |
|
|
139
|
-
| `user-channels-choice` | Phase
|
|
139
|
+
| `user-channels-choice` | Phase 5, the channels menu |
|
|
140
140
|
| absent | `currentPhase + 1`, as before |
|
|
141
141
|
|
|
142
142
|
`waitingFor` is cleared by the write that records the answer. A field that
|
|
@@ -42,7 +42,7 @@ architect/reviewer roles with no file edits.
|
|
|
42
42
|
Personas and dispatch read the **rung** (`fable`, `opus`, `sonnet`, `haiku`). The wire
|
|
43
43
|
model ID each rung resolves to lives in exactly two places: `scripts/cost-table.json`
|
|
44
44
|
(`prices.<rung>.modelId`) and the per-host reviewer table in
|
|
45
|
-
`phases/phase-
|
|
45
|
+
`phases/phase-3-review.md`. A generation move edits those; it never renames a rung and
|
|
46
46
|
never touches a persona file.
|
|
47
47
|
|
|
48
48
|
Current resolution: `fable` -> `claude-fable-5`, `opus` -> `claude-opus-5`,
|
|
@@ -61,7 +61,7 @@ Three shifts on the current opus rung are worth knowing when reading a run that
|
|
|
61
61
|
different rather than broken, and none of them are bugs in this contract:
|
|
62
62
|
|
|
63
63
|
- **Longer user-facing output.** Effort is not the lever; prompt-level conciseness is.
|
|
64
|
-
Phase
|
|
64
|
+
Phase 5 report length and reviewer prose are where this shows.
|
|
65
65
|
- **Self-verification without being asked.** Explicit "double-check your work"
|
|
66
66
|
scaffolding now causes over-verification rather than preventing under-verification.
|
|
67
67
|
Phase 4's deterministic gates already carry that load.
|
|
@@ -162,7 +162,7 @@ prints it once instead:
|
|
|
162
162
|
with `PHASE_MODEL_OVERRIDE=<floorModel>`. A failure at the floor (or when no
|
|
163
163
|
floor is configured) falls through to the normal phase-error path (pause ->
|
|
164
164
|
resume). Never silent-skip the persona. Each downgrade emits its own
|
|
165
|
-
`model_fallback` metric line so a two-step degrade is visible in Phase
|
|
165
|
+
`model_fallback` metric line so a two-step degrade is visible in Phase 5.
|
|
166
166
|
3. **Cost budget ceiling (existing gate).** When `cost-budget-check.mjs` exits 11
|
|
167
167
|
(exceeded) mid-run, the run already pauses per the cost-budget contract; on
|
|
168
168
|
user-approved continue, `preferredModel` personas downgrade to `fallbackModel` for the
|
|
@@ -172,7 +172,7 @@ prints it once instead:
|
|
|
172
172
|
|
|
173
173
|
Every fallback emits one `log-metric.sh` line (`metric: model_fallback`,
|
|
174
174
|
attributes: `persona`, `from`, `to`, `trigger: date-gate|dispatch-error|budget`)
|
|
175
|
-
and one agent-log line so Phase
|
|
175
|
+
and one agent-log line so Phase 5 reports show which phases ran degraded.
|
|
176
176
|
The cost ledger prices the dispatch at the model actually used (the tracker's
|
|
177
177
|
per-phase `model` field already carries the override).
|
|
178
178
|
|
|
@@ -213,5 +213,5 @@ parent model and reasoning effort and silently discards the override, so a
|
|
|
213
213
|
fallback that omits it appears to apply while changing nothing.
|
|
214
214
|
|
|
215
215
|
The three model ids above live in exactly three places - this table,
|
|
216
|
-
`pipeline/scripts/cost-table.json`, and the Phase
|
|
216
|
+
`pipeline/scripts/cost-table.json`, and the Phase 3 reviewer matrix - so an OpenAI
|
|
217
217
|
rename is a three-file change.
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Feature: Plan Todos Iteration (Phase 3)
|
|
2
2
|
|
|
3
|
-
**Gated by `prefs.global.planTodos.enabled`** (default: `false`). When enabled and Phase
|
|
3
|
+
**Gated by `prefs.global.planTodos.enabled`** (default: `false`). When enabled and Phase 1 Step 11 emitted a `plan.todos[]` (conforming to `$HOME/.claude/schemas/plan-todos.schema.json`), Phase 2 iterates with the helper instead of walking `tasks[]` directly:
|
|
4
4
|
|
|
5
5
|
```bash
|
|
6
6
|
while next=$(bash "$HOME/.claude/lib/plan-todos.sh" next "$TASK_ID"); [ -n "$next" ]; do
|
|
@@ -23,7 +23,7 @@ fi
|
|
|
23
23
|
- **Deterministic** - same worktree state → same map. No embeddings, no network. Sub-second on monorepos.
|
|
24
24
|
- **Advisory** - Explore agents may ignore the map if they have stronger signals (Phase 0 knowledge cache, explicit user context). Never gates the pipeline.
|
|
25
25
|
- **Truncation-safe** - output is capped at `tokenBudget`; the script falls back to "no files extracted within budget" rather than over-spending.
|
|
26
|
-
- **Cost ledger** - emit `phase-1.repo_map_emitted bytes=$(wc -c <<<"$REPO_MAP") budget=$BUDGET` so Phase
|
|
26
|
+
- **Cost ledger** - emit `phase-1.repo_map_emitted bytes=$(wc -c <<<"$REPO_MAP") budget=$BUDGET` so Phase 5 cost summary can show the size injected.
|
|
27
27
|
|
|
28
28
|
## When to enable
|
|
29
29
|
|
|
@@ -6,7 +6,7 @@ Gated by `prefs.global.autopilotCircuitBreaker` (`enabled` default true, `identi
|
|
|
6
6
|
|
|
7
7
|
## Files per round
|
|
8
8
|
|
|
9
|
-
Phase
|
|
9
|
+
Phase 3 Step 3.2.1 writes `$WORKTREE/.pipeline/triage-round-<N>.json` (N = `state.reviewIterations | length`), validates it, annotates it and copies it to `$WORKTREE/triage-output.json`, the name Phase 5, `worktree-finalize.sh`, `render-work-summary.sh` and `diff-explain.mjs` read. A copy rather than a symlink because the salvage is `cp -R`, and `.pipeline/` is on the salvage list, so every round survives into `artifactsPath`. Step 3.7 rewrites the round file; the copy is repeated after it.
|
|
10
10
|
|
|
11
11
|
## Step 2.1 block: previous-round findings (iteration >= 2)
|
|
12
12
|
|
|
@@ -34,7 +34,7 @@ The cap of 40 entries drops `important` before `blocking` so the prefix stays bo
|
|
|
34
34
|
|
|
35
35
|
## Step 2.2 block: scope self-check (every iteration)
|
|
36
36
|
|
|
37
|
-
Phase
|
|
37
|
+
Phase 2 Step 3.7 wrote `$WORKTREE/.pipeline/scope-check.json` (contract: `features/scope-check.md`). Render it so reviewers judge the diff against the dev's stated scope and do not re-propose what was rejected:
|
|
38
38
|
|
|
39
39
|
```bash
|
|
40
40
|
SCOPE_JSON="$WORKTREE/.pipeline/scope-check.json"
|
|
@@ -82,7 +82,7 @@ Same argument `shortId()` in `_retrieval.mjs` makes for corpus rows: derived fro
|
|
|
82
82
|
|
|
83
83
|
## Telemetry
|
|
84
84
|
|
|
85
|
-
`review.delta` once per iteration >= 2: `iteration`, `new`, `still_present`, `resolved`, `plateau`, `tripped`. `run-metrics.mjs` reports `reviewDelta.stillPresentFinal`, `resolvedTotal` and `tripped`; Phase
|
|
85
|
+
`review.delta` once per iteration >= 2: `iteration`, `new`, `still_present`, `resolved`, `plateau`, `tripped`. `run-metrics.mjs` reports `reviewDelta.stillPresentFinal`, `resolvedTotal` and `tripped`; Phase 5 renders the three counts per round.
|
|
86
86
|
|
|
87
87
|
## Reference
|
|
88
88
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# Phase 4 Review - Multi-Repo Mode
|
|
2
2
|
|
|
3
|
-
> Loaded on demand from `phases/phase-
|
|
3
|
+
> Loaded on demand from `phases/phase-3-review.md`. Conditional on
|
|
4
4
|
> `state.projects[].length > 1`; a single-repo run (the common case) never needs
|
|
5
5
|
> it and used to pay for it on every review.
|
|
6
6
|
|
|
@@ -1,6 +1,6 @@
|
|
|
1
|
-
# Feature: Scope self-check (Phase
|
|
1
|
+
# Feature: Scope self-check (Phase 2 Step 3.7)
|
|
2
2
|
|
|
3
|
-
**Pattern**: Phase
|
|
3
|
+
**Pattern**: Phase 3 reconstructs everything from the diff. The one thing it cannot reconstruct is why each file was touched and what was left out on purpose, so Dev states both before the handoff, and a deterministic gate checks the statement against the real diff. The record also carries the code-simplifier rationales (Step 3.6) that used to be discarded, and it feeds two later consumers: the `<scope-self-check>` block in the Phase 3 reviewer prefix and the PR body in Phase 4.
|
|
4
4
|
|
|
5
5
|
## The record
|
|
6
6
|
|
|
@@ -33,8 +33,8 @@ Output `{ok, justified, unjustified[], unlisted[], notDone}`. Exit 1 lists `unju
|
|
|
33
33
|
|
|
34
34
|
## Consumers
|
|
35
35
|
|
|
36
|
-
- Phase
|
|
37
|
-
- Phase
|
|
36
|
+
- Phase 3 Step 2.2 renders file reasons, unjustified files and `notDone[]` into the shared reviewer prefix (`features/review-delta.md`).
|
|
37
|
+
- Phase 4 Step 3 builds the PR `## Changes` bullets from `files[].reason` and lists `notDone[]` under `## Related` as "Follow-ups not done in this PR", merged with the final triage `deferred[]` (`channels/pr.md`).
|
|
38
38
|
|
|
39
39
|
## Reference
|
|
40
40
|
|
|
@@ -13,7 +13,7 @@
|
|
|
13
13
|
- [Preference](#preference)
|
|
14
14
|
<!-- /toc -->
|
|
15
15
|
|
|
16
|
-
> **TLDR** - Phase
|
|
16
|
+
> **TLDR** - Phase 3 Step 1.78 resolves, deterministically and before any reviewer runs, WHAT the changed code was supposed to honour: declared rule registries scoped to the diff's languages, in-repo module guides, and the toolchains those registries delegate to. The result is `criteria-manifest.json`: a bounded set of rule IDs that becomes the denominator for "was this applied completely". Reviewers answer per rule ID. An ID that is neither checked nor explicitly waived fails the stage.
|
|
17
17
|
|
|
18
18
|
## Why this exists
|
|
19
19
|
|
|
@@ -88,7 +88,7 @@ Cheap, language-agnostic, and it answers "completely" head on - an exception i
|
|
|
88
88
|
|---|---|
|
|
89
89
|
| `detectedStack` (Phase 1) | language census of the diff by file extension. Describes what the diff CONTAINS, not what the repo is nominally built in, so one Objective-C bridging file in a Swift repo is classified correctly |
|
|
90
90
|
| Phase 1 analysis summary (triage scope) | the task description plus the inline task list Phase 3 generated for itself |
|
|
91
|
-
| Phase
|
|
91
|
+
| Phase 1 plan | same inline task list |
|
|
92
92
|
| `state.evidence.figma[]` (Step 1.8) | recorded as `not-applicable (no Phase 1 evidence)` |
|
|
93
93
|
| Step 2.8 visual conformance | recorded as `not-applicable (no Phase 1 evidence)` |
|
|
94
94
|
|
|
@@ -67,7 +67,7 @@ Append one `state.telemetry.skillCalls[]` entry per skill actually loaded:
|
|
|
67
67
|
|
|
68
68
|
`routedBy` names the index and version that chose it. That is the difference between "the model happened to read a skill" and "the toolkit said this skill governs this task".
|
|
69
69
|
|
|
70
|
-
What Phase 4 actually does with it, precisely: Step 1.78 lists these entries in the manifest under `ledger.routedByToolkit`, so a reviewer and the Phase
|
|
70
|
+
What Phase 4 actually does with it, precisely: Step 1.78 lists these entries in the manifest under `ledger.routedByToolkit`, so a reviewer and the Phase 5 report can see which skills the project's own toolkit selected. It does **not** give them extra weight in the coverage maths. The deterministic resolver stays primary because an unrecorded load and no load are indistinguishable in state, and no `routedBy` tag changes that - the tag says who chose the skill, not that the code honoured it.
|
|
71
71
|
|
|
72
72
|
## Failure modes, and why none of them halt
|
|
73
73
|
|