@mmerterden/multi-agent-pipeline 12.9.0 → 12.10.0

package/CHANGELOG.md

@@ -16,6 +16,59 @@ Internal file-layout changes that don't affect the slash-command surface are sti
 
 ## [Unreleased]
 
+## [12.10.0] - 2026-07-26
+
+Two pieces of abandoned residue, and a gate that had inverted.
+
+### `~/.multi-agent/` is pruned on install
+
+The "shared runtime" the Cursor / Antigravity / VS Code Copilot Chat adapters
+needed, so their emitted agents could reach the gate scripts by absolute path.
+Those adapters were deleted in v10.7.0 along with `installSharedRuntime`,
+`_base.mjs`, `rewriteScriptRefs` and `smoke-shared-runtime.sh` - but not the tree
+they had written. 222 files (174 scripts, 23 lib, 24 schemas) sat frozen at
+whatever the last adapter-era install produced.
+
+It is worse than dead weight because it is indistinguishable from a live install
+when you look at it: same directory names, same file names. Its
+`schemas/migrations/` is missing `prefs-2.3.0-to-2.4.0.mjs`, so reading it gives a
+migration chain three versions short and a reasonable conclusion that the chain
+itself is stale.
+
+`ABANDONED_TREES` now takes `root: "home"` entries for trees beside `~/.claude`
+rather than inside it, and 253 files (this plus the 31 in `~/.claude/eval`) are
+removed on the next install.
+
+### The live-prefs gate was rejecting the only correct state
+
+`smoke-schema-validation.sh` step 7 read:
+
+```bash
+if [ "$LVER" = "2.1.0" ]; then pass "live prefs already v2.1.0"
+elif ... else fail "live prefs has unknown schemaVersion: $LVER"
+```
+
+`migrate-prefs.mjs` `TARGET_VERSION` had since moved to 2.4.0, which inverted the
+gate: a prefs file left behind at 2.1.0 passed as "already current", and a file
+correctly migrated to 2.4.0 fell through to the else arm and FAILED as "unknown".
+The gate rejected the fully-migrated state it exists to encourage.
+
+It now reads the target from `migrate-prefs.mjs` and the accepted set from the
+schema's own `schemaVersion` enum, so it cannot disagree with either again, and a
+known-but-older version reports how far behind it is (`v2.1.0 -> v2.4.0`) instead
+of reading as current. This is a CONSUMER smoke (`/multi-agent:update` runs it), so
+it resolves both paths through `SMOKE_DIR`, which is `pipeline/scripts` in the repo
+and `~/.claude/scripts` in an install.
+
+### Dead-file sweep
+
+Swept refs, schemas, agents, libs and scripts for files nothing references. No
+orphans. The two candidates were both false positives from the sweep's own exclude
+flags: `design-check-config.schema.json` is referenced as the instance filename by
+the design-check command, and `count-lib.sh` is sourced by two siblings inside
+`pipeline/lib/`, which the sweep had excluded. Recorded here so the next sweep does
+not re-flag them.
+
 ## [12.9.0] - 2026-07-26
 
 Context engineering follow-through, and a guard that was blocking safe commands.

package/install/_common.mjs

@@ -252,25 +252,46 @@ export function pruneLegacyMultiAgentSkills(skillsDir) {
  * neither did uninstall - 31 stale files sat there with nothing left that could
  * ever read or remove them.
  *
- * @type {ReadonlyArray<{dir: string, reason: string}>}
+ * `~/.multi-agent/` is the larger case: the "shared runtime" the Cursor /
+ * Antigravity / VS Code Copilot Chat adapters needed, so their emitted agents
+ * could reach the gate scripts by absolute path. Those adapters were deleted in
+ * v10.7.0 along with `installSharedRuntime`, `_base.mjs`, `rewriteScriptRefs` and
+ * `smoke-shared-runtime.sh` - but not the tree they wrote. 221 files (174 scripts,
+ * 23 lib, 24 schemas) frozen at whatever the last adapter-era install produced,
+ * including a migrations directory missing `prefs-2.3.0-to-2.4.0.mjs`. Browsing it
+ * looks exactly like browsing a current install, which is how it comes to be
+ * mistaken for one.
+ *
+ * `root: "home"` entries sit beside `~/.claude`, not inside it.
+ *
+ * @type {ReadonlyArray<{dir: string, root?: "claude"|"home", reason: string}>}
  */
 export const ABANDONED_TREES = Object.freeze([
   {
     dir: "eval",
     reason: "eval corpora; the harnesses that read them are maintainer-only and no longer ship",
   },
+  {
+    dir: ".multi-agent",
+    root: "home",
+    reason:
+      "shared runtime for the Cursor / Antigravity / Copilot Chat adapters, all deleted in v10.7.0",
+  },
 ]);
 
 /**
- * Remove trees an older install left behind under `root`.
+ * Remove trees an older install left behind.
  *
- * @param {string} root e.g. `$HOME/.claude`
+ * @param {string} claudeDir e.g. `$HOME/.claude`
+ * @param {string} [home] `$HOME`, for entries marked `root: "home"`. Defaults to
+ *   the parent of `claudeDir`, which is the layout every installer uses.
  * @returns {number} directories removed
  */
-export function pruneAbandonedTrees(root) {
+export function pruneAbandonedTrees(claudeDir, home = dirname(claudeDir)) {
   let removed = 0;
-  for (const { dir, reason } of ABANDONED_TREES) {
-    const target = join(root, dir);
+  for (const { dir, root, reason } of ABANDONED_TREES) {
+    const base = root === "home" ? home : claudeDir;
+    const target = join(base, dir);
     if (!existsSync(target)) continue;
     if (dryRun) {
       console.log(`    [dry-run] would remove abandoned tree ${target} (${reason})`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mmerterden/multi-agent-pipeline",
-  "version": "12.9.0",
+  "version": "12.10.0",
   "description": "8-phase AI development pipeline with full orchestration on Claude Code and Copilot CLI. Analysis, planning, TDD, CLI-aware parallel review with consensus surfacing + Fable triage, default-FAIL evidence gates, secret + intent guards, per-phase cost ledger, persistent learnings memory, wiki generation, commit automation. Token-preserving uninstall.",
   "type": "module",
   "main": "index.js",

package/pipeline/scripts/smoke-schema-validation.sh

@@ -174,14 +174,40 @@ echo ""
 echo "→ 7. Live preferences (if exists)  -  post-migration check"
 if [ -f "$LIVE_PREFS" ]; then
   LVER=$(node -e "console.log(JSON.parse(require('fs').readFileSync('$LIVE_PREFS','utf8')).schemaVersion || 'none')" 2>/dev/null)
-  if [ "$LVER" = "2.1.0" ]; then
-    pass "live prefs already v2.1.0"
-  elif [ "$LVER" = "2.0.0" ] || [ "$LVER" = "none" ]; then
-    echo "  ⓘ live prefs still $LVER  -  migration pending (Aşama 1.6)"
-    # Not a fail; migration is its own step
-    pass "live prefs present, needs migration (schemaVersion: $LVER)"
+
+  # The target is read from migrate-prefs.mjs, never hardcoded here.
+  #
+  # This block used to say `if [ "$LVER" = "2.1.0" ]; then pass "already v2.1.0"`
+  # with everything else falling through to `fail "unknown schemaVersion"`. The
+  # migration target had since moved to 2.4.0, which inverted the gate: a prefs
+  # file left behind at 2.1.0 reported PASS as "already current", while a file
+  # correctly migrated to 2.4.0 hit the else arm and FAILED as "unknown". The
+  # gate was rejecting the only fully-migrated state it exists to encourage.
+  #
+  # Reading the target from the migrator, and the accepted set from the schema
+  # enum, means this can never disagree with them again.
+  MIGRATOR="$SMOKE_DIR/migrate-prefs.mjs"
+  TARGET=$(grep -oE 'TARGET_VERSION = "[0-9.]+"' "$MIGRATOR" 2>/dev/null | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
+  KNOWN=$(node -e "
+    const s = require('$PREFS_SCHEMA');
+    process.stdout.write((s.properties.schemaVersion.enum || []).join(' '));
+  " 2>/dev/null)
+
+  if [ -z "$TARGET" ]; then
+    fail "cannot read TARGET_VERSION from migrate-prefs.mjs - the check has no reference point"
+  elif [ "$LVER" = "$TARGET" ]; then
+    pass "live prefs at the migration target (v$TARGET)"
+  elif [ "$LVER" = "none" ]; then
+    echo "  ⓘ live prefs carries no schemaVersion  -  migration pending"
+    pass "live prefs present, needs migration (schemaVersion: none)"
+  elif printf '%s\n' $KNOWN | grep -qxF "$LVER"; then
+    # A known-but-older version is legitimately "migration pending", not a
+    # failure: migration is its own install step. Say how far behind it is, so a
+    # file sitting three versions back is visible instead of reading as current.
+    echo "  ⓘ live prefs at v$LVER, target v$TARGET  -  migration pending"
+    pass "live prefs present, needs migration (v$LVER -> v$TARGET)"
   else
-    fail "live prefs has unknown schemaVersion: $LVER"
+    fail "live prefs has a schemaVersion the schema does not know: $LVER (known: $KNOWN)"
   fi
 else
   echo "  ⓘ no live prefs at $LIVE_PREFS  -  ok for fresh install"