@mmerterden/multi-agent-pipeline 12.7.0 → 12.8.0

package/pipeline/scripts/smoke-repo-map.sh

@@ -1,300 +0,0 @@
-#!/usr/bin/env bash
-# smoke-repo-map.sh
-#
-# Verifies pipeline/scripts/repo-map.mjs:
-#   1. CLI parses --root, --budget, --top, --format, --include, --exclude
-#   2. Empty repo → empty output (exit 0, never crashes)
-#   3. Swift fixture extracts class/struct/protocol/func
-#   4. Kotlin fixture extracts class/fun
-#   5. TS fixture extracts exported class/function
-#   6. Python fixture extracts class/def
-#   7. Bash fixture extracts top-level functions
-#   8. TF-IDF rule: an identifier defined in many files does not dominate rank
-#   9. Token budget honored  -  output stops at budget
-#  10. Determinism  -  same input twice = byte-identical output
-#  11. JSON format emits valid JSON with score / declarations
-#  12. Word-boundary match: substring of an identifier is NOT counted
-#
-# Exit 0 = all pass, 1 = any failure.
-
-set -euo pipefail
-
-ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
-SCRIPT="$ROOT/pipeline/scripts/repo-map.mjs"
-
-pass=0
-fail=0
-failures=()
-record_pass() { pass=$((pass + 1)); printf '  \033[0;32mPASS\033[0m %s\n' "$1"; }
-record_fail() { fail=$((fail + 1)); failures+=("$1"); printf '  \033[0;31mFAIL\033[0m %s\n' "$1"; }
-
-printf '→ smoke-repo-map: Aider-style token-budgeted repo map contract\n'
-
-# Sanity: node + script
-if ! command -v node >/dev/null 2>&1; then
-  echo "SKIP smoke-repo-map: node not installed" >&2
-  exit 0
-fi
-if [ ! -f "$SCRIPT" ]; then
-  echo "FAIL: $SCRIPT missing" >&2
-  exit 1
-fi
-
-# --- Fixture builder --------------------------------------------------------
-FIX=$(mktemp -d)
-trap 'rm -rf "$FIX"' EXIT
-
-mkdir -p "$FIX/swift" "$FIX/kotlin" "$FIX/ts" "$FIX/py" "$FIX/bash" "$FIX/shared"
-
-# Swift
-cat > "$FIX/swift/Order.swift" <<'EOF'
-import Foundation
-
-public final class OrderViewModel {
-    public func loadOrders() async throws -> [Order] { return [] }
-}
-
-public struct OrderConfiguration {
-    var pageSize: Int = 20
-}
-
-public protocol OrderRepository {
-    func fetch() async throws -> [Order]
-}
-EOF
-
-cat > "$FIX/swift/Product.swift" <<'EOF'
-public class ProductViewModel {
-    public func loadProducts() async throws { _ = OrderViewModel() }
-}
-EOF
-
-# Kotlin
-cat > "$FIX/kotlin/User.kt" <<'EOF'
-package com.example
-
-data class User(val id: String, val name: String)
-
-class UserViewModel(private val repo: UserRepository) {
-    fun loadUsers(): List<User> = repo.all()
-}
-
-interface UserRepository {
-    fun all(): List<User>
-}
-EOF
-
-# TypeScript
-cat > "$FIX/ts/api.ts" <<'EOF'
-export class APIClient {
-  async fetchUsers(): Promise<User[]> { return []; }
-}
-export interface User {
-  id: string;
-  name: string;
-}
-export function buildClient(): APIClient { return new APIClient(); }
-EOF
-
-# Python
-cat > "$FIX/py/server.py" <<'EOF'
-class Server:
-    def __init__(self): pass
-
-def make_server() -> Server:
-    return Server()
-EOF
-
-# Bash
-cat > "$FIX/bash/helpers.sh" <<'EOF'
-#!/usr/bin/env bash
-common_helper() {
-  echo "hi"
-}
-specific_helper_for_repo() {
-  common_helper
-}
-EOF
-
-# Two shared-name files to test the TF-IDF rule (same identifier defined twice)
-cat > "$FIX/shared/A.swift" <<'EOF'
-class CommonName { var x = 1 }
-EOF
-cat > "$FIX/shared/B.swift" <<'EOF'
-class CommonName { var y = 2 }
-EOF
-
-# A reference file that mentions OrderViewModel (rare) AND CommonName (split)
-cat > "$FIX/shared/refs.swift" <<'EOF'
-import Foundation
-// References: OrderViewModel (defined once), CommonName (defined twice → split credit)
-let a = OrderViewModel()
-let b = CommonName()
-let c = CommonName()
-EOF
-
-# --- 1: CLI args parse without crashing ------------------------------------
-if node "$SCRIPT" --root "$FIX" --budget 800 --top 5 --format md >/dev/null 2>&1; then
-  record_pass "CLI parses standard flags"
-else
-  record_fail "CLI failed on standard flags"
-fi
-
-# --- 2: empty repo behaviour -----------------------------------------------
-EMPTY=$(mktemp -d)
-out2=$(node "$SCRIPT" --root "$EMPTY" --budget 200 --top 5 --format md 2>&1)
-rc=$?
-rm -rf "$EMPTY"
-if [ "$rc" -eq 0 ]; then
-  record_pass "empty repo → exit 0"
-else
-  record_fail "empty repo should exit 0 (got $rc)"
-fi
-
-# --- 3-7: language extractors --------------------------------------------
-MD=$(node "$SCRIPT" --root "$FIX" --budget 5000 --top 50 --format md 2>&1)
-
-if grep -qF "OrderViewModel" <<<"$MD" && grep -qF "OrderConfiguration" <<<"$MD" && grep -qF "OrderRepository" <<<"$MD"; then
-  record_pass "Swift extractor finds class/struct/protocol"
-else
-  record_fail "Swift extractor missed declarations"
-fi
-
-if grep -qF "UserViewModel" <<<"$MD" && grep -qF "UserRepository" <<<"$MD" && grep -qF "User" <<<"$MD"; then
-  record_pass "Kotlin extractor finds class/data class/interface"
-else
-  record_fail "Kotlin extractor missed declarations"
-fi
-
-if grep -qF "APIClient" <<<"$MD" && grep -qF "buildClient" <<<"$MD"; then
-  record_pass "TS extractor finds export class/function"
-else
-  record_fail "TS extractor missed declarations"
-fi
-
-if grep -qF "class Server" <<<"$MD" && grep -qF "def make_server" <<<"$MD"; then
-  record_pass "Python extractor finds class/def"
-else
-  record_fail "Python extractor missed declarations"
-fi
-
-if grep -qF "common_helper()" <<<"$MD" && grep -qF "specific_helper_for_repo()" <<<"$MD"; then
-  record_pass "Bash extractor finds functions"
-else
-  record_fail "Bash extractor missed functions"
-fi
-
-# --- 8: TF-IDF rule  -  rare identifier ranks higher than shared identifier ---
-# OrderViewModel defined once, referenced from refs.swift.
-# CommonName defined twice (A + B), referenced from refs.swift.
-# refs.swift's outgoing edge to Order.swift should weigh more than to A/B
-# combined  -  so Order.swift should rank above A.swift in this fixture.
-order_line=$(echo "$MD" | grep -nF "Order.swift" | head -1 | cut -d: -f1)
-a_line=$(echo "$MD" | grep -nF "shared/A.swift" | head -1 | cut -d: -f1)
-if [ -n "$order_line" ] && [ -n "$a_line" ]; then
-  if [ "$order_line" -lt "$a_line" ]; then
-    record_pass "TF-IDF  -  rarely-defined identifier outranks shared identifier"
-  else
-    record_fail "TF-IDF rule failed: Order.swift should rank above shared/A.swift"
-  fi
-else
-  record_fail "TF-IDF  -  could not locate Order.swift or shared/A.swift in output"
-fi
-
-# --- 9: token budget honored -----------------------------------------------
-SMALL=$(node "$SCRIPT" --root "$FIX" --budget 150 --top 50 --format md 2>&1)
-small_bytes=$(printf '%s' "$SMALL" | wc -c)
-# 150 tokens × 4 chars/token = 600 chars; output may end on file boundary so allow +200
-if [ "$small_bytes" -lt 900 ]; then
-  record_pass "token budget honored (budget=150 → $small_bytes chars)"
-else
-  record_fail "token budget exceeded ($small_bytes chars for budget=150)"
-fi
-
-# --- 10: determinism --------------------------------------------------------
-RUN1=$(node "$SCRIPT" --root "$FIX" --budget 800 --top 10 --format md 2>&1)
-RUN2=$(node "$SCRIPT" --root "$FIX" --budget 800 --top 10 --format md 2>&1)
-if [ "$RUN1" = "$RUN2" ]; then
-  record_pass "determinism  -  same input twice produces byte-identical output"
-else
-  record_fail "non-deterministic output across runs"
-fi
-
-# --- 11: JSON format --------------------------------------------------------
-JSON=$(node "$SCRIPT" --root "$FIX" --budget 2000 --top 5 --format json 2>&1)
-if echo "$JSON" | python3 -c 'import json,sys; data=json.load(sys.stdin); assert isinstance(data,list); assert all("path" in d and "score" in d and "declarations" in d for d in data); print("ok")' >/dev/null 2>&1; then
-  record_pass "JSON format produces valid array with score+declarations"
-else
-  record_fail "JSON output failed schema check"
-fi
-
-# --- 12: word-boundary match -----------------------------------------------
-# Isolated fixture: define a unique identifier in one file, reference its
-# *substring* (no word boundary) in another, then verify in_refs stays 0.
-WB=$(mktemp -d)
-cat > "$WB/def.swift" <<'EOF'
-class WidgetXYZ123 { var x = 0 }
-EOF
-cat > "$WB/ref.swift" <<'EOF'
-// Mentions a SUPER-string only: WidgetXYZ123Helper.
-// \bWidgetXYZ123\b should NOT match inside WidgetXYZ123Helper.
-struct WidgetXYZ123Helper { }
-EOF
-WB_JSON=$(node "$SCRIPT" --root "$WB" --budget 2000 --top 5 --format json 2>&1)
-rm -rf "$WB"
-
-def_refs=$(echo "$WB_JSON" | python3 -c '
-import json, sys
-data = json.load(sys.stdin)
-for d in data:
-    if d["path"] == "def.swift":
-        print(d["incoming_refs"])
-        break
-')
-if [ -n "$def_refs" ] && python3 -c "import sys; sys.exit(0 if abs(${def_refs}) < 0.01 else 1)" 2>/dev/null; then
-  record_pass "word-boundary  -  super-string match (WidgetXYZ123Helper) does not count as WidgetXYZ123 ref"
-else
-  record_fail "word-boundary regression: def.swift in_refs=$def_refs (expected ~0)"
-fi
-
-# --- 13: prefs schema exposes repoMap toggle -------------------------------
-SCHEMA_PATH="$ROOT/pipeline/schemas/prefs.schema.json"
-if jq -e '.properties.global.properties.repoMap.properties.enabled' "$SCHEMA_PATH" >/dev/null 2>&1; then
-  record_pass "prefs schema exposes repoMap.enabled"
-else
-  record_fail "prefs schema missing repoMap.enabled"
-fi
-for prop in tokenBudget topFiles include exclude; do
-  if jq -e ".properties.global.properties.repoMap.properties.${prop}" "$SCHEMA_PATH" >/dev/null 2>&1; then
-    record_pass "prefs schema exposes repoMap.${prop}"
-  else
-    record_fail "prefs schema missing repoMap.${prop}"
-  fi
-done
-# Off by default  -  preserve baseline for existing users.
-if jq -e '.properties.global.properties.repoMap.properties.enabled
-          | has("default") and .default == false' "$SCHEMA_PATH" >/dev/null 2>&1; then
-  record_pass "repoMap.enabled defaults to false (opt-in)"
-else
-  record_fail "repoMap.enabled should default to false"
-fi
-
-# --- 14: Phase 1 + Phase 4 docs wire the injection ------------------------
-P1="$ROOT/pipeline/multi-agent-refs/phases/phase-1-analysis.md"
-P4="$ROOT/pipeline/multi-agent-refs/phases/phase-4-review.md"
-for f in "$P1" "$P4"; do
-  base=$(basename "$f")
-  if grep -qF "repoMap.enabled" "$f" && grep -qF "repo-map.mjs" "$f" && grep -qF '${REPO_MAP}' "$f"; then
-    record_pass "$base wires repoMap injection"
-  else
-    record_fail "$base missing repoMap wiring (need: repoMap.enabled + repo-map.mjs + \${REPO_MAP})"
-  fi
-done
-
-printf '\n══ repo-map smoke: %d passed, %d failed ══\n' "$pass" "$fail"
-if [ "$fail" -gt 0 ]; then
-  printf '\nFailures:\n'
-  for msg in "${failures[@]}"; do printf '  - %s\n' "$msg"; done
-  exit 1
-fi
-exit 0

package/pipeline/scripts/smoke-review-readiness.sh

@@ -1,92 +0,0 @@
-#!/usr/bin/env bash
-# smoke-review-readiness.sh  -  contract for /multi-agent:review-jira + /multi-agent:review-issue.
-#
-# Verifies:
-#   1. Files exist: 2 commands, 2 Copilot skills, 1 shared ref.
-#   2. Frontmatter keys on both surfaces.
-#   3. Both commands delegate to refs/readiness-review.md and reuse issue-fetcher.
-#   4. The shared ref names the maturity engine + both comment channels + the confirm gate.
-#   5. Registration: dispatcher rows, routing rows, help EN+TR, contract inventory + count (38).
-#   6. Read-only guarantee (no worktree/commit/create) stated.
-#   7. Forbidden strings absent (em-dash, section sign, the M-word).
-
-set -euo pipefail
-HERE="$(cd "$(dirname "$0")" && pwd)"
-ROOT="$(cd "$HERE/../.." && pwd)"
-
-REF="$ROOT/pipeline/multi-agent-refs/readiness-review.md"
-CMD_J="$ROOT/pipeline/commands/multi-agent/review-jira/SKILL.md"
-CMD_I="$ROOT/pipeline/commands/multi-agent/review-issue/SKILL.md"
-SK_J="$ROOT/pipeline/skills/shared/core/multi-agent-review-jira/SKILL.md"
-SK_I="$ROOT/pipeline/skills/shared/core/multi-agent-review-issue/SKILL.md"
-DISPATCHER="$ROOT/pipeline/commands/multi-agent/SKILL.md"
-CONTRACT="$ROOT/pipeline/multi-agent-refs/cross-cli-contract.md"
-CMD_COUNT=$(find "$ROOT/pipeline/commands/multi-agent" -mindepth 1 -maxdepth 1 -type d | wc -l | tr -d ' ')
-HELP="$ROOT/pipeline/commands/multi-agent/help/SKILL.md"
-
-PASS=0; FAIL=0
-pass() { PASS=$((PASS+1)); echo "  ✓ $1"; }
-fail() { FAIL=$((FAIL+1)); echo "  ✗ $1"; }
-
-echo "→ 1. files exist"
-for f in "$REF" "$CMD_J" "$CMD_I" "$SK_J" "$SK_I"; do
-  if [ -f "$f" ]; then pass "exists: ${f#$ROOT/}"; else fail "missing: ${f#$ROOT/}"; fi
-done
-[ "$FAIL" -eq 0 ] || { echo "══ review-readiness smoke: $PASS passed, $FAIL failed ══"; exit 1; }
-
-echo ""
-echo "→ 2. frontmatter keys"
-for f in "$CMD_J" "$CMD_I"; do
-  head -4 "$f" | grep -q '^description:' && pass "description: ${f#$ROOT/}" || fail "description missing: ${f#$ROOT/}"
-  head -4 "$f" | grep -q '^argument-hint:' && pass "argument-hint: ${f#$ROOT/}" || fail "argument-hint missing: ${f#$ROOT/}"
-done
-head -8 "$SK_J" | grep -q '^name: multi-agent-review-jira$' && pass "name: multi-agent-review-jira" || fail "name wrong: $SK_J"
-head -8 "$SK_I" | grep -q '^name: multi-agent-review-issue$' && pass "name: multi-agent-review-issue" || fail "name wrong: $SK_I"
-for f in "$SK_J" "$SK_I"; do
-  head -8 "$f" | grep -q '^user-invocable: true' && pass "user-invocable: ${f#$ROOT/}" || fail "user-invocable missing: ${f#$ROOT/}"
-done
-
-echo ""
-echo "→ 3. delegate to shared ref + reuse issue-fetcher"
-for f in "$CMD_J" "$CMD_I" "$SK_J" "$SK_I"; do
-  grep -Fq "readiness-review.md" "$f" && pass "ref link: ${f#$ROOT/}" || fail "ref link missing: ${f#$ROOT/}"
-  grep -Fq "issue-fetcher.sh" "$f" && pass "issue-fetcher reuse: ${f#$ROOT/}" || fail "issue-fetcher missing: ${f#$ROOT/}"
-done
-
-echo ""
-echo "→ 4. shared ref names maturity + channels + confirm gate"
-grep -Fqi "maturity" "$REF" && pass "ref uses maturity engine" || fail "ref missing maturity"
-grep -Fq "channels/jira.md" "$REF" && pass "ref -> jira comment channel" || fail "ref missing jira channel"
-grep -Fq "channels/issue-comment.md" "$REF" && pass "ref -> github comment channel" || fail "ref missing issue channel"
-grep -Fqi "confirm" "$REF" && pass "ref has confirm-before-post gate" || fail "ref missing confirm gate"
-grep -Fqi "rubric" "$REF" && pass "ref has readiness rubric" || fail "ref missing rubric"
-
-echo ""
-echo "→ 5. registration + count (derived)"
-grep -Fq '| `review-jira ' "$DISPATCHER" && pass "dispatcher desc: review-jira" || fail "dispatcher desc missing review-jira"
-grep -Fq '| `review-issue ' "$DISPATCHER" && pass "dispatcher desc: review-issue" || fail "dispatcher desc missing review-issue"
-grep -Fq "review-jira/SKILL.md" "$DISPATCHER" && pass "dispatcher routing: review-jira" || fail "dispatcher routing missing review-jira"
-grep -Fq "review-issue/SKILL.md" "$DISPATCHER" && pass "dispatcher routing: review-issue" || fail "dispatcher routing missing review-issue"
-grep -Fq "## 1. Command Inventory ($CMD_COUNT commands)" "$CONTRACT" && pass "contract count = $CMD_COUNT (derived)" || fail "contract count wrong"
-grep -Eq '(^|[ ,])review-jira([ ,]|$)' "$CONTRACT" && pass "contract inventory has review-jira" || fail "contract missing review-jira"
-grep -Eq '(^|[ ,])review-issue([ ,]|$)' "$CONTRACT" && pass "contract inventory has review-issue" || fail "contract missing review-issue"
-grep -Fq "multi-agent:review-jira" "$HELP" && pass "help lists review-jira" || fail "help missing review-jira"
-grep -Fq "multi-agent:review-issue" "$HELP" && pass "help lists review-issue" || fail "help missing review-issue"
-
-echo ""
-echo "→ 6. read-only guarantee stated"
-for f in "$CMD_J" "$CMD_I"; do
-  grep -Fqi "no worktree" "$f" && pass "read-only stated: ${f#$ROOT/}" || fail "read-only note missing: ${f#$ROOT/}"
-done
-
-echo ""
-echo "→ 7. forbidden strings absent"
-MWORD="MAN""DATORY"
-for f in "$REF" "$CMD_J" "$CMD_I" "$SK_J" "$SK_I"; do
-  if grep -q $'—\|§\|…' "$f"; then fail "forbidden unicode punctuation in ${f##*/}"; else pass "punctuation clean: ${f##*/}"; fi
-  if grep -q "$MWORD" "$f"; then fail "forbidden word in ${f##*/}"; else pass "vocabulary clean: ${f##*/}"; fi
-done
-
-echo ""
-echo "══ review-readiness smoke: $PASS passed, $FAIL failed ══"
-[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-review-watch.sh

@@ -1,146 +0,0 @@
-#!/usr/bin/env bash
-# smoke-review-watch.sh
-#
-# Verifies the auto-review-incoming-PRs surface:
-#   1. pipeline/lib/review-watch.sh exists and parses cleanly
-#   2. --doctor runs without crashing on an unconfigured environment
-#   3. --help shows usage
-#   4. State directory is created
-#   5. prefs schema exposes global.reviewWatch.{enabled,repos,intervalSeconds,labelFilter}
-#   6. global.reviewWatch.enabled defaults to false (opt-in)
-#   7. global.review.dedupeInlineComments default is true (dedupe parity)
-#   8. post-pr-review.sh exposes finding_fingerprint + comment_exists_with_fingerprint
-#   9. render_inline_body accepts a 5th fingerprint arg and embeds the marker
-#  10. Unknown command exits non-zero
-#
-# Exit 0 = all pass, 1 = any failure.
-
-set -uo pipefail
-
-ROOT="$(cd "$(dirname "$0")/../.." && pwd)"
-WATCH="$ROOT/pipeline/lib/review-watch.sh"
-POSTER="$ROOT/pipeline/lib/post-pr-review.sh"
-SCHEMA="$ROOT/pipeline/schemas/prefs.schema.json"
-
-pass=0
-fail=0
-failures=()
-record_pass() { pass=$((pass + 1)); printf '  \033[0;32mPASS\033[0m %s\n' "$1"; }
-record_fail() { fail=$((fail + 1)); failures+=("$1"); printf '  \033[0;31mFAIL\033[0m %s\n' "$1"; }
-
-printf '→ smoke-review-watch: incoming-PR auto-review surface contract\n'
-
-# 1. lib script exists + parses
-if [ ! -f "$WATCH" ]; then
-  record_fail "pipeline/lib/review-watch.sh missing"
-elif ! bash -n "$WATCH" 2>/dev/null; then
-  record_fail "review-watch.sh syntax error"
-else
-  record_pass "review-watch.sh exists and parses"
-fi
-
-# 2. --doctor runs cleanly (zero exit) on unconfigured prefs
-if bash "$WATCH" --doctor >/dev/null 2>&1; then
-  record_pass "--doctor exits 0 on unconfigured environment"
-else
-  record_fail "--doctor crashed (must be safe on unconfigured environment)"
-fi
-
-# 3. --help shows usage
-if bash "$WATCH" --help 2>&1 | grep -qE 'review-watch|usage:'; then
-  record_pass "--help shows usage"
-else
-  record_fail "--help should show usage banner"
-fi
-
-# 4. State dir is created
-STATE_DIR="$HOME/.claude/state/review-watch"
-if [ -d "$STATE_DIR" ]; then
-  record_pass "state dir created at $STATE_DIR"
-else
-  record_fail "state dir not created"
-fi
-
-# 5. Schema toggles
-for prop in enabled repos intervalSeconds labelFilter; do
-  if jq -e ".properties.global.properties.reviewWatch.properties.${prop}" "$SCHEMA" >/dev/null 2>&1; then
-    record_pass "prefs schema exposes reviewWatch.${prop}"
-  else
-    record_fail "prefs schema missing reviewWatch.${prop}"
-  fi
-done
-
-# 6. reviewWatch.enabled defaults to false
-if jq -e '.properties.global.properties.reviewWatch.properties.enabled
-          | has("default") and .default == false' "$SCHEMA" >/dev/null 2>&1; then
-  record_pass "reviewWatch.enabled defaults to false (opt-in)"
-else
-  record_fail "reviewWatch.enabled should default to false"
-fi
-
-# 7. dedupeInlineComments default true
-if jq -e '.properties.global.properties.review.properties.dedupeInlineComments
-          | has("default") and .default == true' "$SCHEMA" >/dev/null 2>&1; then
-  record_pass "review.dedupeInlineComments defaults to true (dedupe parity)"
-else
-  record_fail "review.dedupeInlineComments should default to true"
-fi
-
-# 8. post-pr-review.sh exposes the dedupe helpers (provider-agnostic)
-if grep -qE '^finding_fingerprint\(\)' "$POSTER" \
-   && grep -qE '^comment_exists_with_fingerprint\(\)' "$POSTER" \
-   && grep -qE '^load_existing_comments_github\(\)' "$POSTER" \
-   && grep -qE '^load_existing_comments_bitbucket\(\)' "$POSTER"; then
-  record_pass "post-pr-review.sh declares dedupe helpers (fingerprint + check + github + bitbucket loaders)"
-else
-  record_fail "post-pr-review.sh missing one of the dedupe helpers (github or bitbucket loader)"
-fi
-
-# 8b. Bitbucket dedupe gate wired in post_bitbucket_server
-if awk '/^post_bitbucket_server\(\)/,/^}/' "$POSTER" \
-   | grep -q 'load_existing_comments_bitbucket'; then
-  record_pass "post_bitbucket_server wires the dedupe gate"
-else
-  record_fail "post_bitbucket_server missing load_existing_comments_bitbucket call"
-fi
-if awk '/^post_bitbucket_server\(\)/,/^}/' "$POSTER" \
-   | grep -q 'comment_exists_with_fingerprint'; then
-  record_pass "post_bitbucket_server checks fingerprint before posting"
-else
-  record_fail "post_bitbucket_server missing fingerprint check"
-fi
-
-# 9. render_inline_body takes 5 args (sev issue fix rule_id fingerprint) and writes the marker
-if grep -qE 'render_inline_body\(\)' "$POSTER" \
-   && grep -qE '<!-- multi-agent-finding:' "$POSTER"; then
-  record_pass "render_inline_body embeds the fingerprint marker"
-else
-  record_fail "render_inline_body must embed <!-- multi-agent-finding: ... --> marker"
-fi
-
-# 10. Unknown command exits non-zero
-if bash "$WATCH" --garbage >/dev/null 2>&1; then
-  record_fail "unknown command should exit non-zero"
-else
-  record_pass "unknown command exits non-zero"
-fi
-
-# 11. PR loop must NOT pipe into `while` (a pipe subshell discards every
-# state= / cursor mutation, so save_state would persist the stale cursor and
-# the watcher would re-dispatch the same PRs forever). It must use process
-# substitution so the loop runs in the function's own shell.
-if grep -qE "jq -c '\.\[\]' <<<\"\\\$prs_json\" \| while" "$WATCH"; then
-  record_fail "review-watch PR loop pipes into while (subshell loses cursor state)"
-elif awk '/while read -r pr;/,/done < <\(jq/' "$WATCH" | grep -q 'done < <(jq'; then
-  record_pass "PR loop uses process substitution (cursor mutations persist)"
-else
-  record_fail "PR loop structure unrecognized  -  verify it does not pipe into while"
-fi
-
-printf '\n══ review-watch smoke: %d passed, %d failed ══\n' "$pass" "$fail"
-if [ "$fail" -gt 0 ]; then
-  printf '\nFailures:\n'
-  for msg in "${failures[@]}"; do printf '  - %s\n' "$msg"; done
-  exit 1
-fi
-exit 0

package/pipeline/scripts/smoke-routines.sh

@@ -1,84 +0,0 @@
-#!/usr/bin/env bash
-# smoke-routines.sh  -  contract for routine-registry.mjs, the backend of the
-# user-defined routine commands (/multi-agent:save, :routines, :forget).
-
-set -uo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
-RR="$SCRIPT_DIR/routine-registry.mjs"
-
-PASS=0
-FAIL=0
-record_pass() { PASS=$((PASS + 1)); printf '  \342\234\223 %s\n' "$1"; }
-record_fail() { FAIL=$((FAIL + 1)); printf '  \342\234\227 %s\n' "$1"; }
-
-printf '\342\206\222 smoke-routines: routine-registry backend contract\n'
-
-tmp=$(mktemp -d "${TMPDIR:-/tmp}/routines.XXXXXX")
-trap 'rm -rf "$tmp"' EXIT
-H="$tmp/home"
-mkdir -p "$H/.claude/commands/multi-agent"
-printf '{"global":{}}\n' > "$H/.claude/multi-agent-preferences.json"
-printf 'Run steps 1-6 of the checkin service migration.\n' > "$tmp/body.md"
-
-# 1. add -> writes a local-only command dir + registry entry
-node "$RR" add --name checkin-services --description "Checkin servis kontrolu" \
-  --source "CLAUDE.md" --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
-skill="$H/.claude/commands/multi-agent/checkin-services/SKILL.md"
-if [ -f "$skill" ] && grep -qx "local-only: true" "$skill"; then
-  record_pass "add writes a local-only command SKILL.md"
-else
-  record_fail "add did not write a local-only routine command"
-fi
-if node "$RR" list --json --home "$H" | grep -q '"name": "checkin-services"'; then
-  record_pass "registry records the routine"
-else
-  record_fail "registry missing the routine"
-fi
-
-# 2. add is name-collision safe (same name rejected)
-node "$RR" add --name checkin-services --description x --source y --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
-[ "$?" -eq 1 ] && record_pass "duplicate name rejected" || record_fail "duplicate name should reject"
-
-# 3. invalid name rejected
-node "$RR" add --name "Bad Name" --description x --source y --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
-[ "$?" -eq 1 ] && record_pass "invalid name rejected" || record_fail "invalid name should reject"
-
-# 4. shipped-command guard: never remove a non-local-only command
-mkdir -p "$H/.claude/commands/multi-agent/status"
-printf -- '---\ndescription: "shipped"\n---\nbody\n' > "$H/.claude/commands/multi-agent/status/SKILL.md"
-node "$RR" remove --name status --home "$H" >/dev/null 2>&1
-if [ "$?" -eq 1 ] && [ -d "$H/.claude/commands/multi-agent/status" ]; then
-  record_pass "refuses to remove a shipped command"
-else
-  record_fail "shipped command must be protected"
-fi
-
-# 5. sync backstop proxy: the generated routine carries local-only:true, which is
-# exactly what sync/SKILL.md greps to keep it out of the public repo.
-if grep -qx "local-only: true" "$skill"; then
-  record_pass "routine is sync-excluded (local-only marker present)"
-else
-  record_fail "routine missing local-only marker (would leak on sync)"
-fi
-
-# 6. remove -> deletes dir + registry entry
-node "$RR" remove --name checkin-services --home "$H" >/dev/null 2>&1
-if [ ! -d "$H/.claude/commands/multi-agent/checkin-services" ] \
-  && ! node "$RR" list --json --home "$H" | grep -q "checkin-services"; then
-  record_pass "remove deletes dir + registry entry"
-else
-  record_fail "remove left dir or registry entry behind"
-fi
-
-# 7. install preservation proxy: snapshotLocalOnlyWrappers keys on local-only:true.
-# Re-add, then confirm the marker survives a simulated namespace re-read.
-node "$RR" add --name my-routine --description d --source s --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
-if grep -qx "local-only: true" "$H/.claude/commands/multi-agent/my-routine/SKILL.md"; then
-  record_pass "re-added routine keeps the install-preserving marker"
-else
-  record_fail "re-added routine lost its local-only marker"
-fi
-
-printf '\n\342\225\220\342\225\220 smoke-routines: %d passed, %d failed \342\225\220\342\225\220\n' "$PASS" "$FAIL"
-[ "$FAIL" -eq 0 ]