@mmerterden/multi-agent-pipeline 12.5.0 → 12.7.0

package/pipeline/scripts/migrate-prefs.mjs

@@ -95,7 +95,9 @@ function consolidateFirebase(out, changes) {
     }
     if ("firebase_project" in km) {
       delete km.firebase_project;
-      changes.push("keychainMapping: removed firebase_project (redundant  -  project_id lives inside the SA JSON)");
+      changes.push(
+        "keychainMapping: removed firebase_project (redundant  -  project_id lives inside the SA JSON)",
+      );
     }
   }
   if (Array.isArray(out?.global?.identities)) {
@@ -195,7 +197,9 @@ function migrate(prefs) {
       out.global.identities = out.global.gitIdentities;
       changes.push(`renamed gitIdentities → identities (${out.global.identities.length} entries)`);
     } else {
-      changes.push("gitIdentities present but identities also exists  -  keeping identities, dropping gitIdentities");
+      changes.push(
+        "gitIdentities present but identities also exists  -  keeping identities, dropping gitIdentities",
+      );
     }
     delete out.global.gitIdentities;
   } else if (!Array.isArray(out.global.identities)) {
@@ -214,7 +218,8 @@ function migrate(prefs) {
     }
   }
   out.global.keychainMapping = km;
-  if (kmChanged) changes.push("expanded keychainMapping with missing services (existing values preserved)");
+  if (kmChanged)
+    changes.push("expanded keychainMapping with missing services (existing values preserved)");
 
   // 5. New v2.1.0 fields with defaults
   if (!out.global.platformIdentityRouting) {
@@ -320,25 +325,29 @@ function migrateReportChannels(out, changes) {
   // --- reportChannels ---
   if (!g.reportChannels || typeof g.reportChannels !== "object") {
     const channels = {
-      pr:         true,  // schema default
-      jira:       typeof g.jiraCommentDefault === "boolean" ? g.jiraCommentDefault : true,
+      pr: true, // schema default
+      jira: typeof g.jiraCommentDefault === "boolean" ? g.jiraCommentDefault : true,
       confluence: typeof g.confluenceDefault === "boolean" ? g.confluenceDefault : false,
-      wiki:       typeof g.wikiDefault === "boolean" ? g.wikiDefault : false,
+      wiki: typeof g.wikiDefault === "boolean" ? g.wikiDefault : false,
     };
     g.reportChannels = channels;
-    changes.push("added reportChannels {pr,jira,confluence,wiki} (migrated from jiraCommentDefault/confluenceDefault/wikiDefault if present)");
+    changes.push(
+      "added reportChannels {pr,jira,confluence,wiki} (migrated from jiraCommentDefault/confluenceDefault/wikiDefault if present)",
+    );
   }
 
   // --- reportContent ---
   if (!g.reportContent || typeof g.reportContent !== "object") {
     g.reportContent = {
-      normalAnalysis:    true,
+      normalAnalysis: true,
       technicalAnalysis: false,
-      testScenarios:     true,
-      autoDiff:          false,
-      manualNote:        false,
+      testScenarios: true,
+      autoDiff: false,
+      manualNote: false,
     };
-    changes.push("added reportContent defaults {normalAnalysis,technicalAnalysis,testScenarios,autoDiff,manualNote}");
+    changes.push(
+      "added reportContent defaults {normalAnalysis,technicalAnalysis,testScenarios,autoDiff,manualNote}",
+    );
   } else if (!("technicalAnalysis" in g.reportContent)) {
     // v5.7.3+  -  backfill technicalAnalysis onto already-initialized reportContent
     g.reportContent.technicalAnalysis = false;
@@ -349,24 +358,32 @@ function migrateReportChannels(out, changes) {
   if (!Array.isArray(g.wikiScope)) {
     if (g.wikiDefault === false) {
       g.wikiScope = [];
-      changes.push("added wikiScope: [] (legacy wikiDefault=false  -  opt out of all wiki artifacts)");
+      changes.push(
+        "added wikiScope: [] (legacy wikiDefault=false  -  opt out of all wiki artifacts)",
+      );
     } else {
       g.wikiScope = ["main", "ios", "screenshots", "index"];
-      changes.push("added wikiScope: [main,ios,screenshots,index] (legacy wikiDefault=true or unset)");
+      changes.push(
+        "added wikiScope: [main,ios,screenshots,index] (legacy wikiDefault=true or unset)",
+      );
     }
   }
 
   // --- autopilotReportTimeoutSeconds ---
   if (typeof g.autopilotReportTimeoutSeconds !== "number") {
     g.autopilotReportTimeoutSeconds = 1800;
-    changes.push("added autopilotReportTimeoutSeconds: 1800 (30 min)  -  Phase 7 always-pause timeout");
+    changes.push(
+      "added autopilotReportTimeoutSeconds: 1800 (30 min)  -  Phase 7 always-pause timeout",
+    );
   }
 
   // --- prune deprecated booleans ---
   for (const key of ["jiraCommentDefault", "confluenceDefault", "wikiDefault"]) {
     if (key in g) {
       delete g[key];
-      changes.push(`removed deprecated ${key} (superseded by reportChannels${key === "wikiDefault" ? " + wikiScope" : ""})`);
+      changes.push(
+        `removed deprecated ${key} (superseded by reportChannels${key === "wikiDefault" ? " + wikiScope" : ""})`,
+      );
     }
   }
 }

package/pipeline/scripts/phase-tracker.sh

@@ -724,8 +724,10 @@ case "$ACTION" in
     # Live current-action line for the active phase. Quiet by construction:
     # progress lines are frequent, so `now` never renders - the card picks the
     # value up at the next boundary render/update. Truncated to 60 chars.
+    # 57 + "..." keeps the documented 60-char cap now that the marker is three
+    # ASCII dots rather than a one-character ellipsis.
     if [ "${#TEXT}" -gt 60 ]; then
-      TEXT="${TEXT:0:59}…"
+      TEXT="${TEXT:0:57}..."
     fi
     acquire_state_lock
     state=$(load_state)

package/pipeline/scripts/render-work-summary.sh

@@ -126,7 +126,10 @@ fi
 changed_block=""
 files_count=0
 total_add=0; total_del=0
-if [ -n "$WORKTREE" ] && [ -d "$WORKTREE/.git" -o -d "$WORKTREE" ]; then
+# Only the directory needs to exist here; `git rev-parse HEAD` below is the real
+# repository check. Testing -d "$WORKTREE/.git" would be wrong regardless: in a
+# linked worktree .git is a file, not a directory.
+if [ -n "$WORKTREE" ] && [ -d "$WORKTREE" ]; then
   if git -C "$WORKTREE" rev-parse HEAD >/dev/null 2>&1; then
     diffstat=$(git -C "$WORKTREE" diff --numstat "$state_base"...HEAD 2>/dev/null || true)
     if [ -n "$diffstat" ]; then

package/pipeline/scripts/repo-map.mjs

@@ -26,10 +26,10 @@
 //   2  -  usage / arg error
 //   3  -  root directory missing / not a repo
 
-import { promises as fs } from 'node:fs';
-import { existsSync, statSync } from 'node:fs';
-import path from 'node:path';
-import process from 'node:process';
+import { promises as fs } from "node:fs";
+import { existsSync, statSync } from "node:fs";
+import path from "node:path";
+import process from "node:process";
 
 // ---- CLI args --------------------------------------------------------------
 
@@ -38,25 +38,25 @@ function parseArgs(argv) {
     root: process.cwd(),
     budget: 2000,
     top: 25,
-    format: 'md',
+    format: "md",
     include: null,
     exclude: null,
     verbose: false,
   };
   for (let i = 2; i < argv.length; i++) {
     const a = argv[i];
-    if (a === '--root') args.root = path.resolve(argv[++i]);
-    else if (a === '--budget') args.budget = parseInt(argv[++i], 10);
-    else if (a === '--top') args.top = parseInt(argv[++i], 10);
-    else if (a === '--format') args.format = argv[++i];
-    else if (a === '--include') args.include = argv[++i].split(',').filter(Boolean);
-    else if (a === '--exclude') args.exclude = argv[++i].split(',').filter(Boolean);
-    else if (a === '--verbose' || a === '-v') args.verbose = true;
-    else if (a === '--help' || a === '-h') {
+    if (a === "--root") args.root = path.resolve(argv[++i]);
+    else if (a === "--budget") args.budget = parseInt(argv[++i], 10);
+    else if (a === "--top") args.top = parseInt(argv[++i], 10);
+    else if (a === "--format") args.format = argv[++i];
+    else if (a === "--include") args.include = argv[++i].split(",").filter(Boolean);
+    else if (a === "--exclude") args.exclude = argv[++i].split(",").filter(Boolean);
+    else if (a === "--verbose" || a === "-v") args.verbose = true;
+    else if (a === "--help" || a === "-h") {
       console.log(
-        'usage: repo-map.mjs [--root DIR] [--budget TOKENS] [--top N]\n' +
-          '                   [--format md|json] [--include GLOB,...]\n' +
-          '                   [--exclude GLOB,...] [--verbose]'
+        "usage: repo-map.mjs [--root DIR] [--budget TOKENS] [--top N]\n" +
+          "                   [--format md|json] [--include GLOB,...]\n" +
+          "                   [--exclude GLOB,...] [--verbose]",
       );
       process.exit(0);
     } else {
@@ -64,16 +64,16 @@ function parseArgs(argv) {
       process.exit(2);
     }
   }
-  if (!['md', 'json'].includes(args.format)) {
+  if (!["md", "json"].includes(args.format)) {
     console.error(`repo-map: --format must be md or json (got "${args.format}")`);
     process.exit(2);
   }
   if (!Number.isFinite(args.budget) || args.budget < 100) {
-    console.error('repo-map: --budget must be an integer >= 100');
+    console.error("repo-map: --budget must be an integer >= 100");
     process.exit(2);
   }
   if (!Number.isFinite(args.top) || args.top < 1) {
-    console.error('repo-map: --top must be >= 1');
+    console.error("repo-map: --top must be >= 1");
     process.exit(2);
   }
   return args;
@@ -82,24 +82,38 @@ function parseArgs(argv) {
 // ---- File walking ----------------------------------------------------------
 
 const DEFAULT_IGNORE = new Set([
-  '.git', '.worktrees', 'node_modules', 'Pods', '.build', 'DerivedData', '.next',
-  'dist', 'build', '__pycache__', '.venv', 'venv', '.cache',
-  '.gradle', '.idea', '.vscode', 'target',
+  ".git",
+  ".worktrees",
+  "node_modules",
+  "Pods",
+  ".build",
+  "DerivedData",
+  ".next",
+  "dist",
+  "build",
+  "__pycache__",
+  ".venv",
+  "venv",
+  ".cache",
+  ".gradle",
+  ".idea",
+  ".vscode",
+  "target",
 ]);
 
 const LANG_EXT = {
-  '.swift': 'swift',
-  '.kt':    'kotlin',
-  '.kts':   'kotlin',
-  '.ts':    'ts',
-  '.tsx':   'ts',
-  '.js':    'js',
-  '.mjs':   'js',
-  '.cjs':   'js',
-  '.jsx':   'js',
-  '.py':    'python',
-  '.sh':    'bash',
-  '.bash':  'bash',
+  ".swift": "swift",
+  ".kt": "kotlin",
+  ".kts": "kotlin",
+  ".ts": "ts",
+  ".tsx": "ts",
+  ".js": "js",
+  ".mjs": "js",
+  ".cjs": "js",
+  ".jsx": "js",
+  ".py": "python",
+  ".sh": "bash",
+  ".bash": "bash",
 };
 
 async function walk(root, args) {
@@ -112,7 +126,7 @@ async function walk(root, args) {
       return;
     }
     for (const e of entries) {
-      if (e.name.startsWith('.') && DEFAULT_IGNORE.has(e.name)) continue;
+      if (e.name.startsWith(".") && DEFAULT_IGNORE.has(e.name)) continue;
       if (DEFAULT_IGNORE.has(e.name)) continue;
       const full = path.join(dir, e.name);
       if (e.isDirectory()) {
@@ -151,8 +165,8 @@ const EXTRACTORS = {
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
-      const signature = `${kind} ${name}${rest ? ' ' + rest : ''}`.trim();
+      const rest = (m[3] || "").trim();
+      const signature = `${kind} ${name}${rest ? " " + rest : ""}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
     return out;
@@ -165,8 +179,8 @@ const EXTRACTORS = {
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
-      const signature = `${kind} ${name}${rest ? ' ' + rest : ''}`.trim();
+      const rest = (m[3] || "").trim();
+      const signature = `${kind} ${name}${rest ? " " + rest : ""}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
     return out;
@@ -179,8 +193,8 @@ const EXTRACTORS = {
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
-      const signature = `export ${kind} ${name}${rest ? ' ' + rest : ''}`.trim();
+      const rest = (m[3] || "").trim();
+      const signature = `export ${kind} ${name}${rest ? " " + rest : ""}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
     return out;
@@ -188,13 +202,12 @@ const EXTRACTORS = {
   js: (src) => EXTRACTORS.ts(src),
   python: (src) => {
     const out = [];
-    const re =
-      /^(?:\s{0,4})(?:async\s+)?(class|def)\s+([A-Za-z_][A-Za-z0-9_]*)(\([^)]*\))?/gm;
+    const re = /^(?:\s{0,4})(?:async\s+)?(class|def)\s+([A-Za-z_][A-Za-z0-9_]*)(\([^)]*\))?/gm;
     let m;
     while ((m = re.exec(src))) {
       const kind = m[1];
       const name = m[2];
-      const rest = (m[3] || '').trim();
+      const rest = (m[3] || "").trim();
       const signature = `${kind} ${name}${rest}`.trim();
       out.push({ kind, name, signature: truncateSig(signature) });
     }
@@ -207,15 +220,15 @@ const EXTRACTORS = {
     let m;
     while ((m = re.exec(src))) {
       const name = m[1];
-      out.push({ kind: 'fn', name, signature: `${name}()` });
+      out.push({ kind: "fn", name, signature: `${name}()` });
     }
     return out;
   },
 };
 
 function truncateSig(s, max = 100) {
-  s = s.replace(/\s+/g, ' ').trim();
-  return s.length > max ? s.slice(0, max - 1) + '...' : s;
+  s = s.replace(/\s+/g, " ").trim();
+  return s.length > max ? s.slice(0, max - 1) + "..." : s;
 }
 
 // ---- Pipeline --------------------------------------------------------------
@@ -228,8 +241,8 @@ async function buildMap(args) {
   const files = await walk(args.root, args);
   if (args.verbose) console.error(`repo-map: scanned ${files.length} source files`);
   if (files.length === 0) {
-    if (args.format === 'json') console.log('[]');
-    else console.log('');
+    if (args.format === "json") console.log("[]");
+    else console.log("");
     return;
   }
 
@@ -239,7 +252,7 @@ async function buildMap(args) {
   for (const f of files) {
     let src;
     try {
-      src = await fs.readFile(f.abs, 'utf8');
+      src = await fs.readFile(f.abs, "utf8");
     } catch {
       continue;
     }
@@ -266,16 +279,49 @@ async function buildMap(args) {
 
   // Hard stop-list for sub-3-char + universally-shared shell helpers.
   const STOP_IDENTIFIERS = new Set([
-    'init', 'main', 'run', 'start', 'stop', 'pass', 'fail', 'warn', 'need',
-    'check', 'log', 'set', 'get', 'add', 'new', 'fix', 'has', 'is', 'on',
-    'self', 'this', 'next', 'prev', 'data', 'item', 'name', 'type', 'value',
-    'count', 'list', 'map', 'each', 'reduce', 'true', 'false', 'null', 'undefined',
+    "init",
+    "main",
+    "run",
+    "start",
+    "stop",
+    "pass",
+    "fail",
+    "warn",
+    "need",
+    "check",
+    "log",
+    "set",
+    "get",
+    "add",
+    "new",
+    "fix",
+    "has",
+    "is",
+    "on",
+    "self",
+    "this",
+    "next",
+    "prev",
+    "data",
+    "item",
+    "name",
+    "type",
+    "value",
+    "count",
+    "list",
+    "map",
+    "each",
+    "reduce",
+    "true",
+    "false",
+    "null",
+    "undefined",
   ]);
 
   for (const f of files) {
     let src;
     try {
-      src = await fs.readFile(f.abs, 'utf8');
+      src = await fs.readFile(f.abs, "utf8");
     } catch {
       continue;
     }
@@ -283,7 +329,7 @@ async function buildMap(args) {
       if (name.length < 3) continue;
       if (STOP_IDENTIFIERS.has(name.toLowerCase())) continue;
       if (owners.size === 1 && owners.has(f.path)) continue;
-      const re = new RegExp(`\\b${escapeRe(name)}\\b`, 'g');
+      const re = new RegExp(`\\b${escapeRe(name)}\\b`, "g");
       const matches = src.match(re);
       if (!matches) continue;
       // TF-IDF: credit per occurrence is divided by the number of owners.
@@ -313,7 +359,7 @@ async function buildMap(args) {
   ranks.sort((a, b) => b.score - a.score);
   const top = ranks.slice(0, args.top);
 
-  if (args.format === 'json') {
+  if (args.format === "json") {
     const obj = top.map((r) => ({
       path: r.path,
       lang: r.lang,
@@ -329,7 +375,7 @@ async function buildMap(args) {
   const charBudget = args.budget * 4;
   const header = `# Repo Map (top ${args.top}, budget ${args.budget} tokens)\n`;
   let used = header.length;
-  let out = header + '\n';
+  let out = header + "\n";
   let printed = 0;
 
   for (const r of top) {
@@ -338,16 +384,16 @@ async function buildMap(args) {
     const block =
       `## ${r.path}  [rank ${r.normScore.toFixed(3)}, in_refs ${r.ins}]\n` +
       (filteredDecls.length === 0
-        ? '_no top-level declarations extracted_\n'
-        : filteredDecls.map((d) => `- ${d.signature}`).join('\n') + '\n') +
-      '\n';
+        ? "_no top-level declarations extracted_\n"
+        : filteredDecls.map((d) => `- ${d.signature}`).join("\n") + "\n") +
+      "\n";
     if (used + block.length > charBudget && printed > 0) break;
     out += block;
     used += block.length;
     printed += 1;
   }
   if (printed === 0) {
-    out += '_no files extracted within budget_\n';
+    out += "_no files extracted within budget_\n";
   } else if (printed < top.length) {
     out += `_truncated to ${printed} files (token budget)_\n`;
   }
@@ -355,13 +401,13 @@ async function buildMap(args) {
 }
 
 function escapeRe(s) {
-  return s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  return s.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
 }
 
 // ---- Main ------------------------------------------------------------------
 
 const args = parseArgs(process.argv);
 buildMap(args).catch((err) => {
-  console.error('repo-map: fatal  - ', err.message);
+  console.error("repo-map: fatal  - ", err.message);
   process.exit(1);
 });

package/pipeline/scripts/review-scope.mjs

@@ -63,7 +63,13 @@ function main() {
   try {
     report = JSON.parse(readInput());
   } catch {
-    emit({ scope: "full", reason: "no-risk-data-fail-safe", churn: null, maxScore: null, blockers: [] });
+    emit({
+      scope: "full",
+      reason: "no-risk-data-fail-safe",
+      churn: null,
+      maxScore: null,
+      blockers: [],
+    });
     return;
   }
 

package/pipeline/scripts/routine-registry.mjs

@@ -25,14 +25,7 @@
 //
 // Exit: 0 ok, 1 error (validation / collision / not-found), 64 usage.
 
-import {
-  existsSync,
-  readFileSync,
-  writeFileSync,
-  mkdirSync,
-  rmSync,
-  renameSync,
-} from "node:fs";
+import { existsSync, readFileSync, writeFileSync, mkdirSync, rmSync, renameSync } from "node:fs";
 import { join, dirname } from "node:path";
 
 const NAME_RE = /^[a-z0-9][a-z0-9-]*$/;
@@ -200,7 +193,9 @@ function cmdRemove(home, name) {
     prefs.global.routines = routines;
     writePrefs(home, prefs);
   }
-  console.log(`routine-registry: removed "${name}" (clears from autocomplete on next session reload)`);
+  console.log(
+    `routine-registry: removed "${name}" (clears from autocomplete on next session reload)`,
+  );
 }
 
 function main() {

package/pipeline/scripts/run-aggregator.mjs

@@ -120,7 +120,9 @@ function loadCostTable() {
   const path = flags["cost-table"] || join(__dirname, "cost-table.json");
   const tbl = loadJson(path);
   if (!tbl?.prices) {
-    process.stderr.write(`run-aggregator: cost table missing or malformed at ${path}, costs will be 0\n`);
+    process.stderr.write(
+      `run-aggregator: cost table missing or malformed at ${path}, costs will be 0\n`,
+    );
     return { prices: {} };
   }
   return tbl;
@@ -211,8 +213,8 @@ for (const phase of tracker.phases || []) {
       phase.status === "completed"
         ? "phase.complete"
         : phase.status === "failed"
-        ? "phase.failed"
-        : "phase.transition";
+          ? "phase.failed"
+          : "phase.transition";
     events.push({
       kind: eventKind,
       ts: phase.completed_at,
@@ -262,7 +264,9 @@ const lastTs =
     .filter((e) => e.kind.startsWith("phase.complete") || e.kind === "phase.failed")
     .map((e) => e.ts)
     .sort()
-    .pop() || tracker.started_at || "";
+    .pop() ||
+  tracker.started_at ||
+  "";
 
 events.push({
   kind: "run.end",
@@ -286,7 +290,9 @@ const summary = {
 };
 
 // ─────────────────────────────────────────────────────────────────────────
-const outLines = (flags["summary-only"] ? [summary] : [...events, summary]).map((e) => JSON.stringify(e));
+const outLines = (flags["summary-only"] ? [summary] : [...events, summary]).map((e) =>
+  JSON.stringify(e),
+);
 const outContent = outLines.join("\n") + "\n";
 
 if (flags.stdout) {

package/pipeline/scripts/run-metrics.mjs

@@ -48,7 +48,9 @@ try {
 }
 
 let state;
-try { state = JSON.parse(raw); } catch (e) {
+try {
+  state = JSON.parse(raw);
+} catch (e) {
   console.error(`run-metrics: bad JSON: ${e.message}`);
   process.exit(2);
 }
@@ -58,7 +60,7 @@ try { state = JSON.parse(raw); } catch (e) {
 const iterations = Array.isArray(state.reviewIterations)
   ? state.reviewIterations.filter((it) => it && typeof it === "object")
   : [];
-const lastTriage = iterations.length ? (iterations[iterations.length - 1].triage || {}) : {};
+const lastTriage = iterations.length ? iterations[iterations.length - 1].triage || {} : {};
 
 const accepted = Array.isArray(lastTriage.accepted) ? lastTriage.accepted : [];
 const deferred = Array.isArray(lastTriage.deferred) ? lastTriage.deferred : [];
@@ -78,18 +80,21 @@ let rawFindings = 0;
 let acceptedAll = 0;
 let classifiedAll = 0;
 for (const it of iterations) {
-  for (const r of (Array.isArray(it.reviewers) ? it.reviewers : [])) {
+  for (const r of Array.isArray(it.reviewers) ? it.reviewers : []) {
     rawFindings += Array.isArray(r?.findings) ? r.findings.length : 0;
   }
   const t = it.triage || {};
   acceptedAll += Array.isArray(t.accepted) ? t.accepted.length : 0;
-  classifiedAll += (Array.isArray(t.accepted) ? t.accepted.length : 0)
-    + (Array.isArray(t.deferred) ? t.deferred.length : 0)
-    + (Array.isArray(t.rejected) ? t.rejected.length : 0);
+  classifiedAll +=
+    (Array.isArray(t.accepted) ? t.accepted.length : 0) +
+    (Array.isArray(t.deferred) ? t.deferred.length : 0) +
+    (Array.isArray(t.rejected) ? t.rejected.length : 0);
 }
 
 // Build outcome across repos (multi-repo aware).
-const projects = Array.isArray(state.projects) ? state.projects.filter((p) => p && typeof p === "object") : [];
+const projects = Array.isArray(state.projects)
+  ? state.projects.filter((p) => p && typeof p === "object")
+  : [];
 let buildPassed = null;
 if (projects.length) {
   buildPassed = projects.every((p) => {
@@ -100,7 +105,7 @@ if (projects.length) {
   });
 } else if (state.buildStatus !== undefined) {
   const b = state.buildStatus;
-  buildPassed = typeof b === "string" ? b === "passed" : (b && b.ok === true);
+  buildPassed = typeof b === "string" ? b === "passed" : b && b.ok === true;
 }
 
 const metrics = {