@mmerterden/multi-agent-pipeline 12.3.0 → 12.5.0

package/pipeline/scripts/smoke-routines.sh

@@ -0,0 +1,84 @@
+#!/usr/bin/env bash
+# smoke-routines.sh  -  contract for routine-registry.mjs, the backend of the
+# user-defined routine commands (/multi-agent:save, :routines, :forget).
+
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+RR="$SCRIPT_DIR/routine-registry.mjs"
+
+PASS=0
+FAIL=0
+record_pass() { PASS=$((PASS + 1)); printf '  \342\234\223 %s\n' "$1"; }
+record_fail() { FAIL=$((FAIL + 1)); printf '  \342\234\227 %s\n' "$1"; }
+
+printf '\342\206\222 smoke-routines: routine-registry backend contract\n'
+
+tmp=$(mktemp -d "${TMPDIR:-/tmp}/routines.XXXXXX")
+trap 'rm -rf "$tmp"' EXIT
+H="$tmp/home"
+mkdir -p "$H/.claude/commands/multi-agent"
+printf '{"global":{}}\n' > "$H/.claude/multi-agent-preferences.json"
+printf 'Run steps 1-6 of the checkin service migration.\n' > "$tmp/body.md"
+
+# 1. add -> writes a local-only command dir + registry entry
+node "$RR" add --name checkin-services --description "Checkin servis kontrolu" \
+  --source "CLAUDE.md" --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+skill="$H/.claude/commands/multi-agent/checkin-services/SKILL.md"
+if [ -f "$skill" ] && grep -qx "local-only: true" "$skill"; then
+  record_pass "add writes a local-only command SKILL.md"
+else
+  record_fail "add did not write a local-only routine command"
+fi
+if node "$RR" list --json --home "$H" | grep -q '"name": "checkin-services"'; then
+  record_pass "registry records the routine"
+else
+  record_fail "registry missing the routine"
+fi
+
+# 2. add is name-collision safe (same name rejected)
+node "$RR" add --name checkin-services --description x --source y --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "duplicate name rejected" || record_fail "duplicate name should reject"
+
+# 3. invalid name rejected
+node "$RR" add --name "Bad Name" --description x --source y --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "invalid name rejected" || record_fail "invalid name should reject"
+
+# 4. shipped-command guard: never remove a non-local-only command
+mkdir -p "$H/.claude/commands/multi-agent/status"
+printf -- '---\ndescription: "shipped"\n---\nbody\n' > "$H/.claude/commands/multi-agent/status/SKILL.md"
+node "$RR" remove --name status --home "$H" >/dev/null 2>&1
+if [ "$?" -eq 1 ] && [ -d "$H/.claude/commands/multi-agent/status" ]; then
+  record_pass "refuses to remove a shipped command"
+else
+  record_fail "shipped command must be protected"
+fi
+
+# 5. sync backstop proxy: the generated routine carries local-only:true, which is
+# exactly what sync/SKILL.md greps to keep it out of the public repo.
+if grep -qx "local-only: true" "$skill"; then
+  record_pass "routine is sync-excluded (local-only marker present)"
+else
+  record_fail "routine missing local-only marker (would leak on sync)"
+fi
+
+# 6. remove -> deletes dir + registry entry
+node "$RR" remove --name checkin-services --home "$H" >/dev/null 2>&1
+if [ ! -d "$H/.claude/commands/multi-agent/checkin-services" ] \
+  && ! node "$RR" list --json --home "$H" | grep -q "checkin-services"; then
+  record_pass "remove deletes dir + registry entry"
+else
+  record_fail "remove left dir or registry entry behind"
+fi
+
+# 7. install preservation proxy: snapshotLocalOnlyWrappers keys on local-only:true.
+# Re-add, then confirm the marker survives a simulated namespace re-read.
+node "$RR" add --name my-routine --description d --source s --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+if grep -qx "local-only: true" "$H/.claude/commands/multi-agent/my-routine/SKILL.md"; then
+  record_pass "re-added routine keeps the install-preserving marker"
+else
+  record_fail "re-added routine lost its local-only marker"
+fi
+
+printf '\n\342\225\220\342\225\220 smoke-routines: %d passed, %d failed \342\225\220\342\225\220\n' "$PASS" "$FAIL"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/triage-memory.mjs

@@ -84,6 +84,33 @@ function ensureDir(p) {
   mkdirSync(dirname(p), { recursive: true });
 }
 
+// Freshness gate (P1): stamp each finding with the git blob SHA of its file at
+// ingest time; on query, if the file's current content hash differs, the hit is
+// flagged stale so a reused finding is verified, not trusted blindly.
+function repoTop() {
+  try {
+    return execFileSync("git", ["rev-parse", "--show-toplevel"], {
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "ignore"],
+    }).trim() || null;
+  } catch {
+    return null;
+  }
+}
+
+function fileSha(file, top) {
+  if (!file || !top) return null;
+  try {
+    return execFileSync("git", ["hash-object", "--", file], {
+      cwd: top,
+      encoding: "utf8",
+      stdio: ["ignore", "pipe", "ignore"],
+    }).trim() || null;
+  } catch {
+    return null;
+  }
+}
+
 const STOP = new Set([
   "the","a","an","and","or","but","of","in","on","at","to","for","with","by","is","are",
   "be","been","being","this","that","these","those","it","its","as","not","no","do","does",
@@ -157,6 +184,7 @@ function ingest() {
   catch (e) { die(`cannot parse triage JSON: ${e.message}`, 1); }
 
   const ts = new Date().toISOString();
+  const top = repoTop();
   const corpus = readCorpus(slug);
   const seen = new Set(corpus.map((r) => `${r.task_id}::${r.classification}::${r.file}::${r.issue}`));
 
@@ -188,6 +216,7 @@ function ingest() {
         fix: f.fix || null,
         reason: f._reason || null,
         reviewer: f.reviewer || null,
+        file_sha: fileSha(file, top),
       };
       writeRow(slug, row);
       seen.add(key);
@@ -212,21 +241,30 @@ function query() {
   const qTokens = tokenize(issueText);
   const fileRe = fileGlob ? globToRegExp(fileGlob) : null;
   const filtered = fileRe ? corpus.filter((r) => fileRe.test(r.file || "")) : corpus.slice();
+  const top = repoTop();
   const ranked = filtered
     .map((r) => ({ row: r, score: score(qTokens, r) }))
     .filter((x) => x.score > 0 || qTokens.size === 0)
     .sort((a, b) => b.score - a.score)
     .slice(0, topN)
-    .map(({ row, score }) => ({
-      taskId: row.task_id,
-      classification: row.classification,
-      severity: row.severity,
-      file: row.file,
-      line: row.line,
-      issue: row.issue,
-      reason: row.reason,
-      score: Math.round(score * 1000) / 1000,
-    }));
+    .map(({ row, score }) => {
+      // Freshness: null when we cannot compare (no stored sha, or file gone /
+      // not in a git repo); true means the file changed since the finding was
+      // recorded, so verify before reusing.
+      const cur = row.file_sha ? fileSha(row.file, top) : null;
+      const stale = row.file_sha && cur ? cur !== row.file_sha : null;
+      return {
+        taskId: row.task_id,
+        classification: row.classification,
+        severity: row.severity,
+        file: row.file,
+        line: row.line,
+        issue: row.issue,
+        reason: row.reason,
+        stale,
+        score: Math.round(score * 1000) / 1000,
+      };
+    });
   process.stdout.write(JSON.stringify({ ok: true, slug, total: filtered.length, hits: ranked }) + "\n");
   process.exit(0);
 }

package/pipeline/skills/shared/core/multi-agent-forget/SKILL.md

@@ -0,0 +1,22 @@
+---
+name: multi-agent-forget
+language: en
+description: "Remove a saved /multi-agent routine (created by /multi-agent:save): deletes its local-only command and its registry entry. Asks which one and confirms."
+user-invocable: true
+argument-hint: "[name]"
+---
+
+# multi-agent-forget  -  Remove a Routine
+
+Delete a routine saved via `/multi-agent:save`. Backed by `$HOME/.copilot/scripts/routine-registry.mjs`.
+
+## Steps
+
+1. Resolve which routine: from `$ARGUMENTS`, else `routine-registry.mjs list --json` + `AskUserQuestion` (in `outputLanguage`). None -> nothing to forget.
+2. Confirm via `AskUserQuestion`: "Remove /multi-agent:<name>?" (Remove / Cancel). Anything but Remove -> stop.
+3. `node "$HOME/.copilot/scripts/routine-registry.mjs" remove --name "<name>"` (backend refuses to remove a shipped command; only a registered `local-only: true` dir).
+4. Report removed; note the autocomplete entry clears on the next session reload.
+
+## Notes
+
+- Only user-saved routines can be forgotten. See `/multi-agent:routines` for the list.

package/pipeline/skills/shared/core/multi-agent-routines/SKILL.md

@@ -0,0 +1,20 @@
+---
+name: multi-agent-routines
+language: en
+description: "List your saved /multi-agent routines (from /multi-agent:save) with what each one does, rendered in outputLanguage."
+user-invocable: true
+---
+
+# multi-agent-routines  -  List Saved Routines
+
+Show every routine saved via `/multi-agent:save`. Read-only. Backed by `$HOME/.copilot/scripts/routine-registry.mjs`.
+
+## Steps
+
+1. `node "$HOME/.copilot/scripts/routine-registry.mjs" list --json`
+2. Render in `outputLanguage`: empty -> say there are none yet and point to `/multi-agent:save`; otherwise a compact table of `/multi-agent:<name>` + description + created date.
+3. Flag any registry entry with no matching command dir (or vice versa) as `needs repair`; never modify anything.
+
+## Notes
+
+- Add with `/multi-agent:save`, remove with `/multi-agent:forget <name>`. Routines are local-only and never synced.

package/pipeline/skills/shared/core/multi-agent-save/SKILL.md

@@ -0,0 +1,27 @@
+---
+name: multi-agent-save
+language: en
+description: "Save a recurring job as a reusable /multi-agent:<name> command. Reviews the conversation + your CLAUDE.md for candidate routines, you pick one and name it; stored local-only, never synced."
+user-invocable: true
+argument-hint: "[name]"
+---
+
+# multi-agent-save  -  Save a Routine
+
+**Input**: $ARGUMENTS (optional routine name)
+
+Turn a recurring procedure into a reusable `/multi-agent:<name>` command. The routine is stored local-only (a `local-only: true` command + a `prefs.global.routines` entry) and is never synced. Backed by `$HOME/.copilot/scripts/routine-registry.mjs`.
+
+## Steps
+
+1. Distill candidates from what was just done (primary): group the tasks executed this session into coherent, repeatable jobs (suggested name + one-line summary + ordered steps). Then add named end-to-end procedures from `$HOME/.claude/CLAUDE.md`.
+2. `AskUserQuestion` with `multiSelect: true` (in `outputLanguage`): one option per candidate + an always-present `Other` free-text. One selected -> that routine; several selected -> combine into ONE routine (steps concatenated in shown order, single name); `Other` -> user types it. Empty is not consent.
+3. Name the command (from `$ARGUMENTS` or ask); validate `^[a-z0-9][a-z0-9-]*$`, <= 40 chars; the backend rejects collisions.
+4. Write the full procedure body to a temp file (single candidate: embed its steps, reference the CLAUDE.md section by name when that is the source; combined: concatenate the selected candidates' steps in order under numbered phase headings). Do not invent steps.
+5. Save: `node "$HOME/.copilot/scripts/routine-registry.mjs" add --name "<name>" --description "<summary>" --source "<source>" --body-file "/tmp/routine-<name>.md"`.
+6. Report it is available as `/multi-agent:<name>` after a session reload; offer to run it now.
+
+## Notes
+
+- Never writes under a repo `pipeline/` tree; routines live only under the CLI home.
+- List with `/multi-agent:routines`; remove with `/multi-agent:forget <name>`.

package/pipeline/skills/shared/core/multi-agent-sync/SKILL.md

@@ -29,7 +29,7 @@ Run all steps automatically:
 
 ```
 Step 1: DETECT      Compare timestamps, find stale targets
-Step 2: COPILOT     Claude Code -> Copilot CLI (instructions + 38 sub-command skills)
+Step 2: COPILOT     Claude Code -> Copilot CLI (instructions + 41 sub-command skills)
 Step 3: REPO        Claude Code -> pipeline repo (genericized, personal data scrub)
 Step 4: WEBSITE     Version + phase/model counts -> {website-host} (i18n + projects.ts)
 Step 5: Commit      Commit + push all changed repos
@@ -136,14 +136,14 @@ When invoked with the `release` argument:
 |-------------|-------------|
 | `~/.claude/commands/multi-agent/{cmd}.md` | `~/.copilot/skills/multi-agent-{cmd}/SKILL.md` |
 
-**38 commands are synced** (canonical inventory  -  must match `cross-cli-contract.md` section 1; drift = contract violation):
+**41 commands are synced** (canonical inventory  -  must match `cross-cli-contract.md` section 1; drift = contract violation):
 
 ```
 analysis, analysis-resolve, autopilot, build-optimize, channels, create-jira, dev,
-dev-autopilot, dev-local, dev-local-autopilot, diff-explain, finish, garbage-collect,
+dev-autopilot, dev-local, dev-local-autopilot, diff-explain, finish, forget, garbage-collect,
 help, issue, jira, kill, language, local,
 local-autopilot, log, manual-test, prune-logs, purge, refactor, resume, review, review-issue, review-jira,
-scan, search, setup, stack, status, sync, test, uninstall, update
+routines, save, scan, search, setup, stack, status, sync, test, uninstall, update
 ```
 
 **NOT synced**: `refs/*`  -  Lazy-load references, Claude Code specific