@mmerterden/multi-agent-pipeline 12.2.0 → 12.4.0

package/pipeline/scripts/smoke-migrate-state.sh

@@ -75,12 +75,12 @@ else
   fail "unknown flag did not exit 1"
 fi
 
-# Test 7  -  type auto-detection works
+# Test 7  -  type auto-detection works (feed a doc already at the latest version)
 cat > "$TMPDIR/multi-agent-preferences.json" <<'EOF'
-{"schemaVersion":"2.3.0","global":{"identities":[],"keychainMapping":{},"recentAccounts":[],"accounts":[]},"projects":{}}
+{"schemaVersion":"2.4.0","global":{"identities":[],"keychainMapping":{},"recentAccounts":[],"accounts":[],"routines":[]},"projects":{}}
 EOF
 OUT=$(node "$RUNNER" "$TMPDIR/multi-agent-preferences.json" 2>&1)
-if echo "$OUT" | grep -q "already at schemaVersion 2.3.0"; then
+if echo "$OUT" | grep -q "already at schemaVersion 2.4.0"; then
   pass "prefs type auto-detected from filename"
 else
   fail "prefs auto-detection failed (got: $OUT)"

package/pipeline/scripts/smoke-pref-migration.sh

@@ -64,7 +64,7 @@ F1=$(run_fixture "f1-v2.0.0-legacy" '{
   },
   "projects": {}
 }')
-assert_json_has "f1" "$F1" ".schemaVersion" "2.3.0"
+assert_json_has "f1" "$F1" ".schemaVersion" "2.4.0"
 assert_json_has "f1" "$F1" ".global.identities" "array:1"
 assert_json_has "f1" "$F1" ".global.gitIdentities" "undefined"
 assert_json_has "f1" "$F1" ".global.settings" "object:8"
@@ -73,6 +73,7 @@ assert_json_has "f1" "$F1" ".global.platformIdentityRouting" "object:0"
 assert_json_has "f1" "$F1" ".global.recentGroups" "array:0"
 assert_json_has "f1" "$F1" ".global.recentAccounts" "array:0"
 assert_json_has "f1" "$F1" ".global.accounts" "array:0"
+assert_json_has "f1" "$F1" ".global.routines" "array:0"
 
 echo ""
 echo "→ Fixture 2: no schemaVersion (pre-2.0.0 fossil)"
@@ -80,15 +81,15 @@ F2=$(run_fixture "f2-no-version" '{
   "global": {"gitIdentities": []},
   "projects": {}
 }')
-assert_json_has "f2" "$F2" ".schemaVersion" "2.3.0"
+assert_json_has "f2" "$F2" ".schemaVersion" "2.4.0"
 assert_json_has "f2" "$F2" ".global.identities" "array:0"
 
 echo ""
-echo "→ Fixture 3: v2.3.0 already (no-op)"
-F3_FILE="$TMP/f3-v2.3.0.json"
+echo "→ Fixture 3: v2.4.0 already (no-op)"
+F3_FILE="$TMP/f3-v2.4.0.json"
 cat > "$F3_FILE" <<'EOF'
 {
-  "schemaVersion": "2.3.0",
+  "schemaVersion": "2.4.0",
   "global": {
     "identities": [],
     "keychainMapping": {
@@ -117,7 +118,8 @@ cat > "$F3_FILE" <<'EOF'
     "wikiScope": ["main", "ios", "screenshots", "index"],
     "autopilotReportTimeoutSeconds": 1800,
     "recentAccounts": [],
-    "accounts": []
+    "accounts": [],
+    "routines": []
   },
   "projects": {}
 }

package/pipeline/scripts/smoke-review-readiness.sh

@@ -66,7 +66,7 @@ grep -Fq '| `review-jira ' "$DISPATCHER" && pass "dispatcher desc: review-jira"
 grep -Fq '| `review-issue ' "$DISPATCHER" && pass "dispatcher desc: review-issue" || fail "dispatcher desc missing review-issue"
 grep -Fq "review-jira/SKILL.md" "$DISPATCHER" && pass "dispatcher routing: review-jira" || fail "dispatcher routing missing review-jira"
 grep -Fq "review-issue/SKILL.md" "$DISPATCHER" && pass "dispatcher routing: review-issue" || fail "dispatcher routing missing review-issue"
-grep -Fq "## 1. Command Inventory (38 commands)" "$CONTRACT" && pass "contract count = 38" || fail "contract count wrong"
+grep -Fq "## 1. Command Inventory (41 commands)" "$CONTRACT" && pass "contract count = 41" || fail "contract count wrong"
 grep -Eq '(^|[ ,])review-jira([ ,]|$)' "$CONTRACT" && pass "contract inventory has review-jira" || fail "contract missing review-jira"
 grep -Eq '(^|[ ,])review-issue([ ,]|$)' "$CONTRACT" && pass "contract inventory has review-issue" || fail "contract missing review-issue"
 grep -Fq "multi-agent:review-jira" "$HELP" && pass "help lists review-jira" || fail "help missing review-jira"

package/pipeline/scripts/smoke-routines.sh

@@ -0,0 +1,84 @@
+#!/usr/bin/env bash
+# smoke-routines.sh  -  contract for routine-registry.mjs, the backend of the
+# user-defined routine commands (/multi-agent:save, :routines, :forget).
+
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+RR="$SCRIPT_DIR/routine-registry.mjs"
+
+PASS=0
+FAIL=0
+record_pass() { PASS=$((PASS + 1)); printf '  \342\234\223 %s\n' "$1"; }
+record_fail() { FAIL=$((FAIL + 1)); printf '  \342\234\227 %s\n' "$1"; }
+
+printf '\342\206\222 smoke-routines: routine-registry backend contract\n'
+
+tmp=$(mktemp -d "${TMPDIR:-/tmp}/routines.XXXXXX")
+trap 'rm -rf "$tmp"' EXIT
+H="$tmp/home"
+mkdir -p "$H/.claude/commands/multi-agent"
+printf '{"global":{}}\n' > "$H/.claude/multi-agent-preferences.json"
+printf 'Run steps 1-6 of the checkin service migration.\n' > "$tmp/body.md"
+
+# 1. add -> writes a local-only command dir + registry entry
+node "$RR" add --name checkin-services --description "Checkin servis kontrolu" \
+  --source "CLAUDE.md" --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+skill="$H/.claude/commands/multi-agent/checkin-services/SKILL.md"
+if [ -f "$skill" ] && grep -qx "local-only: true" "$skill"; then
+  record_pass "add writes a local-only command SKILL.md"
+else
+  record_fail "add did not write a local-only routine command"
+fi
+if node "$RR" list --json --home "$H" | grep -q '"name": "checkin-services"'; then
+  record_pass "registry records the routine"
+else
+  record_fail "registry missing the routine"
+fi
+
+# 2. add is name-collision safe (same name rejected)
+node "$RR" add --name checkin-services --description x --source y --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "duplicate name rejected" || record_fail "duplicate name should reject"
+
+# 3. invalid name rejected
+node "$RR" add --name "Bad Name" --description x --source y --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "invalid name rejected" || record_fail "invalid name should reject"
+
+# 4. shipped-command guard: never remove a non-local-only command
+mkdir -p "$H/.claude/commands/multi-agent/status"
+printf -- '---\ndescription: "shipped"\n---\nbody\n' > "$H/.claude/commands/multi-agent/status/SKILL.md"
+node "$RR" remove --name status --home "$H" >/dev/null 2>&1
+if [ "$?" -eq 1 ] && [ -d "$H/.claude/commands/multi-agent/status" ]; then
+  record_pass "refuses to remove a shipped command"
+else
+  record_fail "shipped command must be protected"
+fi
+
+# 5. sync backstop proxy: the generated routine carries local-only:true, which is
+# exactly what sync/SKILL.md greps to keep it out of the public repo.
+if grep -qx "local-only: true" "$skill"; then
+  record_pass "routine is sync-excluded (local-only marker present)"
+else
+  record_fail "routine missing local-only marker (would leak on sync)"
+fi
+
+# 6. remove -> deletes dir + registry entry
+node "$RR" remove --name checkin-services --home "$H" >/dev/null 2>&1
+if [ ! -d "$H/.claude/commands/multi-agent/checkin-services" ] \
+  && ! node "$RR" list --json --home "$H" | grep -q "checkin-services"; then
+  record_pass "remove deletes dir + registry entry"
+else
+  record_fail "remove left dir or registry entry behind"
+fi
+
+# 7. install preservation proxy: snapshotLocalOnlyWrappers keys on local-only:true.
+# Re-add, then confirm the marker survives a simulated namespace re-read.
+node "$RR" add --name my-routine --description d --source s --body-file "$tmp/body.md" --home "$H" >/dev/null 2>&1
+if grep -qx "local-only: true" "$H/.claude/commands/multi-agent/my-routine/SKILL.md"; then
+  record_pass "re-added routine keeps the install-preserving marker"
+else
+  record_fail "re-added routine lost its local-only marker"
+fi
+
+printf '\n\342\225\220\342\225\220 smoke-routines: %d passed, %d failed \342\225\220\342\225\220\n' "$PASS" "$FAIL"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/smoke-validate-analysis-doc.sh

@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# smoke-validate-analysis-doc.sh  -  contract for validate-analysis-doc.mjs,
+# the deterministic gate over an emitted /multi-agent:analysis document.
+
+set -uo pipefail
+
+SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
+V="$SCRIPT_DIR/validate-analysis-doc.mjs"
+
+PASS=0
+FAIL=0
+record_pass() { PASS=$((PASS + 1)); printf '  \342\234\223 %s\n' "$1"; }
+record_fail() { FAIL=$((FAIL + 1)); printf '  \342\234\227 %s\n' "$1"; }
+
+printf '\342\206\222 smoke-validate-analysis-doc: emitted-doc gate\n'
+
+tmp=$(mktemp -d "${TMPDIR:-/tmp}/vdoc.XXXXXX")
+trap 'rm -rf "$tmp"' EXIT
+
+# A well-formed Full-mode doc (neutral UserProfile domain, BR referenced downstream).
+cat > "$tmp/good.md" <<'MD'
+---
+feature: UserProfile
+platform: ios
+language: tr
+mode: full
+template_version: v3
+---
+## 1. Özet
+Profile screen.
+## 2. Hedefler ve Karşı Hedefler
+goals.
+## 4. Kullanıcı Hikayeleri
+### 4.4 İş Kuralları
+| BR-profile-01 | rule | source | Given/When/Then |
+## 9. API Kontratları
+api.
+## 13. Mimari Plan
+arch.
+## 14. Eklenecek Dosyalar
+files.
+## 15. Test Planı
+BR-profile-01 happy path.
+## 20. Riskler ve Açık Sorular
+risk.
+## 21. Referanslar
+refs.
+MD
+
+if node "$V" "$tmp/good.md" >/dev/null 2>&1; then
+  record_pass "well-formed Full doc passes (exit 0)"
+else
+  record_fail "well-formed doc should pass"
+fi
+
+# Lite doc without Section 15 must still pass (Locked 31 mode-aware).
+cat > "$tmp/lite.md" <<'MD'
+---
+feature: UserProfile
+platform: ios
+language: en
+mode: lite
+template_version: v3
+---
+## 1. Summary
+s
+## 2. Goals and Non-Goals
+g
+## 4. User Stories
+### 4.4 Business Rules
+| BR-profile-01 | rule | source | Given/When/Then |
+## 9. API Contracts
+a
+## 13. Architecture
+x
+## 14. Files to Add
+f
+## 20. Risks and Open Questions
+r
+## 21. References
+ref
+MD
+if node "$V" "$tmp/lite.md" >/dev/null 2>&1; then
+  record_pass "Lite doc (no Section 15) passes - mode-aware Locked 31"
+else
+  record_fail "Lite doc without Section 15 must pass"
+fi
+
+# Missing front-matter -> ERROR.
+printf '## 1. Summary\nno front matter\n' > "$tmp/nofm.md"
+node "$V" "$tmp/nofm.md" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "missing front-matter fails (exit 1)" || record_fail "missing front-matter should fail"
+
+# Banned punctuation (em-dash) -> ERROR.
+cp "$tmp/good.md" "$tmp/emdash.md"
+printf 'A line with an em-dash \342\200\224 here.\n' >> "$tmp/emdash.md"
+# Capture first (pipefail + node's nonzero exit would poison a direct pipe).
+emdash_out=$(node "$V" "$tmp/emdash.md" 2>&1 || true)
+if printf '%s' "$emdash_out" | grep -q "em-dash"; then
+  record_pass "em-dash flagged (Locked 7)"
+else
+  record_fail "em-dash should be flagged"
+fi
+
+# Missing a never-omitted section (References) -> ERROR.
+grep -v "Referanslar\|References" "$tmp/good.md" > "$tmp/noref.md"
+node "$V" "$tmp/noref.md" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "missing References section fails" || record_fail "missing References should fail"
+
+# Define-only BR under --strict -> fail (WARN promoted).
+cat > "$tmp/orphan.md" <<'MD'
+---
+feature: UserProfile
+platform: ios
+language: en
+mode: full
+template_version: v3
+---
+## 1. Summary
+s
+## 2. Goals
+g
+## 4. User Stories
+### 4.4 Business Rules
+| BR-profile-42 | rule | source | Given/When/Then |
+## 9. API Contracts
+a
+## 13. Architecture
+x
+## 14. Files to Add
+f
+## 15. Test Plan
+no BR reference here
+## 20. Risks
+r
+## 21. References
+ref
+MD
+node "$V" "$tmp/orphan.md" >/dev/null 2>&1
+[ "$?" -eq 0 ] && record_pass "define-only BR is WARN, not error (default)" || record_fail "orphan BR should not hard-fail by default"
+node "$V" "$tmp/orphan.md" --strict >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "define-only BR fails under --strict" || record_fail "orphan BR should fail under --strict"
+
+# ui_tests: true but no Section 15.6 -> ERROR.
+sed 's/^mode: full/mode: full\nui_tests: true\na11y_depth: basic/' "$tmp/good.md" > "$tmp/uimiss.md"
+node "$V" "$tmp/uimiss.md" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "ui_tests:true without Section 15.6 fails" || record_fail "ui_tests:true must require 15.6"
+
+# ui_tests: true WITH a Section 15.6 heading -> passes.
+cp "$tmp/uimiss.md" "$tmp/uiok.md"
+printf '## 15.6 UI test senaryolari\nUI-profile-01 flow.\n' >> "$tmp/uiok.md"
+node "$V" "$tmp/uiok.md" >/dev/null 2>&1
+[ "$?" -eq 0 ] && record_pass "ui_tests:true with Section 15.6 passes" || record_fail "ui_tests:true + 15.6 should pass"
+
+# a11y_depth: full but no Section 16.2 walkthrough -> ERROR.
+sed 's/^mode: full/mode: full\nui_tests: false\na11y_depth: full/' "$tmp/good.md" > "$tmp/a11ymiss.md"
+node "$V" "$tmp/a11ymiss.md" >/dev/null 2>&1
+[ "$?" -eq 1 ] && record_pass "a11y_depth:full without Section 16.2 fails" || record_fail "a11y_depth:full must require 16.2"
+
+printf '\n\342\225\220\342\225\220 smoke-validate-analysis-doc: %d passed, %d failed \342\225\220\342\225\220\n' "$PASS" "$FAIL"
+[ "$FAIL" -eq 0 ]

package/pipeline/scripts/validate-analysis-doc.mjs

@@ -0,0 +1,196 @@
+#!/usr/bin/env node
+// validate-analysis-doc.mjs  -  deterministic validator for an EMITTED
+// /multi-agent:analysis document (analysis/<feature>-<platform>.md).
+//
+// The analysis SKILL states many "fails the dispatch gate" invariants as prose
+// the model is asked to self-enforce. This turns the high-value, mechanically
+// checkable ones into a real gate so a malformed spec is caught before it is
+// handed to a human or to /multi-agent:dev.
+//
+// Zero deps. Reads one markdown file (path arg or STDIN).
+//
+// Checks (ERROR = blocking exit 1; WARN = advisory, still exit 0 unless --strict):
+//   - Front-matter block with required keys (feature, platform, language, mode,
+//     template_version); mode in {full, lite}; platform in the known set.
+//   - Never-omitted sections present by title keyword (Locked 2): Summary,
+//     Goals, User Stories, API Contracts, Architecture, Files to Add, Risks,
+//     References.
+//   - Humanizer punctuation policy (Locked 7): no em-dash / en-dash / ellipsis /
+//     section-sign / curly quotes anywhere in the body.
+//   - Traceability (Full mode only, Locked 31): every BR-<slug>-NN id defined in
+//     the Business Rules area is referenced again later (test / acceptance /
+//     analytics). A define-only rule is a WARN (heuristic).
+//   - No whole-section "TBD" / "Not applicable" placeholder bodies (Locked 2);
+//     the inline "[label TBD - see Open Questions]" marker is allowed.
+//
+// Usage:
+//   node validate-analysis-doc.mjs analysis/UserProfile-ios.md
+//   cat doc.md | node validate-analysis-doc.mjs -
+//   node validate-analysis-doc.mjs doc.md --strict   # WARN also fails
+//
+// Exit: 0 valid, 1 invalid (or WARN under --strict), 64 usage error.
+
+import { readFileSync } from "node:fs";
+
+const KNOWN_PLATFORMS = new Set(["ios", "android", "backend", "frontend"]);
+const REQUIRED_FM = ["feature", "platform", "language", "mode", "template_version"];
+
+// Never-omitted sections (Locked 2), matched by bilingual title keyword so the
+// re-flowed section numbering does not matter.
+const REQUIRED_SECTIONS = [
+  { key: "summary", any: ["Summary", "Özet", "Ozet"] },
+  { key: "goals", any: ["Goals", "Hedefler"] },
+  { key: "user stories", any: ["User Stories", "Kullanıcı Hikayeleri", "Kullanici Hikayeleri"] },
+  { key: "api contracts", any: ["API Contracts", "API Kontratları", "API Kontratlari"] },
+  { key: "architecture", any: ["Architecture", "Mimari"] },
+  { key: "files to add", any: ["Files to Add", "Eklenecek Dosyalar"] },
+  { key: "risks", any: ["Risks", "Riskler"] },
+  { key: "references", any: ["References", "Referanslar"] },
+];
+
+// Humanizer punctuation policy (Locked 7) - banned codepoints.
+const BANNED_PUNCT = [
+  { ch: "—", name: "em-dash" },
+  { ch: "–", name: "en-dash" },
+  { ch: "…", name: "ellipsis" },
+  { ch: "§", name: "section-sign" },
+  { ch: "“", name: "curly-double-open" },
+  { ch: "”", name: "curly-double-close" },
+  { ch: "‘", name: "curly-single-open" },
+  { ch: "’", name: "curly-single-close" },
+];
+
+function readInput() {
+  const args = process.argv.slice(2).filter((a) => a !== "--strict");
+  const arg = args[0];
+  if (!arg) {
+    console.error("usage: validate-analysis-doc.mjs <path|-> [--strict]");
+    process.exit(64);
+  }
+  if (arg === "-") return readFileSync(0, "utf-8");
+  return readFileSync(arg, "utf-8");
+}
+
+function parseFrontMatter(text) {
+  const lines = text.split("\n");
+  if (lines[0].trim() !== "---") return null;
+  const end = lines.indexOf("---", 1);
+  if (end < 0) return null;
+  const fm = {};
+  for (let i = 1; i < end; i++) {
+    const m = lines[i].match(/^([A-Za-z_][A-Za-z0-9_]*):\s*(.*)$/);
+    if (m) fm[m[1]] = m[2].trim();
+  }
+  return { fm, bodyStart: end + 1 };
+}
+
+function main() {
+  const text = readInput();
+  const strict = process.argv.includes("--strict");
+  const errors = [];
+  const warns = [];
+
+  // 1. Front-matter
+  const parsed = parseFrontMatter(text);
+  if (!parsed) {
+    errors.push("missing YAML front-matter block (--- ... ---) at the top");
+  } else {
+    for (const k of REQUIRED_FM) {
+      if (!parsed.fm[k]) errors.push(`front-matter missing required key: ${k}`);
+    }
+    const mode = parsed.fm.mode;
+    if (mode && mode !== "full" && mode !== "lite") {
+      errors.push(`front-matter mode must be full|lite, got: ${mode}`);
+    }
+    const plat = parsed.fm.platform;
+    if (plat && !KNOWN_PLATFORMS.has(plat)) {
+      errors.push(`front-matter platform not in known set: ${plat}`);
+    }
+  }
+  const mode = parsed?.fm?.mode || "full";
+
+  // 2. Never-omitted sections (by heading keyword)
+  const headings = text
+    .split("\n")
+    .filter((l) => /^#{1,3}\s/.test(l))
+    .map((l) => l.replace(/^#{1,3}\s/, "").trim());
+  const headingBlob = headings.join("\n");
+  for (const sec of REQUIRED_SECTIONS) {
+    if (!sec.any.some((kw) => headingBlob.includes(kw))) {
+      errors.push(`missing required section (Locked 2): ${sec.key}`);
+    }
+  }
+
+  // 2b. Opt-in coverage sections must be present when the front-matter says so.
+  const uiTests = String(parsed?.fm?.ui_tests || "false").toLowerCase() === "true";
+  const a11yDepth = String(parsed?.fm?.a11y_depth || "basic").toLowerCase();
+  const headingBlobLower = headingBlob.toLowerCase();
+  if (uiTests) {
+    const hasUi =
+      headingBlob.includes("15.6") ||
+      headingBlobLower.includes("ui test") ||
+      headingBlobLower.includes("ui-test");
+    if (!hasUi) {
+      errors.push("front-matter ui_tests: true but no Section 15.6 UI test scenarios found (Locked 31)");
+    }
+  }
+  if (a11yDepth === "full") {
+    const hasWalkthrough =
+      headingBlob.includes("16.2") ||
+      headingBlobLower.includes("walkthrough") ||
+      headingBlobLower.includes("gezinme");
+    if (!hasWalkthrough) {
+      errors.push("front-matter a11y_depth: full but no Section 16.2 screen-reader walkthrough found");
+    }
+  }
+
+  // 3. Humanizer punctuation
+  const bodyLines = text.split("\n");
+  for (let i = 0; i < bodyLines.length; i++) {
+    for (const b of BANNED_PUNCT) {
+      if (bodyLines[i].includes(b.ch)) {
+        errors.push(`banned punctuation ${b.name} at line ${i + 1} (Locked 7 humanizer policy)`);
+      }
+    }
+  }
+
+  // 4. Placeholder whole-section bodies (Locked 2)
+  if (/^\s*(TBD|Not applicable|N\/A)\s*$/im.test(text)) {
+    warns.push('a line is a bare "TBD"/"Not applicable"/"N/A" body; omit the section instead (Locked 2)');
+  }
+
+  // 5. Traceability (Full mode only, Locked 31)
+  if (mode === "full") {
+    const idRe = /BR-[a-z0-9]+(?:-[a-z0-9]+)*-\d+/gi;
+    const all = text.match(idRe) || [];
+    const counts = new Map();
+    for (const id of all) {
+      const key = id.toUpperCase();
+      counts.set(key, (counts.get(key) || 0) + 1);
+    }
+    if (counts.size === 0) {
+      warns.push("Full mode but no BR-<slug>-NN business-rule ids found (Section 4.4 / Locked 31)");
+    }
+    for (const [id, n] of counts) {
+      if (n < 2) {
+        warns.push(`business rule ${id} is defined but never referenced downstream (test/acceptance/analytics) - Locked 31 traceability`);
+      }
+    }
+  }
+
+  // Report
+  for (const w of warns) console.error(`WARN: ${w}`);
+  for (const e of errors) console.error(`ERROR: ${e}`);
+  if (errors.length > 0) {
+    console.error(`validate-analysis-doc: FAIL (${errors.length} error(s), ${warns.length} warning(s))`);
+    process.exit(1);
+  }
+  if (strict && warns.length > 0) {
+    console.error(`validate-analysis-doc: FAIL under --strict (${warns.length} warning(s))`);
+    process.exit(1);
+  }
+  console.log(`validate-analysis-doc: OK (mode=${mode}, ${warns.length} warning(s))`);
+  process.exit(0);
+}
+
+main();

package/pipeline/skills/shared/core/multi-agent-forget/SKILL.md

@@ -0,0 +1,22 @@
+---
+name: multi-agent-forget
+language: en
+description: "Remove a saved /multi-agent routine (created by /multi-agent:save): deletes its local-only command and its registry entry. Asks which one and confirms."
+user-invocable: true
+argument-hint: "[name]"
+---
+
+# multi-agent-forget  -  Remove a Routine
+
+Delete a routine saved via `/multi-agent:save`. Backed by `$HOME/.copilot/scripts/routine-registry.mjs`.
+
+## Steps
+
+1. Resolve which routine: from `$ARGUMENTS`, else `routine-registry.mjs list --json` + `AskUserQuestion` (in `outputLanguage`). None -> nothing to forget.
+2. Confirm via `AskUserQuestion`: "Remove /multi-agent:<name>?" (Remove / Cancel). Anything but Remove -> stop.
+3. `node "$HOME/.copilot/scripts/routine-registry.mjs" remove --name "<name>"` (backend refuses to remove a shipped command; only a registered `local-only: true` dir).
+4. Report removed; note the autocomplete entry clears on the next session reload.
+
+## Notes
+
+- Only user-saved routines can be forgotten. See `/multi-agent:routines` for the list.

package/pipeline/skills/shared/core/multi-agent-routines/SKILL.md

@@ -0,0 +1,20 @@
+---
+name: multi-agent-routines
+language: en
+description: "List your saved /multi-agent routines (from /multi-agent:save) with what each one does, rendered in outputLanguage."
+user-invocable: true
+---
+
+# multi-agent-routines  -  List Saved Routines
+
+Show every routine saved via `/multi-agent:save`. Read-only. Backed by `$HOME/.copilot/scripts/routine-registry.mjs`.
+
+## Steps
+
+1. `node "$HOME/.copilot/scripts/routine-registry.mjs" list --json`
+2. Render in `outputLanguage`: empty -> say there are none yet and point to `/multi-agent:save`; otherwise a compact table of `/multi-agent:<name>` + description + created date.
+3. Flag any registry entry with no matching command dir (or vice versa) as `needs repair`; never modify anything.
+
+## Notes
+
+- Add with `/multi-agent:save`, remove with `/multi-agent:forget <name>`. Routines are local-only and never synced.

package/pipeline/skills/shared/core/multi-agent-save/SKILL.md

@@ -0,0 +1,27 @@
+---
+name: multi-agent-save
+language: en
+description: "Save a recurring job as a reusable /multi-agent:<name> command. Reviews the conversation + your CLAUDE.md for candidate routines, you pick one and name it; stored local-only, never synced."
+user-invocable: true
+argument-hint: "[name]"
+---
+
+# multi-agent-save  -  Save a Routine
+
+**Input**: $ARGUMENTS (optional routine name)
+
+Turn a recurring procedure into a reusable `/multi-agent:<name>` command. The routine is stored local-only (a `local-only: true` command + a `prefs.global.routines` entry) and is never synced. Backed by `$HOME/.copilot/scripts/routine-registry.mjs`.
+
+## Steps
+
+1. Distill candidates from what was just done (primary): group the tasks executed this session into coherent, repeatable jobs (suggested name + one-line summary + ordered steps). Then add named end-to-end procedures from `$HOME/.claude/CLAUDE.md`.
+2. `AskUserQuestion` with `multiSelect: true` (in `outputLanguage`): one option per candidate + an always-present `Other` free-text. One selected -> that routine; several selected -> combine into ONE routine (steps concatenated in shown order, single name); `Other` -> user types it. Empty is not consent.
+3. Name the command (from `$ARGUMENTS` or ask); validate `^[a-z0-9][a-z0-9-]*$`, <= 40 chars; the backend rejects collisions.
+4. Write the full procedure body to a temp file (single candidate: embed its steps, reference the CLAUDE.md section by name when that is the source; combined: concatenate the selected candidates' steps in order under numbered phase headings). Do not invent steps.
+5. Save: `node "$HOME/.copilot/scripts/routine-registry.mjs" add --name "<name>" --description "<summary>" --source "<source>" --body-file "/tmp/routine-<name>.md"`.
+6. Report it is available as `/multi-agent:<name>` after a session reload; offer to run it now.
+
+## Notes
+
+- Never writes under a repo `pipeline/` tree; routines live only under the CLI home.
+- List with `/multi-agent:routines`; remove with `/multi-agent:forget <name>`.

package/pipeline/skills/shared/core/multi-agent-sync/SKILL.md

@@ -29,7 +29,7 @@ Run all steps automatically:
 
 ```
 Step 1: DETECT      Compare timestamps, find stale targets
-Step 2: COPILOT     Claude Code -> Copilot CLI (instructions + 38 sub-command skills)
+Step 2: COPILOT     Claude Code -> Copilot CLI (instructions + 41 sub-command skills)
 Step 3: REPO        Claude Code -> pipeline repo (genericized, personal data scrub)
 Step 4: WEBSITE     Version + phase/model counts -> {website-host} (i18n + projects.ts)
 Step 5: Commit      Commit + push all changed repos
@@ -136,14 +136,14 @@ When invoked with the `release` argument:
 |-------------|-------------|
 | `~/.claude/commands/multi-agent/{cmd}.md` | `~/.copilot/skills/multi-agent-{cmd}/SKILL.md` |
 
-**38 commands are synced** (canonical inventory  -  must match `cross-cli-contract.md` section 1; drift = contract violation):
+**41 commands are synced** (canonical inventory  -  must match `cross-cli-contract.md` section 1; drift = contract violation):
 
 ```
 analysis, analysis-resolve, autopilot, build-optimize, channels, create-jira, dev,
-dev-autopilot, dev-local, dev-local-autopilot, diff-explain, finish, garbage-collect,
+dev-autopilot, dev-local, dev-local-autopilot, diff-explain, finish, forget, garbage-collect,
 help, issue, jira, kill, language, local,
 local-autopilot, log, manual-test, prune-logs, purge, refactor, resume, review, review-issue, review-jira,
-scan, search, setup, stack, status, sync, test, uninstall, update
+routines, save, scan, search, setup, stack, status, sync, test, uninstall, update
 ```
 
 **NOT synced**: `refs/*`  -  Lazy-load references, Claude Code specific