@mmerterden/multi-agent-pipeline 11.4.0 → 11.5.0

package/pipeline/scripts/write-state.mjs

@@ -130,6 +130,10 @@ function isLockStale(lockPath, staleMs) {
   }
 }
 
+// Path whose lock this process currently holds (null when none). Lets the
+// top-level error handler release our lock on unexpected failures.
+let heldLockFor = null;
+
 /** @param {string} path */
 function releaseLock(path) {
   const lockPath = `${path}.lock`;
@@ -138,6 +142,7 @@ function releaseLock(path) {
   } catch {
     /* already gone  -  fine */
   }
+  if (heldLockFor === path) heldLockFor = null;
 }
 
 /**
@@ -178,6 +183,7 @@ async function main() {
 
   try {
     await acquireLock(path);
+    heldLockFor = path;
   } catch (err) {
     if (err.code === "LOCK_TIMEOUT") {
       console.error(err.message);
@@ -187,6 +193,10 @@ async function main() {
     process.exit(3);
   }
 
+  // process.exit() inside a try block skips `finally`, so every exit path in
+  // here must release OUR lock explicitly before exiting - otherwise a corrupt
+  // state file (or any I/O error) leaks agent-state.json.lock and blocks the
+  // next writer until the stale-lock window elapses.
   try {
     let next;
     if (replace) {
@@ -198,8 +208,7 @@ async function main() {
         try {
           current = JSON.parse(readFileSync(path, "utf-8"));
         } catch (err) {
-          console.error(`write-state: existing state unreadable  -  ${err.message}`);
-          process.exit(3);
+          throw new Error(`existing state unreadable  -  ${err.message}`, { cause: err });
         }
       }
       next = deepMerge(current, payload);
@@ -210,15 +219,16 @@ async function main() {
     renameSync(tmp, path); // atomic on POSIX
   } catch (err) {
     console.error(`write-state: ${err.message}`);
-    process.exit(3);
-  } finally {
     releaseLock(path);
+    process.exit(3);
   }
 
+  releaseLock(path);
   process.exit(0);
 }
 
 main().catch((err) => {
   console.error(`write-state: unhandled  -  ${err.message}`);
+  if (heldLockFor) releaseLock(heldLockFor);
   process.exit(3);
 });