@mmerterden/multi-agent-pipeline 11.2.0 → 11.3.1

package/pipeline/skills/figma-ios/figma-to-component/phases/phase-4e-modifiers.md

@@ -1,262 +0,0 @@
-# PHASE 4E  -  View Modifiers Extension (+Modifiers)
-
-Generate `{ComponentName}+Modifiers.swift`  -  a thin extension on the View that forwards each Configuration property as a discoverable chain modifier method.
-
-CONDITIONAL: Only for COMPLEX components with `@GenerateViewConfiguration` + Configuration pattern.
-SEQUENTIAL: Runs AFTER Phase 4A (Configuration) and Phase 4B (View) complete.
-
-**NOTE:** `@GenerateViewConfiguration` generates ONLY the `configured()` method. It CANNOT generate View-level forwarding modifiers because Swift macros cannot introspect types other than the one they're attached to  -  the Configuration struct's properties are invisible to a macro on the View. This phase (AI-written +Modifiers) is ALWAYS required for COMPLEX components.
-
----
-
-## CONTEXT VARIABLES
-
-Provided by the orchestrator:
-- `componentName`  -  e.g., "TurkishButton"
-- `componentLocation`  -  e.g., "{repos.components.path}/Sources/UIComponents/Components/DesignSystemCore/Button/TurkishButton"
-- `artifactPath`  -  path to implementation artifacts
-- `complexity`  -  must be COMPLEX (skip if SIMPLE)
-- `gitUser`  -  git user name for file header
-- `date`  -  DD.MM.YYYY format
-
----
-
-## PRE-CHECK
-
-1. **Complexity gate**: If `complexity` is SIMPLE → skip this phase entirely (no Configuration = no modifiers to forward).
-
-2. **Verify files exist**:
-   ```
-   {componentLocation}/{ComponentName}.swift               -  View (Phase 4B)
-   {componentLocation}/{ComponentName}Configuration.swift  -  Configuration (Phase 4A)
-   ```
-   Both must exist. Missing → HALT.
-
-3. **Read Configuration**: Parse all `public let` properties from `{ComponentName}Configuration.swift`. Extract:
-   - Property name
-   - Property type
-   - Whether it's optional (e.g., `Image?`)
-
-HALT if pre-check fails:
-```
-STATUS: HALT
-PHASE: phase-4e
-GATE: PRE_CHECK
-REASON: {ComponentName}Configuration.swift not found. Phase 4A must complete first.
-```
-
----
-
-## ARCHITECTURAL RULE  -  Configuration Purity
-
-**Configuration structs hold ONLY declarative, value-type properties.**
-
-The following MUST NOT be in Configuration  -  they are direct View dependencies:
-
-| Excluded Type | Reason | Where It Lives |
-|---------------|--------|----------------|
-| Closures (`() -> Void`, `(T) -> Void`) | Side effects, not declarative state | View property: `private let action: () -> Void` |
-| `@Binding` / `Binding<T>` | Reference semantics, not value type | View property: `@Binding var isPresented: Bool` |
-| `@State` / `@ObservedObject` | SwiftUI state management | View property |
-| `AnyView` / `@ViewBuilder` closures | View composition, not configuration | View property or generic parameter |
-
-**Consequence for +Modifiers:** Only Configuration properties get forwarding methods. View dependencies (closures, bindings) are set at init time or via paired modifiers (Phase 4B). Paired modifiers (data+closure combined) live in the View file, not in +Modifiers.
-
-**CRITICAL  -  Skip rules for forwarding modifiers:**
-1. **Coexistent/paired properties (PAIRED_ACTION_SUBCOMPONENT):** Do NOT generate forwarding modifiers for config properties that are the data half of a paired modifier (e.g., `secondaryButtonTitle`). Setting title without action creates a nonsensical state. These are ONLY set via paired modifiers in the View file (e.g., `.secondaryButton(title) { action }`).
-2. **Init-param properties:** Do NOT generate forwarding modifiers for config properties that are required init parameters (e.g., `primaryButtonTitle`). These are set once at construction and should not be modified after init.
-
-**`configured()` is internal API.** It is used ONLY inside +Modifiers forwarding methods and paired modifiers. Consumers use the named forwarding modifiers (`.state()`, `.title()`) and paired modifiers (`.secondaryButton(title) { action }`). Never expose `configured()` in Code Connect, previews, or usage examples.
-
----
-
-## GATE 1: GENERATE_MODIFIERS_FILE
-
-### 1.1 File Location
-
-```
-{componentLocation}/{ComponentName}+Modifiers.swift
-```
-
-### 1.2 Template
-
-```swift
-//
-//  {ComponentName}+Modifiers.swift
-//  UIComponents
-//
-//  Created by {gitUser} on {date}.
-//
-
-import SwiftUI
-
-// MARK: - {ComponentName} Modifiers
-
-extension {ComponentName} {
-
-    /// Returns a new {ComponentName} with the specified {propertyName}.
-    ///
-    /// - Parameter {paramName}: {brief description from Configuration doc comment}
-    /// - Returns: A new {ComponentName} instance with the updated {propertyName}
-    public func {methodName}(_ value: {PropertyType}) -> {ComponentName} {
-        configured { $0.{configMethodName}(value) }
-    }
-}
-```
-
-### 1.3 Method Generation Rules
-
-For each `public let` property in the Configuration:
-
-| Configuration Property | Generated Method |
-|------------------------|-----------------|
-| `let title: String` | `func title(_ value: String) -> Self` |
-| `let style: Style` | `func style(_ value: {ComponentName}Configuration.Style) -> Self` |
-| `let icon: Image?` | `func icon(_ value: Image?) -> Self` |
-
-**Naming rules:**
-- Method name = property name (same as Configuration chain modifier)
-- Parameter label: `_ value` (unlabeled, matches Configuration pattern)
-- Return type: the concrete View type (e.g., `TurkishButton`), NOT `Self` or `some View`
-- Nested enum types: use fully qualified path from Configuration (e.g., `TurkishButtonConfiguration.Style`)
-
-**Body**: Always delegates to `configured { $0.{propertyName}(value) }`.
-
-### 1.4 Localized String Overloads
-
-For each `String` property that does NOT have `@IgnoreLocalization` on the Configuration:
-
-```swift
-    /// Returns a new {ComponentName} with a localized {propertyName}.
-    ///
-    /// - Parameter value: The localization key to resolve
-    /// - Returns: A new {ComponentName} instance with the localized {propertyName}
-    public func {methodName}(localized value: LocalizationStringKey) -> {ComponentName} {
-        configured { $0.{configMethodName}(localized: value) }
-    }
-```
-
-If any localized overload is generated, add `import CoreLocalization` to the file imports.
-
-### 1.5 Skip Rules
-
-Do NOT generate a modifier for properties marked with `@IgnoreChainModifier` in the Configuration.
-
----
-
-## GATE 2: VALIDATE
-
-1. **File exists**: `{componentLocation}/{ComponentName}+Modifiers.swift`
-2. **Method count**: Number of generated methods ≥ number of Configuration `public let` properties (excluding `@IgnoreChainModifier`)
-3. **No closures/bindings**: Verify no method accepts closure or Binding parameter types
-4. **Build check**: The file should compile (validated in Phase 4 orchestrator build step)
-
----
-
-## GATE 3: UPDATE_PREVIEW
-
-After generating the +Modifiers file, check if the Preview structs in `{ComponentName}.swift` can benefit from the new API. Do NOT change Preview  -  it should continue using the `{ config in ... }` pattern for clarity. The +Modifiers API is for call-site usage, not previews.
-
----
-
-## EXAMPLE OUTPUT
-
-For `TurkishButton` with Configuration properties `title`, `style`, `size`, `colorTheme`, `icon`, `iconPosition`:
-
-```swift
-//
-//  TurkishButton+Modifiers.swift
-//  UIComponents
-//
-//  Created by SELAHATTIN MUHAMMET DULGEROGLU on 03.03.2026.
-//
-
-import CoreLocalization
-import SwiftUI
-
-// MARK: - TurkishButton Modifiers
-
-extension TurkishButton {
-
-    /// Returns a new TurkishButton with the specified title.
-    ///
-    /// - Parameter value: The button title text
-    /// - Returns: A new TurkishButton instance with the updated title
-    public func title(_ value: String) -> TurkishButton {
-        configured { $0.title(value) }
-    }
-
-    /// Returns a new TurkishButton with a localized title.
-    ///
-    /// - Parameter value: The localization key to resolve
-    /// - Returns: A new TurkishButton instance with the localized title
-    public func title(localized value: LocalizationStringKey) -> TurkishButton {
-        configured { $0.title(localized: value) }
-    }
-
-    /// Returns a new TurkishButton with the specified style.
-    ///
-    /// - Parameter value: The visual style (primary, secondary, ghost)
-    /// - Returns: A new TurkishButton instance with the updated style
-    public func style(_ value: TurkishButtonConfiguration.Style) -> TurkishButton {
-        configured { $0.style(value) }
-    }
-
-    /// Returns a new TurkishButton with the specified size.
-    ///
-    /// - Parameter value: The button size (xlarge, default, medium, small)
-    /// - Returns: A new TurkishButton instance with the updated size
-    public func size(_ value: TurkishButtonConfiguration.Size) -> TurkishButton {
-        configured { $0.size(value) }
-    }
-
-    /// Returns a new TurkishButton with the specified color theme.
-    ///
-    /// - Parameter value: The color theme (brand, white)
-    /// - Returns: A new TurkishButton instance with the updated color theme
-    public func colorTheme(_ value: TurkishButtonConfiguration.ColorTheme) -> TurkishButton {
-        configured { $0.colorTheme(value) }
-    }
-
-    /// Returns a new TurkishButton with the specified icon.
-    ///
-    /// - Parameter value: The icon image, or `nil` to hide
-    /// - Returns: A new TurkishButton instance with the updated icon
-    public func icon(_ value: Image?) -> TurkishButton {
-        configured { $0.icon(value) }
-    }
-
-    /// Returns a new TurkishButton with the specified icon position.
-    ///
-    /// - Parameter value: The icon position (leading, trailing)
-    /// - Returns: A new TurkishButton instance with the updated icon position
-    public func iconPosition(_ value: TurkishButtonConfiguration.IconPosition) -> TurkishButton {
-        configured { $0.iconPosition(value) }
-    }
-}
-```
-
-**Call-site usage becomes:**
-```swift
-// Before (configuration closure):
-TurkishButton { $0.title("Book Now").style(.primary).size(.xlarge) } action: { }
-
-// After (+Modifiers):
-TurkishButton(action: { })
-    .title("Book Now")
-    .style(.primary)
-    .size(.xlarge)
-```
-
----
-
-## SUCCESS OUTPUT
-
-```
-STATUS: COMPLETE
-PHASE: phase-4e
-GATES_PASSED: [PRE_CHECK, GENERATE_MODIFIERS_FILE, VALIDATE, UPDATE_PREVIEW]
-ARTIFACTS_CREATED:
-  - {componentLocation}/{ComponentName}+Modifiers.swift
-SUMMARY: Generated {COUNT} modifier methods forwarding Configuration properties. Closures/Bindings excluded per architectural rule.
-```