@mmerterden/multi-agent-pipeline 11.1.0 → 11.3.0

package/pipeline/skills/figma-ios/figma-to-component/phases/phase-5a-viewinspector.md

@@ -1,274 +0,0 @@
-# PHASE 5A  -  ViewInspector Structure Tests
-
-ViewInspector-based tests verifying view hierarchy, text content, and accessibility identifiers.
-
-PARENT: `phase-5-orchestrator.md`
-required  -  always execute this sub-phase.
-
-**FRAMEWORK**: XCTest (NOT Swift Testing  -  ViewInspector has issues with `@Test`, see GitHub #319)
-
-### Naming Convention
-
-REF: [Kodeco  -  iOS Test-Driven Development by Tutorials](https://www.kodeco.com/books/ios-test-driven-development-by-tutorials/v2.0/chapters/3-tdd-app-setup)
-
-Pattern: `test_{systemUnderTest}_{whenCondition}_{expectedResult}`
-
-For accessibility identifier tests: `test_{elementName}_hasAccessibilityIdentifier()`
-
----
-
-## PRE-CHECK: Load Test Index
-
-```
-Read: {artifactPath}/pass5/_test_index.md
-```
-
-EXTRACT:
-- `componentName`
-- `sourceModule`
-- `componentPath`
-- Artifact paths for: component_properties.json, utility_identifiers.md, utility_integration.md, complexity
-
-Then read the actual artifacts via the paths from the index.
-
-If test index missing → HALT, run orchestrator first.
-
----
-
-## GATE 1: DETERMINE_TEST_LOCATION
-
-### 1.1 Path Derivation
-
-```
-Test Target: {sourceModule}Tests
-Test Dir:    Tests/{sourceModule}Tests/ViewInspector/{componentPath}/
-Test File:   {componentName}ViewInspectorTests.swift
-```
-
-### 1.2 Verify test target exists in Package.swift
-
-| Check | Pass | Fail |
-|-------|------|------|
-| `{sourceModule}Tests` target exists | Proceed | HALT  -  add test target first |
-| Dependencies include ExternalViewInspector, ExternalSnapshotTesting | Proceed | HALT |
-
----
-
-## GATE 2: CREATE_TEST_FILE
-
-### 2.1 Template
-
-Follow the established project pattern (see `ExploreCityDetailAboutCityViewInspectorTests.swift`):
-
-```swift
-//
-//  {componentName}ViewInspectorTests.swift
-//  {sourceModule}Tests
-//
-//  Created by {AUTHOR} on {DD.MM.YYYY}.
-//
-
-import SwiftUI
-import ViewInspector
-import XCTest
-@testable import {sourceModule}
-
-// NOTE: Do NOT add `extension {componentName}: Inspectable {}`  -  deprecated since ViewInspector 0.10+
-
-@MainActor
-final class {componentName}ViewInspectorTests: XCTestCase {
-
-    // MARK: - Structure Tests
-
-    func test_viewExists() throws {
-        let sut = makeSUT()
-        let inspected = try sut.inspect()
-        XCTAssertNotNil(inspected)
-    }
-
-    // MARK: - Helpers
-
-    private func makeSUT(/* variant params */) -> {componentName} {
-        // Use closure init pattern from @GenerateConfiguredInit
-        {componentName} { config in
-            config
-                .{property1}({sampleValue1})
-                .{property2}({sampleValue2})
-        }
-    }
-}
-```
-
-### 2.2 Init Pattern
-
-**COMPLEX components** (with Configuration struct + `@GenerateConfiguredInit`):
-```swift
-private func makeSUT() -> {componentName} {
-    {componentName} { config in
-        config
-            .text("Lorem")
-            .state(.success)
-    }
-}
-```
-
-**SIMPLE components** (direct init, no Configuration):
-```swift
-private func makeSUT() -> {componentName} {
-    {componentName}(title: "Lorem", state: .active)
-}
-```
-
-Read `pass3/05_complexity.md` to determine which pattern to use.
-
----
-
-## GATE 3: IMPLEMENT_STRUCTURE_TESTS
-
-### 3.1 View Existence
-
-Always include:
-```swift
-func test_viewExists() throws {
-    let sut = makeSUT()
-    let inspected = try sut.inspect()
-    XCTAssertNotNil(inspected)
-}
-```
-
-### 3.2 Text Content Tests
-
-From component_properties.json TEXT properties and pass3/04b architecture:
-
-```swift
-func test_containsExpectedText() throws {
-    let sut = makeSUT()
-    let text = try sut.inspect().find(text: "{sampleText}")
-    XCTAssertNotNil(text)
-}
-```
-
-### 3.3 Subview Existence Tests
-
-From component body structure:
-
-```swift
-func test_containsExpectedSubviews() throws {
-    let sut = makeSUT()
-    let texts = try sut.inspect().findAll(ViewType.Text.self)
-    XCTAssertGreaterThanOrEqual(texts.count, {expectedCount})
-}
-```
-
-### 3.4 Variant Rendering Tests
-
-From component_properties.json VARIANT properties with CaseIterable enums:
-
-```swift
-func test_allStatesRender() throws {
-    for state in {componentName}Configuration.{EnumName}.allCases {
-        let sut = {componentName} { config in
-            config
-                .text("Lorem")
-                .state(state)
-        }
-        let inspected = try sut.inspect()
-        XCTAssertNotNil(inspected, "State \(state) failed to render")
-    }
-}
-```
-
-### 3.5 Optional Content Tests
-
-For optional properties (Image?, String?):
-
-```swift
-func test_hidesIconWhenNil() throws {
-    let sut = {componentName} { config in
-        config.text("Lorem").state(.success)
-        // leftIcon is nil by default
-    }
-    let images = try sut.inspect().findAll(ViewType.Image.self)
-    XCTAssertEqual(images.count, 0)
-}
-
-func test_showsIconWhenProvided() throws {
-    let sut = {componentName} { config in
-        config
-            .text("Lorem")
-            .state(.success)
-            .leftIcon(Image(systemName: "checkmark"))
-    }
-    let image = try sut.inspect().find(ViewType.Image.self)
-    XCTAssertNotNil(image)
-}
-```
-
----
-
-## GATE 4: IMPLEMENT_ACCESSIBILITY_IDENTIFIER_TESTS
-
-Read testing identifiers from `pass2/utility_identifiers.md` (via index paths).
-
-For each identifier:
-
-```swift
-// MARK: - Accessibility Identifier Tests
-
-func test_{elementName}_hasAccessibilityIdentifier() throws {
-    let sut = makeSUT()
-    let element = try sut.inspect().find(
-        viewWithAccessibilityIdentifier: "{identifier_value}"
-    )
-    XCTAssertNotNil(element)
-}
-```
-
-**IMPORTANT:** Use the raw identifier VALUE string (e.g., `"labelbadge_badge"`), not the key path notation. ViewInspector matches the actual string applied via `.accessibilityIdentifier()`.
-
-Generate one test per identifier listed in the utility_identifiers artifact.
-
----
-
-## GATE 5: RUN_TESTS
-
-**IMPORTANT:** Use `xcodebuild`, NOT `swift test`. The project uses Xcode-specific features (`ColorResource`, `ImageResource`, asset catalogs) that are unavailable in SPM's `swift build`/`swift test`.
-
-```bash
-cd {repos.components.path} && \
-xcodebuild test \
-  -scheme UIComponents-Package \
-  -destination 'platform=iOS Simulator,name=iPhone 17 Pro' \
-  -only-testing:{sourceModule}Tests/{componentName}ViewInspectorTests
-```
-
-| Result | Action |
-|--------|--------|
-| All pass | Proceed to OUTPUT |
-| Failure | Fix test or implementation, re-run |
-
-FAIL →
-```
-STATUS: HALT
-PHASE: phase-5a
-GATE: RUN_TESTS
-REASON: ViewInspector tests failed.
-ERROR: {test output}
-OPTIONS:
-1) Fix failing tests
-2) Check if ViewInspector needs .implicitAnyView() for Swift 6
-3) Verify accessibility identifiers match implementation
-```
-
----
-
-## OUTPUT
-
-```
-STATUS: COMPLETE
-PHASE: phase-5a
-GATES_PASSED: [PRE_CHECK, DETERMINE_TEST_LOCATION, CREATE_TEST_FILE, IMPLEMENT_STRUCTURE_TESTS, IMPLEMENT_ACCESSIBILITY_TESTS, RUN_TESTS]
-ARTIFACTS_CREATED:
-  - Tests/{sourceModule}Tests/ViewInspector/{componentPath}/{componentName}ViewInspectorTests.swift
-SUMMARY: {COUNT} ViewInspector tests  -  structure ({STRUCT_COUNT}), accessibility identifiers ({ID_COUNT}), variants ({VARIANT_COUNT}).
-```