@mlaursen/eslint-config 1.4.0 → 1.5.0

package/.env.github

@@ -0,0 +1 @@
+GITHUB_TOKEN=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

package/CHANGELOG.md

@@ -2,6 +2,15 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [1.5.0](https://github.com/mlaursen/eslint-config/compare/v1.4.0...v1.5.0) (2022-03-09)
+
+
+### Features
+
+* force braces ([f6d3f69](https://github.com/mlaursen/eslint-config/commit/f6d3f69cb8644746f7db8e6d562fbdd3a20c8d19))
+* Force consistent type imports for typescript 3.8 or greater ([880217f](https://github.com/mlaursen/eslint-config/commit/880217fb7ad258acc6601218bb649c0928d97ade))
+* Upgrade eslint dependencies to latest ([7551d04](https://github.com/mlaursen/eslint-config/commit/7551d0457be41ca3844a35b45a1eb11b9a510ffc))
+
 ## [1.4.0](https://github.com/mlaursen/eslint-config/compare/v1.3.0...v1.4.0) (2022-01-11)
 
 

package/index.js

@@ -2,11 +2,21 @@ const confusingBrowserGlobals = require('confusing-browser-globals');
 
 let react = false;
 let isNewJsx = false;
+let isTypescript38 = false;
 try {
   require.resolve('react');
   react = true;
   isNewJsx = parseInt(require('react').version, 10) > 16;
 } catch (e) {}
+try {
+  const { version } = require('typescript');
+  const [majorString, minorString] = version.split('.');
+  const major = parseInt(majorString, 10);
+  const minor = parseInt(minorString, 10);
+  if (!Number.isNaN(major) && !Number.isNaN(minor)) {
+    isTypescript38 = major > 3 || (major === 3 && minor > 8);
+  }
+} catch (e) {}
 
 module.exports = {
   parser: '@typescript-eslint/parser',
@@ -54,6 +64,8 @@ module.exports = {
 
     // too many false positives with aliases/root dirs
     'import/no-unresolved': 0,
+
+    curly: 'error',
   },
   overrides: [
     {
@@ -104,6 +116,10 @@ module.exports = {
             varsIgnorePattern: '^_',
           },
         ],
+
+        '@typescript-eslint/consistent-type-imports': isTypescript38
+          ? ['error']
+          : 'off',
       },
     },
     {

package/package.json

@@ -1,12 +1,13 @@
 {
   "name": "@mlaursen/eslint-config",
-  "version": "1.4.0",
+  "version": "1.5.0",
   "description": "An eslint config used by mlaursen for most projects.",
   "main": "index.js",
   "repository": "https://github.com/mlaursen/eslint-config.git",
   "author": "Mikkel Laursen <mlaursen03@gmail.com>",
   "license": "MIT",
   "scripts": {
+    "test": "eslint -c index.js \"test/**/*.{js,jsx,ts,tsx}\"",
     "run-script": "ts-node -T -P tsconfig.node.json",
     "release": "yarn run-script scripts/release.ts"
   },
@@ -18,27 +19,28 @@
     "typescript"
   ],
   "dependencies": {
-    "@typescript-eslint/eslint-plugin": "^5.9.1",
-    "@typescript-eslint/parser": "^5.9.1",
+    "@typescript-eslint/eslint-plugin": "^5.14.0",
+    "@typescript-eslint/parser": "^5.14.0",
     "confusing-browser-globals": "^1.0.11",
-    "eslint-config-prettier": "^8.2.0",
+    "eslint-config-prettier": "^8.5.0",
     "eslint-plugin-import": "^2.25.4",
-    "eslint-plugin-jest": "^25.3.4",
+    "eslint-plugin-jest": "^26.1.1",
     "eslint-plugin-jsx-a11y": "^6.5.1",
-    "eslint-plugin-react": "^7.28.0",
+    "eslint-plugin-react": "^7.29.3",
     "eslint-plugin-react-hooks": "^4.3.0",
     "eslint-plugin-tsdoc": "^0.2.14"
   },
   "devDependencies": {
     "@mlaursen/changelog-preset": "^1.1.0",
     "@octokit/core": "^3.5.1",
-    "@types/inquirer": "^8.1.3",
-    "@types/node": "^17.0.8",
-    "dotenv": "^11.0.0",
-    "inquirer": "^8.2.0",
+    "@types/inquirer": "^8.2.0",
+    "@types/node": "^17.0.21",
+    "dotenv": "^16.0.0",
+    "eslint": "^8.10.0",
+    "inquirer": "^8.2.1",
     "standard-version": "^9.3.2",
-    "ts-node": "^10.4.0",
-    "typescript": "^4.5.4"
+    "ts-node": "^10.7.0",
+    "typescript": "^4.6.2"
   },
   "peerDependencies": {
     "eslint": ">= 8.0.0",

package/.prettierrc

@@ -1,9 +0,0 @@
-printWidth: 80
-trailingComma: es5
-overrides:
-  - files: "*.{js,jsx,scss}"
-    options:
-      singleQuote: true
-  - files: "*.md"
-    options:
-      proseWrap: always

package/.versionrc.js

@@ -1 +0,0 @@
-module.exports = require('@mlaursen/changelog-preset');

package/changelog.config.js

@@ -1,28 +0,0 @@
-const packageJson = require('./package.json');
-const {
-  createConfig,
-  defaultGetCommitType,
-} = require('@mlaursen/changelog-preset/createConfig');
-
-module.exports = createConfig({
-  tokens: Array.from(
-    new Set([
-      ...Object.keys(packageJson.dependencies),
-      ...Object.keys(packageJson.devDependencies),
-    ])
-  ),
-  ignoreDeps: false,
-  getCommitType: (commit) => {
-    const { scope = '' } = commit;
-    if (scope === 'deps') {
-      return 'Dependencies';
-    }
-
-    if (scope === 'dev-deps') {
-      // don't include dev-deps
-      return '';
-    }
-
-    return defaultGetCommitType(commit);
-  },
-});

package/scripts/release.ts

@@ -1,142 +0,0 @@
-import { Octokit } from "@octokit/core";
-import { execSync } from "child_process";
-import dotenv from "dotenv";
-import inquirer from "inquirer";
-import { readFileSync } from "node:fs";
-import { join } from "node:path";
-
-function loggedCommand(command: string): void {
-  console.log(command);
-  execSync(command, { stdio: "inherit" });
-  console.log("");
-}
-
-function undo(version?: string): void {
-  loggedCommand("git reset HEAD^");
-  if (typeof version === "string") {
-    loggedCommand(`git tag -d v${version}`);
-  }
-}
-
-const NEW_ENTRY = /^#{1,3}\s+\[\d/;
-
-async function getReleaseNotes(version: string): Promise<string> {
-  console.log("Update the CHANGELOG.md with any additional changes.");
-  const { confirmed } = await inquirer.prompt<{ confirmed: boolean }>([
-    {
-      type: "confirm",
-      name: "confirmed",
-      message: "Continue the release?",
-    },
-  ]);
-  if (!confirmed) {
-    console.error("Canceling the release.");
-    undo(version);
-
-    process.exit(1);
-  }
-
-  const changelog = readFileSync(join(process.cwd(), "CHANGELOG.md"), "utf8");
-  const lines = changelog.split(/\r?\n/);
-  let lastEntryStart = -1;
-  let nextEntryStart = -1;
-
-  for (let i = 0; i < lines.length; i += 1) {
-    if (NEW_ENTRY.test(lines[i])) {
-      if (lastEntryStart === -1) {
-        lastEntryStart = i + 1;
-      } else if (nextEntryStart === -1) {
-        nextEntryStart = i;
-        break;
-      }
-    }
-  }
-
-  if (lastEntryStart === -1 || nextEntryStart === -1) {
-    console.error("Unable to find a release block.");
-    process.exit(1);
-  }
-
-  return lines.slice(lastEntryStart, nextEntryStart).join("\n");
-}
-
-const RELEASE_TYPES = ["major", "minor", "patch"];
-
-async function run(): Promise<void> {
-  let type = "";
-  let prerelease = "";
-  for (let i = 0; i < process.argv.length; i += 1) {
-    const flag = process.argv[i];
-    const value = process.argv[i + 1];
-    if (
-      flag === "-t" &&
-      typeof value === "string" &&
-      RELEASE_TYPES.includes(value)
-    ) {
-      type = ` --release-as ${value}`;
-    } else if (flag === "-p" || flag === "--prerelease") {
-      prerelease = " --prerelease";
-    }
-  }
-
-  const githubDotEnv = join(process.cwd(), ".env.github");
-  dotenv.config({ path: githubDotEnv });
-
-  const { GITHUB_TOKEN } = process.env;
-  if (!GITHUB_TOKEN) {
-    console.error(
-      `Missing a \`GITHUB_TOKEN\` environment variable. This should be located at:
-- ${githubDotEnv}
-
-A token can be created at:
-- https://github.com/settings/tokens/new?scopes=repo
-`
-    );
-
-    process.exit(1);
-  }
-
-  loggedCommand(`yarn standard-version${type}${prerelease}`);
-
-  const { version } = JSON.parse(
-    readFileSync(join(process.cwd(), "package.json"), "utf8")
-  );
-  if (typeof version !== "string") {
-    console.error("Unable to get the package version.");
-    undo();
-    process.exit(1);
-  }
-
-  const releaseNotes = await getReleaseNotes(version);
-  const { confirmed } = await inquirer.prompt<{ confirmed: boolean }>([
-    {
-      type: "confirm",
-      name: "confirmed",
-      message: `Open the authenticator app to get a one-time password and run the following command:
-
-npm publish --otp
-`,
-    },
-  ]);
-  if (!confirmed) {
-    console.error("Canceling the release.");
-    undo(version);
-
-    process.exit(1);
-  }
-  loggedCommand("git push --follow-tags origin main");
-  const octokit = new Octokit({ auth: GITHUB_TOKEN });
-  const response = await octokit.request(
-    "POST /repos/{owner}/{repo}/releases",
-    {
-      owner: "mlaursen",
-      repo: "eslint-config",
-      tag_name: `v${version}`,
-      body: releaseNotes,
-    }
-  );
-
-  console.log(`Created release: ${response.data.html_url}`);
-}
-
-run();

package/tsconfig.json

@@ -1,19 +0,0 @@
-{
-  "compilerOptions": {
-    "target": "es5",
-    "module": "commonjs",
-    "strict": true,
-    "declaration": true,
-    "esModuleInterop": true,
-    "moduleResolution": "node",
-    "resolveJsonModule": true,
-    "noFallthroughCasesInSwitch": true,
-    "allowSyntheticDefaultImports": true,
-    "forceConsistentCasingInFileNames": true,
-    "lib": [
-      "dom",
-      "dom.iterable",
-      "esnext"
-    ]
-  }
-}

package/tsconfig.node.json

@@ -1,10 +0,0 @@
-{
-  "extends": "./tsconfig.json",
-  "compilerOptions": {
-    "jsx": "react-jsx",
-    "target": "es5",
-    "module": "commonjs",
-    "skipLibCheck": false,
-    "isolatedModules": false
-  }
-}