@mlagie/sql-connector 3.3.0 → 3.4.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mlagie/sql-connector",
-  "version": "3.3.0",
+  "version": "3.4.0",
   "description": "The sql-connector module allows you to manage connections to a MySQL database, define table schemas, and interact with data in a simple and efficient way.",
   "main": "index.js",
   "exports": {

package/src/migration/MigrationRunner.js

@@ -61,6 +61,11 @@ class MigrationRunner {
             plan.id
         );
 
+        // The rollback files are written BEFORE the schema is touched: if the
+        // process dies or the write fails, nothing has been changed yet and the
+        // database never ends up "applied" without its rollback metadata.
+        await this.store.writeMigration(plan);
+
         const run = async () => {
             for (const operation of plan.operations) {
                 const sql = this.sqlForOperation(operation);
@@ -75,15 +80,31 @@ class MigrationRunner {
             );
         };
 
-        await this.dialect.transaction(this.connection, run);
-        await this.store.writeMigration(plan);
-        await this.store.writeSnapshot(plan.snapshot);
-        await this.store.cleanup();
+        try {
+            await this.dialect.transaction(this.connection, run);
+        } catch (error) {
+            await this.store.removeMigration(plan.id).catch(() => {});
+            throw error;
+        }
+
+        const warnings = [];
+        try {
+            await this.store.writeSnapshot(plan.snapshot);
+        } catch (error) {
+            warnings.push(`Migration applied but schema snapshot could not be written: ${error.message}`);
+        }
+        try {
+            await this.store.cleanup();
+        } catch (error) {
+            warnings.push(`Migration applied but cleanup failed: ${error.message}`);
+        }
+        for (const warning of warnings) console.warn(warning);
 
         return {
             applied: true,
             plan,
-            backupPath
+            backupPath,
+            ...(warnings.length > 0 ? { warnings } : {})
         };
     }
 

package/src/migration/MigrationStore.js

@@ -43,6 +43,11 @@ class MigrationStore {
         return outputPath;
     }
 
+    async removeMigration(id) {
+        await fs.rm(path.join(this.directory, `${id}.sql.enc`), { force: true });
+        await fs.rm(path.join(this.directory, `${id}.meta.json.enc`), { force: true });
+    }
+
     async readMigration(id) {
         await this.ensureDirectories();
         if (!this.encryptionKey) throw new Error("An encryption key is required to read migration files.");
@@ -134,4 +139,4 @@ class MigrationStore {
     }
 }
 
-module.exports = { MigrationStore };
+module.exports = { MigrationStore };