@mjhls/mjh-framework 1.0.966-test-D4S-1873 → 1.0.966-testV2

package/README.md

@@ -1,11 +1,11 @@
-# mjh-framework v. 1.0.966
+# mjh-framework v. 1.0.967
 
 [![NPM](https://img.shields.io/npm/v/mjh-framework.svg)](https://www.npmjs.com/package/mjh-framework) [![JavaScript Style Guide](https://img.shields.io/badge/code_style-standard-brightgreen.svg)](https://standardjs.com)
 
 ## Install
 
 ```bash
-npm install --save @mjhls/mjh-framework 
+npm install --save @mjhls/mjh-framework
 ```
 
 ## Usage

package/dist/cjs/View.js

@@ -2128,9 +2128,9 @@ var ArticleQueue = function ArticleQueue(props) {
       changeMeta(meta);
     }
     if (props.setCustomDimensions) {
-      props.setCustomDimensions(activeArticle, '200', prevUrl);
+      props.setCustomDimensions(true, activeArticle, '200', prevUrl);
     }
-    if (props.pageview) props.pageview(newPath, null, pageviewProperties);
+    // if (props.pageview) props.pageview(newPath, pageviewProperties)
     refreshAD(path);
   };
 
@@ -2198,13 +2198,12 @@ var View = function View(props) {
   React.useEffect(function () {
     if (pageview && setCustomDimensions) {
       var timer = void 0;
-      var pageviewProperties = _extends._extends({}, getTargeting.getTargeting(props), {
+      _extends._extends({}, getTargeting.getTargeting(props), {
         category: article && article.category ? article.category.name : ''
       });
       var waitAndExicute = function waitAndExicute() {
         if (typeof window.GA_INITIALIZED !== 'undefined') {
-          setCustomDimensions(article, statusCode, prevUrl);
-          pageview(router.asPath, null, pageviewProperties);
+          setCustomDimensions(false, article, statusCode, prevUrl);
         } else timer = setTimeout(waitAndExicute, 1000);
       };
       waitAndExicute();
@@ -2215,7 +2214,7 @@ var View = function View(props) {
   }, []);
 
   var isVideoSeries = false;
-  //check for certain serializers that need to disable infinite scroll
+  // check for certain serializers that need to disable infinite scroll
   var checkBodyForDisableInfiniteScroll = function checkBodyForDisableInfiniteScroll(article) {
     if (!article || !article.body) {
       return false;
@@ -2352,7 +2351,7 @@ var View = function View(props) {
   );
 };
 
-//This should be called in /view/[url] getInitialProps to fetch the article data and related articles.  This will also set the sponsoredFlag to true if any taxonomies have disabled ads.
+// This should be called in /view/[url] getInitialProps to fetch the article data and related articles.  This will also set the sponsoredFlag to true if any taxonomies have disabled ads.
 View.returnGetInitialProps = function () {
   var _ref = asyncToGenerator._asyncToGenerator( /*#__PURE__*/asyncToGenerator.regenerator.mark(function _callee(url, prevUrl, seriesVid, client, sao) {
     var context = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : null;
@@ -2425,7 +2424,7 @@ View.returnGetInitialProps = function () {
               });
             }
             sponsoredFlag = false;
-            //check for disableAds flag on each taxonomoy
+            // check for disableAds flag on each taxonomoy
 
             if (article && article.content_placement) {
               article.content_placement.forEach(function (x) {
@@ -2434,7 +2433,7 @@ View.returnGetInitialProps = function () {
                 }
               });
             }
-            //check for disableAds flag on content category
+            // check for disableAds flag on content category
             if (article.category && article.category.disableAds) {
               sponsoredFlag = true;
             }

package/dist/esm/View.js

@@ -2118,9 +2118,9 @@ var ArticleQueue = function ArticleQueue(props) {
       changeMeta(meta);
     }
     if (props.setCustomDimensions) {
-      props.setCustomDimensions(activeArticle, '200', prevUrl);
+      props.setCustomDimensions(true, activeArticle, '200', prevUrl);
     }
-    if (props.pageview) props.pageview(newPath, null, pageviewProperties);
+    // if (props.pageview) props.pageview(newPath, pageviewProperties)
     refreshAD(path);
   };
 
@@ -2188,13 +2188,12 @@ var View = function View(props) {
   useEffect(function () {
     if (pageview && setCustomDimensions) {
       var timer = void 0;
-      var pageviewProperties = _extends({}, getTargeting(props), {
+      _extends({}, getTargeting(props), {
         category: article && article.category ? article.category.name : ''
       });
       var waitAndExicute = function waitAndExicute() {
         if (typeof window.GA_INITIALIZED !== 'undefined') {
-          setCustomDimensions(article, statusCode, prevUrl);
-          pageview(router.asPath, null, pageviewProperties);
+          setCustomDimensions(false, article, statusCode, prevUrl);
         } else timer = setTimeout(waitAndExicute, 1000);
       };
       waitAndExicute();
@@ -2205,7 +2204,7 @@ var View = function View(props) {
   }, []);
 
   var isVideoSeries = false;
-  //check for certain serializers that need to disable infinite scroll
+  // check for certain serializers that need to disable infinite scroll
   var checkBodyForDisableInfiniteScroll = function checkBodyForDisableInfiniteScroll(article) {
     if (!article || !article.body) {
       return false;
@@ -2342,7 +2341,7 @@ var View = function View(props) {
   );
 };
 
-//This should be called in /view/[url] getInitialProps to fetch the article data and related articles.  This will also set the sponsoredFlag to true if any taxonomies have disabled ads.
+// This should be called in /view/[url] getInitialProps to fetch the article data and related articles.  This will also set the sponsoredFlag to true if any taxonomies have disabled ads.
 View.returnGetInitialProps = function () {
   var _ref = _asyncToGenerator( /*#__PURE__*/regenerator.mark(function _callee(url, prevUrl, seriesVid, client, sao) {
     var context = arguments.length > 5 && arguments[5] !== undefined ? arguments[5] : null;
@@ -2415,7 +2414,7 @@ View.returnGetInitialProps = function () {
               });
             }
             sponsoredFlag = false;
-            //check for disableAds flag on each taxonomoy
+            // check for disableAds flag on each taxonomoy
 
             if (article && article.content_placement) {
               article.content_placement.forEach(function (x) {
@@ -2424,7 +2423,7 @@ View.returnGetInitialProps = function () {
                 }
               });
             }
-            //check for disableAds flag on content category
+            // check for disableAds flag on content category
             if (article.category && article.category.disableAds) {
               sponsoredFlag = true;
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mjhls/mjh-framework",
-  "version": "1.0.966-test-D4S-1873",
+  "version": "1.0.966-testV2",
   "description": "Foundation Framework",
   "author": "mjh-framework",
   "license": "MIT",