@mjhls/mjh-framework 1.0.810-disable-social-share-v2 → 1.0.810-disable-social-test

package/dist/cjs/View.js

@@ -547,12 +547,11 @@ var Article = React.forwardRef(function (props, ref) {
 
   var targeting = getTargeting.getTargeting(props);
 
+  //if showSocialShare is not disabled for entire site, check article taxonomy, docgroup, authors for showSocialShare === false
   if (showSocialShare) {
     showSocialShare = getSocialShareDisableFlag(props.article);
   }
 
-  console.log('SHOW SOCIAL SHARE', showSocialShare, article);
-
   //If sponsored flag, disable contextual ads
   if (sponsoredFlag) {
     article.contextualVideoAD = false;
@@ -1149,8 +1148,7 @@ var Article = React.forwardRef(function (props, ref) {
                     twitterSiteName: twitterSiteName,
                     disableMeta: true,
                     hidePinterest: hidePinterestShare,
-                    hideFacebook: hideFBShare,
-                    showSocialShare: showSocialShare
+                    hideFacebook: hideFBShare
                   })
                 )
               ),
@@ -1483,6 +1481,7 @@ var ArticleQueue = function ArticleQueue(props) {
 
   var changeMeta = function changeMeta(meta) {
     document.title = meta.shareTitle;
+    //this was throwing an error if there was no description, doing a check for the description meta
     if (document.querySelector('meta[name="description"]')) document.querySelector('meta[name="description"]').setAttribute('content', meta.shareSummary);
     document.querySelector('meta[name="keywords"]').setAttribute('content', meta.shareKeywords);
     document.querySelector('meta[property="og:url"]').setAttribute('content', meta.shareUrl);
@@ -1492,6 +1491,7 @@ var ArticleQueue = function ArticleQueue(props) {
     document.querySelector('meta[name="twitter:title"]').setAttribute('content', meta.shareTitle);
     document.querySelector('meta[name="twitter:image"]').setAttribute('content', meta.shareImage);
     document.querySelector('meta[name="twitter:site"]').setAttribute('content', meta.shareVia);
+    //this was throwing an error if there was no description, doing a check for the description meta
     if (document.querySelector('meta[name="twitter:description"]')) document.querySelector('meta[name="twitter:description"]').setAttribute('content', meta.shareSummary);
     if (canonicalTag) {
       document.querySelector('link[rel="canonical"]').setAttribute('href', meta.shareUrl);
@@ -1721,7 +1721,7 @@ var View = function View(props) {
         props.article.seriesDetail && props.article.seriesDetail.nextUrl && React__default['default'].createElement('link', { rel: 'next', href: props.article.seriesDetail.nextUrl })
       )
     ),
-    !needInfiniteScroll ? React__default['default'].createElement(Article, _extends._extends({ infiniteScroll: false, showRelatedArticles: showRelatedArticles, showDisqus: showDisqus }, props, { showSocialShare: showSocialShare })) : React__default['default'].createElement(ArticleQueue, _extends._extends({
+    !needInfiniteScroll ? React__default['default'].createElement(Article, _extends._extends({ infiniteScroll: false, showRelatedArticles: showRelatedArticles, showDisqus: showDisqus }, props)) : React__default['default'].createElement(ArticleQueue, _extends._extends({
       infiniteScroll: true,
       showRelatedArticles: showRelatedArticles,
       canonicalTag: canonicalTag,

package/dist/esm/View.js

@@ -537,12 +537,11 @@ var Article = forwardRef(function (props, ref) {
 
   var targeting = getTargeting(props);
 
+  //if showSocialShare is not disabled for entire site, check article taxonomy, docgroup, authors for showSocialShare === false
   if (showSocialShare) {
     showSocialShare = getSocialShareDisableFlag(props.article);
   }
 
-  console.log('SHOW SOCIAL SHARE', showSocialShare, article);
-
   //If sponsored flag, disable contextual ads
   if (sponsoredFlag) {
     article.contextualVideoAD = false;
@@ -1139,8 +1138,7 @@ var Article = forwardRef(function (props, ref) {
                     twitterSiteName: twitterSiteName,
                     disableMeta: true,
                     hidePinterest: hidePinterestShare,
-                    hideFacebook: hideFBShare,
-                    showSocialShare: showSocialShare
+                    hideFacebook: hideFBShare
                   })
                 )
               ),
@@ -1473,6 +1471,7 @@ var ArticleQueue = function ArticleQueue(props) {
 
   var changeMeta = function changeMeta(meta) {
     document.title = meta.shareTitle;
+    //this was throwing an error if there was no description, doing a check for the description meta
     if (document.querySelector('meta[name="description"]')) document.querySelector('meta[name="description"]').setAttribute('content', meta.shareSummary);
     document.querySelector('meta[name="keywords"]').setAttribute('content', meta.shareKeywords);
     document.querySelector('meta[property="og:url"]').setAttribute('content', meta.shareUrl);
@@ -1482,6 +1481,7 @@ var ArticleQueue = function ArticleQueue(props) {
     document.querySelector('meta[name="twitter:title"]').setAttribute('content', meta.shareTitle);
     document.querySelector('meta[name="twitter:image"]').setAttribute('content', meta.shareImage);
     document.querySelector('meta[name="twitter:site"]').setAttribute('content', meta.shareVia);
+    //this was throwing an error if there was no description, doing a check for the description meta
     if (document.querySelector('meta[name="twitter:description"]')) document.querySelector('meta[name="twitter:description"]').setAttribute('content', meta.shareSummary);
     if (canonicalTag) {
       document.querySelector('link[rel="canonical"]').setAttribute('href', meta.shareUrl);
@@ -1711,7 +1711,7 @@ var View = function View(props) {
         props.article.seriesDetail && props.article.seriesDetail.nextUrl && React.createElement('link', { rel: 'next', href: props.article.seriesDetail.nextUrl })
       )
     ),
-    !needInfiniteScroll ? React.createElement(Article, _extends({ infiniteScroll: false, showRelatedArticles: showRelatedArticles, showDisqus: showDisqus }, props, { showSocialShare: showSocialShare })) : React.createElement(ArticleQueue, _extends({
+    !needInfiniteScroll ? React.createElement(Article, _extends({ infiniteScroll: false, showRelatedArticles: showRelatedArticles, showDisqus: showDisqus }, props)) : React.createElement(ArticleQueue, _extends({
       infiniteScroll: true,
       showRelatedArticles: showRelatedArticles,
       canonicalTag: canonicalTag,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mjhls/mjh-framework",
-  "version": "1.0.810-disable-social-share-v2",
+  "version": "1.0.810-disable-social-test",
   "description": "Foundation Framework",
   "author": "mjh-framework",
   "license": "MIT",