@mjasnikovs/pi-task 0.42.6 → 0.42.8

package/dist/task/deferred-breakage.js

@@ -21,17 +21,37 @@
 const TEST_NOUN = /\b(?:tests?|suites?|assertions?)\b/i;
 const BUILD_NOUN = /\b(?:lint|linter|typecheck|build|ci)\b/i;
 const FAILURE = /\b(?:fail\w*|red|broken|breaks?|breakage|errors?)\b/i;
-/** Before a phrase in its clause: the phrase is rejected. */
-const NOT_A_DECISION = /\b(?:not|never|no|don't|do not|doesn't|does not|rather than|instead of|isn't|is not|without|avoid|avoiding)\b/i;
+/** Before a phrase in its clause: the phrase is rejected. Models emit U+2019 as
+ *  readily as ASCII, so a contraction must not turn the verdict on the character. */
+const NOT_A_DECISION = /\b(?:not|never|no|do(?:es)?n['’]t|do(?:es)? not|won['’]t|will not|wouldn['’]t|would not|rather than|instead of|isn['’]t|is not|without|avoid|avoiding)\b/i;
 /**
- * A modal cancels a phrase only where the condition's own half of the sentence
- * poses an option for it to weigh: "IF NOT EXISTS would still leave the test
- * failing" describes what a rejected option does. A bare hedge does not — "I
- * would flag it as a known issue" is the decision, and treating every modal as
- * hypothetical let the guard be rephrased away.
+ * A modal cancels a phrase only where the sentence is weighing something: "IF NOT
+ * EXISTS would still leave the test failing" describes what a rejected option
+ * does. A bare hedge does not — "I would flag it as a known issue" is the
+ * decision, and treating every modal as hypothetical let the guard be rephrased
+ * away.
  */
 const MODAL = /\b(?:would|could|might)\b/i;
-const HYPOTHETICAL = /\b(?:if|unless|either|whether|option|alternative|otherwise)\b/i;
+/** A condition governs the clauses it opens and stops at the conclusion drawn. */
+const CONDITION = /\b(?:if|unless)\b/i;
+/** Options are posed once and weighed anywhere in the sentence. */
+const OPTION = /\b(?:either|whether|options?|alternatives?|otherwise)\b/i;
+/** Under a condition the subject says whose modal it is: "the latter would leave
+ *  it red" is the option behaving, "I would leave it red" is the answer deciding. */
+const FIRST_PERSON = /\b(?:i|we)\s+(?:would|could|might)\b/i;
+/**
+ * The repair the sentence goes on to choose. An option's consequence is a
+ * hypothesis only where the sentence chooses against it; a deferral that nothing
+ * overrules is the decision, however the sentence hedges it. Checking for the
+ * choice rather than for a pronoun is what stops "it could be left failing for
+ * whoever owns it" from riding out on one option word.
+ */
+const CHOOSES_REPAIR = /\b(?:i|we)(?:\s+will|\s+shall|['’]ll)\s+(?:update|fix|change|add|adjust|amend|correct)\b|\bso\s+(?:update|fix|change|adjust|amend|correct)\b/i;
+/** Where a hypothesis's reach ends: a semicolon starts an independent clause, and
+ *  "so" introduces the conclusion drawn, not another branch of the hypothesis.
+ *  Neither is a comma, which is why scoping a condition by punctuation alone let
+ *  "fails only if X, so it could be flagged as known" through. */
+const HYPOTHESIS_END = /;|\bso\b|\btherefore\b|\bhence\b|\bthus\b/i;
 /** Where one clause ends and the next begins. A semicolon joins clauses of ONE
  *  thought, so the breakage a clause defers may sit in the other half. */
 const CLAUSE_BOUNDARY = /[,:;()]|\s[—–-]\s|\b(?:and|but|so|then|while|whereas|although|though|because|since|however)\b/gi;
@@ -54,10 +74,15 @@ const PHRASES = [
     // Handing the work to an unnamed someone is the deferral itself, whatever the
     // clause is about; bare `whoever` below still needs a check to be one.
     { re: /\bwhoever\s+(?:owns|revisits|maintains|touches)\b/i, needs: 'alone' },
-    // Ownership handed to a ROLE is handed to nobody. Handed to a named team it is
-    // handed to someone, so it counts only where the clause is about a check.
+    // Ownership handed to a ROLE is handed to nobody: no release manager, QA or
+    // on-call engineer sits in a /task-auto run. Anyone else the answer names — a
+    // person, a team, the runner, this task — is ownership TAKEN, so the phrase
+    // alone is not the deferral. The list names the nobodies rather than exempting
+    // the somebodies, because the two misses cost differently: a role it does not
+    // know still reaches the `check` rule below, while a somebody it mistakes for
+    // nobody destroys the answer this guard exists to protect.
     {
-        re: /\bownership\s+(?:belongs|lies|rests)\s+(?:to|with)\s+(?:whoever|someone|somebody|another\b|a\s+later\b|the\s+(?:\w+\s+)?(?:owners?|maintainers?)\b)/i,
+        re: /\bownership\s+(?:belongs|lies|rests)\s+(?:to|with)\s+(?:whoever|someone|somebody|anyone|another\b|a\s+(?:later|future|separate)\b|(?:the\s+)?(?:release\s+manager|on[- ]call|qa|sre)\b|the\s+(?:\w+\s+)?(?:owners?|maintainers?)\b)/i,
         needs: 'alone'
     },
     { re: /\bownership\s+(?:belongs|lies|rests)\s+(?:to|with)\b/i, needs: 'check' },
@@ -83,10 +108,12 @@ function aboutACheck(text) {
 /**
  * Parenthetical asides go, and a code span keeps its words but loses the
  * punctuation that would split a clause in two: `toEqual([{filename: X}])` is
- * one token of the sentence around it, not three clauses.
+ * one token of the sentence around it, not three clauses. Brackets close up
+ * instead of spacing, because a bracket binds to what it encloses — spacing
+ * `arr[i]` leaves a bare `i` for the first-person rule to read as a pronoun.
  */
 function prose(answer) {
-    let text = answer.replace(/`([^`]*)`/g, (_m, code) => code.replace(/[,;:()[\]{}]/g, ' '));
+    let text = answer.replace(/`([^`]*)`/g, (_m, code) => code.replace(/[[\]{}]/g, '').replace(/[,;:()]/g, ' '));
     let before;
     do {
         before = text;
@@ -100,12 +127,16 @@ function clauses(sentence) {
 export function defersBreakage(answer) {
     for (const sentence of prose(answer).split(SENTENCE_BOUNDARY)) {
         const sentenceBreaks = aboutACheck(sentence) && FAILURE.test(sentence);
-        // A condition governs its own half of a semicolon. It joins two independent
-        // clauses, so "the test fails only if X; I would flag it as known" states a
-        // condition and then decides — the decision is not one of X's options.
-        for (const half of sentence.split(';')) {
-            const weighsOptions = HYPOTHETICAL.test(half);
-            for (const clause of clauses(half)) {
+        const weighsRejectedOption = OPTION.test(sentence) && CHOOSES_REPAIR.test(sentence);
+        const cancelsModal = (before, underCondition) => (underCondition && !FIRST_PERSON.test(before)) || weighsRejectedOption;
+        // A condition governs the clauses it opens and stops at the conclusion the
+        // sentence draws, so "fails only if the fixture is stale, so it could be
+        // flagged as known" states a condition and then decides. An option is posed
+        // once and weighed anywhere, but only where the sentence goes on to pick a
+        // repair is the modal describing the branch it rejected.
+        for (const segment of sentence.split(HYPOTHESIS_END)) {
+            const underCondition = CONDITION.test(segment);
+            for (const clause of clauses(segment)) {
                 for (const { re, needs } of PHRASES) {
                     const hit = re.exec(clause);
                     if (!hit)
@@ -113,7 +144,7 @@ export function defersBreakage(answer) {
                     const before = clause.slice(0, hit.index);
                     if (NOT_A_DECISION.test(before))
                         continue;
-                    if (MODAL.test(before) && weighsOptions)
+                    if (MODAL.test(before) && cancelsModal(before, underCondition))
                         continue;
                     if (needs === 'check' && !aboutACheck(clause))
                         continue;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mjasnikovs/pi-task",
-    "version": "0.42.6",
+    "version": "0.42.8",
     "description": "Deterministic task planning and spec-orchestration for local models — crash-safe /task pipelines with verify/enforce gates, a real-time remote web view, and web/docs/fetch/worker subagent tools.",
     "type": "module",
     "main": "./dist/index.js",