@mjasnikovs/pi-task 0.13.37 → 0.13.38

package/dist/task/auto-orchestrator.js

@@ -17,7 +17,7 @@ import { writeTaskFile, readTaskFile, updateTaskFrontMatter, taskFilePath, tasks
 import { gitCommitAll } from './auto-commit.js';
 import { runGuidelineEnforcement, classifyEnforceChildFailure } from './enforce-guidelines.js';
 import { runWorker } from '../workers/pi-worker-core.js';
-import { runPhaseChild, prependHint, USER_CANCELLED } from './child-runner.js';
+import { runPhaseChild, prependHint, formatLoopHint, USER_CANCELLED } from './child-runner.js';
 import { SessionUI, registerBridgeCommand } from '../remote/bridge.js';
 import { pushNotify } from '../remote/push.js';
 import { getConfig } from '../config/config.js';
@@ -362,7 +362,15 @@ function defaultDeps(ctx, cwd, signal, title) {
                             signal: sig,
                             tools,
                             timeoutMs: 0, // no wall-clock timeout — run to completion
-                            loop: false, // no loop guard — revisiting one file IS the job
+                            // Exact-match loop guard only: pathThreshold Infinity
+                            // disables the path-revisit heuristic, so revisiting one
+                            // file (which IS this pass's job) never trips — only a
+                            // literally-identical call repeated past threshold does
+                            // (e.g. the same grep fired 900× in enforce-debug.log).
+                            // A hit nudges via the normal restart-with-hint; a loop
+                            // that survives the nudges is WARNED, not blocked (see
+                            // r.loopHit handling below and classifyEnforceChildFailure).
+                            loop: { pathThreshold: Number.POSITIVE_INFINITY },
                             onLine: line => {
                                 lastLine = line;
                                 logEnforce(line);
@@ -371,6 +379,13 @@ function defaultDeps(ctx, cwd, signal, title) {
                                 contextUsage = resolveContextUsage(snapshot, contextUsage, parentContextWindow);
                             }
                         });
+                        // A loop that survived the restart-with-hint nudges is a
+                        // warning, not a failure: log it and tell the user, but let
+                        // the verdict gate (below) be the only thing that can block.
+                        if (r.loopHit) {
+                            logEnforce(`=== enforce LOOP WARNING — ${formatLoopHint(r.loopHit)} ===`);
+                            enforceCtx.ui.notify(`${taskTitle}: enforce worker looped past the nudges — continuing (not blocked).`, 'warning');
+                        }
                         const failure = classifyEnforceChildFailure(r);
                         logEnforce(failure ?
                             `=== enforce end: FAIL — ${failure} ===`

package/dist/task/enforce-guidelines.d.ts

@@ -56,10 +56,17 @@ export interface EnforceChildResult {
  * when it finished cleanly enough to parse a verdict from its text.
  *
  * The order is load-bearing. A loop-kill AND a wall-clock timeout BOTH also set
- * `aborted` — killProc flips it on every kill path — so the specific causes
- * (timeout, loop, leaked tool call) must be named BEFORE the generic
- * `aborted → user-cancel` mapping. Checking `aborted` first (as the original
- * inline code did) mislabels a loop-killed enforcement child as a user cancel.
+ * `aborted` (and a non-zero exit) — killProc flips it on every kill path — so the
+ * specific causes (timeout, loop, leaked tool call) must be handled BEFORE the
+ * generic `aborted → user-cancel` and `exitCode` mappings. Checking `aborted`
+ * first (as the original inline code did) mislabels a loop-killed enforcement
+ * child as a user cancel.
+ *
+ * A loop is NOT fatal: enforce attaches the detector in nudge-then-warn mode, so a
+ * loop that survived its restart-with-hint nudges returns null here (the caller
+ * logs/notifies it as a warning) and the verdict gate alone decides the outcome.
+ * It still has to be matched before `aborted`/`exitCode` so the kill's side
+ * effects don't get re-classified as a user cancel or a crash.
  */
 export declare function classifyEnforceChildFailure(r: EnforceChildResult): string | null;
 /**

package/dist/task/enforce-guidelines.js

@@ -101,16 +101,23 @@ export function parseEnforceVerdict(text) {
  * when it finished cleanly enough to parse a verdict from its text.
  *
  * The order is load-bearing. A loop-kill AND a wall-clock timeout BOTH also set
- * `aborted` — killProc flips it on every kill path — so the specific causes
- * (timeout, loop, leaked tool call) must be named BEFORE the generic
- * `aborted → user-cancel` mapping. Checking `aborted` first (as the original
- * inline code did) mislabels a loop-killed enforcement child as a user cancel.
+ * `aborted` (and a non-zero exit) — killProc flips it on every kill path — so the
+ * specific causes (timeout, loop, leaked tool call) must be handled BEFORE the
+ * generic `aborted → user-cancel` and `exitCode` mappings. Checking `aborted`
+ * first (as the original inline code did) mislabels a loop-killed enforcement
+ * child as a user cancel.
+ *
+ * A loop is NOT fatal: enforce attaches the detector in nudge-then-warn mode, so a
+ * loop that survived its restart-with-hint nudges returns null here (the caller
+ * logs/notifies it as a warning) and the verdict gate alone decides the outcome.
+ * It still has to be matched before `aborted`/`exitCode` so the kill's side
+ * effects don't get re-classified as a user cancel or a crash.
  */
 export function classifyEnforceChildFailure(r) {
     if (r.timedOut)
         return 'enforcement child timed out';
     if (r.loopHit)
-        return 'enforcement child looped';
+        return null; // looped past the nudges → warning, handled by caller
     if (r.leakedToolCall)
         return 'enforcement child leaked a tool call';
     if (r.aborted)

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mjasnikovs/pi-task",
-    "version": "0.13.37",
+    "version": "0.13.38",
     "description": "Deterministic spec-orchestration for local models, with a bundled real-time remote web view and web/docs/fetch/worker subagent tools.",
     "type": "module",
     "main": "./dist/index.js",