@mjasnikovs/pi-task 0.13.34 → 0.13.35

package/dist/task/auto-orchestrator.js

@@ -15,7 +15,7 @@ import { isDuplicateQuestion, MAX_DUP_STRIKES, DUP_REPROMPT_HINT } from './quest
 import { allocateAutoId, buildAutoBody, parseDecomposeList, parseTaskList, checkOffTask, stampTaskInProgress, findResumableAuto } from './auto-io.js';
 import { writeTaskFile, readTaskFile, updateTaskFrontMatter, taskFilePath, tasksDir } from './task-io.js';
 import { gitCommitAll } from './auto-commit.js';
-import { runGuidelineEnforcement, classifyEnforceChildFailure, ENFORCE_TIMEOUT_MS, ENFORCE_LOOP } from './enforce-guidelines.js';
+import { runGuidelineEnforcement, classifyEnforceChildFailure } from './enforce-guidelines.js';
 import { runWorker } from '../workers/pi-worker-core.js';
 import { runPhaseChild, prependHint, USER_CANCELLED } from './child-runner.js';
 import { SessionUI, registerBridgeCommand } from '../remote/bridge.js';
@@ -313,12 +313,14 @@ function defaultDeps(ctx, cwd, signal, title) {
             return runGuidelineEnforcement({
                 cwd: cwd2,
                 signal,
-                // Reuse the timeout- and loop-guarded worker child. It runs the
-                // same local model with edit tools so it can fix violations in
-                // place. classifyEnforceChildFailure turns any non-clean exit
-                // (loop kill, timeout, leaked tool call, non-zero) into a thrown
-                // error so the pass becomes a blocking outcome rather than
-                // trusting a partial transcript.
+                // Run the worker child UNGUARDED: no loop detector, no wall-clock
+                // timeout. This pass's job is to rework files in place until every
+                // violation is fixed, and it legitimately reads/edits/re-greps the
+                // same file many times — the research-worker guards mislabel that
+                // as a runaway and kill good work (proven on mx5 TASK_0002). Let it
+                // run until the model finishes; classifyEnforceChildFailure still
+                // blocks the commit on a real failure (non-zero exit, leaked tool
+                // call) or a user cancel.
                 runChild: async (tools, prompt, sig) => {
                     // The enforcement child is a slow local-model pass with edit
                     // tools; show the same /task-auto status block as planning so
@@ -329,12 +331,11 @@ function defaultDeps(ctx, cwd, signal, title) {
                     contextUsage = undefined;
                     const startedAt = Date.now();
                     // Per-pass debug log. The enforce child is otherwise
-                    // unobservable (it has no per-task file like the impl runner),
-                    // so a loop/timeout in the verifier was undiagnosable. One
-                    // rolling file under .pi-tasks/; each pass brackets its
+                    // unobservable (it has no per-task file like the impl runner).
+                    // One rolling file under .pi-tasks/; each pass brackets its
                     // tool/text lines with start/end markers naming the task and
-                    // the terminal outcome, so a kill shows the exact repeated
-                    // calls that tripped the loop detector. Fire-and-forget.
+                    // the terminal outcome, so a stop (a real failure or a found
+                    // violation) is diagnosable. Fire-and-forget.
                     const enforceLogPath = path.join(tasksDir(cwd2), 'enforce-debug.log');
                     const logEnforce = (msg) => {
                         void fsp
@@ -358,8 +359,8 @@ function defaultDeps(ctx, cwd, signal, title) {
                             cwd: cwd2,
                             signal: sig,
                             tools,
-                            timeoutMs: ENFORCE_TIMEOUT_MS,
-                            loop: ENFORCE_LOOP,
+                            timeoutMs: 0, // no wall-clock timeout — run to completion
+                            loop: false, // no loop guard — revisiting one file IS the job
                             onLine: line => {
                                 lastLine = line;
                                 logEnforce(line);

package/dist/task/enforce-guidelines.d.ts

@@ -3,25 +3,6 @@ import { type SpawnFn } from '../shared/child-process.js';
 export declare const GUIDELINE_FILENAMES: readonly ["AGENTS.md", "CLAUDE.md"];
 /** Tools the fix pass is allowed: read/search to inspect, edit/write to fix. */
 declare const ENFORCE_TOOLS = "read,grep,find,ls,edit,write";
-/** Wall-clock ceiling for the enforcement child. Local models are slow and the
- *  fix pass reads several files and may rewrite a few; give it room but never
- *  let a wedged child hang the whole run. */
-declare const ENFORCE_TIMEOUT_MS = 600000;
-/**
- * Loop-guard tuning for the enforcement child. Unlike a read-only research
- * worker, this pass's JOB is to rework files in place, so it legitimately reads,
- * edits, and re-greps the SAME file many times — the default path-revisit
- * heuristic (5 ops on one path) mislabels that as a runaway. It is disabled here
- * (pathThreshold = Infinity); only the exact-match guard remains (a byte-for-byte
- * identical call repeated, raised to 12 over a 40-call window), with the 10-min
- * wall-clock timeout as the real runaway backstop. Validated against a real
- * loop-kill on mx5 TASK_0002, where a single-file fix pass on queries.ts tripped
- * the default detector at 5 revisits. */
-export declare const ENFORCE_LOOP: {
-    readonly window: 40;
-    readonly threshold: 12;
-    readonly pathThreshold: number;
-};
 export interface GuidelineDoc {
     /** Filenames found, in discovery order (e.g. ['AGENTS.md', 'CLAUDE.md']). */
     files: string[];
@@ -106,4 +87,4 @@ export interface EnforcementDeps {
  * blocking outcome (ok: false) so an unverifiable task is not committed.
  */
 export declare function runGuidelineEnforcement(deps: EnforcementDeps): Promise<EnforceOutcome>;
-export { ENFORCE_TOOLS, ENFORCE_TIMEOUT_MS };
+export { ENFORCE_TOOLS };

package/dist/task/enforce-guidelines.js

@@ -24,25 +24,6 @@ import { USER_CANCELLED } from './child-runner.js';
 export const GUIDELINE_FILENAMES = ['AGENTS.md', 'CLAUDE.md'];
 /** Tools the fix pass is allowed: read/search to inspect, edit/write to fix. */
 const ENFORCE_TOOLS = 'read,grep,find,ls,edit,write';
-/** Wall-clock ceiling for the enforcement child. Local models are slow and the
- *  fix pass reads several files and may rewrite a few; give it room but never
- *  let a wedged child hang the whole run. */
-const ENFORCE_TIMEOUT_MS = 600_000;
-/**
- * Loop-guard tuning for the enforcement child. Unlike a read-only research
- * worker, this pass's JOB is to rework files in place, so it legitimately reads,
- * edits, and re-greps the SAME file many times — the default path-revisit
- * heuristic (5 ops on one path) mislabels that as a runaway. It is disabled here
- * (pathThreshold = Infinity); only the exact-match guard remains (a byte-for-byte
- * identical call repeated, raised to 12 over a 40-call window), with the 10-min
- * wall-clock timeout as the real runaway backstop. Validated against a real
- * loop-kill on mx5 TASK_0002, where a single-file fix pass on queries.ts tripped
- * the default detector at 5 revisits. */
-export const ENFORCE_LOOP = {
-    window: 40,
-    threshold: 12,
-    pathThreshold: Number.POSITIVE_INFINITY
-};
 /**
  * Read the guideline files that live directly in `cwd` (AGENTS.md, CLAUDE.md).
  * Returns null when none exist or all are empty — the caller treats that as a
@@ -187,4 +168,4 @@ export async function runGuidelineEnforcement(deps) {
         return { ok: true };
     return { ok: false, reason: `guideline violation: ${verdict.detail}` };
 }
-export { ENFORCE_TOOLS, ENFORCE_TIMEOUT_MS };
+export { ENFORCE_TOOLS };

package/dist/workers/pi-worker-core.d.ts

@@ -11,19 +11,24 @@ export interface RunWorkerInput {
     extensions?: string[];
     /** Called for each tool execution start and text-writing event inside the worker. */
     onLine?: (line: string) => void;
-    /** Per-worker wall-clock timeout in ms. Defaults to RESEARCH_WORKER_TIMEOUT_MS. */
+    /**
+     * Per-worker wall-clock timeout in ms. Defaults to RESEARCH_WORKER_TIMEOUT_MS.
+     * Pass 0 to disable the timeout entirely (run until the child exits on its
+     * own) — for a pass that must be allowed to finish however long it takes.
+     */
     timeoutMs?: number;
     /**
      * Per-worker loop-detector tuning. Defaults to the read-only research/impl
      * guard (LOOP_WINDOW / LOOP_THRESHOLD, path threshold = exact threshold). An
      * edit/fix pass legitimately revisits one file, so it can raise (or disable
-     * via Infinity) `pathThreshold` to keep only the exact-match guard.
+     * via Infinity) `pathThreshold`. Pass `false` to turn the detector OFF
+     * entirely — no tool-call pattern will ever kill the worker.
      */
     loop?: {
         window?: number;
         threshold?: number;
         pathThreshold?: number;
-    };
+    } | false;
 }
 export interface RunWorkerResult {
     text: string;

package/dist/workers/pi-worker-core.js

@@ -34,10 +34,14 @@ const WORKER_TIMEOUT_HINT = '[SYSTEM NOTE: Your previous attempt ran out of time
 function workerTimeout(external, ms) {
     const ctrl = new AbortController();
     let timedOut = false;
-    const timer = setTimeout(() => {
-        timedOut = true;
-        ctrl.abort();
-    }, ms);
+    // ms <= 0 (or non-finite) disables the wall-clock timeout: no timer is armed,
+    // so only the external signal can abort and timedOut() stays false forever.
+    const timer = ms > 0 && Number.isFinite(ms) ?
+        setTimeout(() => {
+            timedOut = true;
+            ctrl.abort();
+        }, ms)
+        : undefined;
     const onExternal = () => ctrl.abort();
     if (external) {
         if (external.aborted)
@@ -71,9 +75,16 @@ export async function runWorker(input) {
         const invocation = getPiInvocation([...baseArgs, prompt]);
         const tStart = Date.now();
         let tFirstByte = null;
-        const loopWindow = input.loop?.window ?? LOOP_WINDOW;
-        const loopThreshold = input.loop?.threshold ?? LOOP_THRESHOLD;
-        const loopDetector = new LoopDetector(loopWindow, loopThreshold, input.loop?.pathThreshold ?? loopThreshold);
+        // loop === false turns the guard off entirely (detector is null and no
+        // tool call is ever flagged); otherwise build a detector from the override
+        // or the default research/impl thresholds.
+        const loopDetector = input.loop === false ?
+            null
+            : (() => {
+                const window = input.loop?.window ?? LOOP_WINDOW;
+                const threshold = input.loop?.threshold ?? LOOP_THRESHOLD;
+                return new LoopDetector(window, threshold, input.loop?.pathThreshold ?? threshold);
+            })();
         // Capture the hit the detector reports (it also returns it to the unified
         // runner, which kills the child on a hit). Without capturing it here the
         // SIGTERM that kill produces would surface as a bare non-zero exit the
@@ -86,6 +97,8 @@ export async function runWorker(input) {
                 mode: 'json-events',
                 onFirstByte: () => (tFirstByte = Date.now()),
                 onToolCall: call => {
+                    if (!loopDetector)
+                        return null;
                     const hit = loopDetector.record(call);
                     if (hit && !loopHit)
                         loopHit = hit;

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@mjasnikovs/pi-task",
-    "version": "0.13.34",
+    "version": "0.13.35",
     "description": "Deterministic spec-orchestration for local models, with a bundled real-time remote web view and web/docs/fetch/worker subagent tools.",
     "type": "module",
     "main": "./dist/index.js",