@mj-biz-apps/sales-ng 6.5.0 → 6.7.0

package/dist/lib/custom/company-from-pipeline.d.ts

@@ -0,0 +1,66 @@
+/**
+ * @fileoverview Supplying `Deal.CompanyID` on a new deal, so the form can be saved at all.
+ *
+ * ── THE DEFECT THIS EXISTS FOR ──────────────────────────────────────────────────────────────────
+ *
+ * A new deal could not be saved through the form. `Deal.CompanyID` is `NOT NULL` with no default, the
+ * form renders it as a server-maintained field (correctly — a rep must not choose the selling company),
+ * and `DealEntityServer.stampCompanyFromPipeline()` fills it on save. But `BaseFormComponent.SaveRecord`
+ * runs `Validate()` FIRST and returns early when it fails, so the save never reached the server that was
+ * going to supply the value. Required, unsettable, and filled too late: the record was unsaveable.
+ *
+ * It worked in the deal workspace because `SelectPipeline` stamped it client-side — "so the record
+ * validates locally", in its own words. Unmounting the workspace (9d6ef9e) took the only code that did
+ * this with it, and the form was never given the equivalent. That is the whole bug.
+ *
+ * ── WHY THE CLIENT MAY WRITE A SERVER-OWNED FIELD HERE, WHICH LOOKS WRONG ───────────────────────
+ *
+ * It is not the client DECIDING the selling company. It is the client pre-filling the answer the server
+ * is about to write, read from the SAME authority the server reads — the pipeline. `stampCompanyFromPipeline`
+ * overwrites whatever arrives, so the two cannot disagree: if this stamps the wrong value the server
+ * replaces it, and if it stamps the right one the server writes it again. The pipeline remains the only
+ * thing that can be correct about which company is selling.
+ *
+ * That is also why this does not make `CompanyID` editable. `deal-form.panels.ts` keeps it
+ * `serverMaintained: true` and `server-owned-fields.ts` refuses a user's edit to it. Those stay exactly
+ * as they were — what changes is that the value now arrives without a user having to supply one.
+ *
+ * ── KEYED ON THE CAUSE, NOT ON `IsSaved` ────────────────────────────────────────────────────────
+ *
+ * The obvious guard is "new deals only". The cause is not newness, it is an ABSENT CompanyID with a
+ * pipeline available to resolve it — so that is what is tested. A saved deal always has one (the column
+ * is NOT NULL), so the extra breadth costs nothing today and survives a path that creates a deal some
+ * other way tomorrow. A guard keyed on a threshold gets outgrown; one keyed on a cause does not.
+ *
+ * @module @mj-biz-apps/sales-ng
+ */
+/**
+ * The one column read off a pipeline. CodeGen generates no `PipelineEntity` subclass, and this only
+ * ever reads — so the view runs `ResultType: 'simple'` and the row is typed here rather than borrowed.
+ */
+export interface PipelineCompanyRow {
+    CompanyID: string | null;
+}
+/** What the decision needs to know. Kept flat so it can be tested without an entity or a DOM. */
+export interface CompanyStampState {
+    /** True when the form actually holds a record. */
+    HasRecord: boolean;
+    /** The pipeline the deal is in, as currently chosen. */
+    PipelineID: string | null;
+    /** The company currently on the deal, if any. */
+    CompanyID: string | null;
+}
+/**
+ * Whether `CompanyID` should be resolved from the pipeline and stamped.
+ *
+ * Pure and exported so the rule can be pinned without a database. Each clause is a way the stamp would
+ * be wrong:
+ *
+ *  - no record, nothing to stamp;
+ *  - no pipeline chosen yet, so there is no authority to read the company FROM — the rep has not made
+ *    the choice that decides it, and inventing one would be the client deciding after all;
+ *  - a company already present is left alone. On a saved deal that is the stored value, and overwriting
+ *    it here would make this code an authority it is explicitly not.
+ */
+export declare function ShouldStampCompanyFromPipeline(state: CompanyStampState): boolean;
+//# sourceMappingURL=company-from-pipeline.d.ts.map

package/dist/lib/custom/company-from-pipeline.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"company-from-pipeline.d.ts","sourceRoot":"","sources":["../../../src/lib/custom/company-from-pipeline.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAmCG;AAEH;;;GAGG;AACH,MAAM,WAAW,kBAAkB;IAC/B,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;CAC5B;AAED,iGAAiG;AACjG,MAAM,WAAW,iBAAiB;IAC9B,kDAAkD;IAClD,SAAS,EAAE,OAAO,CAAC;IACnB,wDAAwD;IACxD,UAAU,EAAE,MAAM,GAAG,IAAI,CAAC;IAC1B,iDAAiD;IACjD,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;CAC5B;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,8BAA8B,CAAC,KAAK,EAAE,iBAAiB,GAAG,OAAO,CAQhF"}

package/dist/lib/custom/company-from-pipeline.js

@@ -0,0 +1,67 @@
+/**
+ * @fileoverview Supplying `Deal.CompanyID` on a new deal, so the form can be saved at all.
+ *
+ * ── THE DEFECT THIS EXISTS FOR ──────────────────────────────────────────────────────────────────
+ *
+ * A new deal could not be saved through the form. `Deal.CompanyID` is `NOT NULL` with no default, the
+ * form renders it as a server-maintained field (correctly — a rep must not choose the selling company),
+ * and `DealEntityServer.stampCompanyFromPipeline()` fills it on save. But `BaseFormComponent.SaveRecord`
+ * runs `Validate()` FIRST and returns early when it fails, so the save never reached the server that was
+ * going to supply the value. Required, unsettable, and filled too late: the record was unsaveable.
+ *
+ * It worked in the deal workspace because `SelectPipeline` stamped it client-side — "so the record
+ * validates locally", in its own words. Unmounting the workspace (9d6ef9e) took the only code that did
+ * this with it, and the form was never given the equivalent. That is the whole bug.
+ *
+ * ── WHY THE CLIENT MAY WRITE A SERVER-OWNED FIELD HERE, WHICH LOOKS WRONG ───────────────────────
+ *
+ * It is not the client DECIDING the selling company. It is the client pre-filling the answer the server
+ * is about to write, read from the SAME authority the server reads — the pipeline. `stampCompanyFromPipeline`
+ * overwrites whatever arrives, so the two cannot disagree: if this stamps the wrong value the server
+ * replaces it, and if it stamps the right one the server writes it again. The pipeline remains the only
+ * thing that can be correct about which company is selling.
+ *
+ * That is also why this does not make `CompanyID` editable. `deal-form.panels.ts` keeps it
+ * `serverMaintained: true` and `server-owned-fields.ts` refuses a user's edit to it. Those stay exactly
+ * as they were — what changes is that the value now arrives without a user having to supply one.
+ *
+ * ── KEYED ON THE CAUSE, NOT ON `IsSaved` ────────────────────────────────────────────────────────
+ *
+ * The obvious guard is "new deals only". The cause is not newness, it is an ABSENT CompanyID with a
+ * pipeline available to resolve it — so that is what is tested. A saved deal always has one (the column
+ * is NOT NULL), so the extra breadth costs nothing today and survives a path that creates a deal some
+ * other way tomorrow. A guard keyed on a threshold gets outgrown; one keyed on a cause does not.
+ *
+ * @module @mj-biz-apps/sales-ng
+ */
+/**
+ * Whether `CompanyID` should be resolved from the pipeline and stamped.
+ *
+ * Pure and exported so the rule can be pinned without a database. Each clause is a way the stamp would
+ * be wrong:
+ *
+ *  - no record, nothing to stamp;
+ *  - no pipeline chosen yet, so there is no authority to read the company FROM — the rep has not made
+ *    the choice that decides it, and inventing one would be the client deciding after all;
+ *  - a company already present is left alone. On a saved deal that is the stored value, and overwriting
+ *    it here would make this code an authority it is explicitly not.
+ */
+export function ShouldStampCompanyFromPipeline(state) {
+    if (!state.HasRecord) {
+        return false;
+    }
+    if (!isSet(state.PipelineID)) {
+        return false;
+    }
+    return !isSet(state.CompanyID);
+}
+/**
+ * A GUID field counts as absent when it is null, undefined, or blank.
+ *
+ * The empty string matters: a picker that has been opened and cleared leaves `''`, not null, and a
+ * truthiness test alone would have treated `'   '` as a real company id.
+ */
+function isSet(value) {
+    return typeof value === 'string' && value.trim().length > 0;
+}
+//# sourceMappingURL=company-from-pipeline.js.map

package/dist/lib/custom/company-from-pipeline.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"company-from-pipeline.js","sourceRoot":"","sources":["../../../src/lib/custom/company-from-pipeline.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GAmCG;AAoBH;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,8BAA8B,CAAC,KAAwB;IACnE,IAAI,CAAC,KAAK,CAAC,SAAS,EAAE,CAAC;QACnB,OAAO,KAAK,CAAC;IACjB,CAAC;IACD,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,UAAU,CAAC,EAAE,CAAC;QAC3B,OAAO,KAAK,CAAC;IACjB,CAAC;IACD,OAAO,CAAC,KAAK,CAAC,KAAK,CAAC,SAAS,CAAC,CAAC;AACnC,CAAC;AAED;;;;;GAKG;AACH,SAAS,KAAK,CAAC,KAAgC;IAC3C,OAAO,OAAO,KAAK,KAAK,QAAQ,IAAI,KAAK,CAAC,IAAI,EAAE,CAAC,MAAM,GAAG,CAAC,CAAC;AAChE,CAAC"}

package/dist/lib/custom/deal-form.component.d.ts

@@ -12,6 +12,15 @@ export declare class DealFormComponentExtended extends mjBizAppsSalesDealFormCom
      * the lock, by `ResolveDealLockState`, and handed to the panels; nothing here reads a status name.
      */
     IsLost: boolean;
+    /**
+     * Whether the PERSISTED status is a WIN — read as its own flag, never inferred from `!IsLost`.
+     *
+     * golive#226: the Order and Contract chips belong on a won deal and on no other, because an open
+     * deal's order is still a draft nobody should be editing directly. golive#231's outcome tiles read
+     * the same flag. Resolved with the lock, from the same status row; the panels read it here rather
+     * than asking again.
+     */
+    IsWon: boolean;
     /** Shown when locked, so the greyed-out-ness the form cannot render is at least explained. */
     LockNotice: string | null;
     /** Set when `Deal.Amount` no longer matches its order's total. Null when trustworthy, absent or locked. */
@@ -37,6 +46,24 @@ export declare class DealFormComponentExtended extends mjBizAppsSalesDealFormCom
      * is passed here. A locked deal never warns.
      */
     private resolveAmountFreshness;
+    /**
+     * Fills the selling company from the pipeline before the save is validated.
+     *
+     * WHY IT IS HERE AND NOT IN `Validate()`. `SaveRecord` calls `Validate()` and returns early when it
+     * fails, so a stamp applied inside validation would be racing the thing it exists to satisfy. This
+     * runs before `super.SaveRecord()` — which is what puts it ahead of the validator.
+     *
+     * `company-from-pipeline.ts` holds the decision and the reasoning, including why the client is
+     * allowed to write a server-owned field at all. This method owns only the lookup.
+     *
+     * A pipeline that cannot be read is NOT an error here. The stamp is best-effort: if it fails, the
+     * save proceeds and validation refuses exactly as it did before, which is the behaviour this is
+     * replacing rather than something it makes worse. Swallowing a real problem is the risk, so the
+     * refusal the user then sees still names `CompanyID`.
+     */
+    SaveRecord(StopEditModeAfterSave: boolean): Promise<boolean>;
+    /** Reads the chosen pipeline's company and writes it to the deal. See `SaveRecord` for why. */
+    private stampCompanyFromPipeline;
     /**
      * Refuses a locked edit BEFORE the round trip, naming the fields.
      *

package/dist/lib/custom/deal-form.component.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"deal-form.component.d.ts","sourceRoot":"","sources":["../../../src/lib/custom/deal-form.component.ts"],"names":[],"mappings":"AA6CA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AAE7D,OAAO,EAAE,+BAA+B,EAAE,MAAM,4EAA4E,CAAC;;AAE7H,0GAA0G;AAC1G,qBAMa,yBAA0B,SAAQ,+BAA+B;IAC1E,6EAA6E;IACtE,QAAQ,UAAS;IAExB;;;;;OAKG;IACI,MAAM,UAAS;IAEtB,8FAA8F;IACvF,UAAU,EAAE,MAAM,GAAG,IAAI,CAAQ;IAExC,2GAA2G;IACpG,iBAAiB,EAAE,MAAM,GAAG,IAAI,CAAQ;IAEzB,QAAQ,IAAI,OAAO,CAAC,IAAI,CAAC;IAO/C,qGAAqG;IAC9F,kBAAkB,IAAI,SAAS,MAAM,EAAE,GAAG,IAAI;IAIrD;;;;;OAKG;YACW,gBAAgB;IAQ9B;;;;;;;;;OASG;YACW,sBAAsB;IAepC;;;;;OAKG;IACa,QAAQ,IAAI,gBAAgB;yCA3EnC,yBAAyB;2CAAzB,yBAAyB;CA4GrC;AAED,gCAAgC;AAChC,wBAAgB,YAAY,IAAI,IAAI,CAEnC"}
+{"version":3,"file":"deal-form.component.d.ts","sourceRoot":"","sources":["../../../src/lib/custom/deal-form.component.ts"],"names":[],"mappings":"AA6CA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,sBAAsB,CAAC;AAG7D,OAAO,EAAE,+BAA+B,EAAE,MAAM,4EAA4E,CAAC;;AAI7H,0GAA0G;AAC1G,qBAMa,yBAA0B,SAAQ,+BAA+B;IAC1E,6EAA6E;IACtE,QAAQ,UAAS;IAExB;;;;;OAKG;IACI,MAAM,UAAS;IAEtB;;;;;;;OAOG;IACI,KAAK,UAAS;IAErB,8FAA8F;IACvF,UAAU,EAAE,MAAM,GAAG,IAAI,CAAQ;IAExC,2GAA2G;IACpG,iBAAiB,EAAE,MAAM,GAAG,IAAI,CAAQ;IAEzB,QAAQ,IAAI,OAAO,CAAC,IAAI,CAAC;IAO/C,qGAAqG;IAC9F,kBAAkB,IAAI,SAAS,MAAM,EAAE,GAAG,IAAI;IAIrD;;;;;OAKG;YACW,gBAAgB;IAS9B;;;;;;;;;OASG;YACW,sBAAsB;IAepC;;;;;;;;;;;;;;OAcG;IACmB,UAAU,CAAC,qBAAqB,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAKlF,+FAA+F;YACjF,wBAAwB;IAiCtC;;;;;OAKG;IACa,QAAQ,IAAI,gBAAgB;yCA5InC,yBAAyB;2CAAzB,yBAAyB;CA6KrC;AAED,gCAAgC;AAChC,wBAAgB,YAAY,IAAI,IAAI,CAEnC"}