@mj-biz-apps/marketing-server 0.3.0 → 0.5.0

package/dist/__tests__/adConversionParity.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=adConversionParity.test.d.ts.map

package/dist/__tests__/adConversionParity.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"adConversionParity.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/adConversionParity.test.ts"],"names":[],"mappings":""}

package/dist/__tests__/adConversionParity.test.js

@@ -0,0 +1,127 @@
+import { describe, expect, it } from 'vitest';
+import { GoogleAdsClient } from '../programs/google/GoogleAdsClient.js';
+import { MetaAdsClient, customConversionActionType, metaObjectiveFor } from '../programs/meta/MetaAdsClient.js';
+function googleClient(answer) {
+    const calls = [];
+    const fetchImpl = (async (input, init) => {
+        const url = String(input);
+        calls.push({ url, init });
+        if (url.endsWith('/token'))
+            return new Response(JSON.stringify({ access_token: 't', expires_in: 3600 }), { status: 200 });
+        const body = init?.body ? JSON.parse(String(init.body)) : null;
+        return new Response(JSON.stringify(answer(url, body)), { status: 200 });
+    });
+    return { client: new GoogleAdsClient({ clientId: 'c', clientSecret: 's', refreshToken: 'r', customerId: '4684433735', fetchImpl }), calls };
+}
+const queryOf = (c) => JSON.parse(String(c.init?.body)).query ?? '';
+describe('GoogleAdsClient — conversion actions (D-34 parity)', () => {
+    it('lists the customer\'s conversion actions by id, with whether the account counts them by default', async () => {
+        const { client, calls } = googleClient(() => [{ results: [
+                    { conversionAction: { resourceName: 'customers/4684433735/conversionActions/7845520214', id: '7845520214', name: 'Ascend Book Download - Google - Form Submission', status: 'ENABLED', category: 'SUBMIT_LEAD_FORM', origin: 'WEBSITE', primaryForGoal: false, includeInConversionsMetric: false } },
+                    { conversionAction: { resourceName: 'customers/4684433735/conversionActions/7217103107', id: '7217103107', name: 'SC | GA4 | Purchase', status: 'ENABLED', category: 'PURCHASE', origin: 'WEBSITE', primaryForGoal: true, includeInConversionsMetric: true } },
+                    { conversionAction: { resourceName: 'customers/4684433735/conversionActions/1', id: '1', name: 'Paused one', status: 'PAUSED', primaryForGoal: true } },
+                ] }]);
+        const actions = await client.conversionActions();
+        expect(actions.map(a => [a.id, a.enabled, a.countsByDefault])).toEqual([['7845520214', true, false], ['7217103107', true, true], ['1', false, true]]);
+        expect(queryOf(calls[1])).toContain("FROM conversion_action WHERE conversion_action.status != 'REMOVED'");
+        expect(await client.findConversionActionById(' 7845520214 ')).toMatchObject({ name: 'Ascend Book Download - Google - Form Submission' });
+        expect(await client.findConversionActionById('999')).toBeNull();
+    });
+    it('creates a one-action custom goal named after the action and points the campaign at it with a CAMPAIGN-level goal config', async () => {
+        const { client, calls } = googleClient((url) => url.includes('customConversionGoals') ? { results: [{ resourceName: 'customers/4684433735/customConversionGoals/55' }] } : url.includes('searchStream') ? [] : { results: [{ resourceName: 'x' }] });
+        const goal = await client.ensureCustomConversionGoal('customers/4684433735/conversionActions/7845520214', 'Marketing: Ascend Book Download - Google - Form Submission');
+        expect(goal).toBe('customers/4684433735/customConversionGoals/55');
+        const lookup = calls.find(c => c.url.includes('searchStream'));
+        expect(queryOf(lookup)).toContain('FROM custom_conversion_goal');
+        const create = calls.find(c => c.url.includes('customConversionGoals:mutate'));
+        expect(JSON.parse(String(create.init?.body))).toEqual({ operations: [{ create: { name: 'Marketing: Ascend Book Download - Google - Form Submission', conversionActions: ['customers/4684433735/conversionActions/7845520214'], status: 'ENABLED' } }] });
+        await client.setCampaignConversionGoal('customers/4684433735/campaigns/24313683017', goal);
+        const point = calls.find(c => c.url.includes('conversionGoalCampaignConfigs:mutate'));
+        expect(JSON.parse(String(point.init?.body))).toEqual({ operations: [{
+                    update: { resourceName: 'customers/4684433735/conversionGoalCampaignConfigs/24313683017', goalConfigLevel: 'CAMPAIGN', customConversionGoal: goal },
+                    updateMask: 'goal_config_level,custom_conversion_goal',
+                }] });
+        // Google allows ONE goal per action list on the customer: an existing goal holding exactly this action is reused
+        // as is (whoever made it, whatever its name), a goal holding more actions is not a match.
+        const { client: adoptingClient, calls: adoptCalls } = googleClient(() => [{ results: [
+                    { customConversionGoal: { resourceName: 'customers/4684433735/customConversionGoals/9', name: 'Agency bundle', conversionActions: ['customers/4684433735/conversionActions/7845520214', 'customers/4684433735/conversionActions/7217103107'] } },
+                    { customConversionGoal: { resourceName: 'customers/4684433735/customConversionGoals/6459699002', name: 'CG-01 — conversion goal', conversionActions: ['customers/4684433735/conversionActions/7845520214'] } },
+                ] }]);
+        expect(await adoptingClient.ensureCustomConversionGoal('customers/4684433735/conversionActions/7845520214', 'Marketing: whatever')).toBe('customers/4684433735/customConversionGoals/6459699002');
+        expect(adoptCalls.some(c => c.url.includes('customConversionGoals:mutate'))).toBe(false);
+    });
+    it('measures the named action alone (all_conversions segmented by it) and leaves impressions, clicks and cost unsegmented', async () => {
+        const { client, calls } = googleClient((_url, body) => {
+            const q = body.query;
+            return q.includes('segments.conversion_action')
+                ? [{ results: [{ metrics: { allConversions: 3 } }] }]
+                : [{ results: [{ metrics: { impressions: 1000, clicks: 40, conversions: 0, costMicros: 12_500_000 } }] }];
+        });
+        const m = await client.campaignMetrics(['customers/4684433735/campaigns/1'], new Date('2026-10-01T00:00:00Z'), new Date('2026-10-14T00:00:00Z'), 'customers/4684433735/conversionActions/7845520214');
+        expect(m).toEqual({ impressions: 1000, clicks: 40, conversions: 3, spendUsd: 12.5 });
+        const queries = calls.filter(c => c.url.includes('searchStream')).map(queryOf);
+        expect(queries).toHaveLength(2);
+        expect(queries[0]).not.toContain('segments.conversion_action');
+        expect(queries[1]).toContain("SELECT metrics.all_conversions FROM campaign WHERE campaign.resource_name IN ('customers/4684433735/campaigns/1') AND segments.date BETWEEN '2026-10-01' AND '2026-10-14' AND segments.conversion_action = 'customers/4684433735/conversionActions/7845520214'");
+        const plain = await client.campaignMetrics(['customers/4684433735/campaigns/1'], new Date('2026-10-01T00:00:00Z'), new Date('2026-10-14T00:00:00Z'));
+        expect(plain.conversions).toBe(0);
+        expect(calls.filter(c => c.url.includes('searchStream'))).toHaveLength(3);
+    });
+});
+function metaClient(answer) {
+    const calls = [];
+    const fetchImpl = (async (input, init) => {
+        const url = new URL(String(input));
+        const body = init?.body instanceof URLSearchParams ? init.body : null;
+        calls.push({ url, body });
+        return new Response(JSON.stringify(answer(url, body)), { status: 200 });
+    });
+    return { client: new MetaAdsClient({ appSecret: 's', accessToken: 't', adAccountId: 'act_2312673322359408', fetchImpl }), calls };
+}
+describe('MetaAdsClient — custom conversions (D-34 parity)', () => {
+    it('lists custom conversions by id with archived ones disabled, and finds one by id', async () => {
+        const { client, calls } = metaClient(() => ({ data: [
+                { id: '795683087750734', name: 'SC | Ascend Download', custom_event_type: 'LEAD', is_archived: false, pixel: { id: '415938279713144' } },
+                { id: '167817987988570', name: 'Newsletter Subscribe', custom_event_type: 'SUBSCRIBE', is_archived: true, pixel: { id: '415938279713144' } },
+            ] }));
+        const list = await client.customConversions();
+        expect(list).toEqual([
+            { id: '795683087750734', name: 'SC | Ascend Download', enabled: true, customEventType: 'LEAD', pixelId: '415938279713144' },
+            { id: '167817987988570', name: 'Newsletter Subscribe', enabled: false, customEventType: 'SUBSCRIBE', pixelId: '415938279713144' },
+        ]);
+        expect(calls[0].url.pathname).toBe('/v21.0/act_2312673322359408/customconversions');
+        expect(calls[0].url.searchParams.get('fields')).toBe('id,name,custom_event_type,is_archived,pixel{id}');
+        expect(await client.findCustomConversionById('795683087750734')).toMatchObject({ name: 'SC | Ascend Download' });
+    });
+    it('creates the ad set optimising for the custom conversion (custom_conversion_id only — Meta 400s 100/1885014 if pixel_id is included), and the campaign under the objective the conversion calls for', async () => {
+        const { client, calls } = metaClient(() => ({ id: '120' }));
+        await client.createCampaign({ name: 'CX-05 — campaign', status: 'PAUSED', objective: 'OUTCOME_LEADS' });
+        expect(calls[0].body?.get('objective')).toBe('OUTCOME_LEADS');
+        await client.createAdSet({ name: 'CX-05 — ad set', campaignId: '120', dailyBudgetUsd: 25, status: 'PAUSED', runSchedule: { start: 1_792_000_000_000 }, countries: ['US'], conversion: { customConversionId: '795683087750734', pixelId: '415938279713144' } });
+        const adSet = calls[1].body;
+        expect(adSet.get('optimization_goal')).toBe('OFFSITE_CONVERSIONS');
+        expect(JSON.parse(adSet.get('promoted_object'))).toEqual({ custom_conversion_id: '795683087750734' });
+        await client.createAdSet({ name: 'CX-06 — ad set', campaignId: '120', dailyBudgetUsd: 25, status: 'PAUSED', runSchedule: { start: 1_792_000_000_000 }, countries: ['US'] });
+        expect(calls[2].body?.get('optimization_goal')).toBe('LINK_CLICKS');
+        expect(calls[2].body?.has('promoted_object')).toBe(false);
+    });
+    it('counts only the named conversion\'s action when one is given, every offsite/lead action otherwise', async () => {
+        const rows = { data: [{ impressions: '500', clicks: '20', spend: '10.5', actions: [
+                        { action_type: 'offsite_conversion.custom.795683087750734', value: '2' },
+                        { action_type: 'offsite_conversion.fb_pixel_lead', value: '5' },
+                        { action_type: 'link_click', value: '20' },
+                    ] }] };
+        const { client } = metaClient(() => rows);
+        expect((await client.adSetMetrics(['1'], new Date('2026-10-01T00:00:00Z'), new Date('2026-10-14T00:00:00Z'), '795683087750734')).conversions).toBe(2);
+        expect((await client.adSetMetrics(['1'], new Date('2026-10-01T00:00:00Z'), new Date('2026-10-14T00:00:00Z'))).conversions).toBe(7);
+        expect(customConversionActionType('795683087750734')).toBe('offsite_conversion.custom.795683087750734');
+    });
+    it('picks the ODAX objective from the conversion\'s event class', () => {
+        expect(metaObjectiveFor(null)).toBe('OUTCOME_TRAFFIC');
+        expect(metaObjectiveFor({ id: '1', name: 'x', enabled: true, customEventType: 'LEAD', pixelId: null })).toBe('OUTCOME_LEADS');
+        expect(metaObjectiveFor({ id: '1', name: 'x', enabled: true, customEventType: 'complete_registration', pixelId: null })).toBe('OUTCOME_LEADS');
+        expect(metaObjectiveFor({ id: '1', name: 'x', enabled: true, customEventType: 'PURCHASE', pixelId: null })).toBe('OUTCOME_SALES');
+        expect(metaObjectiveFor({ id: '1', name: 'x', enabled: true, customEventType: 'OTHER', pixelId: null })).toBe('OUTCOME_SALES');
+    });
+});
+//# sourceMappingURL=adConversionParity.test.js.map

package/dist/__tests__/adConversionParity.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"adConversionParity.test.js","sourceRoot":"","sources":["../../src/__tests__/adConversionParity.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,eAAe,EAAE,MAAM,uCAAuC,CAAC;AACxE,OAAO,EAAE,aAAa,EAAE,0BAA0B,EAAE,gBAAgB,EAAE,MAAM,mCAAmC,CAAC;AAShH,SAAS,YAAY,CAAC,MAA+C;IACjE,MAAM,KAAK,GAAe,EAAE,CAAC;IAC7B,MAAM,SAAS,GAAG,CAAC,KAAK,EAAE,KAA6B,EAAE,IAAkB,EAAE,EAAE;QAC3E,MAAM,GAAG,GAAG,MAAM,CAAC,KAAK,CAAC,CAAC;QAC1B,KAAK,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAAC;QAC1B,IAAI,GAAG,CAAC,QAAQ,CAAC,QAAQ,CAAC;YAAE,OAAO,IAAI,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,EAAE,YAAY,EAAE,GAAG,EAAE,UAAU,EAAE,IAAI,EAAE,CAAC,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC;QAC1H,MAAM,IAAI,GAAG,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,CAAY,CAAC,CAAC,CAAC,IAAI,CAAC;QAC1E,OAAO,IAAI,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC;IAC5E,CAAC,CAAiB,CAAC;IACnB,OAAO,EAAE,MAAM,EAAE,IAAI,eAAe,CAAC,EAAE,QAAQ,EAAE,GAAG,EAAE,YAAY,EAAE,GAAG,EAAE,YAAY,EAAE,GAAG,EAAE,UAAU,EAAE,YAAY,EAAE,SAAS,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC;AAChJ,CAAC;AACD,MAAM,OAAO,GAAG,CAAC,CAAW,EAAU,EAAE,CAAE,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,IAAI,EAAE,IAAI,CAAC,CAAwB,CAAC,KAAK,IAAI,EAAE,CAAC;AAE9G,QAAQ,CAAC,oDAAoD,EAAE,GAAG,EAAE;IAChE,EAAE,CAAC,iGAAiG,EAAE,KAAK,IAAI,EAAE;QAC7G,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE;oBACrD,EAAE,gBAAgB,EAAE,EAAE,YAAY,EAAE,mDAAmD,EAAE,EAAE,EAAE,YAAY,EAAE,IAAI,EAAE,iDAAiD,EAAE,MAAM,EAAE,SAAS,EAAE,QAAQ,EAAE,kBAAkB,EAAE,MAAM,EAAE,SAAS,EAAE,cAAc,EAAE,KAAK,EAAE,0BAA0B,EAAE,KAAK,EAAE,EAAE;oBACpS,EAAE,gBAAgB,EAAE,EAAE,YAAY,EAAE,mDAAmD,EAAE,EAAE,EAAE,YAAY,EAAE,IAAI,EAAE,qBAAqB,EAAE,MAAM,EAAE,SAAS,EAAE,QAAQ,EAAE,UAAU,EAAE,MAAM,EAAE,SAAS,EAAE,cAAc,EAAE,IAAI,EAAE,0BAA0B,EAAE,IAAI,EAAE,EAAE;oBAC9P,EAAE,gBAAgB,EAAE,EAAE,YAAY,EAAE,0CAA0C,EAAE,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,YAAY,EAAE,MAAM,EAAE,QAAQ,EAAE,cAAc,EAAE,IAAI,EAAE,EAAE;iBAC1J,EAAE,CAAC,CAAC,CAAC;QACN,MAAM,OAAO,GAAG,MAAM,MAAM,CAAC,iBAAiB,EAAE,CAAC;QACjD,MAAM,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC,eAAe,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,CAAC,YAAY,EAAE,IAAI,EAAE,KAAK,CAAC,EAAE,CAAC,YAAY,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,GAAG,EAAE,KAAK,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC;QACtJ,MAAM,CAAC,OAAO,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,oEAAoE,CAAC,CAAC;QAC1G,MAAM,CAAC,MAAM,MAAM,CAAC,wBAAwB,CAAC,cAAc,CAAC,CAAC,CAAC,aAAa,CAAC,EAAE,IAAI,EAAE,iDAAiD,EAAE,CAAC,CAAC;QACzI,MAAM,CAAC,MAAM,MAAM,CAAC,wBAAwB,CAAC,KAAK,CAAC,CAAC,CAAC,QAAQ,EAAE,CAAC;IACpE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yHAAyH,EAAE,KAAK,IAAI,EAAE;QACrI,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,YAAY,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,GAAG,CAAC,QAAQ,CAAC,uBAAuB,CAAC,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,YAAY,EAAE,+CAA+C,EAAE,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,YAAY,EAAE,GAAG,EAAE,CAAC,EAAE,CAAC,CAAC;QACrP,MAAM,IAAI,GAAG,MAAM,MAAM,CAAC,0BAA0B,CAAC,mDAAmD,EAAE,4DAA4D,CAAC,CAAC;QACxK,MAAM,CAAC,IAAI,CAAC,CAAC,IAAI,CAAC,+CAA+C,CAAC,CAAC;QACnE,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAE,CAAC;QAChE,MAAM,CAAC,OAAO,CAAC,MAAM,CAAC,CAAC,CAAC,SAAS,CAAC,6BAA6B,CAAC,CAAC;QACjE,MAAM,MAAM,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,8BAA8B,CAAC,CAAE,CAAC;QAChF,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,UAAU,EAAE,CAAC,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,4DAA4D,EAAE,iBAAiB,EAAE,CAAC,mDAAmD,CAAC,EAAE,MAAM,EAAE,SAAS,EAAE,EAAE,CAAC,EAAE,CAAC,CAAC;QACzP,MAAM,MAAM,CAAC,yBAAyB,CAAC,4CAA4C,EAAE,IAAI,CAAC,CAAC;QAC3F,MAAM,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,sCAAsC,CAAC,CAAE,CAAC;QACvF,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,IAAI,EAAE,IAAI,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,UAAU,EAAE,CAAC;oBAChE,MAAM,EAAE,EAAE,YAAY,EAAE,gEAAgE,EAAE,eAAe,EAAE,UAAU,EAAE,oBAAoB,EAAE,IAAI,EAAE;oBACnJ,UAAU,EAAE,0CAA0C;iBACzD,CAAC,EAAE,CAAC,CAAC;QACN,iHAAiH;QACjH,0FAA0F;QAC1F,MAAM,EAAE,MAAM,EAAE,cAAc,EAAE,KAAK,EAAE,UAAU,EAAE,GAAG,YAAY,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,OAAO,EAAE;oBACjF,EAAE,oBAAoB,EAAE,EAAE,YAAY,EAAE,8CAA8C,EAAE,IAAI,EAAE,eAAe,EAAE,iBAAiB,EAAE,CAAC,mDAAmD,EAAE,mDAAmD,CAAC,EAAE,EAAE;oBAChP,EAAE,oBAAoB,EAAE,EAAE,YAAY,EAAE,uDAAuD,EAAE,IAAI,EAAE,yBAAyB,EAAE,iBAAiB,EAAE,CAAC,mDAAmD,CAAC,EAAE,EAAE;iBACjN,EAAE,CAAC,CAAC,CAAC;QACN,MAAM,CAAC,MAAM,cAAc,CAAC,0BAA0B,CAAC,mDAAmD,EAAE,qBAAqB,CAAC,CAAC,CAAC,IAAI,CAAC,uDAAuD,CAAC,CAAC;QAClM,MAAM,CAAC,UAAU,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,8BAA8B,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC7F,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uHAAuH,EAAE,KAAK,IAAI,EAAE;QACnI,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,YAAY,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,EAAE;YAClD,MAAM,CAAC,GAAI,IAA0B,CAAC,KAAK,CAAC;YAC5C,OAAO,CAAC,CAAC,QAAQ,CAAC,4BAA4B,CAAC;gBAC3C,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,cAAc,EAAE,CAAC,EAAE,EAAE,CAAC,EAAE,CAAC;gBACrD,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,CAAC,EAAE,OAAO,EAAE,EAAE,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,WAAW,EAAE,CAAC,EAAE,UAAU,EAAE,UAAU,EAAE,EAAE,CAAC,EAAE,CAAC,CAAC;QAClH,CAAC,CAAC,CAAC;QACH,MAAM,CAAC,GAAG,MAAM,MAAM,CAAC,eAAe,CAAC,CAAC,kCAAkC,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,mDAAmD,CAAC,CAAC;QACtM,MAAM,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,WAAW,EAAE,CAAC,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;QACrF,MAAM,OAAO,GAAG,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,CAAC;QAC/E,MAAM,CAAC,OAAO,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAChC,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,SAAS,CAAC,4BAA4B,CAAC,CAAC;QAC/D,MAAM,CAAC,OAAO,CAAC,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,gQAAgQ,CAAC,CAAC;QAC/R,MAAM,KAAK,GAAG,MAAM,MAAM,CAAC,eAAe,CAAC,CAAC,kCAAkC,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAC,CAAC;QACrJ,MAAM,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QAClC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IAC9E,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC;AAEH,SAAS,UAAU,CAAC,MAA2D;IAC3E,MAAM,KAAK,GAAsD,EAAE,CAAC;IACpE,MAAM,SAAS,GAAG,CAAC,KAAK,EAAE,KAA6B,EAAE,IAAkB,EAAE,EAAE;QAC3E,MAAM,GAAG,GAAG,IAAI,GAAG,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC;QACnC,MAAM,IAAI,GAAG,IAAI,EAAE,IAAI,YAAY,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC;QACtE,KAAK,CAAC,IAAI,CAAC,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAAC;QAC1B,OAAO,IAAI,QAAQ,CAAC,IAAI,CAAC,SAAS,CAAC,MAAM,CAAC,GAAG,EAAE,IAAI,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAC;IAC5E,CAAC,CAAiB,CAAC;IACnB,OAAO,EAAE,MAAM,EAAE,IAAI,aAAa,CAAC,EAAE,SAAS,EAAE,GAAG,EAAE,WAAW,EAAE,GAAG,EAAE,WAAW,EAAE,sBAAsB,EAAE,SAAS,EAAE,CAAC,EAAE,KAAK,EAAE,CAAC;AACtI,CAAC;AAED,QAAQ,CAAC,kDAAkD,EAAE,GAAG,EAAE;IAC9D,EAAE,CAAC,iFAAiF,EAAE,KAAK,IAAI,EAAE;QAC7F,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,UAAU,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,IAAI,EAAE;gBAChD,EAAE,EAAE,EAAE,iBAAiB,EAAE,IAAI,EAAE,sBAAsB,EAAE,iBAAiB,EAAE,MAAM,EAAE,WAAW,EAAE,KAAK,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,iBAAiB,EAAE,EAAE;gBACxI,EAAE,EAAE,EAAE,iBAAiB,EAAE,IAAI,EAAE,sBAAsB,EAAE,iBAAiB,EAAE,WAAW,EAAE,WAAW,EAAE,IAAI,EAAE,KAAK,EAAE,EAAE,EAAE,EAAE,iBAAiB,EAAE,EAAE;aAC/I,EAAE,CAAC,CAAC,CAAC;QACN,MAAM,IAAI,GAAG,MAAM,MAAM,CAAC,iBAAiB,EAAE,CAAC;QAC9C,MAAM,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC;YACjB,EAAE,EAAE,EAAE,iBAAiB,EAAE,IAAI,EAAE,sBAAsB,EAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,OAAO,EAAE,iBAAiB,EAAE;YAC3H,EAAE,EAAE,EAAE,iBAAiB,EAAE,IAAI,EAAE,sBAAsB,EAAE,OAAO,EAAE,KAAK,EAAE,eAAe,EAAE,WAAW,EAAE,OAAO,EAAE,iBAAiB,EAAE;SACpI,CAAC,CAAC;QACH,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,+CAA+C,CAAC,CAAC;QACpF,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,YAAY,CAAC,GAAG,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,iDAAiD,CAAC,CAAC;QACxG,MAAM,CAAC,MAAM,MAAM,CAAC,wBAAwB,CAAC,iBAAiB,CAAC,CAAC,CAAC,aAAa,CAAC,EAAE,IAAI,EAAE,sBAAsB,EAAE,CAAC,CAAC;IACrH,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oMAAoM,EAAE,KAAK,IAAI,EAAE;QAChN,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,GAAG,UAAU,CAAC,GAAG,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,KAAK,EAAE,CAAC,CAAC,CAAC;QAC5D,MAAM,MAAM,CAAC,cAAc,CAAC,EAAE,IAAI,EAAE,kBAAkB,EAAE,MAAM,EAAE,QAAQ,EAAE,SAAS,EAAE,eAAe,EAAE,CAAC,CAAC;QACxG,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC9D,MAAM,MAAM,CAAC,WAAW,CAAC,EAAE,IAAI,EAAE,gBAAgB,EAAE,UAAU,EAAE,KAAK,EAAE,cAAc,EAAE,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE,EAAE,KAAK,EAAE,iBAAiB,EAAE,EAAE,SAAS,EAAE,CAAC,IAAI,CAAC,EAAE,UAAU,EAAE,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,OAAO,EAAE,iBAAiB,EAAE,EAAE,CAAC,CAAC;QAC/P,MAAM,KAAK,GAAG,KAAK,CAAC,CAAC,CAAC,CAAC,IAAK,CAAC;QAC7B,MAAM,CAAC,KAAK,CAAC,GAAG,CAAC,mBAAmB,CAAC,CAAC,CAAC,IAAI,CAAC,qBAAqB,CAAC,CAAC;QACnE,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,GAAG,CAAC,iBAAiB,CAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,oBAAoB,EAAE,iBAAiB,EAAE,CAAC,CAAC;QACvG,MAAM,MAAM,CAAC,WAAW,CAAC,EAAE,IAAI,EAAE,gBAAgB,EAAE,UAAU,EAAE,KAAK,EAAE,cAAc,EAAE,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,WAAW,EAAE,EAAE,KAAK,EAAE,iBAAiB,EAAE,EAAE,SAAS,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;QAC5K,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,GAAG,CAAC,mBAAmB,CAAC,CAAC,CAAC,IAAI,CAAC,aAAa,CAAC,CAAC;QACpE,MAAM,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,IAAI,EAAE,GAAG,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC9D,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mGAAmG,EAAE,KAAK,IAAI,EAAE;QAC/G,MAAM,IAAI,GAAG,EAAE,IAAI,EAAE,CAAC,EAAE,WAAW,EAAE,KAAK,EAAE,MAAM,EAAE,IAAI,EAAE,KAAK,EAAE,MAAM,EAAE,OAAO,EAAE;wBAC9E,EAAE,WAAW,EAAE,2CAA2C,EAAE,KAAK,EAAE,GAAG,EAAE;wBACxE,EAAE,WAAW,EAAE,kCAAkC,EAAE,KAAK,EAAE,GAAG,EAAE;wBAC/D,EAAE,WAAW,EAAE,YAAY,EAAE,KAAK,EAAE,IAAI,EAAE;qBAC7C,EAAE,CAAC,EAAE,CAAC;QACP,MAAM,EAAE,MAAM,EAAE,GAAG,UAAU,CAAC,GAAG,EAAE,CAAC,IAAI,CAAC,CAAC;QAC1C,MAAM,CAAC,CAAC,MAAM,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,iBAAiB,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACtJ,MAAM,CAAC,CAAC,MAAM,MAAM,CAAC,YAAY,CAAC,CAAC,GAAG,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,EAAE,IAAI,IAAI,CAAC,sBAAsB,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC;QACnI,MAAM,CAAC,0BAA0B,CAAC,iBAAiB,CAAC,CAAC,CAAC,IAAI,CAAC,2CAA2C,CAAC,CAAC;IAC5G,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACnE,MAAM,CAAC,gBAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,iBAAiB,CAAC,CAAC;QACvD,MAAM,CAAC,gBAAgB,CAAC,EAAE,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,MAAM,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC9H,MAAM,CAAC,gBAAgB,CAAC,EAAE,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,uBAAuB,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC/I,MAAM,CAAC,gBAAgB,CAAC,EAAE,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,UAAU,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAClI,MAAM,CAAC,gBAAgB,CAAC,EAAE,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,GAAG,EAAE,OAAO,EAAE,IAAI,EAAE,eAAe,EAAE,OAAO,EAAE,OAAO,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;IACnI,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/dist/__tests__/googleCreativeImage.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=googleCreativeImage.test.d.ts.map

package/dist/__tests__/googleCreativeImage.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"googleCreativeImage.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/googleCreativeImage.test.ts"],"names":[],"mappings":""}

package/dist/__tests__/googleCreativeImage.test.js

@@ -0,0 +1,53 @@
+import { afterEach, describe, expect, it, vi } from 'vitest';
+import { GoogleAdsProgramDriver } from '../programs/google/GoogleAdsProgramDriver.js';
+/** A PNG whose IHDR says width×height — enough for the header-only dimension reader. */
+function png(width, height) {
+    const b = new Uint8Array(33);
+    b.set([0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a], 0);
+    const dv = new DataView(b.buffer);
+    dv.setUint32(8, 13);
+    b.set([0x49, 0x48, 0x44, 0x52], 12);
+    dv.setUint32(16, width);
+    dv.setUint32(20, height);
+    return b;
+}
+const user = { ID: 'U1', Email: 'harness@example.test' };
+const ctx = async () => ({ ok: true, client: { conversionActions: async () => [], findConversionActionById: async () => null }, brandConnectionId: 'C1', customerId: '4684433735', brandAssets: null, launchState: 'Paused' });
+const program = (levers) => ({ id: 'P1', brandId: 'B1', params: { tacticConfigJSON: JSON.stringify({ audience: 'targeted', dailyBudgetUsd: 25, landingPageUrl: 'https://sidecar.ai/ai', optimizeFor: 'clicks', creativeHeadlines: ['Free Ebook'], creativeDescriptions: ['Download it'], ...levers }) } });
+describe('GoogleAdsProgramDriver — the program image is held to Google\'s landscape slot at propose (KI-156)', () => {
+    afterEach(() => vi.unstubAllGlobals());
+    it('refuses a 16:9 generator frame with GA_CREATIVE_IMAGE_RATIO naming the size', async () => {
+        vi.stubGlobal('fetch', async () => new Response(Buffer.from(png(1376, 768)), { status: 200, headers: { 'content-type': 'image/png' } }));
+        const issues = await new GoogleAdsProgramDriver(user, ctx).validateProposal(program({ creativeImageUrl: 'https://example.test/ad.png' }));
+        const hit = issues.find(i => i.code === 'GA_CREATIVE_IMAGE_RATIO');
+        expect(hit?.severity).toBe('error');
+        expect(hit?.message).toMatch(/1376×768/);
+        expect(hit?.message).toMatch(/1\.91:1/);
+    });
+    it('accepts a 1.91:1 image and says nothing', async () => {
+        vi.stubGlobal('fetch', async () => new Response(Buffer.from(png(1200, 628)), { status: 200, headers: { 'content-type': 'image/png' } }));
+        const issues = await new GoogleAdsProgramDriver(user, ctx).validateProposal(program({ creativeImageUrl: 'https://example.test/ad.png' }));
+        expect(issues.filter(i => i.code.startsWith('GA_CREATIVE_IMAGE'))).toEqual([]);
+    });
+    it('warns, never refuses, when the image cannot be fetched', async () => {
+        vi.stubGlobal('fetch', async () => { throw new Error('ECONNRESET'); });
+        const issues = await new GoogleAdsProgramDriver(user, ctx).validateProposal(program({ creativeImageUrl: 'https://example.test/ad.png' }));
+        const hit = issues.find(i => i.code === 'GA_CREATIVE_IMAGE_UNREACHABLE');
+        expect(hit?.severity).toBe('warning');
+        expect(hit?.message).not.toMatch(/fall back/);
+    });
+    it('reports GA_CREATIVE_IMAGE_INVALID when the URL serves a non-image content-type', async () => {
+        vi.stubGlobal('fetch', async () => new Response('<html>not an image</html>', { status: 200, headers: { 'content-type': 'text/html' } }));
+        const issues = await new GoogleAdsProgramDriver(user, ctx).validateProposal(program({ creativeImageUrl: 'https://example.test/page' }));
+        const hit = issues.find(i => i.code === 'GA_CREATIVE_IMAGE_INVALID');
+        expect(hit?.severity).toBe('error');
+        expect(hit?.message).toMatch(/PNG or JPEG required/);
+    });
+    it('does not fetch anything when no image lever is set', async () => {
+        const f = vi.fn();
+        vi.stubGlobal('fetch', f);
+        await new GoogleAdsProgramDriver(user, ctx).validateProposal(program({}));
+        expect(f).not.toHaveBeenCalled();
+    });
+});
+//# sourceMappingURL=googleCreativeImage.test.js.map

package/dist/__tests__/googleCreativeImage.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"googleCreativeImage.test.js","sourceRoot":"","sources":["../../src/__tests__/googleCreativeImage.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,SAAS,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC7D,OAAO,EAAE,sBAAsB,EAAE,MAAM,8CAA8C,CAAC;AAGtF,wFAAwF;AACxF,SAAS,GAAG,CAAC,KAAa,EAAE,MAAc;IACtC,MAAM,CAAC,GAAG,IAAI,UAAU,CAAC,EAAE,CAAC,CAAC;IAC7B,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE,CAAC,CAAC,CAAC;IAC3D,MAAM,EAAE,GAAG,IAAI,QAAQ,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;IAClC,EAAE,CAAC,SAAS,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC;IAAC,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,IAAI,EAAE,IAAI,EAAE,IAAI,CAAC,EAAE,EAAE,CAAC,CAAC;IAAC,EAAE,CAAC,SAAS,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;IAAC,EAAE,CAAC,SAAS,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC;IAC5G,OAAO,CAAC,CAAC;AACb,CAAC;AACD,MAAM,IAAI,GAAG,EAAE,EAAE,EAAE,IAAI,EAAE,KAAK,EAAE,sBAAsB,EAAW,CAAC;AAClE,MAAM,GAAG,GAAG,KAAK,IAAqC,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,iBAAiB,EAAE,KAAK,IAAI,EAAE,CAAC,EAAE,EAAE,wBAAwB,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI,EAAW,EAAE,iBAAiB,EAAE,IAAI,EAAE,UAAU,EAAE,YAAY,EAAE,WAAW,EAAE,IAAI,EAAE,WAAW,EAAE,QAAQ,EAAE,CAAC,CAAC;AACzQ,MAAM,OAAO,GAAG,CAAC,MAA+B,EAAE,EAAE,CAAC,CAAC,EAAE,EAAE,EAAE,IAAI,EAAE,OAAO,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,gBAAgB,EAAE,IAAI,CAAC,SAAS,CAAC,EAAE,QAAQ,EAAE,UAAU,EAAE,cAAc,EAAE,EAAE,EAAE,cAAc,EAAE,uBAAuB,EAAE,WAAW,EAAE,QAAQ,EAAE,iBAAiB,EAAE,CAAC,YAAY,CAAC,EAAE,oBAAoB,EAAE,CAAC,aAAa,CAAC,EAAE,GAAG,MAAM,EAAE,CAAC,EAAE,EAAE,CAAU,CAAC;AAE7U,QAAQ,CAAC,oGAAoG,EAAE,GAAG,EAAE;IAChH,SAAS,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,gBAAgB,EAAE,CAAC,CAAC;IACvC,EAAE,CAAC,6EAA6E,EAAE,KAAK,IAAI,EAAE;QACzF,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,OAAO,EAAE,EAAE,cAAc,EAAE,WAAW,EAAE,EAAE,CAAC,CAAC,CAAC;QACzI,MAAM,MAAM,GAAG,MAAM,IAAI,sBAAsB,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,EAAE,gBAAgB,EAAE,6BAA6B,EAAE,CAAC,CAAC,CAAC;QAC1I,MAAM,GAAG,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,yBAAyB,CAAC,CAAC;QACnE,MAAM,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACpC,MAAM,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC;QACzC,MAAM,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;IAC5C,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,yCAAyC,EAAE,KAAK,IAAI,EAAE;QACrD,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI,QAAQ,CAAC,MAAM,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,OAAO,EAAE,EAAE,cAAc,EAAE,WAAW,EAAE,EAAE,CAAC,CAAC,CAAC;QACzI,MAAM,MAAM,GAAG,MAAM,IAAI,sBAAsB,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,EAAE,gBAAgB,EAAE,6BAA6B,EAAE,CAAC,CAAC,CAAC;QAC1I,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,CAAC,UAAU,CAAC,mBAAmB,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC;IACnF,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,wDAAwD,EAAE,KAAK,IAAI,EAAE;QACpE,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,GAAG,MAAM,IAAI,KAAK,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;QACvE,MAAM,MAAM,GAAG,MAAM,IAAI,sBAAsB,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,EAAE,gBAAgB,EAAE,6BAA6B,EAAE,CAAC,CAAC,CAAC;QAC1I,MAAM,GAAG,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,+BAA+B,CAAC,CAAC;QACzE,MAAM,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QACtC,MAAM,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,GAAG,CAAC,OAAO,CAAC,WAAW,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;QAC5F,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI,QAAQ,CAAC,2BAA2B,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,OAAO,EAAE,EAAE,cAAc,EAAE,WAAW,EAAE,EAAE,CAAC,CAAC,CAAC;QACzI,MAAM,MAAM,GAAG,MAAM,IAAI,sBAAsB,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,EAAE,gBAAgB,EAAE,2BAA2B,EAAE,CAAC,CAAC,CAAC;QACxI,MAAM,GAAG,GAAG,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,IAAI,KAAK,2BAA2B,CAAC,CAAC;QACrE,MAAM,CAAC,GAAG,EAAE,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACpC,MAAM,CAAC,GAAG,EAAE,OAAO,CAAC,CAAC,OAAO,CAAC,sBAAsB,CAAC,CAAC;IACzD,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,oDAAoD,EAAE,KAAK,IAAI,EAAE;QAChE,MAAM,CAAC,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC;QAAC,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;QAC7C,MAAM,IAAI,sBAAsB,CAAC,IAAI,EAAE,GAAG,CAAC,CAAC,gBAAgB,CAAC,OAAO,CAAC,EAAE,CAAC,CAAC,CAAC;QAC1E,MAAM,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACrC,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/dist/__tests__/linkedInTargeting.test.d.ts

@@ -0,0 +1,2 @@
+export {};
+//# sourceMappingURL=linkedInTargeting.test.d.ts.map

package/dist/__tests__/linkedInTargeting.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"linkedInTargeting.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/linkedInTargeting.test.ts"],"names":[],"mappings":""}

package/dist/__tests__/linkedInTargeting.test.js

@@ -0,0 +1,65 @@
+import { describe, expect, it } from 'vitest';
+import { creativeRetireTarget, inlineCreativeContent, lacksConversionScope } from '../programs/linkedin/LinkedInAdsClient.js';
+import { withRequiredFacets } from '../programs/linkedin/LinkedInAdsClient.js';
+/**
+ * R1 (plans/linkedin-ad-setup-plan.md): a campaign's targeting is the saved audience's own criteria — plus the
+ * location/locale pair LinkedIn requires when the template lacks it, plus the retargeting segment when the audience
+ * lever asked for one. CP-02's criteria were the pair ALONE (300M people); this is what makes that impossible.
+ */
+const staff = {
+    include: { and: [
+            { or: { 'urn:li:adTargetingFacet:jobFunctions': ['urn:li:function:7'] } },
+            { or: { 'urn:li:adTargetingFacet:locations': ['urn:li:geo:103644278', 'urn:li:geo:101174742'] } },
+            { or: { 'urn:li:adTargetingFacet:interfaceLocales': ['urn:li:locale:en_US'] } },
+        ] },
+    exclude: { or: { 'urn:li:adTargetingFacet:industries': ['urn:li:industry:68'] } },
+};
+const facetsOf = (c) => (c['include'].and).map(a => Object.keys(a.or)[0]);
+describe('withRequiredFacets', () => {
+    it('copies the template verbatim when it already carries a location and a locale, exclude included', () => {
+        const out = withRequiredFacets(staff, null);
+        expect(facetsOf(out)).toEqual(['urn:li:adTargetingFacet:jobFunctions', 'urn:li:adTargetingFacet:locations', 'urn:li:adTargetingFacet:interfaceLocales']);
+        expect(out['exclude']).toEqual(staff.exclude);
+    });
+    it('adds the required location and locale when the template lacks them', () => {
+        const out = withRequiredFacets({ include: { and: [{ or: { 'urn:li:adTargetingFacet:industries': ['urn:li:industry:100'] } }] } }, null);
+        expect(facetsOf(out)).toEqual(['urn:li:adTargetingFacet:industries', 'urn:li:adTargetingFacet:locations', 'urn:li:adTargetingFacet:interfaceLocales']);
+    });
+    it('AND-s the retargeting segment in through the dynamic facet, first', () => {
+        const out = withRequiredFacets(staff, 'urn:li:adSegment:42');
+        expect(facetsOf(out)[0]).toBe('urn:li:adTargetingFacet:dynamicSegments');
+        expect(facetsOf(out)).toHaveLength(4);
+    });
+    it('never mutates the template object', () => {
+        const before = JSON.stringify(staff);
+        withRequiredFacets(staff, 'urn:li:adSegment:42');
+        expect(JSON.stringify(staff)).toBe(before);
+    });
+});
+describe('creativeRetireTarget (KI-146)', () => {
+    it('archives an approved creative and leaves one LinkedIn has not approved untouched (no transition is allowed before approval)', () => {
+        expect(creativeRetireTarget({ intendedStatus: 'ACTIVE', review: { status: 'APPROVED' } })).toEqual({ status: 'ARCHIVED', change: true });
+        expect(creativeRetireTarget({ intendedStatus: 'ACTIVE', review: { status: 'REJECTED' } })).toEqual({ status: 'HELD', change: false });
+        expect(creativeRetireTarget({ intendedStatus: 'ACTIVE', review: { status: 'PENDING' } })).toEqual({ status: 'HELD', change: false });
+        expect(creativeRetireTarget({ intendedStatus: 'ACTIVE' })).toEqual({ status: 'HELD', change: false });
+    });
+    it('changes nothing that is already archived', () => {
+        expect(creativeRetireTarget({ intendedStatus: 'ARCHIVED', review: { status: 'REJECTED' } })).toEqual({ status: 'ARCHIVED', change: false });
+    });
+});
+describe('KI-148: a conversion needs the rw_conversions scope', () => {
+    it('a known scope list without it is a miss; with it, or unknown, it is not', () => {
+        expect(lacksConversionScope(['r_ads', 'rw_ads', 'r_ads_reporting'])).toBe(true);
+        expect(lacksConversionScope(['r_ads', 'rw_ads', 'rw_conversions'])).toBe(false);
+        expect(lacksConversionScope(null)).toBe(false);
+    });
+});
+describe('KI-150: an ad is article content with the image as thumbnail — the shape Campaign Manager renders with headline, destination and button', () => {
+    it('with an image: source, title, description, thumbnail + alt text; without: a plain link card', () => {
+        expect(inlineCreativeContent({ landingPageUrl: 'https://x.test/a?utm_source=linkedin', headline: 'H', description: 'D', imageUrn: 'urn:li:image:1' }))
+            .toEqual({ article: { source: 'https://x.test/a?utm_source=linkedin', title: 'H', description: 'D', thumbnail: 'urn:li:image:1', thumbnailAltText: 'H' } });
+        expect(inlineCreativeContent({ landingPageUrl: 'https://x.test/a', headline: 'H', description: null, imageUrn: null }))
+            .toEqual({ article: { source: 'https://x.test/a', title: 'H' } });
+    });
+});
+//# sourceMappingURL=linkedInTargeting.test.js.map

package/dist/__tests__/linkedInTargeting.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"linkedInTargeting.test.js","sourceRoot":"","sources":["../../src/__tests__/linkedInTargeting.test.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAC;AAC9C,OAAO,EAAE,oBAAoB,EAAE,qBAAqB,EAAE,oBAAoB,EAAE,MAAM,2CAA2C,CAAC;AAC9H,OAAO,EAAE,kBAAkB,EAAE,MAAM,2CAA2C,CAAC;AAE/E;;;;GAIG;AACH,MAAM,KAAK,GAAG;IACV,OAAO,EAAE,EAAE,GAAG,EAAE;YACZ,EAAE,EAAE,EAAE,EAAE,sCAAsC,EAAE,CAAC,mBAAmB,CAAC,EAAE,EAAE;YACzE,EAAE,EAAE,EAAE,EAAE,mCAAmC,EAAE,CAAC,sBAAsB,EAAE,sBAAsB,CAAC,EAAE,EAAE;YACjG,EAAE,EAAE,EAAE,EAAE,0CAA0C,EAAE,CAAC,qBAAqB,CAAC,EAAE,EAAE;SAClF,EAAE;IACH,OAAO,EAAE,EAAE,EAAE,EAAE,EAAE,oCAAoC,EAAE,CAAC,oBAAoB,CAAC,EAAE,EAAE;CACpF,CAAC;AACF,MAAM,QAAQ,GAAG,CAAC,CAA0B,EAAE,EAAE,CAAC,CAAE,CAAC,CAAC,SAAS,CAAsD,CAAC,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC;AAEzJ,QAAQ,CAAC,oBAAoB,EAAE,GAAG,EAAE;IAChC,EAAE,CAAC,gGAAgG,EAAE,GAAG,EAAE;QACtG,MAAM,GAAG,GAAG,kBAAkB,CAAC,KAAK,EAAE,IAAI,CAAC,CAAC;QAC5C,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,sCAAsC,EAAE,mCAAmC,EAAE,0CAA0C,CAAC,CAAC,CAAC;QACzJ,MAAM,CAAC,GAAG,CAAC,SAAS,CAAC,CAAC,CAAC,OAAO,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC;IAClD,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,oEAAoE,EAAE,GAAG,EAAE;QAC1E,MAAM,GAAG,GAAG,kBAAkB,CAAC,EAAE,OAAO,EAAE,EAAE,GAAG,EAAE,CAAC,EAAE,EAAE,EAAE,EAAE,oCAAoC,EAAE,CAAC,qBAAqB,CAAC,EAAE,EAAE,CAAC,EAAE,EAAE,EAAE,IAAI,CAAC,CAAC;QACxI,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,OAAO,CAAC,CAAC,oCAAoC,EAAE,mCAAmC,EAAE,0CAA0C,CAAC,CAAC,CAAC;IAC3J,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,mEAAmE,EAAE,GAAG,EAAE;QACzE,MAAM,GAAG,GAAG,kBAAkB,CAAC,KAAK,EAAE,qBAAqB,CAAC,CAAC;QAC7D,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,yCAAyC,CAAC,CAAC;QACzE,MAAM,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;IAC1C,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,mCAAmC,EAAE,GAAG,EAAE;QACzC,MAAM,MAAM,GAAG,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC;QACrC,kBAAkB,CAAC,KAAK,EAAE,qBAAqB,CAAC,CAAC;QACjD,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,KAAK,CAAC,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,+BAA+B,EAAE,GAAG,EAAE;IAC3C,EAAE,CAAC,6HAA6H,EAAE,GAAG,EAAE;QACnI,MAAM,CAAC,oBAAoB,CAAC,EAAE,cAAc,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,EAAE,IAAI,EAAE,CAAC,CAAC;QACzI,MAAM,CAAC,oBAAoB,CAAC,EAAE,cAAc,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;QACtI,MAAM,CAAC,oBAAoB,CAAC,EAAE,cAAc,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,MAAM,EAAE,SAAS,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;QACrI,MAAM,CAAC,oBAAoB,CAAC,EAAE,cAAc,EAAE,QAAQ,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,MAAM,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;IAC1G,CAAC,CAAC,CAAC;IACH,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QAChD,MAAM,CAAC,oBAAoB,CAAC,EAAE,cAAc,EAAE,UAAU,EAAE,MAAM,EAAE,EAAE,MAAM,EAAE,UAAU,EAAE,EAAE,CAAC,CAAC,CAAC,OAAO,CAAC,EAAE,MAAM,EAAE,UAAU,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC,CAAC;IAChJ,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,qDAAqD,EAAE,GAAG,EAAE;IACjE,EAAE,CAAC,yEAAyE,EAAE,GAAG,EAAE;QAC/E,MAAM,CAAC,oBAAoB,CAAC,CAAC,OAAO,EAAE,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAChF,MAAM,CAAC,oBAAoB,CAAC,CAAC,OAAO,EAAE,QAAQ,EAAE,gBAAgB,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QAChF,MAAM,CAAC,oBAAoB,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IACnD,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC;AAEH,QAAQ,CAAC,yIAAyI,EAAE,GAAG,EAAE;IACrJ,EAAE,CAAC,6FAA6F,EAAE,GAAG,EAAE;QACnG,MAAM,CAAC,qBAAqB,CAAC,EAAE,cAAc,EAAE,sCAAsC,EAAE,QAAQ,EAAE,GAAG,EAAE,WAAW,EAAE,GAAG,EAAE,QAAQ,EAAE,gBAAgB,EAAE,CAAC,CAAC;aACjJ,OAAO,CAAC,EAAE,OAAO,EAAE,EAAE,MAAM,EAAE,sCAAsC,EAAE,KAAK,EAAE,GAAG,EAAE,WAAW,EAAE,GAAG,EAAE,SAAS,EAAE,gBAAgB,EAAE,gBAAgB,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC;QAChK,MAAM,CAAC,qBAAqB,CAAC,EAAE,cAAc,EAAE,kBAAkB,EAAE,QAAQ,EAAE,GAAG,EAAE,WAAW,EAAE,IAAI,EAAE,QAAQ,EAAE,IAAI,EAAE,CAAC,CAAC;aAClH,OAAO,CAAC,EAAE,OAAO,EAAE,EAAE,MAAM,EAAE,kBAAkB,EAAE,KAAK,EAAE,GAAG,EAAE,EAAE,CAAC,CAAC;IAC1E,CAAC,CAAC,CAAC;AACP,CAAC,CAAC,CAAC"}

package/dist/agents/MarketingCreativeAgent.d.ts

@@ -0,0 +1,16 @@
+import { BaseMarketingAgent } from './BaseMarketingAgent.js';
+/**
+ * Marketing Creative Agent — driver class (D-29).
+ *
+ * The Programs agent's SUB-AGENT for the picture in an ad: it decides what the image shows and which candidate
+ * fits the brand, through `Generate Ad Image` (generate, or adapt a supplied picture). It is a child of the Programs
+ * agent in metadata (`ParentID`), so MJ discovers it from the relationship and the parent delegates when a draft
+ * needs an image. The base class gives it what every marketing agent has: the brand from the payload or the
+ * caller's grants, and the payload bootstrap. Nothing else is special about it — the judgment is in its prompt.
+ */
+/** The agent row's Name — what the Programs agent's delegation names and its sub-agent hook matches on (KI-134). */
+export declare const CREATIVE_AGENT_NAME = "Marketing Creative Agent";
+export declare class MarketingCreativeAgent extends BaseMarketingAgent {
+}
+export declare function LoadMarketingCreativeAgent(): void;
+//# sourceMappingURL=MarketingCreativeAgent.d.ts.map

package/dist/agents/MarketingCreativeAgent.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"MarketingCreativeAgent.d.ts","sourceRoot":"","sources":["../../src/agents/MarketingCreativeAgent.ts"],"names":[],"mappings":"AAEA,OAAO,EAAE,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAE7D;;;;;;;;GAQG;AACH,oHAAoH;AACpH,eAAO,MAAM,mBAAmB,6BAA6B,CAAC;AAE9D,qBACa,sBAAuB,SAAQ,kBAAkB;CAC7D;AAED,wBAAgB,0BAA0B,SAAK"}

package/dist/agents/MarketingCreativeAgent.js

@@ -0,0 +1,28 @@
+var __decorate = (this && this.__decorate) || function (decorators, target, key, desc) {
+    var c = arguments.length, r = c < 3 ? target : desc === null ? desc = Object.getOwnPropertyDescriptor(target, key) : desc, d;
+    if (typeof Reflect === "object" && typeof Reflect.decorate === "function") r = Reflect.decorate(decorators, target, key, desc);
+    else for (var i = decorators.length - 1; i >= 0; i--) if (d = decorators[i]) r = (c < 3 ? d(r) : c > 3 ? d(target, key, r) : d(target, key)) || r;
+    return c > 3 && r && Object.defineProperty(target, key, r), r;
+};
+import { RegisterClass } from '@memberjunction/global';
+import { BaseAgent } from '@memberjunction/ai-agents';
+import { BaseMarketingAgent } from './BaseMarketingAgent.js';
+/**
+ * Marketing Creative Agent — driver class (D-29).
+ *
+ * The Programs agent's SUB-AGENT for the picture in an ad: it decides what the image shows and which candidate
+ * fits the brand, through `Generate Ad Image` (generate, or adapt a supplied picture). It is a child of the Programs
+ * agent in metadata (`ParentID`), so MJ discovers it from the relationship and the parent delegates when a draft
+ * needs an image. The base class gives it what every marketing agent has: the brand from the payload or the
+ * caller's grants, and the payload bootstrap. Nothing else is special about it — the judgment is in its prompt.
+ */
+/** The agent row's Name — what the Programs agent's delegation names and its sub-agent hook matches on (KI-134). */
+export const CREATIVE_AGENT_NAME = 'Marketing Creative Agent';
+let MarketingCreativeAgent = class MarketingCreativeAgent extends BaseMarketingAgent {
+};
+MarketingCreativeAgent = __decorate([
+    RegisterClass(BaseAgent, 'MarketingCreativeAgent')
+], MarketingCreativeAgent);
+export { MarketingCreativeAgent };
+export function LoadMarketingCreativeAgent() { }
+//# sourceMappingURL=MarketingCreativeAgent.js.map

package/dist/agents/MarketingCreativeAgent.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"MarketingCreativeAgent.js","sourceRoot":"","sources":["../../src/agents/MarketingCreativeAgent.ts"],"names":[],"mappings":";;;;;;AAAA,OAAO,EAAE,aAAa,EAAE,MAAM,wBAAwB,CAAC;AACvD,OAAO,EAAE,SAAS,EAAE,MAAM,2BAA2B,CAAC;AACtD,OAAO,EAAE,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAE7D;;;;;;;;GAQG;AACH,oHAAoH;AACpH,MAAM,CAAC,MAAM,mBAAmB,GAAG,0BAA0B,CAAC;AAGvD,IAAM,sBAAsB,GAA5B,MAAM,sBAAuB,SAAQ,kBAAkB;CAC7D,CAAA;AADY,sBAAsB;IADlC,aAAa,CAAC,SAAS,EAAE,wBAAwB,CAAC;GACtC,sBAAsB,CAClC;;AAED,MAAM,UAAU,0BAA0B,KAAI,CAAC"}

package/dist/agents/MarketingExperimentationAgent.d.ts

@@ -1,5 +1,25 @@
 import type { AgentConfiguration, AIPromptParams, ExecuteAgentParams, BaseAgentNextStep, MJAIAgentRunEntityExtended, MJAIAgentRunStepEntityExtended } from '@memberjunction/ai-core-plus';
 import { BaseMarketingAgent } from './BaseMarketingAgent.js';
+/**
+ * One proposal a run produced, as stamped on the payload for the proposal card.
+ * `draft` is set when nothing was saved (the in-app Assistant); otherwise `programId` names the row.
+ */
+interface ProposalRef {
+    programId: string | null;
+    code: string | null;
+    name: string | null;
+    approvalRequestId: string | null;
+    draft: {
+        /** Identifies the draft so the user's decision can be recorded against it. */
+        key: string;
+        /** The exact `Propose Program` inputs that passed validation — re-submitted on Approve. */
+        inputs: Record<string, unknown>;
+        programTier: string | null;
+        programType: string | null;
+        proposalConfidence: string | null;
+        requiresOverride: boolean;
+    } | null;
+}
 /**
  * Marketing Programs Agent — driver class.
  *
@@ -90,6 +110,17 @@ export declare class MarketingExperimentationAgent extends BaseMarketingAgent {
      * the gate; the entity runs it on save) — this is the cheaper, earlier door, not the only one.
      */
     protected validateActionsNextStep<P>(params: ExecuteAgentParams, nextStep: BaseAgentNextStep<P>, currentPayload: P, agentRun: MJAIAgentRunEntityExtended, currentStep: MJAIAgentRunStepEntityExtended): Promise<BaseAgentNextStep<P>>;
+    /**
+     * A Creative delegation never ends the parent's run (KI-134) — MJ's `validateSubAgentNextStep` hook, the
+     * sub-agent twin of the action hook above. On the adapt follow-up ("use the Ascend cover, make it square") the
+     * model delegated with `terminateAfter: true`; the framework honoured it, so the run ended the moment the
+     * Creative agent returned: the square image was generated and hosted, `payload.creative` carried it, but the
+     * founder saw a bare "completed" with no message and `creativeImageUrl` never changed. The parent is the only
+     * one who can merge `creative` into the levers and answer, so the delegation is forced to hand control back.
+     */
+    protected validateSubAgentNextStep<P>(params: ExecuteAgentParams, nextStep: BaseAgentNextStep<P>, currentPayload: P, agentRun: MJAIAgentRunEntityExtended, currentStep: MJAIAgentRunStepEntityExtended): Promise<BaseAgentNextStep<P>>;
+    /** The provenance verdict for a proposal's creativeImageUrl, or null when there is nothing to bounce. */
+    private creativeImageBounce;
     /**
      * Decides, in code, whether this run may SAVE a proposal or only DRAFT one.
      *
@@ -134,4 +165,12 @@ export declare class MarketingExperimentationAgent extends BaseMarketingAgent {
 }
 /** Anti-tree-shaking loader — the @RegisterClass above is a side effect. */
 export declare function LoadMarketingExperimentationAgent(): void;
+/**
+ * One card per program (KI-124): the model sometimes calls Propose Program twice in a run for the same program (a
+ * revision after the user's follow-up, or a plain repeat — CP-Meta drafted twice three seconds apart), and the card
+ * showed "(+1 more)" with two identical drafts. The LATER call is the proposal: drafts collapse by name, committed
+ * programs by id. Steps arrive in StepNumber order, so last wins.
+ */
+export declare function dedupeProposals(proposals: ProposalRef[]): ProposalRef[];
+export {};
 //# sourceMappingURL=MarketingExperimentationAgent.d.ts.map

package/dist/agents/MarketingExperimentationAgent.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"MarketingExperimentationAgent.d.ts","sourceRoot":"","sources":["../../src/agents/MarketingExperimentationAgent.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,kBAAkB,EAAE,cAAc,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,0BAA0B,EAAE,8BAA8B,EAAE,MAAM,8BAA8B,CAAC;AAoB1L,OAAO,EAAE,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAmC7D;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,qBACa,6BAA8B,SAAQ,kBAAkB;IACjE;;;;;;OAMG;IACH,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,kBAAkB,CAA4B;IAEtE,4EAA4E;IAC5E,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,WAAW,CAA0B;IAE7D;;;;;;;;;;;;OAYG;cACsB,mBAAmB,CAAC,CAAC,EAC1C,MAAM,EAAE,kBAAkB,EAC1B,OAAO,EAAE,CAAC,EACV,MAAM,EAAE,kBAAkB,GAC3B,OAAO,CAAC,cAAc,CAAC;IA8C1B;;;;OAIG;YACW,yBAAyB;IAuCvC;;;;;;;;;;;OAWG;IACH,OAAO,CAAC,cAAc;IAkBtB;;;;;;;;;;OAUG;cACsB,uBAAuB,CAAC,CAAC,EAC9C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAahC,0FAA0F;cACjE,oBAAoB,CAAC,CAAC,EAC3C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAMhC;;;;;;OAMG;cACsB,uBAAuB,CAAC,CAAC,EAC9C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAiDhC;;;;;;;;;;;OAWG;cACsB,yBAAyB,CAAC,CAAC,GAAG,OAAO,EAAE,MAAM,EAAE,kBAAkB,CAAC,OAAO,EAAE,CAAC,CAAC,GAAG,OAAO,CAAC,IAAI,CAAC;IAMtH;;;;;;;;;;;OAWG;YACW,eAAe;IAkC7B,mGAAmG;IACnG,OAAO,CAAC,gBAAgB;IA0CxB;;;;;OAKG;YACW,2BAA2B;IA4HzC;;;;OAIG;IACH,OAAO,CAAC,iBAAiB;CAc5B;AAED,4EAA4E;AAC5E,wBAAgB,iCAAiC,IAAI,IAAI,CAAG"}
+{"version":3,"file":"MarketingExperimentationAgent.d.ts","sourceRoot":"","sources":["../../src/agents/MarketingExperimentationAgent.ts"],"names":[],"mappings":"AAEA,OAAO,KAAK,EAAE,kBAAkB,EAAE,cAAc,EAAE,kBAAkB,EAAE,iBAAiB,EAAE,0BAA0B,EAAE,8BAA8B,EAAE,MAAM,8BAA8B,CAAC;AAqB1L,OAAO,EAAE,kBAAkB,EAAE,MAAM,yBAAyB,CAAC;AAG7D;;;GAGG;AACH,UAAU,WAAW;IACjB,SAAS,EAAE,MAAM,GAAG,IAAI,CAAC;IACzB,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,IAAI,EAAE,MAAM,GAAG,IAAI,CAAC;IACpB,iBAAiB,EAAE,MAAM,GAAG,IAAI,CAAC;IACjC,KAAK,EAAE;QACH,8EAA8E;QAC9E,GAAG,EAAE,MAAM,CAAC;QACZ,2FAA2F;QAC3F,MAAM,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;QAChC,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;QAC3B,WAAW,EAAE,MAAM,GAAG,IAAI,CAAC;QAC3B,kBAAkB,EAAE,MAAM,GAAG,IAAI,CAAC;QAClC,gBAAgB,EAAE,OAAO,CAAC;KAC7B,GAAG,IAAI,CAAC;CACZ;AAcD;;;;;;;;;;;;;;;;;;;;;;;GAuBG;AACH,qBACa,6BAA8B,SAAQ,kBAAkB;IACjE;;;;;;OAMG;IACH,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,kBAAkB,CAA4B;IAEtE,4EAA4E;IAC5E,OAAO,CAAC,MAAM,CAAC,QAAQ,CAAC,WAAW,CAA0B;IAE7D;;;;;;;;;;;;OAYG;cACsB,mBAAmB,CAAC,CAAC,EAC1C,MAAM,EAAE,kBAAkB,EAC1B,OAAO,EAAE,CAAC,EACV,MAAM,EAAE,kBAAkB,GAC3B,OAAO,CAAC,cAAc,CAAC;IA8C1B;;;;OAIG;YACW,yBAAyB;IAuCvC;;;;;;;;;;;OAWG;IACH,OAAO,CAAC,cAAc;IAkBtB;;;;;;;;;;OAUG;cACsB,uBAAuB,CAAC,CAAC,EAC9C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAahC,0FAA0F;cACjE,oBAAoB,CAAC,CAAC,EAC3C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAMhC;;;;;;OAMG;cACsB,uBAAuB,CAAC,CAAC,EAC9C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAwDhC;;;;;;;OAOG;cACsB,wBAAwB,CAAC,CAAC,EAC/C,MAAM,EAAE,kBAAkB,EAC1B,QAAQ,EAAE,iBAAiB,CAAC,CAAC,CAAC,EAC9B,cAAc,EAAE,CAAC,EACjB,QAAQ,EAAE,0BAA0B,EACpC,WAAW,EAAE,8BAA8B,GAC5C,OAAO,CAAC,iBAAiB,CAAC,CAAC,CAAC,CAAC;IAYhC,yGAAyG;IACzG,OAAO,CAAC,mBAAmB;IAY3B;;;;;;;;;;;OAWG;cACsB,yBAAyB,CAAC,CAAC,GAAG,OAAO,EAAE,MAAM,EAAE,kBAAkB,CAAC,OAAO,EAAE,CAAC,CAAC,GAAG,OAAO,CAAC,IAAI,CAAC;IAMtH;;;;;;;;;;;OAWG;YACW,eAAe;IAkC7B,mGAAmG;IACnG,OAAO,CAAC,gBAAgB;IA+CxB;;;;;OAKG;YACW,2BAA2B;IA4HzC;;;;OAIG;IACH,OAAO,CAAC,iBAAiB;CAc5B;AAED,4EAA4E;AAC5E,wBAAgB,iCAAiC,IAAI,IAAI,CAAG;AAG5D;;;;;GAKG;AACH,wBAAgB,eAAe,CAAC,SAAS,EAAE,WAAW,EAAE,GAAG,WAAW,EAAE,CAQvE"}

package/dist/agents/MarketingExperimentationAgent.js

@@ -8,8 +8,9 @@ var MarketingExperimentationAgent_1;
 import { EscapeSQLString, RegisterClass } from '@memberjunction/global';
 import { BaseAgent } from '@memberjunction/ai-agents';
 import { LogStatus, LogError, Metadata, RunView } from '@memberjunction/core';
-import { blockingLearningErrors, blockingErrors, driverProposalIssues, ProgramMetadataEngine, decidedProgramFromTaskInput, parseTaskInput, enrichFinding, loadProgramKnowledge, renderKnowledgeBase, toMarketingEntityName, validateLearning, } from '@mj-biz-apps/marketing-core';
+import { blockingLearningErrors, blockingErrors, driverProposalIssues, ProgramMetadataEngine, decidedProgramFromTaskInput, parseTaskInput, enrichFinding, loadProgramKnowledge, renderKnowledgeBase, toMarketingEntityName, validateLearning, creativeImageProvenance, } from '@mj-biz-apps/marketing-core';
 import { BaseMarketingAgent } from './BaseMarketingAgent.js';
+import { CREATIVE_AGENT_NAME } from './MarketingCreativeAgent.js';
 /** Below this, a request is too short to rank a corpus against. */
 const MIN_RETRIEVAL_QUERY_CHARS = 25;
 /**
@@ -255,6 +256,13 @@ let MarketingExperimentationAgent = class MarketingExperimentationAgent extends
                     continue; // Propose Program reports an unresolved type itself
                 const levers = p['TacticConfigJSON'];
                 const tacticConfigJSON = typeof levers === 'string' ? levers : levers != null ? JSON.stringify(levers) : null;
+                // KI-131: an ad image URL must be one this run RECEIVED — the Creative Agent's payload block or the
+                // founder's words. The first live run invented one; the prompt's "never invent" is advice, this is the rule.
+                const imageBounce = this.creativeImageBounce(tacticConfigJSON, bag, params);
+                if (imageBounce) {
+                    LogStatus(`MarketingExperimentationAgent: Propose Program call bounced — creativeImageUrl provenance`);
+                    return { step: 'Retry', terminate: false, errorMessage: imageBounce };
+                }
                 const issues = blockingErrors(await driverProposalIssues({
                     Name: str('Name'), Hypothesis: str('Hypothesis'), MetricName: str('MetricName'), MetricBaseline: num('MetricBaseline'),
                     Budget: num('Budget'), SegmentCuts: str('SegmentCuts'), ProgramTypeID: typeRow.ID, TacticConfigJSON: tacticConfigJSON,
@@ -276,6 +284,45 @@ let MarketingExperimentationAgent = class MarketingExperimentationAgent extends
         }
         return base;
     }
+    /**
+     * A Creative delegation never ends the parent's run (KI-134) — MJ's `validateSubAgentNextStep` hook, the
+     * sub-agent twin of the action hook above. On the adapt follow-up ("use the Ascend cover, make it square") the
+     * model delegated with `terminateAfter: true`; the framework honoured it, so the run ended the moment the
+     * Creative agent returned: the square image was generated and hosted, `payload.creative` carried it, but the
+     * founder saw a bare "completed" with no message and `creativeImageUrl` never changed. The parent is the only
+     * one who can merge `creative` into the levers and answer, so the delegation is forced to hand control back.
+     */
+    async validateSubAgentNextStep(params, nextStep, currentPayload, agentRun, currentStep) {
+        const base = await super.validateSubAgentNextStep(params, nextStep, currentPayload, agentRun, currentStep);
+        if (base.step !== nextStep.step)
+            return base; // the framework already refused it
+        for (const req of this.getRequestedSubAgents(base)) {
+            if (req.name.trim().toLowerCase() === CREATIVE_AGENT_NAME.toLowerCase() && req.terminateAfter) {
+                LogStatus(`MarketingExperimentationAgent: ${CREATIVE_AGENT_NAME} delegation asked to terminate the run — overridden, the parent must merge the creative and answer (KI-134)`);
+                req.terminateAfter = false;
+            }
+        }
+        return base;
+    }
+    /** The provenance verdict for a proposal's creativeImageUrl, or null when there is nothing to bounce. */
+    creativeImageBounce(tacticConfigJSON, bag, params) {
+        if (!tacticConfigJSON)
+            return null;
+        let url;
+        try {
+            url = JSON.parse(tacticConfigJSON)['creativeImageUrl'];
+        }
+        catch {
+            return null;
+        } // the parser reports bad JSON
+        if (typeof url !== 'string' || !url.trim())
+            return null;
+        const founderTexts = (params.conversationMessages ?? [])
+            .filter(m => m.role === 'user')
+            .map(m => typeof m.content === 'string' ? m.content : m.content.map(b => (b.type === 'text' ? b.content : '')).join('\n'));
+        const verdict = creativeImageProvenance(url.trim(), { payloadCreative: bag['creative'], founderTexts });
+        return verdict.ok ? null : verdict.message;
+    }
     /**
      * Decides, in code, whether this run may SAVE a proposal or only DRAFT one.
      *
@@ -319,9 +366,9 @@ let MarketingExperimentationAgent = class MarketingExperimentationAgent extends
                 LogError(`MarketingExperimentationAgent: could not read this run's proposal steps — ${res.ErrorMessage}`);
                 return;
             }
-            const proposals = (res.Results ?? [])
+            const proposals = dedupeProposals((res.Results ?? [])
                 .map(step => this.proposalFromStep(step.OutputData))
-                .filter((p) => p !== null);
+                .filter((p) => p !== null));
             if (proposals.length === 0)
                 return;
             bag['proposals'] = proposals;
@@ -358,6 +405,14 @@ let MarketingExperimentationAgent = class MarketingExperimentationAgent extends
             if (!draftKey)
                 return null;
             delete inputs['DraftOnly']; // the re-submit on Approve must COMMIT
+            // D-32: budgets are computed by Propose; the card shows the computed figures, not what the model typed.
+            if (outputs['ComputedBudget'] !== undefined)
+                inputs['Budget'] = outputs['ComputedBudget'];
+            if (outputs['ComputedBudgetPerSprint'] !== undefined)
+                inputs['BudgetPerSprint'] = outputs['ComputedBudgetPerSprint'];
+            // D-34: the levers with the platform's names cached beside the ids — what the card and the commit carry.
+            if (typeof outputs['ResolvedTacticConfigJSON'] === 'string' && outputs['ResolvedTacticConfigJSON'])
+                inputs['TacticConfigJSON'] = outputs['ResolvedTacticConfigJSON'];
             return {
                 programId: null, code: null, name: text(inputs['Name']), approvalRequestId: null,
                 draft: {
@@ -524,4 +579,19 @@ MarketingExperimentationAgent = MarketingExperimentationAgent_1 = __decorate([
 export { MarketingExperimentationAgent };
 /** Anti-tree-shaking loader — the @RegisterClass above is a side effect. */
 export function LoadMarketingExperimentationAgent() { }
+/**
+ * One card per program (KI-124): the model sometimes calls Propose Program twice in a run for the same program (a
+ * revision after the user's follow-up, or a plain repeat — CP-Meta drafted twice three seconds apart), and the card
+ * showed "(+1 more)" with two identical drafts. The LATER call is the proposal: drafts collapse by name, committed
+ * programs by id. Steps arrive in StepNumber order, so last wins.
+ */
+export function dedupeProposals(proposals) {
+    const byKey = new Map();
+    for (const p of proposals) {
+        const key = p.programId ? `id:${p.programId.toLowerCase()}` : `name:${(p.name ?? '').trim().toLowerCase()}`;
+        byKey.delete(key);
+        byKey.set(key, p);
+    }
+    return [...byKey.values()];
+}
 //# sourceMappingURL=MarketingExperimentationAgent.js.map