@mittwald/flow-codemods 1.1.28 → 1.1.29

package/dist/migrations/renamed-css-export/transform.js

@@ -0,0 +1,59 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const oldPath = "@mittwald/flow-react-components/styles";
+const newPath = "@mittwald/flow-react-components/all.css";
+/**
+ * Rewrites the module specifier `@mittwald/flow-react-components/styles` to
+ * `@mittwald/flow-react-components/all.css` (alpha.292).
+ *
+ * The same shape as `password-tools-subpath-renamed`: one exact specifier, in
+ * every form that names a module — `import`, `import type`, `export … from`, a
+ * side-effect import, `import()` and `require()`. In practice it is nearly
+ * always the side-effect form (`import "…/styles"`), which is why that case is
+ * the one the fixtures lead with.
+ *
+ * Exact match, not a prefix: `./styles` was a single export with nothing
+ * underneath it, so there is no deeper path to rewrite and no risk of touching
+ * an unrelated `styles` of someone else's.
+ *
+ * What this cannot reach is an `@import` in a `.css` or `.scss` file —
+ * jscodeshift only walks the JavaScript and TypeScript extensions. `apply` says
+ * so.
+ */
+const renamedCssExportTransform = (fileInfo, { j }) => {
+    const root = j(fileInfo.source, { parser: "tsx" });
+    let changed = false;
+    const rewrite = (node) => {
+        if (node.value === oldPath) {
+            node.value = newPath;
+            changed = true;
+        }
+    };
+    // import … from "…", import "…"
+    root.find(j.ImportDeclaration).forEach((path) => rewrite(path.node.source));
+    // export … from "…", export * from "…"
+    root
+        .find(j.ExportNamedDeclaration)
+        .forEach((path) => path.node.source && rewrite(path.node.source));
+    root
+        .find(j.ExportAllDeclaration)
+        .forEach((path) => rewrite(path.node.source));
+    // import("…") and require("…")
+    root
+        .find(j.CallExpression)
+        .filter((path) => {
+        const callee = path.node.callee;
+        return (callee.type === "Import" ||
+            (callee.type === "Identifier" && callee.name === "require"));
+    })
+        .forEach((path) => {
+        const [argument] = path.node.arguments;
+        if (argument &&
+            (argument.type === "StringLiteral" || argument.type === "Literal")) {
+            rewrite(argument);
+        }
+    });
+    // Returning the source untouched keeps this file out of the "changed" count.
+    return changed ? root.toSource() : fileInfo.source;
+};
+exports.default = renamedCssExportTransform;

package/dist/migrations/table-column-width-props/transform.js

@@ -0,0 +1,131 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+/**
+ * Drops `maxWidth` from `TableColumn`, and drops `width`/`minWidth` where they
+ * were `null` (alpha.956).
+ *
+ * Two changes with different decidability, which is why the transform covers
+ * both but not equally:
+ *
+ * - **`maxWidth` always goes.** The prop was removed from the type, so an
+ *   explicit `maxWidth` attribute is wrong whatever its value is —
+ *   `maxWidth={400}` and `maxWidth={computed}` alike. Removing it does change
+ *   the rendered column (there is no maximum any more); that is the migration,
+ *   not a side effect.
+ * - **`width` and `minWidth` only go when the source says `null`.** The type
+ *   dropped `null`, and `null` meant "no explicit width", which is what
+ *   omitting the prop means now. Only the literal is decidable:
+ *   `width={maybeNull}` could be anything at runtime and is left alone, the way
+ *   `accent-box-color-to-background-color` leaves `color={expression}`.
+ *
+ * The scope is the same as its neighbours': only JSX elements that resolve to
+ * `TableColumn` — imported named, aliased, or through a namespace, from
+ * `@mittwald/flow-react-components` or
+ * `@mittwald/flow-remote-react-components`, including their subpath entries.
+ *
+ * A spread (`<TableColumn {...props} />`) carrying `maxWidth` is invisible
+ * here. The explicit attributes beside it are still handled; `apply` names the
+ * gap.
+ */
+const tableColumnWidthPropsTransform = (fileInfo, { j }) => {
+    const flowPackages = [
+        "@mittwald/flow-react-components",
+        "@mittwald/flow-remote-react-components",
+    ];
+    const affectedComponents = new Set(["TableColumn"]);
+    /** Removed from the type — an explicit attribute is wrong at any value. */
+    const removedProps = new Set(["maxWidth"]);
+    /** Retyped without `null` — remove only where the source literally says so. */
+    const nullableProps = new Set(["width", "minWidth"]);
+    const isFlowImport = (source) => flowPackages.some((pkg) => source === pkg || source.startsWith(`${pkg}/`));
+    /**
+     * Whether this JSX attribute value is the literal `null`.
+     *
+     * Both spellings, because which one appears depends on the parser: babel
+     * emits `NullLiteral`, esprima-style parsers a `Literal` whose `value` is
+     * `null`. Anything else — an identifier, a call, a ternary — is not decidable
+     * from the source and stays.
+     */
+    const isNullLiteral = (value) => {
+        if (!value || typeof value !== "object" || !("type" in value)) {
+            return false;
+        }
+        const container = value;
+        if (container.type !== "JSXExpressionContainer") {
+            return false;
+        }
+        const expression = container.expression;
+        if (!expression ||
+            typeof expression !== "object" ||
+            !("type" in expression)) {
+            return false;
+        }
+        const typed = expression;
+        return (typed.type === "NullLiteral" ||
+            (typed.type === "Literal" && typed.value === null));
+    };
+    const root = j(fileInfo.source, { parser: "tsx" });
+    // Local JSX identifier -> canonical component name (resolves `as` aliases).
+    const localToComponent = new Map();
+    // Local names of `import * as Flow` namespace imports from a Flow package.
+    const flowNamespaces = new Set();
+    root
+        .find(j.ImportDeclaration)
+        .filter((path) => isFlowImport(String(path.node.source.value)))
+        .forEach((path) => {
+        for (const specifier of path.node.specifiers ?? []) {
+            if (specifier.type === "ImportSpecifier" &&
+                specifier.imported.type === "Identifier" &&
+                affectedComponents.has(specifier.imported.name)) {
+                localToComponent.set(String(specifier.local?.name ?? specifier.imported.name), String(specifier.imported.name));
+            }
+            else if (specifier.type === "ImportNamespaceSpecifier" &&
+                specifier.local) {
+                flowNamespaces.add(String(specifier.local.name));
+            }
+        }
+    });
+    if (localToComponent.size === 0 && flowNamespaces.size === 0) {
+        return fileInfo.source;
+    }
+    let changed = false;
+    root.find(j.JSXOpeningElement).forEach((path) => {
+        const name = path.node.name;
+        let isAffected = false;
+        if (name.type === "JSXIdentifier") {
+            isAffected = localToComponent.has(name.name);
+        }
+        else if (name.type === "JSXMemberExpression" &&
+            name.object.type === "JSXIdentifier" &&
+            name.property.type === "JSXIdentifier") {
+            isAffected =
+                flowNamespaces.has(name.object.name) &&
+                    affectedComponents.has(name.property.name);
+        }
+        if (!isAffected) {
+            return;
+        }
+        const attributes = path.node.attributes ?? [];
+        const kept = attributes.filter((attribute) => {
+            if (attribute.type !== "JSXAttribute" ||
+                attribute.name.type !== "JSXIdentifier") {
+                return true;
+            }
+            const attributeName = attribute.name.name;
+            if (removedProps.has(attributeName)) {
+                return false;
+            }
+            if (nullableProps.has(attributeName) && isNullLiteral(attribute.value)) {
+                return false;
+            }
+            return true;
+        });
+        if (kept.length !== attributes.length) {
+            path.node.attributes = kept;
+            changed = true;
+        }
+    });
+    // Returning the source untouched keeps this file out of the "changed" count.
+    return changed ? root.toSource() : fileInfo.source;
+};
+exports.default = tableColumnWidthPropsTransform;

package/dist/migrations.generated.js

@@ -98,9 +98,9 @@ export const migrations = [
         since: "0.2.0-alpha.956",
         title: "TableColumn: `maxWidth` removed, `width` and `minWidth` retyped",
         kind: "migration",
-        action: "manual",
+        action: "codemod",
         remotePackage: true,
-        apply: "Remove `maxWidth` from every `TableColumn`. Where `width` or `minWidth` was `null`, omit the prop instead — the type no longer accepts `null`, only `number | string`.",
+        apply: "Remove `maxWidth` from every `TableColumn`. Where `width` or `minWidth` was `null`, omit the prop instead — the type no longer accepts `null`, only `number | string`. A codemod does both for the cases it can decide from the source. Two it declines: a `width`/`minWidth` whose value is an expression (`width={maybeNull}`), and a spread that might carry `maxWidth` (`<TableColumn {...props} />`). Check those by hand.",
     },
     {
         id: "table-render-prop-removed",
@@ -233,8 +233,8 @@ export const migrations = [
         since: "0.1.0-alpha.292",
         title: "Renamed CSS export",
         kind: "migration",
-        action: "manual",
+        action: "codemod",
         remotePackage: false,
-        apply: "Replace the import `@mittwald/flow-react-components/styles` with `@mittwald/flow-react-components/all.css`.",
+        apply: "Replace the import `@mittwald/flow-react-components/styles` with `@mittwald/flow-react-components/all.css`. A codemod does this for JavaScript and TypeScript files. An `@import` of the old path inside a `.css` or `.scss` file is not covered — search for it by hand.",
     },
 ];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mittwald/flow-codemods",
-  "version": "1.1.28",
+  "version": "1.1.29",
   "type": "module",
   "description": "Codemods and an upgrade CLI for consumers of Flow, mittwald's design system",
   "homepage": "https://flow.mittwald.de",
@@ -37,5 +37,5 @@
     "vitest": "^4.1.11",
     "yaml": "^2.8.1"
   },
-  "gitHead": "620d70dc1c876b78cd6a7e693f79ce315088f757"
+  "gitHead": "9c65be4254837ed7a23e6ef79e07ca6717938d19"
 }