@mitre/inspec-objects 0.0.14 → 0.0.17

package/lib/index.d.ts

@@ -1,6 +1,7 @@
-export * from './objects/control';
-export * from './objects/profile';
-export * from './parsers/json';
-export * from './parsers/xccdf';
-export * from './utilities/diff';
-export * from './utilities/update';
+export * from "./objects/control";
+export * from "./objects/profile";
+export * from "./parsers/json";
+export * from "./parsers/oval";
+export * from "./parsers/xccdf";
+export * from "./utilities/diff";
+export * from "./utilities/update";

package/lib/index.js

@@ -4,6 +4,7 @@ const tslib_1 = require("tslib");
 tslib_1.__exportStar(require("./objects/control"), exports);
 tslib_1.__exportStar(require("./objects/profile"), exports);
 tslib_1.__exportStar(require("./parsers/json"), exports);
+tslib_1.__exportStar(require("./parsers/oval"), exports);
 tslib_1.__exportStar(require("./parsers/xccdf"), exports);
 tslib_1.__exportStar(require("./utilities/diff"), exports);
 tslib_1.__exportStar(require("./utilities/update"), exports);

package/lib/objects/control.d.ts

@@ -3,16 +3,16 @@ export declare function objectifyDescriptions(descs: ExecJSON.ControlDescription
     [key: string]: string | undefined;
 } | null | undefined): {
     [key: string]: string | undefined;
-} | null | undefined;
+};
 export default class Control {
-    id?: string | null;
+    id: string;
     title?: string | null;
     code?: string | null;
     describe?: string | null;
     desc?: string | null;
-    descs?: {
+    descs: {
         [key: string]: string | undefined;
-    } | null;
+    };
     impact?: number;
     ref?: string;
     refs?: (string | {

package/lib/objects/control.js

@@ -13,7 +13,7 @@ function objectifyDescriptions(descs) {
         });
         return descriptions;
     }
-    return descs;
+    return descs || {};
 }
 exports.objectifyDescriptions = objectifyDescriptions;
 class Control {
@@ -81,7 +81,7 @@ class Control {
             if (value) {
                 if (typeof value === "object") {
                     if (Array.isArray(value) && typeof value[0] === "string") {
-                        result += `  tag ${tag}: ${JSON.stringify(value)}\n`;
+                        result += `  tag ${tag}: ${JSON.stringify(value).split('","').join('", "')}\n`;
                     }
                     else {
                         // Convert JSON Object to Ruby Hash

package/lib/parsers/json.js

@@ -45,7 +45,7 @@ function processProfileJSON(profileInput) {
         version: profileInput.data.version,
     });
     profileInput.data.controls.forEach((control) => {
-        profile.controls.push(new control_1.default({
+        const newControl = new control_1.default({
             id: control.id,
             title: control.title,
             desc: control.desc,
@@ -53,7 +53,17 @@ function processProfileJSON(profileInput) {
             code: control.code,
             tags: control.tags,
             descs: (0, control_1.objectifyDescriptions)(control.descriptions),
-        }));
+        });
+        // Migrate check and fix text from tags to descriptions
+        if (newControl.tags.check && !newControl.descs.check) {
+            lodash_1.default.set(newControl.descs, 'check', control.tags.check);
+            lodash_1.default.set(newControl.tags, 'check', undefined);
+        }
+        if (newControl.tags.fix && !newControl.descs.fix) {
+            lodash_1.default.set(newControl.descs, 'fix', control.tags.fix);
+            lodash_1.default.set(newControl.tags, 'fix', undefined);
+        }
+        profile.controls.push(newControl);
     });
     return profile;
 }

package/lib/parsers/oval.d.ts

@@ -1,2 +1,2 @@
 import { OvalDefinitionValue } from '../types/oval';
-export declare function processOVAL(oval: string): Record<string, OvalDefinitionValue>;
+export declare function processOVAL(oval?: string): Record<string, OvalDefinitionValue> | undefined;

package/lib/parsers/oval.js

@@ -3,6 +3,9 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.processOVAL = void 0;
 const xccdf_1 = require("../utilities/xccdf");
 function processOVAL(oval) {
+    if (!oval) {
+        return undefined;
+    }
     const parsed = (0, xccdf_1.convertEncodedXmlIntoJson)(oval);
     const extractedDefinitions = {};
     for (const ovalDefinitions of parsed.oval_definitions) {

package/lib/parsers/xccdf.js

@@ -62,14 +62,21 @@ function processXCCDF(xml, removeNewlines = false, useRuleId, ovalDefinitions) {
                 control.id = rule.version;
                 break;
             case 'cis':
-                // 
-                control.id = 'CIS-PLACEHOLDER';
+                const controlIdRegex = /\d(\d?)(\d?)(\d?)(.\d(\d?)(\d?)(\d?))?(.\d(\d?)(\d?)(\d?))?(.\d(\d?)(\d?)(\d?))?(.\d(\d?)(\d?)(\d?))?/g;
+                const controlIdMatch = controlIdRegex.exec(rule['@_id']);
+                if (controlIdMatch) {
+                    control.id = controlIdMatch[0];
+                }
+                else {
+                    throw new Error(`Could not parse control ID from rule ID: ${rule['@_id']}. Expecting format: 'xccdf_org.cisecurity.benchmarks_rule_1.1.11_Rule_title_summary`);
+                }
                 break;
             default:
                 throw new Error('useRuleId must be one of "group", "rule", or "version"');
         }
         control.title = (0, xccdf_1.removeXMLSpecialCharacters)(rule['@_severity'] ? ensureDecodedXMLStringValue(rule.title) : `[[[MISSING SEVERITY FROM STIG]]] ${ensureDecodedXMLStringValue(rule.title)}`);
-        control.desc = (0, xccdf_1.removeXMLSpecialCharacters)(typeof extractedDescription === 'string' ? extractedDescription : ((_a = extractedDescription.VulnDiscussion) === null || _a === void 0 ? void 0 : _a.split('Satisfies: ')[0]) || 'Missing Description');
+        const descriptionText = (typeof extractedDescription === 'object' && !Array.isArray(extractedDescription)) ? ((_a = extractedDescription.VulnDiscussion) === null || _a === void 0 ? void 0 : _a.split('Satisfies: ')[0]) || 'Missing Description' : '';
+        control.desc = (0, xccdf_1.removeXMLSpecialCharacters)(descriptionText);
         control.impact = (0, xccdf_1.severityStringToImpact)(rule['@_severity'] || 'medium', rule.group['@_id']);
         if (!control.descs || Array.isArray(control.descs)) {
             control.descs = {};
@@ -77,6 +84,7 @@ function processXCCDF(xml, removeNewlines = false, useRuleId, ovalDefinitions) {
         if (rule.check) {
             if (rule.check.some((ruleValue) => 'check-content' in ruleValue)) {
                 control.descs.check = (0, xccdf_1.removeXMLSpecialCharacters)(rule.check ? rule.check[0]['check-content'] : 'Missing description');
+                control.tags.check_id = rule.check[0]['@_system'];
             }
             else if (rule.check.some((ruleValue) => 'check-content-ref' in ruleValue) && ovalDefinitions) {
                 let referenceID = null;
@@ -97,7 +105,25 @@ function processXCCDF(xml, removeNewlines = false, useRuleId, ovalDefinitions) {
                 }
             }
         }
-        control.descs.fix = (0, xccdf_1.removeXMLSpecialCharacters)(rule.fixtext ? rule.fixtext[0]['#text'] : (rule.fix ? rule.fix[0]['#text'] || 'Missing fix text' : 'Missing fix text'));
+        if (lodash_1.default.get(rule.fixtext, '[0]["#text"]')) {
+            control.descs.fix = (0, xccdf_1.removeXMLSpecialCharacters)(rule.fixtext[0]['#text']);
+        }
+        else if (typeof rule.fixtext === 'string') {
+            control.descs.fix = (0, xccdf_1.removeXMLSpecialCharacters)(rule.fixtext);
+        }
+        else if (typeof rule.fixtext === 'object') {
+            if (Array.isArray(rule.fixtext)) {
+                control.descs.fix = (0, xccdf_1.removeXMLSpecialCharacters)(JSON.stringify(rule.fixtext));
+            }
+        }
+        else if (typeof rule.fixtext === 'undefined') {
+            if (rule.fix && rule.fix[0]) {
+                control.descs.fix = (0, xccdf_1.removeXMLSpecialCharacters)(rule.fix[0]['#text'] || 'Missing fix text');
+            }
+        }
+        else {
+            control.descs.fix = 'Missing fix text';
+        }
         control.tags.severity = (0, xccdf_1.impactNumberToSeverityString)((0, xccdf_1.severityStringToImpact)(rule['@_severity'] || 'critical', control.id || 'Unknown'));
         control.tags.gid = rule.group['@_id'],
             control.tags.rid = rule['@_id'];
@@ -161,11 +187,6 @@ function processXCCDF(xml, removeNewlines = false, useRuleId, ovalDefinitions) {
                     }
                     (_c = control.tags.nist) === null || _c === void 0 ? void 0 : _c.push(identifier['#text']);
                 }
-                else {
-                    // console.log('Alert')
-                    // console.log(identifier['@_system'])
-                    // console.log(identifier['#text'])
-                }
             });
         }
         (_c = rule.reference) === null || _c === void 0 ? void 0 : _c.forEach((reference) => {

package/lib/resources/automatticUpdateTemplate.json

@@ -1,3 +1,3 @@
 {
-    "data": "## Automattic Update: {{fromVersion}} -> {{toVersion}}\n\n### New Controls:\n{{#addedControls}}\n+   {{id}} - {{title}}\n{{/addedControls}}\n\n### Updated Check/Fixes:\n#### Checks:\n\n{{#checks}}\n{{id}}:\n```\n{{{check}}}\n```\n\n\n{{/checks}}"
+    "data": "## Automatic Update: {{fromVersion}} -> {{toVersion}}\n\n### New Controls:\n{{#addedControls}}\n+   {{id}} - {{title}}\n{{/addedControls}}\n\n{{#hasRenamedControls}}\n### Updated Control IDs:\n<details>\n  <summary>Click to expand.</summary>\n  \n  {{#renamedControls}}\n -  {{oldId}} -> {{newId}}\n  {{/renamedControls}} \n</details>\n{{/hasRenamedControls}}\n\n### Updated Check/Fixes:\n#### Checks:\n<details open>\n  <summary>Click to expand.</summary>\n{{#updatedChecks}}\n{{id}}:\nOld: \n```\n{{{old}}}\n\n```\n\nUpdated:\n```\n{{{new}}}\n\n```\n---\n{{/updatedChecks}}\n</details>\n\n#### Fixes:\n<details open>\n  <summary>Click to expand.</summary>\n{{#updatedFixes}}\n{{id}}:\nOld: \n```\n{{{old}}}\n\n```\nNew:\n```\n{{{new}}}\n\n```\n---\n{{/updatedFixes}}\n</details>\n\n### Updated Impacts\n<details open>\n  <summary>Click to expand.</summary>\n{{#updatedImpacts}}\n{{id}}:\nOld: {{old}}\nNew: {{new}}\n---\n{{/updatedImpacts}}\n</details>\n\n### Updated Titles\n<details>\n  <summary>Click to expand.</summary>\n{{#updatedTitles}}\n{{id}}:\nOld: {{old}}\nNew: {{new}}\n---\n{{/updatedTitles}}\n</details>\n\n### Updated Descriptions\n<details>\n  <summary>Click to expand.</summary>\n{{#updatedDescriptions}}\n{{id}}:\nOld:\n```\n{{{old}}}\n\n```\nNew:\n```\n{{{new}}}\n\n```\n---\n{{/updatedDescriptions}}\n</details>"
 }

package/lib/utilities/diff.d.ts

@@ -1,8 +1,9 @@
-import Profile from '../objects/profile';
-import { ProfileDiff } from '../types/diff';
+import Profile from "../objects/profile";
+import { ProfileDiff } from "../types/diff";
+import winston from "winston";
 export declare function removeNewlines(control?: Record<string, unknown>): Record<string, unknown>;
 export declare function simplifyDiff(diffData: Record<string, unknown>): Record<string, unknown>;
-export declare function diffProfile(fromProfile: Profile, toProfile: Profile): {
+export declare function diffProfile(fromProfile: Profile, toProfile: Profile, logger: winston.Logger): {
     simplified: ProfileDiff;
     originalDiff: Record<string, unknown>;
 };

package/lib/utilities/diff.js

@@ -4,15 +4,16 @@ exports.diffProfile = exports.simplifyDiff = exports.removeNewlines = void 0;
 const tslib_1 = require("tslib");
 const json_diff_1 = require("json-diff");
 const lodash_1 = tslib_1.__importDefault(require("lodash"));
+const update_1 = require("./update");
 function removeNewlines(control) {
     if (!control) {
         return {};
     }
     return lodash_1.default.mapValues(control, (value) => {
-        if (typeof value === 'string') {
-            return value.replace(/\n/g, '{{{{newlineHERE}}}}').trim();
+        if (typeof value === "string") {
+            return value.replace(/\n/g, "{{{{newlineHERE}}}}").trim();
         }
-        else if (typeof value === 'object' && value !== null) {
+        else if (typeof value === "object" && value !== null) {
             return removeNewlines(value);
         }
         return value;
@@ -21,24 +22,28 @@ function removeNewlines(control) {
 exports.removeNewlines = removeNewlines;
 function simplifyDiff(diffData) {
     return lodash_1.default.transform(diffData, (result, diffValue, key) => {
-        if (lodash_1.default.has(diffValue, '__new')) {
+        if (lodash_1.default.has(diffValue, "__new")) {
             // Remove any trailing space
-            if (typeof lodash_1.default.get(diffValue, '__new') === 'string' && typeof lodash_1.default.get(diffValue, '__old') === 'string') {
-                if (lodash_1.default.get(diffValue, '__new').trim() !== lodash_1.default.get(diffValue, '__old').trim()) {
-                    lodash_1.default.set(result, key, lodash_1.default.get(diffValue, '__new'));
+            if (typeof lodash_1.default.get(diffValue, "__new") === "string" &&
+                typeof lodash_1.default.get(diffValue, "__old") === "string") {
+                if (lodash_1.default.get(diffValue, "__new").trim() !==
+                    lodash_1.default.get(diffValue, "__old").trim()) {
+                    lodash_1.default.set(result, key, lodash_1.default.get(diffValue, "__new"));
                 }
             }
             else {
-                result[key] = lodash_1.default.get(diffValue, '__new');
+                result[key] = lodash_1.default.get(diffValue, "__new");
             }
         }
         else if (Array.isArray(diffValue)) {
-            result[key] = diffValue.map((value) => value[0] === '+' && value[1]).filter(value => value);
+            result[key] = diffValue
+                .map((value) => value[0] === "+" && value[1])
+                .filter((value) => value);
         }
-        else if (typeof diffValue === 'object') {
+        else if (typeof diffValue === "object") {
             result[key] = simplifyDiff(diffValue);
         }
-        else if (key.endsWith('__deleted')) {
+        else if (key.endsWith("__deleted")) {
             return undefined;
         }
         else {
@@ -47,37 +52,62 @@ function simplifyDiff(diffData) {
     });
 }
 exports.simplifyDiff = simplifyDiff;
-function diffProfile(fromProfile, toProfile) {
+function diffProfile(fromProfile, toProfile, logger) {
     const profileDiff = {
         addedControlIDs: [],
         removedControlIDs: [],
+        renamedControlIds: {},
         addedControls: {},
-        changedControls: {}
+        changedControls: {},
     };
     const originalDiff = {
         addedControlIDs: [],
         removedControlIDs: [],
+        renamedControlIds: {},
         addedControls: {},
-        changedControls: {}
+        changedControls: {},
     };
-    const fromControlIDs = fromProfile.controls.map((control) => control.id).sort();
+    const fromControlIDs = fromProfile.controls
+        .map((control) => control.id)
+        .sort();
     const toControlIDs = toProfile.controls.map((control) => control.id).sort();
     // Find new controls
     const controlIDDiff = (0, json_diff_1.diff)(fromControlIDs, toControlIDs);
+    // Contains the new IDs
+    const changedControlIds = [];
     controlIDDiff === null || controlIDDiff === void 0 ? void 0 : controlIDDiff.forEach((diffValue) => {
-        if (diffValue[0] === '-') {
-            profileDiff.removedControlIDs.push(diffValue[1]);
-            originalDiff.removedControlIDs.push(diffValue[1]);
+        if (diffValue[0] === "-") {
+            const existingControl = fromProfile.controls.find((control) => control.id === diffValue[1]);
+            // Check if the control has been given a new ID
+            if (existingControl) {
+                const newControl = (0, update_1.findUpdatedControlByAllIdentifiers)(existingControl, toProfile.controls);
+                if (newControl && newControl.id !== existingControl.id) {
+                    profileDiff.renamedControlIds[existingControl.id] = newControl.id;
+                    originalDiff.renamedControlIds[existingControl.id] = newControl.id;
+                    changedControlIds.push(newControl.id.toLowerCase());
+                    const controlDiff = lodash_1.default.omit((0, json_diff_1.diff)(existingControl, newControl), "code__deleted");
+                    profileDiff.changedControls[newControl.id] = simplifyDiff(controlDiff);
+                    originalDiff.changedControls[newControl.id] = controlDiff;
+                    logger.verbose(`Control ${existingControl.id} has been upgraded to ${newControl.id}`);
+                }
+                else {
+                    profileDiff.removedControlIDs.push(diffValue[1]);
+                    originalDiff.removedControlIDs.push(diffValue[1]);
+                }
+            }
+            else {
+                logger.error(`Unable to find existing control ${diffValue[1]}`);
+            }
         }
-        else if (diffValue[0] === '+') {
+        else if (diffValue[0] === "+" && !changedControlIds.includes(diffValue[1].toLowerCase())) {
             profileDiff.addedControlIDs.push(diffValue[1]);
             originalDiff.addedControlIDs.push(diffValue[1]);
         }
     });
-    // Add new controls to changedControls
+    // Add new controls to addedControls
     profileDiff.addedControlIDs.forEach((addedControl) => {
         const newControl = toProfile.controls.find((control) => addedControl === control.id);
-        if (newControl) {
+        if (newControl && !profileDiff.changedControls[newControl.id]) {
             profileDiff.addedControls[addedControl] = newControl;
             originalDiff.addedControls[addedControl] = newControl;
         }
@@ -86,7 +116,7 @@ function diffProfile(fromProfile, toProfile) {
     for (const fromControl of fromProfile.controls) {
         const toControl = toProfile.controls.find((control) => control.id === fromControl.id);
         if (toControl) {
-            const controlDiff = lodash_1.default.omit((0, json_diff_1.diff)(fromControl, toControl), 'code__deleted');
+            const controlDiff = lodash_1.default.omit((0, json_diff_1.diff)(fromControl, toControl), "code__deleted");
             if (controlDiff) {
                 profileDiff.changedControls[toControl.id] = simplifyDiff(controlDiff);
                 originalDiff.changedControls[toControl.id] = controlDiff;

package/lib/utilities/diffMarkdown.d.ts

@@ -1,6 +1,5 @@
 import { ProfileDiff } from "../types/diff";
-import Profile from '../objects/profile';
 export declare function createDiffMarkdown(diff: {
     simplified: ProfileDiff;
     originalDiff: any;
-}, updatedProfile: Profile): string;
+}): string;

package/lib/utilities/diffMarkdown.js

@@ -4,26 +4,87 @@ exports.createDiffMarkdown = void 0;
 const tslib_1 = require("tslib");
 const mustache_1 = tslib_1.__importDefault(require("mustache"));
 const lodash_1 = tslib_1.__importDefault(require("lodash"));
-const global_1 = require("./global");
-const xccdf_1 = require("./xccdf");
 const automatticUpdateTemplate_json_1 = tslib_1.__importDefault(require("../resources/automatticUpdateTemplate.json"));
 function getUpdatedCheckForId(id, profile) {
     const foundControl = profile.controls.find((control) => control.id === id);
-    return lodash_1.default.get(foundControl === null || foundControl === void 0 ? void 0 : foundControl.descs, 'check') || 'Missing check';
+    return lodash_1.default.get(foundControl === null || foundControl === void 0 ? void 0 : foundControl.descs, "check") || "Missing check";
 }
-function createDiffMarkdown(diff, updatedProfile) {
+function createDiffMarkdown(diff) {
     const renderableDiffData = {
         addedControls: Object.values(diff.simplified.addedControls),
-        checks: [],
-        fixes: [],
+        hasRenamedControls: false,
+        renamedControls: [],
+        updatedChecks: [],
+        updatedFixes: [],
+        updatedImpacts: [],
+        updatedTitles: [],
+        updatedDescriptions: [],
     };
-    Object.entries(diff.simplified.changedControls).forEach(([id, updatedControl]) => {
-        if (lodash_1.default.get(updatedControl, "descs.check")) {
-            // console.log(removeXMLSpecialCharacters(removeNewlinePlaceholders(getUpdatedCheckForId(id, updatedProfile))))
-            renderableDiffData.checks.push({
-                id,
-                check: (0, xccdf_1.removeXMLSpecialCharacters)((0, global_1.removeNewlinePlaceholders)(getUpdatedCheckForId(id, updatedProfile))),
-            });
+    Object.entries(diff.simplified.renamedControlIds).forEach(([oldId, newId]) => {
+        renderableDiffData.hasRenamedControls = true;
+        renderableDiffData.renamedControls.push({
+            oldId: oldId,
+            newId: newId,
+        });
+    });
+    Object.entries(diff.originalDiff.changedControls).forEach(([id, controlDiff]) => {
+        var _a, _b;
+        if ((_a = controlDiff.descs) === null || _a === void 0 ? void 0 : _a.check) {
+            const oldCheck = lodash_1.default.get(controlDiff.descs.check, "__old");
+            const newCheck = lodash_1.default.get(controlDiff.descs.check, "__new");
+            if (oldCheck.replace(/\n/g, "").replace(/\W/g, "") !==
+                newCheck.replace(/\n/g, "").replace(/\W/g, "")) {
+                renderableDiffData.updatedChecks.push({
+                    id: id,
+                    old: oldCheck,
+                    new: newCheck,
+                });
+            }
+        }
+        if ((_b = controlDiff.descs) === null || _b === void 0 ? void 0 : _b.fix) {
+            const oldFix = lodash_1.default.get(controlDiff.descs.fix, "__old");
+            const newFix = lodash_1.default.get(controlDiff.descs.fix, "__new");
+            if (oldFix.replace(/\n/g, "").replace(/\W/g, "") !==
+                newFix.replace(/\n/g, "").replace(/\W/g, "")) {
+                renderableDiffData.updatedFixes.push({
+                    id: id,
+                    old: oldFix,
+                    new: newFix,
+                });
+            }
+        }
+        if (controlDiff.impact) {
+            const oldImpact = lodash_1.default.get(controlDiff.impact, "__old");
+            const newImpact = lodash_1.default.get(controlDiff.impact, "__new");
+            if (oldImpact !== newImpact) {
+                renderableDiffData.updatedImpacts.push({
+                    id: id,
+                    old: oldImpact,
+                    new: newImpact,
+                });
+            }
+        }
+        if (controlDiff.title) {
+            const oldTitle = lodash_1.default.get(controlDiff.title, "__old");
+            const newTitle = lodash_1.default.get(controlDiff.title, "__new");
+            if (oldTitle !== newTitle) {
+                renderableDiffData.updatedTitles.push({
+                    id: id,
+                    old: oldTitle,
+                    new: newTitle,
+                });
+            }
+        }
+        if (controlDiff.desc) {
+            const oldDesc = lodash_1.default.get(controlDiff.desc, "__old");
+            const newDesc = lodash_1.default.get(controlDiff.desc, "__new");
+            if (oldDesc !== newDesc) {
+                renderableDiffData.updatedDescriptions.push({
+                    id: id,
+                    old: oldDesc,
+                    new: newDesc,
+                });
+            }
         }
     });
     // Render output

package/lib/utilities/update.d.ts

@@ -11,6 +11,7 @@ export declare type UpdatedProfileReturn = {
     };
     markdown: string;
 };
-export declare function updateControl(from: Control, update: Partial<Control>): Control;
-export declare function updateProfile(from: Profile, using: Profile): Omit<UpdatedProfileReturn, 'markdown'>;
-export declare function updateProfileUsingXCCDF(from: Profile, using: string, id: 'group' | 'rule' | 'version', logger: winston.Logger, ovalDefinitions?: Record<string, OvalDefinitionValue>): UpdatedProfileReturn;
+export declare function findUpdatedControlByAllIdentifiers(existingControl: Control, updatedControls: Control[]): Control | undefined;
+export declare function updateControl(from: Control, update: Partial<Control>, logger: winston.Logger): Control;
+export declare function updateProfile(from: Profile, using: Profile, logger: winston.Logger): Omit<UpdatedProfileReturn, 'markdown'>;
+export declare function updateProfileUsingXCCDF(from: Profile, using: string, id: 'group' | 'rule' | 'version' | 'cis', logger: winston.Logger, ovalDefinitions?: Record<string, OvalDefinitionValue>): UpdatedProfileReturn;

package/lib/utilities/update.js

@@ -2,7 +2,7 @@
 // Utilities to update a profile or control with new metadata
 // The ultimate goal is to preserve all the metadata that is already there and only add what is new
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.updateProfileUsingXCCDF = exports.updateProfile = exports.updateControl = void 0;
+exports.updateProfileUsingXCCDF = exports.updateProfile = exports.updateControl = exports.findUpdatedControlByAllIdentifiers = void 0;
 const tslib_1 = require("tslib");
 const lodash_1 = tslib_1.__importDefault(require("lodash"));
 const profile_1 = tslib_1.__importDefault(require("../objects/profile"));
@@ -65,43 +65,64 @@ function getExistingDescribeFromControl(control) {
         return '';
     }
 }
-function updateControl(from, update) {
+function findUpdatedControlByAllIdentifiers(existingControl, updatedControls) {
+    // Try to match based on IDs
+    let updatedControl = updatedControls.find((updatedControl) => {
+        return updatedControl.id.toLowerCase() === existingControl.id.toLowerCase();
+    });
+    if (updatedControl) {
+        return updatedControl;
+    }
+    // Try to match based on legacy identifiers
+    updatedControl = updatedControls.find((updatedControl) => {
+        var _a;
+        return (_a = updatedControl.tags.legacy) === null || _a === void 0 ? void 0 : _a.some((legacyTag) => {
+            var _a;
+            return legacyTag.toLowerCase() === ((_a = existingControl.id) === null || _a === void 0 ? void 0 : _a.toLowerCase());
+        });
+    });
+    if (updatedControl) {
+        return updatedControl;
+    }
+    return undefined;
+}
+exports.findUpdatedControlByAllIdentifiers = findUpdatedControlByAllIdentifiers;
+function updateControl(from, update, logger) {
     const existingDescribeBlock = getExistingDescribeFromControl(from);
+    logger.debug(`Existing describe block for control ${from.id}: ${JSON.stringify(existingDescribeBlock)}`);
     const projectedControl = projectValuesOntoExistingObj(from, update);
     projectedControl.describe = existingDescribeBlock;
     return projectedControl;
 }
 exports.updateControl = updateControl;
-function updateProfile(from, using) {
+function updateProfile(from, using, logger) {
     // Update the profile with the new metadata
     const to = new profile_1.default(lodash_1.default.omit(from, 'controls'));
     // Find the diff
-    const diff = (0, diff_1.diffProfile)(from, using);
+    const diff = (0, diff_1.diffProfile)(from, using, logger);
     // Add the new controls
     diff.simplified.addedControlIDs.forEach(id => {
         const addedControl = diff.simplified.addedControls[id];
         if (addedControl) {
+            logger.debug(`New Control: ${addedControl.id} - ${addedControl.title}`);
             to.controls.push(addedControl);
         }
         else {
-            throw new Error("New control added but don't have the control data");
+            throw new Error(`New control ${id} added but don't have the control data`);
         }
     });
     // Update the existing controls
     for (const existingControl of from.controls) {
-        const updatedControl = using.controls.find(control => control.id === existingControl.id);
+        const updatedControl = findUpdatedControlByAllIdentifiers(existingControl, using.controls);
         if (updatedControl) {
-            const controlDiff = diff.simplified.changedControls[existingControl.id];
+            const controlDiff = diff.simplified.changedControls[updatedControl.id];
             if (controlDiff) {
-                to.controls.push(updateControl(existingControl, controlDiff));
+                to.controls.push(updateControl(existingControl, controlDiff, logger));
             }
             else {
                 to.controls.push(existingControl);
             }
         }
-        else {
-            console.log("Control not updated: " + existingControl.id);
-        }
     }
     return {
         profile: to,
@@ -110,19 +131,17 @@ function updateProfile(from, using) {
 }
 exports.updateProfile = updateProfile;
 function updateProfileUsingXCCDF(from, using, id, logger, ovalDefinitions) {
+    logger.debug(`Updating profile ${from.name} with control IDs: ${id}`);
     // Parse the XCCDF benchmark and convert it into a Profile
     logger.debug('Loading XCCDF File');
-    const xccdfProfile = (0, xccdf_1.processXCCDF)(using, false, id);
+    const xccdfProfile = (0, xccdf_1.processXCCDF)(using, false, id, ovalDefinitions);
     logger.debug('Loaded XCCDF File');
-    logger.debug('Loading XCCDF File with newline replacements');
-    const xccdfProfileWithNLReplacement = (0, xccdf_1.processXCCDF)(using, true, id);
-    logger.debug('Loaded XCCDF File with newline replacements');
     // Update the profile and return
     logger.debug('Creating updated profile');
-    const updatedProfile = updateProfile(from, xccdfProfile);
+    const updatedProfile = updateProfile(from, xccdfProfile, logger);
     logger.debug('Creating diff markdown');
     // Create the markdown
-    const markdown = (0, diffMarkdown_1.createDiffMarkdown)(updatedProfile.diff, xccdfProfileWithNLReplacement);
+    const markdown = (0, diffMarkdown_1.createDiffMarkdown)(updatedProfile.diff);
     logger.debug('Profile update complete');
     return {
         profile: updatedProfile.profile,

package/lib/utilities/xccdf.js

@@ -6,20 +6,6 @@ const fast_xml_parser_1 = tslib_1.__importDefault(require("fast-xml-parser"));
 const htmlparser = tslib_1.__importStar(require("htmlparser2"));
 const lodash_1 = tslib_1.__importDefault(require("lodash"));
 const he_1 = tslib_1.__importDefault(require("he"));
-var htmlEntities = {
-    nbsp: ' ',
-    cent: '¢',
-    pound: '£',
-    yen: '¥',
-    euro: '€',
-    copy: '©',
-    reg: '®',
-    lt: '<',
-    gt: '>',
-    quot: '"',
-    amp: '&',
-    apos: '\''
-};
 function convertEncodedXmlIntoJson(encodedXml) {
     return fast_xml_parser_1.default.parse(encodedXml, {
         ignoreAttributes: false,

package/package-lock.json

@@ -1,12 +1,12 @@
 {
   "name": "@mitre/inspec-objects",
-  "version": "0.0.14",
+  "version": "0.0.17",
   "lockfileVersion": 2,
   "requires": true,
   "packages": {
     "": {
       "name": "@mitre/inspec-objects",
-      "version": "0.0.14",
+      "version": "0.0.17",
       "license": "Apache-2.0",
       "dependencies": {
         "@types/flat": "^5.0.2",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@mitre/inspec-objects",
-  "version": "0.0.14",
+  "version": "0.0.17",
   "description": "Typescript objects for normalizing between InSpec profiles and XCCDF benchmarks",
   "main": "lib/index.js",
   "publishConfig": {