@misterhuydo/sentinel 1.5.4 → 1.5.6

package/python/tests/test_repo_router.py

@@ -0,0 +1,73 @@
+"""
+test_repo_router.py — Unit tests for repo routing logic.
+"""
+import pytest
+from sentinel.repo_router import route
+from sentinel.log_parser import ErrorEvent
+from sentinel.config_loader import RepoConfig
+
+
+def _make_event(source: str, fingerprint: str = "fp1") -> ErrorEvent:
+    return ErrorEvent(
+        source=source,
+        fingerprint=fingerprint,
+        level="ERROR",
+        timestamp="2026-01-01T00:00:00",
+        log_file="",
+        thread="",
+        logger_name="com.example.Test",
+        message="some error",
+        stack_trace=[],
+    )
+
+
+def _make_repo(name: str) -> RepoConfig:
+    r = RepoConfig()
+    r.repo_name = name
+    r.repo_url = f"git@github.com:org/{name}.git"
+    r.local_path = f"/repos/{name}"
+    return r
+
+
+# ── routing by source name ────────────────────────────────────────────────────
+
+def test_routes_by_source_name():
+    repos = {"my-service": _make_repo("my-service")}
+    event = _make_event("my-service")
+    result = route(event, repos)
+    assert result is not None
+    assert result.repo_name == "my-service"
+
+
+def test_returns_none_for_unknown_source(caplog):
+    repos = {"other-service": _make_repo("other-service")}
+    event = _make_event("unknown-source")
+    result = route(event, repos)
+    assert result is None
+
+
+def test_returns_none_for_empty_repos():
+    event = _make_event("any-source")
+    result = route(event, {})
+    assert result is None
+
+
+def test_exact_match_only():
+    repos = {
+        "service-a": _make_repo("service-a"),
+        "service-b": _make_repo("service-b"),
+    }
+    event = _make_event("service-a")
+    result = route(event, repos)
+    assert result.repo_name == "service-a"
+
+
+def test_multiple_repos_correct_routing():
+    repos = {
+        "auth-service":  _make_repo("auth-service"),
+        "order-service": _make_repo("order-service"),
+    }
+    for source, expected in [("auth-service", "auth-service"), ("order-service", "order-service")]:
+        result = route(_make_event(source), repos)
+        assert result is not None
+        assert result.repo_name == expected

package/python/tests/test_smoke.py

@@ -0,0 +1,96 @@
+"""
+test_smoke.py — Import-level smoke tests.
+If any of these fail, a Patch fix broke a module import or removed a critical symbol.
+"""
+import textwrap
+
+
+def test_import_config_loader():
+    from sentinel.config_loader import ConfigLoader, SentinelConfig, RepoConfig, LogSourceConfig
+    assert callable(ConfigLoader)
+    assert hasattr(SentinelConfig, "__dataclass_fields__")
+    assert hasattr(RepoConfig, "ssh_key_file")          # property must exist
+
+
+def test_import_log_parser():
+    from sentinel.log_parser import parse_log_file, ErrorEvent, _fingerprint
+    assert callable(parse_log_file)
+    assert callable(_fingerprint)
+
+
+def test_import_repo_router():
+    from sentinel.repo_router import route
+    assert callable(route)
+
+
+def test_import_state_store():
+    from sentinel.state_store import StateStore
+    assert callable(StateStore)
+
+
+def test_import_notify():
+    from sentinel.notify import slack_alert, notify_fix_applied
+    assert callable(slack_alert)
+    assert callable(notify_fix_applied)
+
+
+def test_import_git_manager():
+    from sentinel.git_manager import _git_env
+    assert callable(_git_env)
+
+
+def test_ssh_key_priority(tmp_path):
+    """Deploy key takes priority over user key on RepoConfig.ssh_key_file."""
+    from sentinel.config_loader import ConfigLoader
+
+    (tmp_path / "log-configs").mkdir()
+    (tmp_path / "repo-configs").mkdir()
+    (tmp_path / "sentinel.properties").write_text(
+        "GIT_SSH_USER_KEY=~/.ssh/user.key\n"
+    )
+    (tmp_path / "repo-configs" / "my-repo.properties").write_text(textwrap.dedent("""\
+        REPO_URL=git@github.com:org/my-repo.git
+        GIT_SSH_DEPLOY_KEY=~/.ssh/deploy.key
+    """))
+
+    loader = ConfigLoader(str(tmp_path))
+    repo = loader.repos["my-repo"]
+    assert "deploy.key" in repo.ssh_key_file   # deploy key wins
+
+
+def test_ssh_user_key_fallback(tmp_path):
+    """User key is used when no deploy key is set."""
+    from sentinel.config_loader import ConfigLoader
+
+    (tmp_path / "log-configs").mkdir()
+    (tmp_path / "repo-configs").mkdir()
+    (tmp_path / "sentinel.properties").write_text(
+        "GIT_SSH_USER_KEY=~/.ssh/user.key\n"
+    )
+    (tmp_path / "repo-configs" / "my-repo.properties").write_text(
+        "REPO_URL=git@github.com:org/my-repo.git\n"
+    )
+
+    loader = ConfigLoader(str(tmp_path))
+    repo = loader.repos["my-repo"]
+    assert "user.key" in repo.ssh_key_file     # falls back to user key
+
+
+def test_severity_critical_on_oom():
+    from sentinel.log_parser import ErrorEvent
+    e = ErrorEvent(
+        source="svc", log_file="", timestamp="2026-01-01T00:00:00",
+        level="ERROR", thread="main", logger_name="com.example.App",
+        message="java.lang.OutOfMemoryError: Java heap space",
+    )
+    assert e.severity == "CRITICAL"
+
+
+def test_severity_infra_issue():
+    from sentinel.log_parser import ErrorEvent
+    e = ErrorEvent(
+        source="svc", log_file="", timestamp="2026-01-01T00:00:00",
+        level="ERROR", thread="main", logger_name="com.example.App",
+        message="ConnectException: Connection refused",
+    )
+    assert e.is_infra_issue is True

package/python/tests/test_state_store.py

@@ -0,0 +1,128 @@
+"""
+test_state_store.py — Unit tests for StateStore (in-memory SQLite).
+"""
+import pytest
+from sentinel.state_store import StateStore
+
+
+@pytest.fixture
+def store(tmp_path):
+    return StateStore(str(tmp_path / "test.db"))
+
+
+# ── errors ────────────────────────────────────────────────────────────────────
+
+def test_record_and_get_error(store):
+    store.record_error("fp1", "source-A", "NullPointerException in Foo.bar")
+    errors = store.get_recent_errors(24)
+    assert len(errors) == 1
+    assert errors[0]["fingerprint"] == "fp1"
+    assert errors[0]["source"] == "source-A"
+    assert errors[0]["count"] == 1
+
+
+def test_error_count_increments(store):
+    store.record_error("fp1", "source-A", "some error")
+    store.record_error("fp1", "source-A", "some error")
+    errors = store.get_recent_errors(24)
+    assert errors[0]["count"] == 2
+
+
+def test_is_seen(store):
+    assert not store.seen("fp1")
+    store.record_error("fp1", "source-A", "msg")
+    assert store.seen("fp1")
+
+
+# ── fixes ─────────────────────────────────────────────────────────────────────
+
+def test_record_fix(store):
+    store.record_error("fp1", "src", "msg")
+    store.record_fix("fp1", "applied", patch_path="/tmp/x.diff",
+                     commit_hash="abc123", branch="sentinel/fix-fp1", repo_name="my-repo")
+    fixes = store.get_recent_fixes(24)
+    assert len(fixes) == 1
+    assert fixes[0]["status"] == "applied"
+    assert fixes[0]["repo_name"] == "my-repo"
+
+
+def test_get_open_prs(store):
+    store.record_error("fp1", "src", "msg")
+    store.record_fix("fp1", "pending", pr_url="https://github.com/org/repo/pull/1",
+                     branch="sentinel/fix-fp1", repo_name="repo")
+    prs = store.get_open_prs()
+    assert len(prs) == 1
+    assert prs[0]["pr_url"] == "https://github.com/org/repo/pull/1"
+
+
+# ── slack_users ───────────────────────────────────────────────────────────────
+
+def test_upsert_and_get_user(store):
+    store.upsert_user("U123", "huy")
+    assert store.get_user_name("U123") == "huy"
+
+
+def test_get_user_unknown_returns_id(store):
+    assert store.get_user_name("UNKNOWN") == "UNKNOWN"
+
+
+def test_get_all_users(store):
+    store.upsert_user("U1", "alice")
+    store.upsert_user("U2", "bob")
+    users = store.get_all_users()
+    assert users == {"U1": "alice", "U2": "bob"}
+
+
+def test_upsert_user_updates_name(store):
+    store.upsert_user("U1", "old-name")
+    store.upsert_user("U1", "new-name")
+    assert store.get_user_name("U1") == "new-name"
+
+
+# ── conversations ─────────────────────────────────────────────────────────────
+
+def test_save_and_load_conversation(store):
+    history = [{"role": "user", "content": "hello"}, {"role": "assistant", "content": "hi"}]
+    store.save_conversation("U1", history)
+    loaded = store.load_conversation("U1")
+    assert loaded == history
+
+
+def test_load_conversation_empty(store):
+    assert store.load_conversation("U_NOBODY") == []
+
+
+def test_clear_conversation(store):
+    store.save_conversation("U1", [{"role": "user", "content": "test"}])
+    store.save_conversation("U1", [])
+    assert store.load_conversation("U1") == []
+
+
+# ── admin ops ─────────────────────────────────────────────────────────────────
+
+def test_reset_fingerprint(store):
+    store.record_error("fp1", "src", "msg")
+    store.record_fix("fp1", "applied", branch="b", repo_name="r")
+    assert store.reset_fingerprint("fp1") is True
+    fixes = store.get_recent_fixes(24)
+    assert all(f["fingerprint"] != "fp1" for f in fixes)
+
+
+def test_reset_fingerprint_not_found(store):
+    assert store.reset_fingerprint("nonexistent") is False
+
+
+def test_get_all_errors(store):
+    store.record_error("fp1", "src", "msg1")
+    store.record_error("fp2", "src", "msg2")
+    errors = store.get_all_errors()
+    assert len(errors) == 2
+
+
+def test_get_all_user_stats(store):
+    store.upsert_user("U1", "alice")
+    store.upsert_user("U2", "bob")
+    stats = store.get_all_user_stats()
+    assert len(stats) == 2
+    ids = {s["user_id"] for s in stats}
+    assert ids == {"U1", "U2"}