@misofm/platform 0.25.0 → 0.26.0

package/src/read/works.ts

@@ -1,139 +1,27 @@
 // Copyright (c) Miso Labs, Inc.
 // SPDX-License-Identifier: Apache-2.0
 
-import type { ClientWithCoreApi } from "@mysten/sui/client";
-import type { SuiGraphQLClient } from "@mysten/sui/graphql";
+import { Effect } from "effect";
 import { normalizeSuiAddress } from "@mysten/sui/utils";
 import {
   contracts,
   extractTypeParams2,
   getCompositionsByIds,
-  type Composition,
-  type Recording,
-  type Release,
+  getWorkAddressesByShareTypes,
+  Composition,
+  Recording,
+  Release,
   type TrackState,
+  type WorkAddressesByShareType,
+  type WorkShareTypes,
 } from "@misofm/musicos";
+import { decodeBcs, SuiClient, SuiGraphQL, SuiRpcError, type BcsDecodeError } from "@misofm/effect";
 
-export interface WorkShareTypes {
-  compositions: readonly string[];
-  recordings: readonly string[];
-}
-
-export interface WorkAddressesByShareType {
-  compositions: Partial<Record<string, string>>;
-  recordings: Partial<Record<string, string>>;
-}
-
-interface WorkAddressConnection {
-  nodes: Array<{
-    address: string;
-    asMoveObject?: {
-      contents?: { type?: { repr?: string } | null } | null;
-    } | null;
-  }>;
-  pageInfo?: { hasNextPage: boolean; endCursor: string | null };
-}
-
-/** Resolve all work share types in one aliased GraphQL request. */
-export async function getWorkAddressesByShareTypes(
-  client: SuiGraphQLClient,
-  shareTypes: WorkShareTypes,
-  misoPackageId: string,
-): Promise<WorkAddressesByShareType> {
-  const compositions = [...new Set(shareTypes.compositions)];
-  const recordings = new Set(shareTypes.recordings);
-  const out: WorkAddressesByShareType = { compositions: {}, recordings: {} };
-  if (compositions.length === 0 && recordings.size === 0) return out;
-
-  const declarations: string[] = [];
-  const selections: string[] = [];
-  const variables: Record<string, string> = {};
-  compositions.forEach((shareType, index) => {
-    const variable = `compositionType${index}`;
-    declarations.push(`$${variable}: String!`);
-    selections.push(
-      `composition${index}: objects(first: 1, filter: { type: $${variable} }) { nodes { address } }`,
-    );
-    variables[variable] =
-      `${misoPackageId}::composition::Composition<${shareType}>`;
-  });
-  if (recordings.size > 0) {
-    declarations.push("$recordingType: String!");
-    selections.push(`recordings: objects(first: 50, filter: { type: $recordingType }) {
-      pageInfo { hasNextPage endCursor }
-      nodes { address asMoveObject { contents { type { repr } } } }
-    }`);
-    variables.recordingType = `${misoPackageId}::recording::Recording`;
-  }
-
-  const result = await client.query<
-    Record<string, WorkAddressConnection | null>,
-    Record<string, string>
-  >({
-    query: `query WorkAddressesByShareTypes(${declarations.join(", ")}) {
-      ${selections.join("\n")}
-    }`,
-    variables,
-  });
-  if (result.errors?.length) {
-    throw new AggregateError(
-      result.errors.map((error) => new Error(error.message)),
-      "Work type discovery failed",
-    );
-  }
-  compositions.forEach((shareType, index) => {
-    const address = result.data?.[`composition${index}`]?.nodes[0]?.address;
-    if (address) out.compositions[shareType] = address;
-  });
-
-  const readRecordingPage = (
-    page: WorkAddressConnection | null | undefined,
-  ) => {
-    for (const node of page?.nodes ?? []) {
-      const repr = node.asMoveObject?.contents?.type?.repr;
-      if (!repr) continue;
-      try {
-        const [shareType] = extractTypeParams2(repr);
-        if (recordings.has(shareType)) out.recordings[shareType] = node.address;
-      } catch {
-        // Ignore objects whose deployed type does not match the Recording ABI.
-      }
-    }
-  };
-
-  let page = result.data?.recordings;
-  readRecordingPage(page);
-  while (
-    page?.pageInfo?.hasNextPage &&
-    page.pageInfo.endCursor &&
-    Object.keys(out.recordings).length < recordings.size
-  ) {
-    const next = await client.query<
-      { recordings: WorkAddressConnection | null },
-      { recordingType: string; cursor: string }
-    >({
-      query: `query RecordingWorkAddresses($recordingType: String!, $cursor: String!) {
-        recordings: objects(first: 50, after: $cursor, filter: { type: $recordingType }) {
-          pageInfo { hasNextPage endCursor }
-          nodes { address asMoveObject { contents { type { repr } } } }
-        }
-      }`,
-      variables: {
-        recordingType: variables.recordingType!,
-        cursor: page.pageInfo.endCursor,
-      },
-    });
-    if (next.errors?.length) {
-      throw new AggregateError(
-        next.errors.map((error) => new Error(error.message)),
-        "Recording type discovery failed",
-      );
-    }
-    page = next.data?.recordings;
-    readRecordingPage(page);
-  }
-  return out;
-}
+// `getWorkAddressesByShareTypes` (GraphQL type discovery) is owned by
+// `@misofm/musicos` now — re-exported here so existing platform imports keep
+// working.
+export { getWorkAddressesByShareTypes };
+export type { WorkAddressesByShareType, WorkShareTypes };
 
 export interface WorkIds {
   compositions: readonly string[];
@@ -147,122 +35,121 @@ export interface WorksById {
   releases: Partial<Record<string, Release>>;
 }
 
+// deno-lint-ignore no-explicit-any -- generated parse output is loosely typed
 type Parsed = Record<string, any>;
 
-function workState(value: Parsed): Composition["state"] {
+function workState(value: Parsed): (typeof Composition.Type)["state"] {
   return value?.$kind === "Published"
     ? { type: "Published", timestampMs: Number(value.Published) }
     : { type: "Initialized" };
 }
 
-function parseComposition(id: string, content: Uint8Array): Composition {
-  const value = contracts.composition.Composition.parse(content) as Parsed;
+function mapComposition(id: string, d: Parsed) {
   return {
     id,
-    state: workState(value.state),
-    title: String(value.title),
+    state: workState(d.state),
+    title: String(d.title),
     royaltyRate: {
-      value: Number(
-        Array.isArray(value.royalty_rate)
-          ? value.royalty_rate[0]
-          : value.royalty_rate,
-      ),
+      value: Number(Array.isArray(d.royalty_rate) ? d.royalty_rate[0] : d.royalty_rate),
     },
   };
 }
 
-function parseRecording(id: string, content: Uint8Array): Recording {
-  const value = contracts.recording.Recording.parse(content) as Parsed;
+function mapRecording(id: string, d: Parsed) {
   return {
     id,
-    state: workState(value.state),
-    compositionId: String(value.composition_id),
+    state: workState(d.state),
+    compositionId: String(d.composition_id),
   };
 }
 
-export function parseReleaseObject(
-  id: string,
-  content: Uint8Array,
-): Release {
-  const value = contracts.release.Release.parse(content) as Parsed;
+function mapReleaseObject(id: string, d: Parsed) {
   return {
     id,
-    state: workState(value.state),
-    title: String(value.title),
-    tracks: (value.tracks ?? []).map((track: Parsed) => ({
+    state: workState(d.state),
+    title: String(d.title),
+    tracks: (d.tracks ?? []).map((track: Parsed) => ({
       state: (track.state?.$kind ?? "Unassigned") as TrackState,
       compositionId: String(track.composition_id),
       recordingId: String(track.recording_id),
       splitBps: {
-        value: Number(
-          Array.isArray(track.split_bps) ? track.split_bps[0] : track.split_bps,
-        ),
+        value: Number(Array.isArray(track.split_bps) ? track.split_bps[0] : track.split_bps),
       },
     })),
   };
 }
 
+/** Decode a Release object's raw BCS content into the public `Release` type. */
+export function parseReleaseObject(id: string, content: Uint8Array): Effect.Effect<Release, BcsDecodeError> {
+  return decodeBcs(
+    { parse: (bytes: Uint8Array) => mapReleaseObject(id, contracts.release.Release.parse(bytes) as Parsed) },
+    Release,
+    content,
+    { type: "Release", objectId: id },
+  );
+}
+
 /** Fetch and parse heterogeneous works through one Core bulk request. */
-export async function getWorksByIds(
-  client: ClientWithCoreApi,
+export const getWorksByIds = Effect.fn("getWorksByIds")(function* (
   ids: WorkIds,
-): Promise<WorksById> {
+): Effect.fn.Return<WorksById, SuiRpcError | BcsDecodeError, SuiClient> {
   const kinds = new Map<string, keyof WorksById>();
-  for (const [kind, objectIds] of Object.entries(ids) as Array<
-    [keyof WorksById, readonly string[]]
-  >) {
+  for (const [kind, objectIds] of Object.entries(ids) as Array<[keyof WorksById, readonly string[]]>) {
     for (const objectId of objectIds) {
       const normalized = normalizeSuiAddress(objectId);
       const previous = kinds.get(normalized);
       if (previous && previous !== kind) {
-        throw new Error(
-          `Work ${normalized} was requested as both ${previous} and ${kind}`,
-        );
+        throw new Error(`Work ${normalized} was requested as both ${previous} and ${kind}`);
       }
       kinds.set(normalized, kind);
     }
   }
   const out: WorksById = { compositions: {}, recordings: {}, releases: {} };
   if (kinds.size === 0) return out;
-  const { objects } = await client.core.getObjects({
-    objectIds: [...kinds.keys()],
-    include: { content: true },
+
+  const client = yield* SuiClient;
+  const { objects } = yield* Effect.tryPromise({
+    try: (signal) => client.core.getObjects({ objectIds: [...kinds.keys()], include: { content: true }, signal }),
+    catch: (cause) => new SuiRpcError({ operation: "getObjects", cause }),
   });
   for (const object of objects) {
     if (object instanceof Error || !object.content) continue;
     const kind = kinds.get(normalizeSuiAddress(object.objectId));
-    if (kind === "compositions")
-      out.compositions[object.objectId] = parseComposition(
-        object.objectId,
-        object.content,
+    const objectId = object.objectId;
+    const content = object.content;
+    if (kind === "compositions") {
+      out.compositions[objectId] = yield* decodeBcs(
+        { parse: (bytes: Uint8Array) => mapComposition(objectId, contracts.composition.Composition.parse(bytes) as Parsed) },
+        Composition,
+        content,
+        { type: "Composition", objectId },
       );
-    else if (kind === "recordings")
-      out.recordings[object.objectId] = parseRecording(
-        object.objectId,
-        object.content,
-      );
-    else if (kind === "releases")
-      out.releases[object.objectId] = parseReleaseObject(
-        object.objectId,
-        object.content,
+    } else if (kind === "recordings") {
+      out.recordings[objectId] = yield* decodeBcs(
+        { parse: (bytes: Uint8Array) => mapRecording(objectId, contracts.recording.Recording.parse(bytes) as Parsed) },
+        Recording,
+        content,
+        { type: "Recording", objectId },
       );
+    } else if (kind === "releases") {
+      out.releases[objectId] = yield* parseReleaseObject(objectId, content);
+    }
   }
   return out;
-}
+});
 
 /** Resolve recording titles through each recording's canonical composition type. */
-export async function getRecordingTitles(
-  client: ClientWithCoreApi,
-  graphql: SuiGraphQLClient,
+export const getRecordingTitles = Effect.fn("getRecordingTitles")(function* (
   recordingIds: readonly string[],
   misoPackageId: string,
-): Promise<Record<string, string>> {
+): Effect.fn.Return<Record<string, string>, SuiRpcError | BcsDecodeError, SuiClient | SuiGraphQL> {
   const ids = [...new Set(recordingIds)];
   if (ids.length === 0) return {};
 
-  const { objects } = await client.core.getObjects({
-    objectIds: ids,
-    include: {},
+  const client = yield* SuiClient;
+  const { objects } = yield* Effect.tryPromise({
+    try: (signal) => client.core.getObjects({ objectIds: ids, include: {}, signal }),
+    catch: (cause) => new SuiRpcError({ operation: "getObjects", cause }),
   });
   const titles: Record<string, string> = {};
   const compositionShareByRecording: Record<string, string> = {};
@@ -275,23 +162,17 @@ export async function getRecordingTitles(
 
   const compositionShareTypes = Object.values(compositionShareByRecording);
   if (compositionShareTypes.length === 0) return titles;
-  const addresses = await getWorkAddressesByShareTypes(
-    graphql,
+  const addresses = yield* getWorkAddressesByShareTypes(
     { compositions: compositionShareTypes, recordings: [] },
     misoPackageId,
   );
-  const compositions = await getCompositionsByIds(
-    client,
+  const compositions = yield* getCompositionsByIds(
     Object.values(addresses.compositions).filter((id): id is string => !!id),
   );
-  for (const [recordingId, shareType] of Object.entries(
-    compositionShareByRecording,
-  )) {
+  for (const [recordingId, shareType] of Object.entries(compositionShareByRecording)) {
     const compositionId = addresses.compositions[shareType];
-    const title = compositionId
-      ? compositions[compositionId]?.title
-      : undefined;
+    const title = compositionId ? compositions[compositionId]?.title : undefined;
     if (title) titles[recordingId] = title;
   }
   return titles;
-}
+});

package/src/recording-extensions.ts

@@ -4,10 +4,10 @@
 /** Cap-authorized builders and reads for data-only Recording metadata extensions. */
 
 import { bcs } from "@mysten/sui/bcs";
-import type { ClientWithCoreApi } from "@mysten/sui/client";
 import type { Transaction, TransactionArgument, TransactionObjectArgument } from "@mysten/sui/transactions";
 import { deriveDynamicFieldID, fromHex, toHex } from "@mysten/sui/utils";
-import { isNotFound } from "@misofm/musicos";
+import { Effect, Option } from "effect";
+import { getObjectsContent, getOptionalObjectContent, type SuiClient, type SuiRpcError } from "@misofm/effect";
 import type { TxThunk } from "./transactions.ts";
 import { invokeWithAdminCap, type AdminCapAuthority, type ObjectInput } from "./vault.ts";
 import * as advisory from "./contracts/recording_advisory/recording_advisory.ts";
@@ -271,33 +271,23 @@ export function recordingStreamingTranscodeFieldId(
 }
 
 /** Read one Recording's streaming-transcode Quilt id, or null when absent. */
-export async function getRecordingStreamingTranscode(
-  client: ClientWithCoreApi,
+export const getRecordingStreamingTranscode = Effect.fn("getRecordingStreamingTranscode")(function* (
   recordingId: string,
   recordingStreamingTranscodePackageId: string,
-): Promise<string | null> {
-  return (
-    (
-      await getRecordingStreamingTranscodesByIds(
-        client,
-        [recordingId],
-        recordingStreamingTranscodePackageId,
-      )
-    )[recordingId] ?? null
-  );
-}
+): Effect.fn.Return<string | null, SuiRpcError, SuiClient> {
+  const found = yield* getRecordingStreamingTranscodesByIds([recordingId], recordingStreamingTranscodePackageId);
+  return found[recordingId] ?? null;
+});
 
 /**
  * Read streaming-transcode Quilt ids for many Recordings in one Core request.
  * Missing and malformed fields are omitted, like master references.
  */
-export async function getRecordingStreamingTranscodesByIds(
-  client: ClientWithCoreApi,
+export function getRecordingStreamingTranscodesByIds(
   recordingIdsInput: readonly string[],
   recordingStreamingTranscodePackageId: string,
-): Promise<Partial<Record<string, string>>> {
+): Effect.Effect<Partial<Record<string, string>>, SuiRpcError, SuiClient> {
   return readSoftFields(
-    client,
     recordingIdsInput,
     (recordingId) => recordingStreamingTranscodeFieldId(recordingId, recordingStreamingTranscodePackageId),
     parseRecordingStreamingTranscodeContent,
@@ -309,30 +299,27 @@ export async function getRecordingStreamingTranscodesByIds(
  * parse each, dropping Recordings whose field is missing or malformed so one
  * stale extension cannot take a whole tracklist down.
  */
-async function readSoftFields<T>(
-  client: ClientWithCoreApi,
+const readSoftFields = Effect.fn("readSoftFields")(function* <T>(
   recordingIdsInput: readonly string[],
   fieldIdOf: (recordingId: string) => string,
   parse: (content: Uint8Array) => T,
-): Promise<Partial<Record<string, T>>> {
+): Effect.fn.Return<Partial<Record<string, T>>, SuiRpcError, SuiClient> {
   const recordingIds = [...new Set(recordingIdsInput)];
   if (recordingIds.length === 0) return {};
-  const { objects } = await client.core.getObjects({
-    objectIds: recordingIds.map(fieldIdOf),
-    include: { content: true },
-  });
+  const fieldIds = recordingIds.map(fieldIdOf);
+  const contentById = yield* getObjectsContent(fieldIds);
   const out: Partial<Record<string, T>> = {};
-  objects.forEach((object, index) => {
-    const recordingId = recordingIds[index];
-    if (!recordingId || object instanceof Error || !object.content) return;
+  recordingIds.forEach((recordingId, index) => {
+    const found = contentById.get(fieldIds[index]!);
+    if (!found) return;
     try {
-      out[recordingId] = parse(object.content);
+      out[recordingId] = parse(found.content);
     } catch {
       // Extension metadata is soft: retain valid tracks when one field is stale.
     }
   });
   return out;
-}
+});
 
 // ── Engine-session reads ─────────────────────────────────────────────────────
 
@@ -381,37 +368,25 @@ export function recordingEngineSessionFieldId(
 }
 
 /** Read one Recording's engine session, or null when none is attached. */
-export async function getRecordingEngineSession(
-  client: ClientWithCoreApi,
+export const getRecordingEngineSession = Effect.fn("getRecordingEngineSession")(function* (
   recordingId: string,
   recordingEngineSessionPackageId: string,
-): Promise<RecordingEngineSessionView | null> {
+): Effect.fn.Return<RecordingEngineSessionView | null, SuiRpcError, SuiClient> {
   const fieldId = recordingEngineSessionFieldId(recordingId, recordingEngineSessionPackageId);
-  const { objects } = await client.core.getObjects({
-    objectIds: [fieldId],
-    include: { content: true },
-  });
-  const field = objects[0];
-  if (!field) throw new Error("Recording engine-session read returned no result");
-  if (field instanceof Error) {
-    if (isNotFound(field)) return null;
-    throw field;
-  }
-  if (!field.content) throw new Error("Recording engine-session field is missing BCS content");
-  return parseRecordingEngineSessionContent(field.content);
-}
+  const found = yield* getOptionalObjectContent(fieldId);
+  if (Option.isNone(found)) return null;
+  return parseRecordingEngineSessionContent(found.value.content);
+});
 
 /**
  * Read engine sessions for many Recordings in one Core request. Missing and
  * malformed fields are omitted.
  */
-export async function getRecordingEngineSessionsByIds(
-  client: ClientWithCoreApi,
+export function getRecordingEngineSessionsByIds(
   recordingIdsInput: readonly string[],
   recordingEngineSessionPackageId: string,
-): Promise<Partial<Record<string, RecordingEngineSessionView>>> {
+): Effect.Effect<Partial<Record<string, RecordingEngineSessionView>>, SuiRpcError, SuiClient> {
   return readSoftFields(
-    client,
     recordingIdsInput,
     (recordingId) => recordingEngineSessionFieldId(recordingId, recordingEngineSessionPackageId),
     parseRecordingEngineSessionContent,
@@ -455,21 +430,13 @@ export function recordingMasterReferenceFieldId(
 }
 
 /** Read one Recording's master-reference blob id, or null when absent. */
-export async function getRecordingMasterReference(
-  client: ClientWithCoreApi,
+export const getRecordingMasterReference = Effect.fn("getRecordingMasterReference")(function* (
   recordingId: string,
   recordingMasterReferencePackageId: string,
-): Promise<string | null> {
-  return (
-    (
-      await getRecordingMasterReferencesByIds(
-        client,
-        [recordingId],
-        recordingMasterReferencePackageId,
-      )
-    )[recordingId] ?? null
-  );
-}
+): Effect.fn.Return<string | null, SuiRpcError, SuiClient> {
+  const found = yield* getRecordingMasterReferencesByIds([recordingId], recordingMasterReferencePackageId);
+  return found[recordingId] ?? null;
+});
 
 /**
  * Read master-reference blob ids for many Recordings in one Core request.
@@ -477,34 +444,13 @@ export async function getRecordingMasterReference(
  * Missing fields and malformed individual objects are omitted so one Recording
  * without a playable master cannot make the rest of an album unplayable.
  */
-export async function getRecordingMasterReferencesByIds(
-  client: ClientWithCoreApi,
+export function getRecordingMasterReferencesByIds(
   recordingIdsInput: readonly string[],
   recordingMasterReferencePackageId: string,
-): Promise<Partial<Record<string, string>>> {
-  const recordingIds = [...new Set(recordingIdsInput)];
-  const targets = recordingIds.map((recordingId) => ({
-    recordingId,
-    fieldId: recordingMasterReferenceFieldId(
-      recordingId,
-      recordingMasterReferencePackageId,
-    ),
-  }));
-  if (targets.length === 0) return {};
-
-  const { objects } = await client.core.getObjects({
-    objectIds: targets.map((target) => target.fieldId),
-    include: { content: true },
-  });
-  const out: Partial<Record<string, string>> = {};
-  objects.forEach((object, index) => {
-    const target = targets[index];
-    if (!target || object instanceof Error || !object.content) return;
-    try {
-      out[target.recordingId] = parseRecordingMasterReferenceContent(object.content);
-    } catch {
-      // Extension metadata is soft: retain valid tracks when one field is stale.
-    }
-  });
-  return out;
+): Effect.Effect<Partial<Record<string, string>>, SuiRpcError, SuiClient> {
+  return readSoftFields(
+    recordingIdsInput,
+    (recordingId) => recordingMasterReferenceFieldId(recordingId, recordingMasterReferencePackageId),
+    parseRecordingMasterReferenceContent,
+  );
 }

package/src/release-extensions.ts

@@ -5,7 +5,6 @@
 // intent aggregates these concerns, but every value is written by its own
 // independently deployed extension package.
 
-import type { ClientWithCoreApi } from "@mysten/sui/client";
 import { bcs } from "@mysten/sui/bcs";
 import { deriveDynamicFieldID } from "@mysten/sui/utils";
 import type {
@@ -13,6 +12,8 @@ import type {
   TransactionArgument,
   TransactionObjectArgument,
 } from "@mysten/sui/transactions";
+import { Effect, Option } from "effect";
+import { getOptionalObjectContent, type SuiClient, type SuiRpcError } from "@misofm/effect";
 import type { TxThunk } from "./transactions.ts";
 import * as releaseDescription from "./contracts/release_description/release_description.ts";
 import * as releaseDspLink from "./contracts/release_dsp_link/release_dsp_link.ts";
@@ -86,19 +87,13 @@ export function parseReleaseKindContent(content: Uint8Array): string {
 }
 
 /** Read a Release's self-declared kind, or `null` when the extension is absent. */
-export async function getReleaseKind(
-  client: ClientWithCoreApi,
+export const getReleaseKind = Effect.fn("getReleaseKind")(function* (
   releaseId: string,
   releaseKindPackageId: string,
-): Promise<string | null> {
-  const { objects } = await client.core.getObjects({
-    objectIds: [releaseKindFieldId(releaseId, releaseKindPackageId)],
-    include: { content: true },
-  });
-  const object = objects[0];
-  if (!object || object instanceof Error || !object.content) return null;
-  return parseReleaseKindContent(object.content);
-}
+): Effect.fn.Return<string | null, SuiRpcError, SuiClient> {
+  const found = yield* getOptionalObjectContent(releaseKindFieldId(releaseId, releaseKindPackageId));
+  return Option.isNone(found) ? null : parseReleaseKindContent(found.value.content);
+});
 
 export type SetReleaseDescriptionParams = ReleaseExtensionTarget & {
   description: string;