@miso.ai/server-sdk 0.6.6-beta.13 → 0.6.6-beta.14

package/cli/index.js

@@ -47,29 +47,12 @@ const users = {
     .command(status('users')),
 };
 
-const experiments = {
-  command: 'experiments',
-  aliases: ['experiment'],
-  description: 'Experiment commands',
-  builder: yargs => buildForApi(yargs)
-    .option('experiment-id', {
-      alias: ['exp-id'],
-      describe: 'Experiment ID for experiment API',
-    })
-    .command({
-      command: 'events',
-      builder: yargs => yargs
-        .command(upload('experiment-events')),
-    }),
-};
-
 yargs.build(yargs => {
   yargs
     .env('MISO')
     .command(interactions)
     .command(products)
     .command(users)
-    .command(experiments)
     .command(transform)
     .command(mergeLocal)
     .command(search)

package/cli/utils.js

@@ -17,7 +17,7 @@ export function buildForApi(yargs) {
     .option('param', {
       alias: ['v', 'var'],
       describe: 'Extra URL parameters',
-      type: 'array',
+      type: 'string',
       coerce: _yargs.coerceToArray,
     })
     .option('debug', {

package/package.json

@@ -16,12 +16,12 @@
     "simonpai <simon.pai@askmiso.com>"
   ],
   "dependencies": {
-    "@miso.ai/server-commons": "0.6.6-beta.13",
+    "@miso.ai/server-commons": "0.6.6-beta.14",
     "axios": "^1.6.2",
     "axios-retry": "^4.5.0",
     "dotenv": "^16.0.1",
     "split2": "^4.1.0",
     "yargs": "^17.5.1"
   },
-  "version": "0.6.6-beta.13"
+  "version": "0.6.6-beta.14"
 }

package/src/api/helpers.js

@@ -14,12 +14,15 @@ export async function upload(client, type, records, options = {}) {
 }
 
 async function recoverValidRecords(client, type, records, options, response) {
-  if (!response || response.status !== 422 || !options.recoverValidRecordsOn422) {
+  if (!response || response.status !== 422) {
     return;
   }
   records = extractRecordsFromUploadPayload(records);
   // try to collect valid records and resend them, which should pass the validation
-  const { groups = [], unrecognized = [] } = process422ResponseBody(records, response.data); // it takes records too
+  const { groups = [], unrecognized = [] } = response.issues = process422ResponseBody(records, response.data); // it takes records too
+  if (!options.recoverValidRecordsOn422) {
+    return; // still write issues to response
+  }
   if (groups.length === 0 || groups.length === records.length || unrecognized.length > 0) {
     // if there are unrecognized messages, it's hard to tell which records are valid
     return;

package/src/api/index.js

@@ -1,7 +1,6 @@
 import Products from './products.js';
 import Users from './users.js';
 import Interactions from './interactions.js';
-import Experiments from './experiments.js';
 import Ask from './ask.js';
 import Search from './search.js';
 import Recommendation from './recommendation.js';
@@ -12,7 +11,6 @@ export default class Api {
     this.products = new Products(client);
     this.users = new Users(client);
     this.interactions = new Interactions(client);
-    this.experiments = new Experiments(client);
     this.ask = new Ask(client);
     this.search = new Search(client);
     this.recommendation = new Recommendation(client);

package/src/stream/api-sink.js

@@ -62,6 +62,9 @@ export default class ApiSink extends sink.BpsSink {
       if (error.response.recovered) {
         data.recovered = error.response.recovered;
       }
+      if (error.response.issues) {
+        data.issues = error.response.issues;
+      }
     }
 
     // keep track of service stats on successful calls

package/src/stream/upload-sink.js

@@ -28,28 +28,12 @@ class UploadSink extends ApiSink {
 
 }
 
-class ExperimentEventUploadSink extends UploadSink {
-
-  constructor(client, options) {
-    super(client, { ...options, type: 'experiment-events' });
-  }
-
-  async _execute(payload) {
-    const { experimentId } = this._options;
-    const { data } = await this._client.api.experiments.uploadEvent(experimentId, payload);
-    return data;
-  }
-
-}
-
 export default function create(client, type, options) {
   switch (type) {
     case 'users':
     case 'products':
     case 'interactions':
       return new UploadSink(client, { ...options, type });
-    case 'experiment-events':
-      return new ExperimentEventUploadSink(client, options);
     default:
       throw new Error(`Unrecognized type: ${type}`);
   }

package/src/stream/upload.js

@@ -2,7 +2,6 @@ import { stream } from '@miso.ai/server-commons';
 import version from '../version.js';
 import createSink from './upload-sink.js';
 import createBuffer from './upload-buffer.js';
-import { process422ResponseBody } from '../api/helpers.js';
 
 export default class UploadStream extends stream.BufferedWriteStream {
 
@@ -67,13 +66,12 @@ export default class UploadStream extends stream.BufferedWriteStream {
 
     // if upload fails, emit extracted payload at response event
     if (message.event === 'response') {
-      // TODO: we can do these near recoverValidRecords()
       const { response, payload } = args;
       if (payload) {
         output.payload = JSON.parse(payload);
-        if (response && response.status === 422) {
-          output.issues = process422ResponseBody(payload, response);
-        }
+      }
+      if (response && response.issues) {
+        output.issues = response.issues;
       }
     }
 

package/src/version.js

@@ -1 +1 @@
-export default '0.6.6-beta.13';
+export default '0.6.6-beta.14';

package/src/api/experiments.js

@@ -1,19 +0,0 @@
-import { buildUrl } from './helpers.js';
-
-export default class Experiments {
-
-  constructor(client) {
-    this._client = client;
-  }
-
-  async uploadEvent(experimentId, record) {
-    // TODO: support non-string record
-    const url = buildUrl(this._client, `experiments/${experimentId}/events`);
-    // TODO: make content type header global
-    const headers = { 'Content-Type': 'application/json' };
-    const response = await this._client._axios.post(url, record, { headers });
-    // 200 response body does not have .data layer
-    return response.data ? response : { data: response };
-  }
-
-}