@miqro/core 1.5.13 → 1.5.16

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (55) hide show
  1. package/dist/api-router.d.ts +6 -5
  2. package/dist/api-router.js +9 -3
  3. package/dist/api-router.js.map +1 -1
  4. package/dist/app-utils.d.ts +13 -0
  5. package/dist/app-utils.js +82 -0
  6. package/dist/app-utils.js.map +1 -0
  7. package/dist/app.js +6 -88
  8. package/dist/app.js.map +1 -1
  9. package/dist/common/api-router-utils.d.ts +1 -1
  10. package/dist/common/api-router-utils.js +4 -3
  11. package/dist/common/api-router-utils.js.map +1 -1
  12. package/dist/common/context.js +4 -1
  13. package/dist/common/context.js.map +1 -1
  14. package/dist/common/router-handler.d.ts +20 -0
  15. package/dist/common/router-handler.js +136 -0
  16. package/dist/common/router-handler.js.map +1 -0
  17. package/dist/common/router-utils.d.ts +7 -5
  18. package/dist/common/router-utils.js +37 -47
  19. package/dist/common/router-utils.js.map +1 -1
  20. package/dist/common/session/common.d.ts +5 -2
  21. package/dist/common/tokenize-match.d.ts +13 -20
  22. package/dist/common/tokenize-match.js +25 -57
  23. package/dist/common/tokenize-match.js.map +1 -1
  24. package/dist/middleware/group.js +2 -0
  25. package/dist/middleware/group.js.map +1 -1
  26. package/dist/middleware/index.d.ts +1 -0
  27. package/dist/middleware/index.js +1 -0
  28. package/dist/middleware/index.js.map +1 -1
  29. package/dist/middleware/result.d.ts +3 -0
  30. package/dist/middleware/result.js +51 -0
  31. package/dist/middleware/result.js.map +1 -0
  32. package/dist/router.d.ts +3 -30
  33. package/dist/router.js +5 -167
  34. package/dist/router.js.map +1 -1
  35. package/package.json +8 -6
  36. package/src/api-router.ts +16 -7
  37. package/src/api-router.unit.test.js +273 -0
  38. package/src/app-utils.ts +82 -0
  39. package/src/app-utils.unit.test.js +100 -0
  40. package/src/app.ts +4 -89
  41. package/src/app.unit.test.js +334 -0
  42. package/src/common/api-router-utils.ts +3 -3
  43. package/src/common/context.ts +4 -1
  44. package/src/common/context.unit.test.js +286 -0
  45. package/src/common/router-handler.ts +159 -0
  46. package/src/common/router-utils.ts +46 -44
  47. package/src/common/session/common.ts +5 -2
  48. package/src/common/tokenize-match.ts +30 -52
  49. package/src/middleware/group.ts +2 -0
  50. package/src/middleware/index.ts +1 -0
  51. package/src/middleware/result.ts +43 -0
  52. package/src/proxy.unit.test.js +157 -0
  53. package/src/router.ts +7 -196
  54. package/src/router.unit.test.js +397 -0
  55. package/src/setup-test.js +5 -0
@@ -0,0 +1,100 @@
1
+ const {fake, requireMock} = require("@miqro/test");
2
+ const {resolve} = require("path");
3
+ const {strictEqual} = require("assert");
4
+ const {distPath} = require("./setup-test.js");
5
+ const {ForbiddenError, NotFoundError, MethodNotImplementedError, UnAuthorizedError, BadRequestError} = require("../dist");
6
+ const {ParseOptionsError} = require("@miqro/parser");
7
+
8
+ const testFilePath = resolve(distPath, "app-utils.js");
9
+
10
+ describe("app-utils unit tests", () => {
11
+ describe("defaultAppErrorHandler", () => {
12
+ [{err: new Error("some error")}, {err: undefined}, {err: null}, {err: false}, {err: ""}, {err: true}].forEach(({err}) => {
13
+ [{env: "test"}, {env: "development"}, {env: "OTHER"}].forEach(({env}) => {
14
+ describe("NODE_ENV=" + env, () => {
15
+ const oldNODE_ENV = process.env.NODE_ENV;
16
+
17
+ before(() => {
18
+ process.env.NODE_ENV = env;
19
+ });
20
+ after(() => {
21
+ process.env.NODE_ENV = oldNODE_ENV;
22
+ });
23
+
24
+ it("error is " + err + " ends only on test and development", async () => {
25
+ const context = {
26
+ headersSent: false,
27
+ logger: {
28
+ error: fake(() => {
29
+
30
+ })
31
+ },
32
+ end: fake(() => {
33
+ if (context.headersSent) {
34
+ throw new Error("double end");
35
+ }
36
+ context.headersSent = true;
37
+ })
38
+ };
39
+ const {defaultAppErrorHandler} = requireMock(testFilePath, {
40
+ "./common": {},
41
+ }, distPath);
42
+ const handler = defaultAppErrorHandler();
43
+ await handler(err, context);
44
+ if (env === "OTHER") {
45
+ strictEqual(context.end.callCount, 0);
46
+ strictEqual(context.logger.error.callCount, 1);
47
+ strictEqual(context.logger.error.callArgs[0][0], err);
48
+ } else {
49
+ strictEqual(context.end.callCount, 1);
50
+ strictEqual(context.end.callArgs[0][0].status, 503);
51
+ strictEqual(context.end.callArgs[0][0].headers["Content-Type"], "text/html; charset=utf-8");
52
+ strictEqual(context.end.callArgs[0][0].body.indexOf("You are seeing this message") !== -1, true);
53
+ strictEqual(context.logger.error.callCount, 1);
54
+ strictEqual(context.logger.error.callArgs[0][0], err);
55
+ }
56
+ });
57
+ });
58
+ });
59
+ });
60
+ [
61
+ {err: {name: "ConfigFileNotFoundError"}, res: {status: 503}},
62
+ {err: {name: "SequelizeUniqueConstraintError"}, res: {status: 400}},
63
+ {err: {name: "SequelizeEagerLoadingError"}, res: {status: 400}},
64
+ {err: {name: "SequelizeValidationError"}, res: {status: 400}},
65
+ {err: new ParseOptionsError(), res: {status: 400}},
66
+ {err: new BadRequestError(), res: {status: 400}},
67
+ {err: new UnAuthorizedError(), res: {status: 401}},
68
+ {err: new ForbiddenError(), res: {status: 403}},
69
+ {err: new MethodNotImplementedError(), res: {status: 501}},
70
+ {err: new NotFoundError(), res: {status: 404}}
71
+ ].forEach(({err, res}) => {
72
+ it("error is " + err.name + " sends " + res.status, async () => {
73
+ const context = {
74
+ headersSent: false,
75
+ logger: {
76
+ error: fake(() => {
77
+
78
+ })
79
+ },
80
+ end: fake(() => {
81
+ if (context.headersSent) {
82
+ throw new Error("double end");
83
+ }
84
+ context.headersSent = true;
85
+ })
86
+ };
87
+ const {defaultAppErrorHandler} = requireMock(testFilePath, {
88
+ "./common": {},
89
+ }, distPath);
90
+ const handler = defaultAppErrorHandler();
91
+ await handler(err, context);
92
+ strictEqual(context.end.callCount, 1);
93
+ strictEqual(context.end.callArgs[0][0].status, res.status);
94
+ strictEqual(context.end.callArgs[0][0].headers["Content-Type"], "text/html; charset=utf-8");
95
+ strictEqual(context.logger.error.callCount, 1);
96
+ strictEqual(context.logger.error.callArgs[0][0], err);
97
+ });
98
+ })
99
+ });
100
+ });
package/src/app.ts CHANGED
@@ -1,14 +1,15 @@
1
1
  import {createServer, RequestListener, Server} from "http";
2
2
  import {v4} from "uuid";
3
- import {Context, defaultLoggerFactory, ErrorHandler} from "./common";
3
+ import {Context, defaultLoggerFactory} from "./common";
4
4
  import {Router, RouterOptions} from "./router";
5
+ import {defaultAppErrorHandler, HTML_HEADERS, STATUS} from "./app-utils";
5
6
 
6
7
  export class App extends Router {
7
8
  public readonly listener: RequestListener;
8
9
 
9
10
  constructor(config?: RouterOptions) {
10
11
  super(config);
11
- const errorHandler = DefaultErrorHandler();
12
+ const errorHandler = defaultAppErrorHandler();
12
13
  const loggerFactory = this.config && this.config.loggerFactory ? this.config.loggerFactory : defaultLoggerFactory;
13
14
  this.listener = async (req, res) => {
14
15
  const uuid = v4().toString();
@@ -31,7 +32,7 @@ export class App extends Router {
31
32
  if (!ctx.res.headersSent) {
32
33
  ctx.logger.error(e);
33
34
  await ctx.end({
34
- headers: TEXT_HEADERS,
35
+ headers: HTML_HEADERS,
35
36
  status: STATUS.ERROR,
36
37
  body: "SERVER ERROR"
37
38
  });
@@ -48,89 +49,3 @@ export class App extends Router {
48
49
  return createServer(this.listener).listen(...args)
49
50
  }
50
51
  }
51
-
52
- const TEXT_HEADERS = {
53
- ["Content-Type"]: "plain/text; charset=utf-8"
54
- }
55
-
56
- const HTML_HEADERS = {
57
- ["Content-Type"]: "text/html; charset=utf-8"
58
- }
59
-
60
- const STATUS = {
61
- ERROR: 503,
62
- BAD_REQUEST: 400,
63
- NOT_FOUND: 404,
64
- NOT_IMPLEMENTED: 501,
65
- FORBIDDEN: 403,
66
- UNAUTHORIZED: 401,
67
- };
68
-
69
- const DefaultErrorHandler = (): ErrorHandler<boolean> => {
70
- return async (e: any, ctx: Context): Promise<boolean> => {
71
- if (!e || !e.name || e.name === "Error") {
72
- if (process.env.NODE_ENV === "development" || process.env.NODE_ENV === "test") {
73
- ctx.logger.error(e);
74
- await ctx.end({
75
- headers: TEXT_HEADERS,
76
- status: STATUS.ERROR,
77
- body: `${e && e.message ? e.message : String(e)}. You are seeing this message because NODE_ENV === "development" || NODE_ENV === "test"${e && e.stack ? ` ${e.stack}` : ""}`
78
- });
79
- return false;
80
- }
81
- } else {
82
- ctx.logger.error(e);
83
- const name = e && e.name ? e.name : undefined;
84
- switch (name) {
85
- case "NotFoundError":
86
- await ctx.end({
87
- headers: HTML_HEADERS,
88
- status: STATUS.NOT_FOUND,
89
- body: e.message ? e.message : "NOT FOUND"
90
- });
91
- break;
92
- case "MethodNotImplementedError":
93
- await ctx.end({
94
- headers: HTML_HEADERS,
95
- status: STATUS.NOT_IMPLEMENTED,
96
- body: e.message ? e.message : "NOT IMPLEMENTED"
97
- });
98
- break;
99
- case "ForbiddenError":
100
- await ctx.end({
101
- headers: HTML_HEADERS,
102
- status: STATUS.FORBIDDEN,
103
- body: e.message ? e.message : "FORBIDDEN"
104
- });
105
- break;
106
- case "UnAuthorizedError":
107
- await ctx.end({
108
- headers: HTML_HEADERS,
109
- status: STATUS.UNAUTHORIZED,
110
- body: e.message ? e.message : "UNAUTHORIZED"
111
- });
112
- break;
113
- case "ParseOptionsError":
114
- case "BadRequestError":
115
- case "SequelizeValidationError":
116
- case "SequelizeEagerLoadingError":
117
- case "SequelizeUniqueConstraintError":
118
- await ctx.end({
119
- headers: HTML_HEADERS,
120
- status: STATUS.BAD_REQUEST,
121
- body: e.message ? e.message : "BAD REQUEST"
122
- });
123
- break;
124
- default:
125
- await ctx.end({
126
- headers: HTML_HEADERS,
127
- status: STATUS.ERROR,
128
- body: e.message ? e.message : "SERVER ERROR"
129
- });
130
- break;
131
- }
132
- return false;
133
- }
134
- return true;
135
- };
136
- };
@@ -0,0 +1,334 @@
1
+ const {fake, requireMock} = require("@miqro/test");
2
+ const {resolve} = require("path");
3
+ const {strictEqual} = require("assert");
4
+ const {distPath} = require("./setup-test.js");
5
+
6
+ const testFilePath = resolve(distPath, "app.js");
7
+
8
+ describe("app unit tests", () => {
9
+ describe("this.listen", () => {
10
+ it("happy path", () => {
11
+ const defaultAppErrorHandler = fake(() => {
12
+ });
13
+ const fakeServer = {
14
+ listen: fake(() => {
15
+
16
+ })
17
+ };
18
+ const createServer = fake(() => {
19
+ return fakeServer;
20
+ });
21
+ const {App} = requireMock(testFilePath, {
22
+ "http": {
23
+ createServer
24
+ },
25
+ "uuid": {},
26
+ "./common": {},
27
+ "./router": {
28
+ Router: class {
29
+
30
+ }
31
+ },
32
+ "./app-utils": {
33
+ defaultAppErrorHandler
34
+ }
35
+ }, distPath);
36
+ const app = new App();
37
+ strictEqual(defaultAppErrorHandler.callCount, 1);
38
+ strictEqual(createServer.callCount, 0);
39
+ app.listen(8080);
40
+ strictEqual(createServer.callCount, 1);
41
+ strictEqual(createServer.callArgs[0][0], app.listener);
42
+ strictEqual(fakeServer.listen.callCount, 1);
43
+ strictEqual(fakeServer.listen.callArgs[0][0], 8080);
44
+ });
45
+ });
46
+ describe("this.listener", () => {
47
+ it("run doesnt send response should send 404", async () => {
48
+
49
+ const v4Ret = "v4Ret";
50
+
51
+ const fakeLogger = {
52
+ trace: fake(() => {
53
+
54
+ })
55
+ };
56
+
57
+ const fakeReq = {};
58
+
59
+ const fakeRes = {}
60
+
61
+ const defaultAppErrorHandler = fake(() => {
62
+ });
63
+
64
+ const v4 = fake(() => {
65
+ return v4Ret;
66
+ });
67
+
68
+ const defaultLoggerFactory = fake(() => {
69
+ return fakeLogger;
70
+ });
71
+
72
+ const routerRun = fake(() => {
73
+ });
74
+
75
+ const ctxEnd = fake(() => {
76
+
77
+ });
78
+
79
+ class Context {
80
+ constructor(uuid, req, res, logger) {
81
+ this.uuid = uuid;
82
+ this.req = req;
83
+ this.res = res;
84
+ this.logger = logger;
85
+ }
86
+
87
+ end() {
88
+ if (this.res.headersSent) {
89
+ throw new Error("cannot double end res");
90
+ }
91
+ this.res.headersSent = true;
92
+ return ctxEnd(...arguments);
93
+ }
94
+ }
95
+
96
+ const {App} = requireMock(testFilePath, {
97
+ "http": {},
98
+ "uuid": {
99
+ v4
100
+ },
101
+ "./common": {
102
+ defaultLoggerFactory,
103
+ Context
104
+ },
105
+ "./router": {
106
+ Router: class {
107
+ run() {
108
+ return routerRun(...arguments);
109
+ }
110
+ }
111
+ },
112
+ "./app-utils": {
113
+ defaultAppErrorHandler,
114
+ HTML_HEADERS: "HTML_HEADERS",
115
+ STATUS: {
116
+ NOT_FOUND: "NOT_FOUND"
117
+ }
118
+ }
119
+ }, distPath);
120
+ const app = new App();
121
+ strictEqual(defaultAppErrorHandler.callCount, 1);
122
+ const ret = await app.listener(fakeReq, fakeRes);
123
+ strictEqual(ret, undefined);
124
+ strictEqual(routerRun.callCount, 1);
125
+ strictEqual(routerRun.callArgs[0][0] instanceof Context, true);
126
+ strictEqual(routerRun.callArgs[0][0].res, fakeRes);
127
+ strictEqual(routerRun.callArgs[0][0].req, fakeReq);
128
+ strictEqual(routerRun.callArgs[0][0].uuid, v4Ret);
129
+ strictEqual(routerRun.callArgs[0][0].logger, fakeLogger);
130
+ strictEqual(ctxEnd.callCount, 1);
131
+ strictEqual(ctxEnd.callArgs[0][0].status, "NOT_FOUND");
132
+ strictEqual(ctxEnd.callArgs[0][0].body, "NOT FOUND");
133
+ strictEqual(ctxEnd.callArgs[0][0].headers, "HTML_HEADERS");
134
+ });
135
+
136
+ it("run throws and defaultErrorHandler send response", async () => {
137
+ const v4Ret = "v4Ret";
138
+
139
+ const fakeLogger = {
140
+ trace: fake(() => {
141
+
142
+ })
143
+ };
144
+
145
+ const fakeReq = {};
146
+
147
+ const fakeRes = {}
148
+
149
+ const errorHandler = fake(async (e, ctx) => {
150
+ await ctx.end("fakeEnd");
151
+ });
152
+
153
+ const defaultAppErrorHandler = fake(() => {
154
+ return errorHandler;
155
+ });
156
+
157
+ const v4 = fake(() => {
158
+ return v4Ret;
159
+ });
160
+
161
+ const defaultLoggerFactory = fake(() => {
162
+ return fakeLogger;
163
+ });
164
+
165
+ const routerRun = fake(() => {
166
+ throw new Error("routerRunError");
167
+ });
168
+
169
+ const ctxEnd = fake(() => {
170
+
171
+ });
172
+
173
+ class Context {
174
+ constructor(uuid, req, res, logger) {
175
+ this.uuid = uuid;
176
+ this.req = req;
177
+ this.res = res;
178
+ this.logger = logger;
179
+ }
180
+
181
+ end() {
182
+ if (this.res.headersSent) {
183
+ throw new Error("cannot double end res");
184
+ }
185
+ this.res.headersSent = true;
186
+ return ctxEnd(...arguments);
187
+ }
188
+ }
189
+
190
+ const {App} = requireMock(testFilePath, {
191
+ "http": {},
192
+ "uuid": {
193
+ v4
194
+ },
195
+ "./common": {
196
+ defaultLoggerFactory,
197
+ Context
198
+ },
199
+ "./router": {
200
+ Router: class {
201
+ run() {
202
+ return routerRun(...arguments);
203
+ }
204
+ }
205
+ },
206
+ "./app-utils": {
207
+ defaultAppErrorHandler
208
+ }
209
+ }, distPath);
210
+ const app = new App();
211
+ strictEqual(defaultAppErrorHandler.callCount, 1);
212
+ const ret = await app.listener(fakeReq, fakeRes);
213
+ strictEqual(errorHandler.callCount, 1);
214
+ strictEqual(errorHandler.callArgs[0][0].message, "routerRunError");
215
+ strictEqual(errorHandler.callArgs[0][1] instanceof Context, true);
216
+ strictEqual(errorHandler.callArgs[0][1].res, fakeRes);
217
+ strictEqual(errorHandler.callArgs[0][1].req, fakeReq);
218
+ strictEqual(errorHandler.callArgs[0][1].uuid, v4Ret);
219
+ strictEqual(errorHandler.callArgs[0][1].logger, fakeLogger);
220
+ strictEqual(ret, undefined);
221
+ strictEqual(routerRun.callCount, 1);
222
+ strictEqual(routerRun.callArgs[0][0] instanceof Context, true);
223
+ strictEqual(routerRun.callArgs[0][0].res, fakeRes);
224
+ strictEqual(routerRun.callArgs[0][0].req, fakeReq);
225
+ strictEqual(routerRun.callArgs[0][0].uuid, v4Ret);
226
+ strictEqual(routerRun.callArgs[0][0].logger, fakeLogger);
227
+ strictEqual(ctxEnd.callCount, 1);
228
+ strictEqual(ctxEnd.callArgs[0][0], "fakeEnd");
229
+ });
230
+
231
+ it("run throws and defaultErrorHandler doesn't send response", async () => {
232
+ const v4Ret = "v4Ret";
233
+
234
+ const fakeLogger = {
235
+ trace: fake(() => {
236
+
237
+ }),
238
+ error: fake(() => {
239
+
240
+ })
241
+ };
242
+
243
+ const fakeReq = {};
244
+
245
+ const fakeRes = {}
246
+
247
+ const errorHandler = fake(async (e, ctx) => {
248
+ });
249
+
250
+ const defaultAppErrorHandler = fake(() => {
251
+ return errorHandler;
252
+ });
253
+
254
+ const v4 = fake(() => {
255
+ return v4Ret;
256
+ });
257
+
258
+ const defaultLoggerFactory = fake(() => {
259
+ return fakeLogger;
260
+ });
261
+
262
+ const routerRun = fake(() => {
263
+ throw new Error("routerRunError");
264
+ });
265
+
266
+ const ctxEnd = fake(() => {
267
+
268
+ });
269
+
270
+ class Context {
271
+ constructor(uuid, req, res, logger) {
272
+ this.uuid = uuid;
273
+ this.req = req;
274
+ this.res = res;
275
+ this.logger = logger;
276
+ }
277
+
278
+ end() {
279
+ if (this.res.headersSent) {
280
+ throw new Error("cannot double end res");
281
+ }
282
+ this.res.headersSent = true;
283
+ return ctxEnd(...arguments);
284
+ }
285
+ }
286
+
287
+ const {App} = requireMock(testFilePath, {
288
+ "http": {},
289
+ "uuid": {
290
+ v4
291
+ },
292
+ "./common": {
293
+ defaultLoggerFactory,
294
+ Context
295
+ },
296
+ "./router": {
297
+ Router: class {
298
+ run() {
299
+ return routerRun(...arguments);
300
+ }
301
+ }
302
+ },
303
+ "./app-utils": {
304
+ defaultAppErrorHandler,
305
+ HTML_HEADERS: "HTML_HEADERS",
306
+ STATUS: {
307
+ ERROR: "ERROR"
308
+ }
309
+ }
310
+ }, distPath);
311
+ const app = new App();
312
+ strictEqual(defaultAppErrorHandler.callCount, 1);
313
+ const ret = await app.listener(fakeReq, fakeRes);
314
+ strictEqual(errorHandler.callCount, 1);
315
+ strictEqual(errorHandler.callArgs[0][0].message, "routerRunError");
316
+ strictEqual(errorHandler.callArgs[0][1] instanceof Context, true);
317
+ strictEqual(errorHandler.callArgs[0][1].res, fakeRes);
318
+ strictEqual(errorHandler.callArgs[0][1].req, fakeReq);
319
+ strictEqual(errorHandler.callArgs[0][1].uuid, v4Ret);
320
+ strictEqual(errorHandler.callArgs[0][1].logger, fakeLogger);
321
+ strictEqual(ret, undefined);
322
+ strictEqual(routerRun.callCount, 1);
323
+ strictEqual(routerRun.callArgs[0][0] instanceof Context, true);
324
+ strictEqual(routerRun.callArgs[0][0].res, fakeRes);
325
+ strictEqual(routerRun.callArgs[0][0].req, fakeReq);
326
+ strictEqual(routerRun.callArgs[0][0].uuid, v4Ret);
327
+ strictEqual(routerRun.callArgs[0][0].logger, fakeLogger);
328
+ strictEqual(ctxEnd.callCount, 1);
329
+ strictEqual(ctxEnd.callArgs[0][0].status, "ERROR");
330
+ strictEqual(ctxEnd.callArgs[0][0].headers, "HTML_HEADERS");
331
+ strictEqual(ctxEnd.callArgs[0][0].body, "SERVER ERROR");
332
+ });
333
+ });
334
+ });
@@ -26,11 +26,11 @@ export const APIRouteValidator: ParseOptionMap = {
26
26
  handler: "function[]!"
27
27
  };
28
28
 
29
- export const traverseAPIRouteDir = (
29
+ export function traverseAPIRouteDir(
30
30
  featureName: string,
31
31
  dirname: string,
32
32
  basePath = "/",
33
- features: FeatureRouterOptions = {}, logger?: Logger): FeatureRouterOptions => {
33
+ features: FeatureRouterOptions = {}, logger?: Logger): FeatureRouterOptions {
34
34
  if (logger) {
35
35
  logger.trace("loading routes from [%s]", dirname);
36
36
  }
@@ -203,4 +203,4 @@ export const FeatureRouter = (options: FeatureRouterOptions, logger?: Logger): R
203
203
  }
204
204
  }
205
205
  return router;
206
- };
206
+ }
@@ -71,7 +71,7 @@ export class Context {
71
71
  const current = c ? c instanceof Array ? c.join(", ") : String(c) : "";
72
72
  const nV = value instanceof Array ? value.join(", ") : String(value);
73
73
  const newValue = current ? `${current}, ${nV}` : nV;
74
- return this.res.setHeader("Vary", newValue.indexOf("*") !== -1 ? "*" : newValue);
74
+ return this.setHeader("Vary", newValue.indexOf("*") !== -1 ? "*" : newValue);
75
75
  }
76
76
 
77
77
  public setHeader(name: string, value: number | string | ReadonlyArray<string>): ServerResponse {
@@ -87,6 +87,9 @@ export class Context {
87
87
  status: number;
88
88
  headers: OutgoingHttpHeaders;
89
89
  }): Promise<void> {
90
+ if (this.res.headersSent) {
91
+ return Promise.reject(new Error("already ended"));
92
+ }
90
93
  return new Promise<void>((resolve, reject) => {
91
94
  try {
92
95
  if (this.res.headersSent) {