@miphamai/cli 0.16.0 → 0.16.1

package/src/core/engine.ts

@@ -277,6 +277,7 @@ export class QueryEngine {
 
     // ── PreInference DLP checkpoint ──
     if (isInferenceHookEnabled(this.inferenceHookConfig)) {
+      const hookConfig = this.inferenceHookConfig!
       const provider = this.registry.getActive().config.id
       const model = this.registry.getActiveModel()
       const request = buildRequest(
@@ -284,9 +285,9 @@ export class QueryEngine {
         'session-1',
         provider,
         model,
-        this.inferenceHookConfig!.organization_id,
+        hookConfig.organization_id,
       )
-      const verdict = await sendInferenceCheck(this.inferenceHookConfig!, request)
+      const verdict = await sendInferenceCheck(hookConfig, request)
       if (!verdict.allowed) {
         yield {
           type: 'error',
@@ -556,6 +557,7 @@ export class QueryEngine {
 
       // ── PreInference DLP checkpoint (every tool-calling turn) ──
       if (isInferenceHookEnabled(this.inferenceHookConfig)) {
+        const hookConfig = this.inferenceHookConfig!
         const provider = this.registry.getActive().config.id
         const model = this.registry.getActiveModel()
         const request = buildRequest(
@@ -563,9 +565,9 @@ export class QueryEngine {
           'session-1',
           provider,
           model,
-          this.inferenceHookConfig!.organization_id,
+          hookConfig.organization_id,
         )
-        const verdict = await sendInferenceCheck(this.inferenceHookConfig!, request)
+        const verdict = await sendInferenceCheck(hookConfig, request)
         if (!verdict.allowed) {
           yield {
             type: 'error',
@@ -826,9 +828,8 @@ export class QueryEngine {
       const model = this.registry.findModel(modelId)
       if (model) {
         const DISABLE_1M = process.env.MIPHAM_DISABLE_1M_CONTEXT === '1'
-        const maxTokens = (DISABLE_1M && model.contextWindow > 200_000)
-          ? 200_000
-          : model.contextWindow
+        const maxTokens =
+          DISABLE_1M && model.contextWindow > 200_000 ? 200_000 : model.contextWindow
         this.context.updateMaxTokens(maxTokens)
       }
     }

package/src/core/permission.ts

@@ -139,6 +139,11 @@ export class PermissionSystem {
    * 8. System default → 'ask'
    */
   check(tool: ToolDefinition, input: Record<string, unknown>): PermissionLevel {
+    // ── Guard: reject undefined/null tool (defense-in-depth) ──
+    if (!tool) {
+      return 'ask' // absent tool → safest default
+    }
+
     // ── Cache lookup (P2): reuse decision for same tool+mode+input ──
     const cacheKey = tool.name + '|' + JSON.stringify(input, Object.keys(input).sort())
     if (this.cacheMode === this.mode) {

package/src/core/session-store.ts

@@ -134,7 +134,10 @@ export class SessionStore {
   /**
    * Auto-save with timestamp-based name.
    */
-  static autoSave(messages: Message[], metadata?: { provider?: string; model?: string; cwd?: string }): string {
+  static autoSave(
+    messages: Message[],
+    metadata?: { provider?: string; model?: string; cwd?: string },
+  ): string {
     const name = `session-${new Date().toISOString().replace(/[:.]/g, '-').slice(0, 19)}`
     SessionStore.save(name, messages, metadata)
     return name

package/src/index.tsx

@@ -87,7 +87,8 @@ export async function runApp(options: RunOptions): Promise<void> {
   const pluginManager = new PluginManager()
 
   // Generate session name for tracking (used by /cd to persist cwd)
-  const sessionName = options.resume || `session-${new Date().toISOString().replace(/[:.]/g, '-').slice(0, 19)}`
+  const sessionName =
+    options.resume || `session-${new Date().toISOString().replace(/[:.]/g, '-').slice(0, 19)}`
 
   // Initialize context — restore saved session if available
   // Read the active model's context window for dynamic max-token sizing.
@@ -111,12 +112,12 @@ export async function runApp(options: RunOptions): Promise<void> {
   }
 
   const DISABLE_1M = process.env.MIPHAM_DISABLE_1M_CONTEXT === '1'
-  const contextMaxTokens = (DISABLE_1M && modelContextWindow > 200_000)
-    ? 200_000
-    : modelContextWindow
+  const contextMaxTokens = DISABLE_1M && modelContextWindow > 200_000 ? 200_000 : modelContextWindow
 
   if (DISABLE_1M && modelContextWindow <= 200_000) {
-    console.error('[mipham] ⚠ MIPHAM_DISABLE_1M_CONTEXT is set but auto-compaction is not holding the session to 200K — model context window is already ≤ 200K')
+    console.error(
+      '[mipham] ⚠ MIPHAM_DISABLE_1M_CONTEXT is set but auto-compaction is not holding the session to 200K — model context window is already ≤ 200K',
+    )
   }
 
   const context = new ContextManager({ maxTokens: contextMaxTokens, compactionThreshold: 0.9 })

package/src/skills/community-registry.json

@@ -0,0 +1,72 @@
+[
+  {
+    "name": "code-review",
+    "description": "Automated code review with multiple dimensions — complexity, security, performance, quality",
+    "url": "https://github.com/One-Mipham/skill-code-review",
+    "file": "code-review.SKILL.md",
+    "category": "Development",
+    "author": "MiphamAI",
+    "builtin": true
+  },
+  {
+    "name": "systematic-debugging",
+    "description": "Systematic debugging workflow — find root cause before fixing",
+    "url": "https://github.com/anthropics/skills",
+    "file": "systematic-debugging.SKILL.md",
+    "category": "Development",
+    "author": "Anthropic"
+  },
+  {
+    "name": "test-driven-development",
+    "description": "TDD workflow — write failing test first, then implement",
+    "url": "https://github.com/anthropics/skills",
+    "file": "test-driven-development.SKILL.md",
+    "category": "Development",
+    "author": "Anthropic",
+    "builtin": true
+  },
+  {
+    "name": "web-access",
+    "description": "Web search, scraping, and browser automation — search engines, page fetching, authenticated sites",
+    "url": "https://github.com/One-Mipham/skill-web-access",
+    "file": "web-access.SKILL.md",
+    "category": "Network",
+    "author": "MiphamAI",
+    "builtin": true
+  },
+  {
+    "name": "doc-generator",
+    "description": "Generate API docs, READMEs, and changelogs from code analysis",
+    "url": "https://github.com/One-Mipham/skill-doc-generator",
+    "file": "doc-generator.SKILL.md",
+    "category": "Documentation",
+    "author": "MiphamAI",
+    "builtin": true
+  },
+  {
+    "name": "github-ops",
+    "description": "GitHub PR/issue management and automation — labels, milestones, reviews",
+    "url": "https://github.com/One-Mipham/skill-github-ops",
+    "file": "github-ops.SKILL.md",
+    "category": "DevOps",
+    "author": "MiphamAI",
+    "builtin": true
+  },
+  {
+    "name": "security-review",
+    "description": "Security audit and vulnerability scanning for code changes — OWASP, secrets, supply chain",
+    "url": "https://github.com/One-Mipham/skill-security-review",
+    "file": "security-review.SKILL.md",
+    "category": "Security",
+    "author": "MiphamAI",
+    "builtin": true
+  },
+  {
+    "name": "frontend-design",
+    "description": "Distinctive visual design guidance for UI components — typography, color, layout",
+    "url": "https://github.com/anthropics/skills",
+    "file": "frontend-design.SKILL.md",
+    "category": "Design",
+    "author": "Anthropic"
+  }
+]

package/src/skills/registry.ts

@@ -11,6 +11,7 @@ import { homedir } from 'node:os'
 import { spawnSync } from 'node:child_process'
 import { URL } from 'node:url'
 import type { MiphamConfig } from '../shared/types.js'
+import communitySkills from './community-registry.json'
 
 const SKILLS_DIR = join(homedir(), '.mipham', 'skills')
 
@@ -39,81 +40,7 @@ export interface SkillEntry {
  * Embedded community skill registry.
  * In the future, this can be fetched from a remote URL.
  */
-const COMMUNITY_SKILLS: SkillEntry[] = [
-  {
-    name: 'code-review',
-    description:
-      'Automated code review with multiple dimensions — complexity, security, performance, quality',
-    url: 'https://github.com/One-Mipham/skill-code-review',
-    file: 'code-review.SKILL.md',
-    category: 'Development',
-    author: 'MiphamAI',
-    builtin: true,
-  },
-  {
-    name: 'systematic-debugging',
-    description: 'Systematic debugging workflow — find root cause before fixing',
-    url: 'https://github.com/anthropics/skills',
-    file: 'systematic-debugging.SKILL.md',
-    category: 'Development',
-    author: 'Anthropic',
-  },
-  {
-    name: 'test-driven-development',
-    description: 'TDD workflow — write failing test first, then implement',
-    url: 'https://github.com/anthropics/skills',
-    file: 'test-driven-development.SKILL.md',
-    category: 'Development',
-    author: 'Anthropic',
-    builtin: true,
-  },
-  {
-    name: 'web-access',
-    description:
-      'Web search, scraping, and browser automation — search engines, page fetching, authenticated sites',
-    url: 'https://github.com/One-Mipham/skill-web-access',
-    file: 'web-access.SKILL.md',
-    category: 'Network',
-    author: 'MiphamAI',
-    builtin: true,
-  },
-  {
-    name: 'doc-generator',
-    description: 'Generate API docs, READMEs, and changelogs from code analysis',
-    url: 'https://github.com/One-Mipham/skill-doc-generator',
-    file: 'doc-generator.SKILL.md',
-    category: 'Documentation',
-    author: 'MiphamAI',
-    builtin: true,
-  },
-  {
-    name: 'github-ops',
-    description: 'GitHub PR/issue management and automation — labels, milestones, reviews',
-    url: 'https://github.com/One-Mipham/skill-github-ops',
-    file: 'github-ops.SKILL.md',
-    category: 'DevOps',
-    author: 'MiphamAI',
-    builtin: true,
-  },
-  {
-    name: 'security-review',
-    description:
-      'Security audit and vulnerability scanning for code changes — OWASP, secrets, supply chain',
-    url: 'https://github.com/One-Mipham/skill-security-review',
-    file: 'security-review.SKILL.md',
-    category: 'Security',
-    author: 'MiphamAI',
-    builtin: true,
-  },
-  {
-    name: 'frontend-design',
-    description: 'Distinctive visual design guidance for UI components — typography, color, layout',
-    url: 'https://github.com/anthropics/skills',
-    file: 'frontend-design.SKILL.md',
-    category: 'Design',
-    author: 'Anthropic',
-  },
-]
+const COMMUNITY_SKILLS: SkillEntry[] = communitySkills as SkillEntry[]
 
 // ═══════════════════════════════════════════════════════════════
 // Skill Installer

package/src/tools/exec/bash.ts

@@ -28,9 +28,9 @@ const BLOCKED_PATTERNS = [
   /\$\(/,
   // Backtick command substitution
   /`[^`]+`/,
-  // Interpreter code execution (bypass vector)
-  /\bpython3?\s+-c\b/,
-  /\bpython3?\s+-m\b/,
+  // Interpreter code execution (bypass vector) — covers python, python2, python3
+  /\bpython[23]?\s+-c\b/,
+  /\bpython[23]?\s+-m\b/,
   /\bperl\s+-[ep]\b/,
   /\bruby\s+-e\b/,
   /\bnode\s+-e\b/,

package/src/tools/exec/enter-worktree.ts

@@ -45,9 +45,31 @@ export const enterWorktreeTool: ToolDefinition = {
           'Worktree name may only contain letters, digits, dots, underscores, dashes, and slashes.',
       }
     }
+    // Prevent path traversal via .. segments
+    if (name.includes('..')) {
+      return {
+        success: false,
+        content: '',
+        error: 'Worktree name may not contain ".." path segments.',
+      }
+    }
 
     const cwd = ctx.cwd
-    const worktreePath = `${cwd}/.claude/worktrees/${name}`
+    const { resolve } = await import('node:path')
+    const worktreePath = resolve(`${cwd}/.claude/worktrees/${name}`)
+    const allowedPrefix = resolve(`${cwd}/.claude/worktrees/`)
+
+    // Defense-in-depth: verify resolved path is within .claude/worktrees/
+    if (
+      !worktreePath.startsWith(allowedPrefix + '/') &&
+      worktreePath !== allowedPrefix.slice(0, -1)
+    ) {
+      return {
+        success: false,
+        content: '',
+        error: 'Worktree path must be within .claude/worktrees/.',
+      }
+    }
 
     try {
       // Validate we're in a git repo

package/src/tools/exec/exit-worktree.ts

@@ -36,6 +36,19 @@ export const exitWorktreeTool: ToolDefinition = {
 
     // Validate the path is under .claude/worktrees
     const cwd = ctx.cwd
+    const { resolve } = await import('node:path')
+    const resolvedPath = resolve(worktreePath)
+    const allowedPrefix = resolve(`${cwd}/.claude/worktrees/`)
+
+    if (!resolvedPath.startsWith(allowedPrefix)) {
+      return {
+        success: false,
+        content: '',
+        error:
+          `Path "${worktreePath}" is not under .claude/worktrees/. ` +
+          `Only worktrees created by EnterWorktree can be managed here.`,
+      }
+    }
 
     try {
       // Verify the worktree exists in git's worktree list

package/src/ui/agent-footer.tsx

@@ -0,0 +1,89 @@
+import React from 'react'
+import { Box, Text } from 'ink'
+
+export interface AgentEntry {
+  id: string
+  name: string
+  description: string
+  startTime: number
+  tokensUsed: number
+  status: 'running' | 'completed'
+}
+
+interface AgentFooterProps {
+  agents: AgentEntry[]
+  gitBranch: string
+  /** Tick counter for live elapsed-time re-renders. */
+  tick: number
+}
+
+/** Format elapsed seconds into human-readable string (e.g. "2m 51s", "38s"). */
+function formatElapsed(seconds: number): string {
+  if (seconds < 60) return `${seconds}s`
+  const m = Math.floor(seconds / 60)
+  const s = seconds % 60
+  return `${m}m ${s}s`
+}
+
+/** Format token count: 42400 → "42.4k", 1500000 → "1.5M". */
+function formatTokens(n: number): string {
+  if (n >= 1_000_000) return `${(n / 1_000_000).toFixed(1)}M`
+  if (n >= 1000) return `${(n / 1000).toFixed(1)}k`
+  return String(n)
+}
+
+export function AgentFooter({ agents, gitBranch, tick: _tick }: AgentFooterProps) {
+  const hasAgents = agents.length > 0
+  const hasBranch = gitBranch.length > 0
+
+  if (!hasAgents && !hasBranch) return null
+
+  return (
+    <Box flexDirection="column" marginTop={1}>
+      {/* Git branch indicator */}
+      {hasBranch && (
+        <Box>
+          <Text dimColor>
+            {'  '}⏺ {gitBranch}
+          </Text>
+        </Box>
+      )}
+
+      {/* Agent status lines */}
+      {agents.map((agent) => {
+        const elapsed = Math.floor((Date.now() - agent.startTime) / 1000)
+        const isRunning = agent.status === 'running'
+        const symbol = isRunning ? '◯' : '◼'
+        const symbolColor = isRunning ? 'cyan' : undefined
+
+        // Truncate description to keep lines readable
+        const desc =
+          agent.description.length > 80 ? agent.description.slice(0, 80) + '...' : agent.description
+
+        return (
+          <Box key={agent.id}>
+            <Text dimColor={!isRunning} color={symbolColor}>
+              {'  '}
+              {symbol}{' '}
+            </Text>
+            <Text bold color={isRunning ? 'cyan' : undefined} dimColor={!isRunning}>
+              {agent.name}
+            </Text>
+            <Text dimColor> {desc}</Text>
+            {/* Spacer pushes stats to the right — Ink handles this naturally */}
+            <Text dimColor>
+              {'  '}
+              {isRunning ? formatElapsed(elapsed) : 'finished'}
+            </Text>
+            {isRunning && agent.tokensUsed > 0 && (
+              <Text dimColor>
+                {' · ↓ '}
+                {formatTokens(agent.tokensUsed)} tokens
+              </Text>
+            )}
+          </Box>
+        )
+      })}
+    </Box>
+  )
+}